- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Dmitry Zhadinets (Code Review) 17 Mar '25

17 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... Patch Set 2: (1 comment) File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/889ee33e_32699c42?us… : PS2, Line 79: : global_log_callback = flashrom_log_callback_v2_handler; > I've implemented the new callback utilizing the old one. […] *Set means _replace_ here, flashrom_set_log_callback checks nothing -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 17 Mar 2025 16:14:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Dmitry Zhadinets (Code Review) 17 Mar '25

17 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/86875/comment/b5bb1771_919181a8?us… : PS2, Line 7: libflashrom: Update the API for Logger Callback > You need to be more concrete, and also one commit should do one thing. […] Honestly, I've copied the title from your patch about the progress. But let me explain. Update API means here: to add new function, new prototype of callback function, and probably to add flashrom_set_loglevel (this is another commit if it will be implemented). BTW. please see my question bellow about it. All of these are about logging and is in the single patch. I do not think it is good to have 2 patches initially with callback prototype with vargs and then with char* you may like my approach or not. this is what we are talking about File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/2655f3e5_8207a85d?us… : PS2, Line 59: /* Dynamic messages and double formatting may not be ideal, : as they are slow. It would be better to limit the message : size to a fixed value (e.g., char message[1024] = {0};). */ : char *message; : va_list args_attempt; : va_copy(args_attempt, args); : int size = vsnprintf(NULL, 0, format, args_attempt); : va_end(args_attempt); : if (size < 0) : return size; : message = malloc(size+1); : if (!message) : return -ENOMEM; : vsnprintf(message, size + 1, format, args); : global_log_callback_v2(level, message, global_log_user_data); : free(message); : return 0; > I am not sure this belongs to the library. […] So, this is the main thing to discuss. the prototype of the logger callback is like glib has https://docs.gtk.org/glib/callback.LogFunc.html. And many other libraries. I wanted to add log domain as well (it is convenient way to highlight where the message is from and adds good way to filter logs) but it is mostly used in the libraries with huge number of logs and, moreover, will lead to the big change in the flashrom itself. This is not me wants to use the formatting. This is how it is used everywhere, from my point of view. Usually, libraries have API like ... format, varg ... to provide an option for some custom formatting of the datatypes within the fmt. Does flashrom have some specific messages with custom args that can be treated by the client some other way than POSIX's vsnprintf do? I can do not know something. Please correct me if I'm wrong. even flashrom_print_cb works the same way. Moreover it looks like there is a bug here in update_line_state. because of does not care about vargs. Will it be ok if format is "some %s", and vargs is "string\n"? As far as I see there is no such cases in the code but it's a potential glitch in the terminal https://review.coreboot.org/c/flashrom/+/86875/comment/6500966c_3355c191?us… : PS2, Line 79: : global_log_callback = flashrom_log_callback_v2_handler; > I don't think you need it here: the v2 should set `global_log_callback_v2` only […] I've implemented the new callback utilizing the old one. And did not change something in the mechanism of publishing messages itself. If I would do so, just imaging what change will be in print function with my prototype of callback (with formatting) and maybe somewhere else (I'm not familiar with the whole codebase of flashrom yet). And yes, this is an idea there are two options for callback (v1 and v2), and only one of them can be used. Set means replays here, flashrom_set_log_callback checks nothing -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 17 Mar 2025 16:01:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Anastasia Klimchuk (Code Review) 17 Mar '25

17 Mar '25

Attention is currently required from: Dmitry Zhadinets, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... Patch Set 2: (6 comments) Patchset: PS2: Dmitry, thank you for the patch! I like that you have ideas and trying to do one of your ideas straight away. I added my comments. Commit Message: https://review.coreboot.org/c/flashrom/+/86875/comment/63a3f6a0_068f3553?us… : PS2, Line 7: libflashrom: Update the API for Logger Callback You need to be more concrete, and also one commit should do one thing. First commit can add v2 of log callback which allows the caller to pass user_data - and first commit should do only this. I see that you implemented some formatting code here too - I wanted to discuss more about it (see my other comment), but in any case that should be in a separate commit (can be second commit in the chain). https://review.coreboot.org/c/flashrom/+/86875/comment/9da1ae33_b8587594?us… : PS2, Line 9: The initial implementation does not account for user_data, requiring the calling application to use a global scope. This may lead to issues related to object lifecycle management and other architectural concerns. : : This patch adds user_data to the user’s log callback. Moreover, it performs message formatting, so the application only needs to pass the formatted string to the selected output. : : The change does not break the existing logging API but extends it. A new API version is introduced with the v2 suffix. : : Testing: Both unit tests and CLI tools serve as libflashrom clients. : All unit tests run successfully. We wrap commit message by 72 chars width, I feel these lines are longer check the guidelines: https://flashrom.org/dev_guide/development_guide.html#commit-message https://review.coreboot.org/c/flashrom/+/86875/comment/3c240130_6ff3664a?us… : PS2, Line 15: Testing: Both unit tests and CLI tools serve as libflashrom clients. : All unit tests run successfully. Yes, but you are not adding new tests: so v2 is not tested. Unit tests and cli are v1 clients. Ideally if you could a test which uses v2 log callback, that would be cool! File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/da1b3b68_660a8b03?us… : PS2, Line 59: /* Dynamic messages and double formatting may not be ideal, : as they are slow. It would be better to limit the message : size to a fixed value (e.g., char message[1024] = {0};). */ : char *message; : va_list args_attempt; : va_copy(args_attempt, args); : int size = vsnprintf(NULL, 0, format, args_attempt); : va_end(args_attempt); : if (size < 0) : return size; : message = malloc(size+1); : if (!message) : return -ENOMEM; : vsnprintf(message, size + 1, format, args); : global_log_callback_v2(level, message, global_log_user_data); : free(message); : return 0; I am not sure this belongs to the library. I understand that you want to use this formatting, but I don't know whether all the clients of the API would want exactly this. From your point of view, you can implement the formatting in your callback - and there you have it. flashrom's cli callback implementation has the formatting (flashrom_print_cb in cli_output.c), which is a client of API. https://review.coreboot.org/c/flashrom/+/86875/comment/adfd7f99_5c3e86f5?us… : PS2, Line 79: : global_log_callback = flashrom_log_callback_v2_handler; I don't think you need it here: the v2 should set `global_log_callback_v2` only So each version should set only its callback. But before that, check if the other callback is set already - then do nothing. The idea is, there are two options for callback (v1 and v2), and only one of them can be used. The user of the library can decide which version they want to use. -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 17 Mar 2025 11:54:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Dmitry Zhadinets (Code Review) 17 Mar '25

17 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... Patch Set 2: (1 comment) File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/7eecc4a3_c2ae6a97?us… : PS2, Line 49: /* TODO: flashrom_set_loglevel()? do we need it? > What if to implement this in the patch. […] What was the idea of struct flashrom_programmer? I'm a bit confused what is it for when there is struct flashrom_flashctx -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 17 Mar 2025 04:42:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets(a)gmail.com>

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Dmitry Zhadinets (Code Review) 17 Mar '25

17 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... Patch Set 2: (1 comment) File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/83610806_379c4788?us… : PS2, Line 49: /* TODO: flashrom_set_loglevel()? do we need it? What if to implement this in the patch. It would prevent a lot of callings and unnecessary allocations and formatting. flashrom will cut everything in advance But where should it be stored? Another global variable... Or is it finally time to introduce `struct flashrom_programmer`? -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 17 Mar 2025 04:36:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Dmitry Zhadinets (Code Review) 17 Mar '25

17 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... Patch Set 2: (1 comment) File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/86875/comment/57d2e041_bc887c26?us… : PS1, Line 76: void flashrom_set_log_callback_v2(flashrom_log_callback_v2 *log_callback, void* user_data); > This should have a doc comment block, basically the same as `flashrom_set_log_callback` above. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 17 Mar 2025 04:14:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Dmitry Zhadinets (Code Review) 17 Mar '25

17 Mar '25

Attention is currently required from: Anastasia Klimchuk, Dmitry Zhadinets. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86875?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... libflashrom: Update the API for Logger Callback The initial implementation does not account for user_data, requiring the calling application to use a global scope. This may lead to issues related to object lifecycle management and other architectural concerns. This patch adds user_data to the user’s log callback. Moreover, it performs message formatting, so the application only needs to pass the formatted string to the selected output. The change does not break the existing logging API but extends it. A new API version is introduced with the v2 suffix. Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/libflashrom.h M libflashrom.c M libflashrom.map 3 files changed, 50 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/86875/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Peter Marheine (Code Review) 17 Mar '25

17 Mar '25

Attention is currently required from: Anastasia Klimchuk, Dmitry Zhadinets. Peter Marheine has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: This looks rather easier than the progress callback was, which is nice. It might be nice to see about moving logging to be associated with some kind of library context, but that seems moderately difficult because it can't go into a flashctx (because we want to be able to log before a flashctx is gotten) so it's probably not worth trying to do right now. File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/86875/comment/8025b55e_dfe63489?us… : PS1, Line 76: void flashrom_set_log_callback_v2(flashrom_log_callback_v2 *log_callback, void* user_data); This should have a doc comment block, basically the same as `flashrom_set_log_callback` above. -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 17 Mar 2025 03:39:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Dmitry Zhadinets (Code Review) 17 Mar '25

17 Mar '25

Dmitry Zhadinets has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... libflashrom: Update the API for Logger Callback The initial implementation does not account for user_data, requiring the calling application to use a global scope. This may lead to issues related to object lifecycle management and other architectural concerns. This patch adds user_data to the user’s log callback. Moreover, it performs message formatting, so the application only needs to pass the formatted string to the selected output. The change does not break the existing logging API but extends it. A new API version is introduced with the v2 suffix. Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/libflashrom.h M libflashrom.c M libflashrom.map 3 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/86875/1 diff --git a/include/libflashrom.h b/include/libflashrom.h index 41c7424..fb4fb6a 100644 --- a/include/libflashrom.h +++ b/include/libflashrom.h @@ -69,6 +69,12 @@ */ void flashrom_set_log_callback(flashrom_log_callback *log_callback); +typedef void (flashrom_log_callback_v2)( + enum flashrom_log_level, + const char* message, + void* user_data); +void flashrom_set_log_callback_v2(flashrom_log_callback_v2 *log_callback, void* user_data); + enum flashrom_progress_stage { FLASHROM_PROGRESS_READ, FLASHROM_PROGRESS_WRITE, diff --git a/libflashrom.c b/libflashrom.c index 8cc38c4..66b4de4 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -31,6 +31,8 @@ /** Pointer to log callback function. */ static flashrom_log_callback *global_log_callback = NULL; +static flashrom_log_callback_v2 *global_log_callback_v2 = NULL; +static void *global_log_user_data = NULL; int flashrom_init(const int perform_selfcheck) { @@ -50,6 +52,36 @@ { global_log_callback = log_callback; } + +static int flashrom_log_callback_v2_handler(enum flashrom_log_level level, + const char *format, va_list args) +{ + /* Dynamic messages and double formatting may not be ideal, + as they are slow. It would be better to limit the message + size to a fixed value (e.g., char message[1024] = {0};). */ + char *message; + va_list args_attempt; + va_copy(args_attempt, args); + int size = vsnprintf(NULL, 0, format, args_attempt); + va_end(args_attempt); + if (size < 0) + return size; + message = malloc(size+1); + if (!message) + return -ENOMEM; + vsnprintf(message, size + 1, format, args); + global_log_callback_v2(level, message, global_log_user_data); + free(message); + return 0; +} + +void flashrom_set_log_callback_v2(flashrom_log_callback_v2 *const log_callback, void* user_data) +{ + global_log_callback = flashrom_log_callback_v2_handler; + global_log_callback_v2 = log_callback; + global_log_user_data = user_data; +} + /** @private */ int print(const enum flashrom_log_level level, const char *const fmt, ...) { diff --git a/libflashrom.map b/libflashrom.map index 8e4635d..4ab9ac9 100644 --- a/libflashrom.map +++ b/libflashrom.map @@ -24,6 +24,7 @@ flashrom_programmer_init; flashrom_programmer_shutdown; flashrom_set_log_callback; + flashrom_set_log_callback_v2; flashrom_set_progress_callback; flashrom_set_progress_callback_v2; flashrom_shutdown; -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com>

1 0

[XS] Change in flashrom[main]: flashchips/winbond: Update test status for Winbond W25Q128.JW.DTR
by Anastasia Klimchuk (Code Review) 16 Mar '25

16 Mar '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/86848?usp=email ) Change subject: flashchips/winbond: Update test status for Winbond W25Q128.JW.DTR ...................................................................... flashchips/winbond: Update test status for Winbond W25Q128.JW.DTR Tested probe, read, erase, write, and WP operations on a Winbond W25Q128.JW.DTR chip using internal and raiden_debug_spi programmers. Change-Id: Ie2fdb2c305dca3677950cc6855d41b7161a0fce9 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/86848 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips/winbond.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved Andy Ebrahiem: Looks good to me, but someone else must approve diff --git a/flashchips/winbond.c b/flashchips/winbond.c index 48fdc94..ae80b13 100644 --- a/flashchips/winbond.c +++ b/flashchips/winbond.c @@ -264,7 +264,7 @@ .total_size = 16384, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI | FEATURE_WRSR2, - .tested = TEST_OK_PREW, + .tested = TEST_OK_PREWB, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/c/flashrom/+/86848?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie2fdb2c305dca3677950cc6855d41b7161a0fce9 Gerrit-Change-Number: 86848 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit