- flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: Use SPDX in cli_getop files
by Antonio Vázquez Blanco (Code Review) 25 Nov '24

25 Nov '24

Antonio Vázquez Blanco has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85073?usp=email ) Change subject: Use SPDX in cli_getop files ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Knowing that in general you want to keep a single header style among all prohect files, should I drop this in favour of you possibly changing all headers in all files at once? Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/85073?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie523cf5b26a29de8e9e9efb56efe04a5ff86a59c Gerrit-Change-Number: 85073 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 25 Nov 2024 08:48:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: Extract cli_output declarations to a separate header.
by Antonio Vázquez Blanco (Code Review) 25 Nov '24

25 Nov '24

Attention is currently required from: Anastasia Klimchuk. Antonio Vázquez Blanco has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85134?usp=email ) Change subject: Extract cli_output declarations to a separate header. ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: All done :D File include/cli_output.h: https://review.coreboot.org/c/flashrom/+/85134/comment/d1c1611e_6c10d592?us… : PS1, Line 4: * SPDX-FileCopyrightText: 2024 Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> : * SPDX-License-Identifier: GPL-2.0-or-later > > Would you rather I copy the full license text from other file? […] Done! :) Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/85134?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I4209d5ed205ca14c39e83aa923e103b7282a7059 Gerrit-Change-Number: 85134 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 25 Nov 2024 08:42:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: Extract cli_output declarations to a separate header.
by Antonio Vázquez Blanco (Code Review) 25 Nov '24

25 Nov '24

Attention is currently required from: Antonio Vázquez Blanco. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85134?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Extract cli_output declarations to a separate header. ...................................................................... Extract cli_output declarations to a separate header. This is a simple refactor that aims to simplify maintenance and to clarify file dependency inside the project. Currently, many declarations reside in flash.h making it difficult to really understand file dependency. Change-Id: I4209d5ed205ca14c39e83aa923e103b7282a7059 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M cli_classic.c M cli_output.c A include/cli_output.h M include/flash.h 4 files changed, 35 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/85134/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85134?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I4209d5ed205ca14c39e83aa923e103b7282a7059 Gerrit-Change-Number: 85134 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com>

1 0

[M] Change in flashrom[main]: cli_classic.c: Make -r/-w/-v argument optional when using -i
by Anastasia Klimchuk (Code Review) 25 Nov '24

25 Nov '24

Attention is currently required from: Matt DeVillier. Anastasia Klimchuk has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/flashrom/+/85159?usp=email ) Change subject: cli_classic.c: Make -r/-w/-v argument optional when using -i ...................................................................... Patch Set 7: (1 comment) File doc/classic_cli_manpage.rst: https://review.coreboot.org/c/flashrom/+/85159/comment/40ca8c14_272c98cd?us… : PS5, Line 227: If filenames are specified for -r and -i args, then: > updated to fix the issue below, but can't reproduce this one using https://snippets.documatt. […] That is only repro when generating manpage from rst, html is fine (I couldn't find in the tool the option to generated manpage). But I tried myself, and my idea works (not sure why :)), adding a new empty line between 227 and 228 fixes the issue with bold format! If you add new empty line that would be it. Locally I was viewing `man doc/man8/flashrom.8` from builddir, after building -- To view, visit https://review.coreboot.org/c/flashrom/+/85159?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I6eba095d478f1a7bdbc3854627a656f93dd9e452 Gerrit-Change-Number: 85159 Gerrit-PatchSet: 7 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Mon, 25 Nov 2024 08:40:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XL] Change in flashrom[main]: flashchips: Splitting flashchips into separate files by vendor
by Anastasia Klimchuk (Code Review) 25 Nov '24

25 Nov '24

Attention is currently required from: Angel Pons. Anastasia Klimchuk has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/flashrom/+/83307?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: flashchips: Splitting flashchips into separate files by vendor ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Leaving unresolved comment as a note to submit this after v1.5.0 tag is done. ETA 6th December https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/WM4C… -- To view, visit https://review.coreboot.org/c/flashrom/+/83307?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3a9ebb0575e2700c5871d16875495d9c8943b30b Gerrit-Change-Number: 83307 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 25 Nov 2024 00:10:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in flashrom[main]: flashchips: Splitting flashchips into separate files by vendor
by Peter Marheine (Code Review) 24 Nov '24

24 Nov '24

Attention is currently required from: Anastasia Klimchuk, Angel Pons. Peter Marheine has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/flashrom/+/83307?usp=email ) Change subject: flashchips: Splitting flashchips into separate files by vendor ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83307?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3a9ebb0575e2700c5871d16875495d9c8943b30b Gerrit-Change-Number: 83307 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 24 Nov 2024 22:40:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in flashrom[main]: flashchips: Splitting flashchips into separate files by vendor
by Anastasia Klimchuk (Code Review) 24 Nov '24

24 Nov '24

Attention is currently required from: Angel Pons, Peter Marheine. Anastasia Klimchuk has uploaded a new patch set (#3) to the change originally created by Angel Pons. ( https://review.coreboot.org/c/flashrom/+/83307?usp=email ) Change subject: flashchips: Splitting flashchips into separate files by vendor ...................................................................... flashchips: Splitting flashchips into separate files by vendor To make the flashchips "database" easier to manage, split it by vendor into several smaller files. This commit transfers the bulk of the data to separate files and includes them from `flashchips.c`. Although this is ugly (.c includes are usually frowned upon), it is a necessary evil to make this commit reproducible. Tested in two ways: 1) Output of `flashrom -L` has no diffs with/without the patch compared with diff and cmp tools 2) flashrom binary has no diffs with/without the patch compared with diff and cmp tools Note for binary comparison documentation and manpages need to be disabled (documentation is actually modified in the patch), also version in meson.build set to "none" (otherwise git version counts every commit). Change-Id: I3a9ebb0575e2700c5871d16875495d9c8943b30b Co-developed-by: Angel Pons <th3fanbus(a)gmail.com> Co-developed-by: Anastasia Klimchuk <aklm(a)flashrom.org> Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M MAINTAINERS M doc/contrib_howtos/how_to_add_new_chip.rst M flashchips.c A flashchips/amd.c A flashchips/amic.c A flashchips/atmel.c A flashchips/boya_bohong.c A flashchips/bright.c A flashchips/catalyst.c A flashchips/ene.c A flashchips/eon.c A flashchips/esi.c A flashchips/esmt.c A flashchips/fudan.c A flashchips/fujitsu.c A flashchips/gigadevice.c A flashchips/hyundai.c A flashchips/intel.c A flashchips/issi.c A flashchips/macronix.c A flashchips/micron.c A flashchips/micron_numonyx_st.c A flashchips/mosel_vitelic.c A flashchips/nantronics.c A flashchips/pmc.c A flashchips/puya.c A flashchips/sanyo.c A flashchips/sharp.c A flashchips/spansion.c A flashchips/sst.c A flashchips/st.c A flashchips/syncmos_mosel_vitelic.c A flashchips/ti.c A flashchips/winbond.c A flashchips/xmc.c A flashchips/xtx.c A flashchips/zetta.c 37 files changed, 24,143 insertions(+), 23,458 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/07/83307/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/83307?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3a9ebb0575e2700c5871d16875495d9c8943b30b Gerrit-Change-Number: 83307 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

[XL] Change in flashrom[main]: flashchips: Splitting flashchips into separate files by vendor
by Anastasia Klimchuk (Code Review) 24 Nov '24

24 Nov '24

Attention is currently required from: Angel Pons, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/flashrom/+/83307?usp=email ) Change subject: flashchips: Splitting flashchips into separate files by vendor ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > At current state, the output of `flashrom -L` is identical before / after the patch. […] I forgot about docs! Tried again, with docs and manpage disabled like this: `meson configure -Ddocumentation=disabled -Dman-pages=disabled` and also in line 61 of meson.build, changed the version to be "none" Now binaries are the same with and without the patch! (Maybe there is more elegant way of ignoring version, other then modifying line 61, but I only came up with this hack) -- To view, visit https://review.coreboot.org/c/flashrom/+/83307?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3a9ebb0575e2700c5871d16875495d9c8943b30b Gerrit-Change-Number: 83307 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sun, 24 Nov 2024 22:26:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: doc: Double-clarify that mailing list is public
by Stefan Reinauer (Code Review) 23 Nov '24

23 Nov '24

Attention is currently required from: Anastasia Klimchuk. Stefan Reinauer has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85277?usp=email ) Change subject: doc: Double-clarify that mailing list is public ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id8e0daf75e25e6153a80fb9444547bdf91d1d343 Gerrit-Change-Number: 85277 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 23 Nov 2024 18:44:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: cli_classic.c: Make -r/-w/-v argument optional when using -i
by Matt DeVillier (Code Review) 23 Nov '24

23 Nov '24

Attention is currently required from: Matt DeVillier. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85159?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: cli_classic.c: Make -r/-w/-v argument optional when using -i ...................................................................... cli_classic.c: Make -r/-w/-v argument optional when using -i Make the filename parameter directly following -r/-w/-v optional, since the -i parameter allows the image to be written to be sourced from multiple files, regions to be read from flash and written to separate image files, and regions to be verified using an image file only containing that region. Since the filename parameter following -w/-v was ignored when a filename was specified following `-i <region>:<filename>`, this patch essentially removes the requirement to provide an unused parameter. Based on https://review.coreboot.org/c/flashrom/+/52362. TEST=run the following commands on a supported board: flashrom -p internal -r /tmp/coreboot.rom flashrom -p internal -r --ifd -i bios:/tmp/coreboot.rom flashrom -p internal -r /tmp/coreboot.rom --ifd -i bios:/tmp/bios.bin flashrom -p internal -w /tmp/coreboot.rom flashrom -p internal -w --ifd -i bios:/tmp/coreboot.rom flashrom -p internal -w /tmp/coreboot.rom --ifd -i bios:/tmp/bios.bin flashrom -p internal -v /tmp/coreboot.rom flashrom -p internal -v --ifd -i bios:/tmp/coreboot.rom flashrom -p internal -v /tmp/coreboot.rom --ifd -i bios:/tmp/bios.bin Change-Id: I6eba095d478f1a7bdbc3854627a656f93dd9e452 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M cli_classic.c M doc/classic_cli_manpage.rst M include/layout.h M layout.c 4 files changed, 160 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/85159/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/85159?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I6eba095d478f1a7bdbc3854627a656f93dd9e452 Gerrit-Change-Number: 85159 Gerrit-PatchSet: 5 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit