- flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[main]: tests/chip: fix print format errors in gcc 14.2.0
by Anastasia Klimchuk (Code Review) 16 Mar '25

16 Mar '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/86679?usp=email ) Change subject: tests/chip: fix print format errors in gcc 14.2.0 ...................................................................... tests/chip: fix print format errors in gcc 14.2.0 Change-Id: I8c461accefddce3d5ee33b0fb6b91c434d721945 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/86679 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M tests/chip.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Anastasia Klimchuk: Looks good to me, approved Elyes Haouas: Looks good to me, but someone else must approve build bot (Jenkins): Verified diff --git a/tests/chip.c b/tests/chip.c index 95c8616..be82dbe 100644 --- a/tests/chip.c +++ b/tests/chip.c @@ -92,7 +92,7 @@ } if (current >= total - 1) - printf("Progress almost complete for stage %d, current %ld, total %ld\n", stage, current, total); + printf("Progress almost complete for stage %d, current %zu, total %zu\n", stage, current, total); progress_user_data->last_seen[stage] = current; } -- To view, visit https://review.coreboot.org/c/flashrom/+/86679?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8c461accefddce3d5ee33b0fb6b91c434d721945 Gerrit-Change-Number: 86679 Gerrit-PatchSet: 4 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: tests/chip: fix print format errors in gcc 14.2.0
by Elyes Haouas (Code Review) 16 Mar '25

16 Mar '25

Attention is currently required from: Antonio Vázquez Blanco. Elyes Haouas has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/86679?usp=email ) Change subject: tests/chip: fix print format errors in gcc 14.2.0 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/86679?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8c461accefddce3d5ee33b0fb6b91c434d721945 Gerrit-Change-Number: 86679 Gerrit-PatchSet: 3 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Comment-Date: Sun, 16 Mar 2025 07:14:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Anastasia Klimchuk (Code Review) 15 Mar '25

15 Mar '25

Attention is currently required from: Simon Arlott. Anastasia Klimchuk has posted comments on this change by Simon Arlott. ( https://review.coreboot.org/c/flashrom/+/86411?usp=email ) Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: I am approving this (to follow up on what I wrote), but see my previous message - what do others think? -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 5 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Comment-Date: Sat, 15 Mar 2025 08:10:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Anastasia Klimchuk (Code Review) 14 Mar '25

14 Mar '25

Attention is currently required from: Simon Arlott. Anastasia Klimchuk has posted comments on this change by Simon Arlott. ( https://review.coreboot.org/c/flashrom/+/86411?usp=email ) Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > Looks reasonable to me, but would you mind adding some tests for this programmer too? A `run_basic_l […] To begin with, I love tests, and even more so, I love flashrom tests! (git history can confirm :)) With this I want to say something here, because I don't want to get Simon worried. For this case, I think it's totally fine to have a test (any test) in a separate patch (Peter, let me know what you think?). This patch is large already, and it's a pain to carry over a large patch, and then make it even larger, and then rebase again etc. Part of the reason why test is more important in this case, is that Simon you indicated you can't be a dedicated maintainer for this programmer. In such situation, test would help us to keep the programmer in a good state. Tests are running on CI for each patch. More to the technical details: we do have a bunch of tests running `run_basic_lifecycle` (which means init and shutdown programmer, nothing else). In this case, you can mock `spidriver_serialport_setup` (which just need to return 0), and `spidriver_sendrecv` (this one need to return 0 and populate `buf`). Simon, please tell us what you think! As I said I think this patch can go ahead and test can be separate patch later. Especially if you can hang around in case something happens with this programmer, so that you can answer email for example. If you agree to go on an adventure and write a test, I am so happy to help you! Did I mention I love tests. -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 5 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Comment-Date: Fri, 14 Mar 2025 08:39:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Peter Marheine (Code Review) 13 Mar '25

13 Mar '25

Attention is currently required from: Anastasia Klimchuk, Simon Arlott. Peter Marheine has posted comments on this change by Simon Arlott. ( https://review.coreboot.org/c/flashrom/+/86411?usp=email ) Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Looks reasonable to me, but would you mind adding some tests for this programmer too? A `run_basic_lifecycle` case for the programmer will at least help us ensure it's not completely broken since fully mocking out the hardware for testing would probably be labor-intensive. -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 5 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 13 Mar 2025 22:58:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Simon Arlott (Code Review) 13 Mar '25

13 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Simon Arlott has posted comments on this change by Simon Arlott. ( https://review.coreboot.org/c/flashrom/+/86411?usp=email ) Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > Would you rebase the patch on the latest head? Thank you! Done -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 5 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 13 Mar 2025 20:26:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Simon Arlott (Code Review) 13 Mar '25

13 Mar '25

Attention is currently required from: Peter Marheine, Simon Arlott. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86411?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... spidriver: Add support for the Excamera Labs SPIDriver programmer This is a SPI hardware interface with a display (https://spidriver.com/), connected as an FT230X USB serial device at a fixed baud rate of 460800. Firmware: https://github.com/jamesbowman/spidriver Protocol: https://github.com/jamesbowman/spidriver/blob/master/protocol.md Most of the implementation is copied from the Bus Pirate programmer. Tested with a SPIDriver v2 by reading FM25Q128A flash memory on Linux. Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Signed-off-by: Simon Arlott <flashrom(a)octiron.net> --- M doc/classic_cli_manpage.rst M doc/release_notes/devel.rst M include/programmer.h M meson.build M meson_options.txt M programmer_table.c A spidriver.c M test_build.sh 8 files changed, 380 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/86411/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 5 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Anastasia Klimchuk (Code Review) 13 Mar '25

13 Mar '25

Attention is currently required from: Peter Marheine, Simon Arlott. Anastasia Klimchuk has posted comments on this change by Simon Arlott. ( https://review.coreboot.org/c/flashrom/+/86411?usp=email ) Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: Would you rebase the patch on the latest head? Thank you! File spidriver.c: https://review.coreboot.org/c/flashrom/+/86411/comment/7a79f64e_87cf1819?us… : PS4, Line 307: fw_version >= 2 > Only version 2 supports setting the SPI mode, I don't have a version 1 device so the condition does […] I see, thanks -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 4 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 13 Mar 2025 20:22:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Arlott <flashrom.simon(a)arlott.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips/winbond: Update test status for Winbond W25Q128.JW.DTR
by Anastasia Klimchuk (Code Review) 13 Mar '25

13 Mar '25

Attention is currently required from: Matt DeVillier, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/flashrom/+/86848?usp=email ) Change subject: flashchips/winbond: Update test status for Winbond W25Q128.JW.DTR ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86848?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie2fdb2c305dca3677950cc6855d41b7161a0fce9 Gerrit-Change-Number: 86848 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 13 Mar 2025 20:10:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: flashchips/winbond: Update test status for Winbond W25Q128.JW.DTR
by Andy Ebrahiem (Code Review) 13 Mar '25

13 Mar '25

Attention is currently required from: Anastasia Klimchuk, Matt DeVillier, Nikolai Artemiev, Stefan Reinauer. Andy Ebrahiem has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/flashrom/+/86848?usp=email ) Change subject: flashchips/winbond: Update test status for Winbond W25Q128.JW.DTR ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/86848?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie2fdb2c305dca3677950cc6855d41b7161a0fce9 Gerrit-Change-Number: 86848 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 13 Mar 2025 18:29:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit