- flashrom-gerrit - mail.coreboot.org

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Anastasia Klimchuk (Code Review) 23 Mar '25

23 Mar '25

Attention is currently required from: Peter Marheine, Simon Arlott. Anastasia Klimchuk has posted comments on this change by Simon Arlott. ( https://review.coreboot.org/c/flashrom/+/86411?usp=email ) Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... Patch Set 7: (4 comments) Patchset: PS5: > I've added a test and found a bug writing the SPI mode. […] Simon, thank you so much for your work! Your test is so well written, and so detailed, it is very impressive! I will close this comment thread. I added few small comments to the latest version of the patch. File tests/spidriver.c: https://review.coreboot.org/c/flashrom/+/86411/comment/5b02879a_4c9869d1?us… : PS7, Line 4: * Copyright 2021 Google LLC I don't think this line is needed here? I would just leave your name (just line #5). You wrote a brand new test. https://review.coreboot.org/c/flashrom/+/86411/comment/cd47edc5_72905efe?us… : PS7, Line 83: snprintf((char *)ts->input, sizeof(ts->input), "[spidriver2 AAAAAAAA 000000002 5.190 000 21.9 1 1 1 ffff 0 ]"); This line length goes above our limit (112 chars), but I think if you put arguments on new lines it should be fine. I mean like this ``` snprintf((char *)ts->input, sizeof(ts->input), "[spidriver2 AAAAAAAA 000000002 5.190 000 21.9 1 1 1 ffff 0 ]"); ``` File tests/tests.c: https://review.coreboot.org/c/flashrom/+/86411/comment/9c295399_a9288833?us… : PS7, Line 27: : struct termios; : I don't think you need this line here, because `wraps.h` is already included, and wraps.h has this line (also things like that are meant to be in wraps.h anyway) -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 7 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sun, 23 Mar 2025 12:39:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Arlott <flashrom.simon(a)arlott.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Add API to return the list of supported programmers
by Dmitry Zhadinets (Code Review) 23 Mar '25

23 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email ) Change subject: libflashrom: Add API to return the list of supported programmers ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: It is strange. Somehow commits has squashed. let me check -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 3 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sun, 23 Mar 2025 03:52:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: libflashrom: Add API to return the list of supported programmers
by Dmitry Zhadinets (Code Review) 23 Mar '25

23 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86921?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: libflashrom: Add API to return the list of supported programmers ...................................................................... libflashrom: Add API to return the list of supported programmers Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/libflashrom.h M libflashrom.c M libflashrom.map A tests/libflashrom.c M tests/meson.build M tests/tests.c M tests/tests.h 7 files changed, 147 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/86921/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 3 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Added API to enumerate supported programmers
by Dmitry Zhadinets (Code Review) 23 Mar '25

23 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email ) Change subject: libflashrom: Added API to enumerate supported programmers ...................................................................... Patch Set 2: (7 comments) Patchset: PS1: > At least `list_programmers_linebreak` can be converted to use the new API, so it makes sense to do t […] If you are about iterator. lets discuss it in the next commit Commit Message: https://review.coreboot.org/c/flashrom/+/86921/comment/3d88b9fa_a592b3ab?us… : PS2, Line 6: : libflashrom: Added API to enumerate supported programmers > Few corrections: […] Done File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/86921/comment/a4773c9d_9879ee74?us… : PS2, Line 169: flashrom_supported_programmers > This needs to be added to libflashrom. […] Done File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/86921/comment/8ab50306_35e32acf?us… : PS1, Line 166: * @return List of supported programmers, or NULL if an error occurred. > Just to be explicit, this should say that the last entry in the returned list is followed by a NULL. Done File tests/libflashrom.c: https://review.coreboot.org/c/flashrom/+/86921/comment/69b455e4_70880105?us… : PS1, Line 4: Copyright 2020 Google LLC > That's you are adding a new test, should be your name here Done File tests/libflashrom.c: https://review.coreboot.org/c/flashrom/+/86921/comment/d317f8c4_42a5cf02?us… : PS2, Line 22: enumerators_test_success > I would rename this to `flashrom_supported_programmers_test_success` to use the same name as the fun […] Done https://review.coreboot.org/c/flashrom/+/86921/comment/67d89092_5cae1a6a?us… : PS2, Line 24: (void) state; /* unused */ : const char** array = flashrom_supported_programmers(); : const char** ptr = array; : assert_non_null(array); : while (*(ptr++)){} : flashrom_data_free(array); : assert_int_not_equal(ptr - array, 0); > This needs a fix for the indentation (use tabs always) […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sun, 23 Mar 2025 03:35:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Dmitry Zhadinets (Code Review) 23 Mar '25

23 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... Patch Set 6: (1 comment) Patchset: PS5: > You probably haven't uploaded the latest changes? because I see you resolved the comments, but file […] done -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 6 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sun, 23 Mar 2025 03:17:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Dmitry Zhadinets (Code Review) 22 Mar '25

22 Mar '25

Attention is currently required from: Dmitry Zhadinets, Peter Marheine. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86875?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... libflashrom: Update the API for Logger Callback The initial implementation does not account for user_data, requiring the calling application to use a global scope. This may lead to issues related to object lifecycle management and other architectural concerns. This patch adds user_data to the user’s log callback. Moreover, it performs message formatting, so the application only needs to pass the formatted string to the selected output. The change does not break the existing logging API but extends it. A new API version is introduced with the v2 suffix. Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/libflashrom.h M libflashrom.c M libflashrom.map A tests/libflashrom.c M tests/meson.build M tests/tests.c M tests/tests.h 7 files changed, 135 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/86875/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 6 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Anastasia Klimchuk (Code Review) 22 Mar '25

22 Mar '25

Attention is currently required from: Dmitry Zhadinets, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: You probably haven't uploaded the latest changes? because I see you resolved the comments, but file are still the same? -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 5 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 22 Mar 2025 09:24:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Simon Arlott (Code Review) 22 Mar '25

22 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86411?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... spidriver: Add support for the Excamera Labs SPIDriver programmer This is a SPI hardware interface with a display (https://spidriver.com/), connected as an FT230X USB serial device at a fixed baud rate of 460800. Firmware: https://github.com/jamesbowman/spidriver Protocol: https://github.com/jamesbowman/spidriver/blob/master/protocol.md Most of the implementation is copied from the Bus Pirate programmer. Tested with a SPIDriver v2 by reading FM25Q128A flash memory on Linux. Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Signed-off-by: Simon Arlott <flashrom(a)octiron.net> --- M doc/classic_cli_manpage.rst M doc/release_notes/devel.rst M include/programmer.h M meson.build M meson_options.txt M programmer_table.c A spidriver.c A subprojects/.gitignore M test_build.sh M tests/io_mock.h M tests/meson.build A tests/spidriver.c M tests/tests.c M tests/tests.h M tests/wraps.h 15 files changed, 660 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/86411/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 7 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

[XS] Change in flashrom[main]: doc: Update supported flashchips page because we split the large file
by Anastasia Klimchuk (Code Review) 22 Mar '25

22 Mar '25

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86953?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: doc: Update supported flashchips page because we split the large file ...................................................................... doc: Update supported flashchips page because we split the large file Change-Id: Ic6179517d0f951a32c0c4e0baf32677398224542 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/supported_hw/supported_flashchips.rst 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/86953/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86953?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic6179517d0f951a32c0c4e0baf32677398224542 Gerrit-Change-Number: 86953 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Dmitry Zhadinets (Code Review) 22 Mar '25

22 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... Patch Set 5: (11 comments) File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/86875/comment/7d2e9291_05e28814?us… : PS4, Line 83: * > This documentation needs to explain about formatting Hmmmm. The user does not affect this, but as you wish. File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/9e3097ef_424d2a04?us… : PS2, Line 59: /* Dynamic messages and double formatting may not be ideal, : as they are slow. It would be better to limit the message : size to a fixed value (e.g., char message[1024] = {0};). */ : char *message; : va_list args_attempt; : va_copy(args_attempt, args); : int size = vsnprintf(NULL, 0, format, args_attempt); : va_end(args_attempt); : if (size < 0) : return size; : message = malloc(size+1); : if (!message) : return -ENOMEM; : vsnprintf(message, size + 1, format, args); : global_log_callback_v2(level, message, global_log_user_data); : free(message); : return 0; > Alright, I can agree on that. […] I hope I understood markers correctly File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/3048a4ba_74ce1643?us… : PS4, Line 56: flashrom_log_callback_v2_handler > This is a static function, so it doesn't have to start with "flashrom" , also I would try to give it […] Done https://review.coreboot.org/c/flashrom/+/86875/comment/e60ddde1_ee8e6916?us… : PS4, Line 57: > You probably don't need all these tabs, also I think this fits on one line? fn name and all params Done https://review.coreboot.org/c/flashrom/+/86875/comment/6be5d942_a8bfae88?us… : PS4, Line 59: /* Dynamic messages and double formatting may not be ideal, : as they are slow. It would be better to limit the message : size to a fixed value (e.g., char message[1024] = {0};). */ > You need to align with comments style (https://flashrom.org/dev_guide/development_guide. […] This is a question to a reviewer. I propose removing double allocation and maintaining messages at a constant length. How long can a single message generated by Flashrom be? A length of 1K might be excessive. File tests/libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/59a91b79_9ecbbe99?us… : PS4, Line 3: : * Copyright 2020 Google LLC > I commented on the other patch too, there should be your name here! Done https://review.coreboot.org/c/flashrom/+/86875/comment/e9c39f97_5714c31c?us… : PS4, Line 30: last_callback_version = 1; > We usually avoid global state (if possible), and in this case I think you can avoid it by returning […] Done https://review.coreboot.org/c/flashrom/+/86875/comment/6627a992_91e7cd05?us… : PS4, Line 48: logapi_test_success > Thank you so much for adding tests! […] Done https://review.coreboot.org/c/flashrom/+/86875/comment/afefb00f_f51d78f0?us… : PS4, Line 59: and > unfinished sentence? fixed https://review.coreboot.org/c/flashrom/+/86875/comment/fab052dd_344858d3?us… : PS4, Line 60: assert_int_equal(last_callback_version, 2); > You don't need the global state for v2 , you upgraded it, so it doesn't need global state! […] I re-implemented tests https://review.coreboot.org/c/flashrom/+/86875/comment/eb8f6956_063b5372?us… : PS4, Line 62: flashrom_set_log_callback(test_log_callback); : print(FLASHROM_MSG_INFO, "%s", "\n"); : /* check that v1 calback set back */ : assert_int_equal(last_callback_version, 1); > why do you reset the callback again (3rd time)? I don't think API clients would be setting callbacks […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 5 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 22 Mar 2025 02:25:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit