- flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: Extract SPI declarations to the correct header
by Antonio Vázquez Blanco (Code Review) 09 Dec '24

09 Dec '24

Antonio Vázquez Blanco has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/85539?usp=email ) Change subject: Extract SPI declarations to the correct header ...................................................................... Extract SPI declarations to the correct header Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M edi.c M include/flash.h M include/programmer.h M include/spi.h M rpmc.c M spi.c 6 files changed, 17 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/39/85539/1 diff --git a/edi.c b/edi.c index 56ed62c..0d504e7 100644 --- a/edi.c +++ b/edi.c @@ -15,6 +15,7 @@ */ #include <string.h> +#include <spi.h> #include "flash.h" #include "chipdrivers.h" #include "ene.h" diff --git a/include/flash.h b/include/flash.h index 629ef3a..f5ec4da 100644 --- a/include/flash.h +++ b/include/flash.h @@ -758,17 +758,6 @@ void init_progress(struct flashctx *flash, enum flashrom_progress_stage stage, size_t total); void update_progress(struct flashctx *flash, enum flashrom_progress_stage stage, size_t increment); -/* spi.c */ -struct spi_command { - unsigned int writecnt; - unsigned int readcnt; - const unsigned char *writearr; - unsigned char *readarr; -}; -#define NULL_SPI_CMD { 0, 0, NULL, NULL, } -int spi_send_command(const struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, const unsigned char *writearr, unsigned char *readarr); -int spi_send_multicommand(const struct flashctx *flash, struct spi_command *cmds); - enum chipbustype get_buses_supported(void); #endif /* !__FLASH_H__ */ diff --git a/include/programmer.h b/include/programmer.h index babb0bc..4784be1 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -23,6 +23,7 @@ #include <stdbool.h> #include <stdint.h> +#include <spi.h> #include "flash.h" /* for chipaddr and flashctx */ enum programmer_type { diff --git a/include/spi.h b/include/spi.h index 505aecd..f5519d3 100644 --- a/include/spi.h +++ b/include/spi.h @@ -16,6 +16,8 @@ #ifndef __SPI_H__ #define __SPI_H__ 1 +#include <flash.h> + /* * Contains the generic SPI headers */ @@ -235,6 +237,16 @@ #define SPI_FLASHROM_BUG -5 #define SPI_PROGRAMMER_ERROR -6 +struct spi_command { + unsigned int writecnt; + unsigned int readcnt; + const unsigned char *writearr; + unsigned char *readarr; +}; +#define NULL_SPI_CMD { 0, 0, NULL, NULL, } +int spi_send_command(const struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, const unsigned char *writearr, unsigned char *readarr); +int spi_send_multicommand(const struct flashctx *flash, struct spi_command *cmds); + void clear_spi_id_cache(void); #endif /* !__SPI_H__ */ diff --git a/rpmc.c b/rpmc.c index 72b0f2f..27e9332 100644 --- a/rpmc.c +++ b/rpmc.c @@ -23,6 +23,7 @@ #include <openssl/evp.h> #include <openssl/rand.h> #include <string.h> +#include <spi.h> // OP1 commands #define RPMC_WRITE_ROOT_KEY_MSG_LENGTH (RPMC_OP1_MSG_HEADER_LENGTH + RPMC_HMAC_KEY_LENGTH + RPMC_TRUNCATED_SIG_LENGTH) diff --git a/spi.c b/spi.c index b2ffc33..99f60fa 100644 --- a/spi.c +++ b/spi.c @@ -18,13 +18,13 @@ * Contains the generic SPI framework */ +#include <spi.h> + #include <strings.h> #include <string.h> -#include "flash.h" #include "flashchips.h" #include "chipdrivers.h" #include "programmer.h" -#include "spi.h" static int default_spi_send_command(const struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, -- To view, visit https://review.coreboot.org/c/flashrom/+/85539?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Gerrit-Change-Number: 85539 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com>

1 0

[XS] Change in flashrom[main]: Extract programmer declarations to the correct header
by Antonio Vázquez Blanco (Code Review) 09 Dec '24

09 Dec '24

Antonio Vázquez Blanco has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/85538?usp=email ) Change subject: Extract programmer declarations to the correct header ...................................................................... Extract programmer declarations to the correct header Change-Id: Ib37b33417154f666d7f72a904381cdf32f6ecc77 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M include/flash.h M include/programmer.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/85538/1 diff --git a/include/flash.h b/include/flash.h index 629ef3a..a845186 100644 --- a/include/flash.h +++ b/include/flash.h @@ -769,6 +769,4 @@ int spi_send_command(const struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, const unsigned char *writearr, unsigned char *readarr); int spi_send_multicommand(const struct flashctx *flash, struct spi_command *cmds); -enum chipbustype get_buses_supported(void); - #endif /* !__FLASH_H__ */ diff --git a/include/programmer.h b/include/programmer.h index babb0bc..e0630b8 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -526,4 +526,6 @@ (flash->chip->feature_bits & (FEATURE_4BA_ENTER | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_ENTER_EAR7)); } +enum chipbustype get_buses_supported(void); + #endif /* !__PROGRAMMER_H__ */ -- To view, visit https://review.coreboot.org/c/flashrom/+/85538?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib37b33417154f666d7f72a904381cdf32f6ecc77 Gerrit-Change-Number: 85538 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com>

1 0

[S] Change in flashrom[main]: Add Glasgow to supported serprog programmers documentation
by Name of user not set (Code Review) 08 Dec '24

08 Dec '24

cattusqq(a)gmail.com has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/85527?usp=email ) Change subject: Add Glasgow to supported serprog programmers documentation ...................................................................... Add Glasgow to supported serprog programmers documentation Updated the serprog overview page with info about the Glasgow Interface Explorer as a valid programmer. Wasnt able to test as the project wouldnt compile with meson for me (MacOS 15.1) but tried to make it as similar as possible to what was already there. Change-Id: Iabcec27dd675485c69875178858c604ce5c3da29 Signed-off-by: Cattus QQ <cattusqq(a)gmail.com> --- A doc/supported_hw/supported_prog/serprog/300px-glasgow-in-case.png A doc/supported_hw/supported_prog/serprog/300px-glasgow-pcba.png M doc/supported_hw/supported_prog/serprog/overview.rst 3 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/27/85527/1 diff --git a/doc/supported_hw/supported_prog/serprog/300px-glasgow-in-case.png b/doc/supported_hw/supported_prog/serprog/300px-glasgow-in-case.png new file mode 100644 index 0000000..8630424 --- /dev/null +++ b/doc/supported_hw/supported_prog/serprog/300px-glasgow-in-case.png Binary files differ diff --git a/doc/supported_hw/supported_prog/serprog/300px-glasgow-pcba.png b/doc/supported_hw/supported_prog/serprog/300px-glasgow-pcba.png new file mode 100644 index 0000000..b06bb9f --- /dev/null +++ b/doc/supported_hw/supported_prog/serprog/300px-glasgow-pcba.png Binary files differ diff --git a/doc/supported_hw/supported_prog/serprog/overview.rst b/doc/supported_hw/supported_prog/serprog/overview.rst index ba01b02..6088414 100644 --- a/doc/supported_hw/supported_prog/serprog/overview.rst +++ b/doc/supported_hw/supported_prog/serprog/overview.rst @@ -93,3 +93,16 @@ `Riku_V's fork <https://codeberg.org/Riku_V/pico-serprog>`_ which uses the hardware SPI implementation instead of SPI over PIO (programmable IO) which sacrifices arbitrary pinouts. The fork also implements custom USB descriptors which allow for custom udev-rules. + +Glasgow Interface Explorer by Whitequark +======================================== + +.. image:: 300px-glasgow-in-case.png +.. image:: 300px-glasgow-pcba.png + +The Glasgow Interface Explorer is a tool for programming, debugging, and analysing digital electronics. +It is based on an FPGA and a microcontroller, and can be used as a serprog programmer. +Source for the Glasgow Project can be found `here <https://github.com/GlasgowEmbedded/glasgow>`_. +For example use with Flashrom and serprog, see `this blog post <https://cattusqq.github.io/posts/Firmware_Dumping_with_SPI/>`_. + +76hPuPkpDOTAxj7TegVqV8UkmKEjZ8TvLLBoDoVPpw \ No newline at end of file -- To view, visit https://review.coreboot.org/c/flashrom/+/85527?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iabcec27dd675485c69875178858c604ce5c3da29 Gerrit-Change-Number: 85527 Gerrit-PatchSet: 1 Gerrit-Owner: cattusqq(a)gmail.com

1 0

[S] Change in flashrom[main]: cli_classic: Add option to use first detected chip if multiple found
by Matt DeVillier (Code Review) 08 Dec '24

08 Dec '24

Attention is currently required from: Anastasia Klimchuk, David Hendricks. Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/flashrom/+/85160?usp=email ) Change subject: cli_classic: Add option to use first detected chip if multiple found ...................................................................... Patch Set 2: (1 comment) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/85160/comment/021bfeb3_32c4dc71?us… : PS2, Line 133: " --use-first-chip in cases where multiple chips are detected, use the first one found\n" > For your use case, are you interested at all in WP feature? If yes, I am not sure it would work with the strategy of choosing first matching model always. in 99% of cases, WP is already disabled when doing the initial flash via ChromeOS, but I do use `--wp-status` and `--wp-disable` to be sure. > If most of chips in this context are new enough to support SFDP, would you consider trying SFDP auto-detection first? Specifically, that's adding -c "SFDP-capable chip" to command line, so that instead of going through the full list flashrom only tries to talk to chip as a generic "SFDP-capable chip"? I tested this on a few older devices (Haswell, Broadwell, Sany/IvyBridge) and none of them support SFDP, so report chip not found when using the `-c "SFDP-capable chip` param -- To view, visit https://review.coreboot.org/c/flashrom/+/85160?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0427b1ef80e4eca16623f0fc9119d79f7dd62551 Gerrit-Change-Number: 85160 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 08 Dec 2024 02:42:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: cli_classic: Add option to use first detected chip if multiple found
by Anastasia Klimchuk (Code Review) 06 Dec '24

06 Dec '24

Attention is currently required from: David Hendricks, Matt DeVillier. Anastasia Klimchuk has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/flashrom/+/85160?usp=email ) Change subject: cli_classic: Add option to use first detected chip if multiple found ...................................................................... Patch Set 2: (1 comment) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/85160/comment/9e9a871e_3c7edd88?us… : PS2, Line 133: " --use-first-chip in cases where multiple chips are detected, use the first one found\n" > The context is very useful, thank you. […] Hello Matt, just checking, what do you think about all the above? Purely as an example, an output for `flashrom -p dummy:emulate=MX25L6436 -c "SFDP-capable chip" -VV` has these lines (at the time of writing): ``` Probing for Unknown SFDP-capable chip, 0 kB: SFDP revision = 1.0 SFDP number of parameter headers is 2 (NPH = 1). SFDP parameter table header 0/1: ID 0x00, version 1.0 Length 36 B, Parameter Table Pointer 0x00001c Parsing JEDEC flash parameter table... 3-Byte only addressing. Status register is non-volatile and the standard does not allow vendors to tell us whether EWSR/WREN is needed for status register writes - assuming EWSR. Write chunk size is at least 64 B. Flash chip size is 8192 kB. Block eraser 0: 2048 x 4096 B with opcode 0x20 Tried to add a duplicate block eraser: 2048 x 4096 B with opcode 0x20. Block eraser 1: 256 x 32768 B with opcode 0x52 Block eraser 2: 128 x 65536 B with opcode 0xd8 done. SFDP parameter table header 1/1: ID 0xc2, version 1.0 Length 16 B, Parameter Table Pointer 0x000048 Support for SFDP Page with ID 0xc2 not implemented, skipping it. ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/85160?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0427b1ef80e4eca16623f0fc9119d79f7dd62551 Gerrit-Change-Number: 85160 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Fri, 06 Dec 2024 08:37:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: flashchips.c: Add reg_bits for W25Q256JW
by Anastasia Klimchuk (Code Review) 06 Dec '24

06 Dec '24

Attention is currently required from: Hsuan Ting Chen, Kapil Porwal. Anastasia Klimchuk has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/flashrom/+/85323?usp=email ) Change subject: flashchips.c: Add reg_bits for W25Q256JW ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Thanks everyone, for contribution and reviews! […] Kapil, the patch CB:83307 is submitted, so you can go ahead. You need to move your code to `winbond.c`, upload new patchset (make sure it builds), and then resolve this comment. Thanks. -- To view, visit https://review.coreboot.org/c/flashrom/+/85323?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I050754b28a90911a50f891869297524ce9a6720e Gerrit-Change-Number: 85323 Gerrit-PatchSet: 2 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Fri, 06 Dec 2024 06:33:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: Extract cli_output declarations to a separate header.
by Anastasia Klimchuk (Code Review) 06 Dec '24

06 Dec '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85134?usp=email ) Change subject: Extract cli_output declarations to a separate header. ...................................................................... Extract cli_output declarations to a separate header. This is a simple refactor that aims to simplify maintenance and to clarify file dependency inside the project. Currently, many declarations reside in flash.h making it difficult to really understand file dependency. Change-Id: I4209d5ed205ca14c39e83aa923e103b7282a7059 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85134 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M cli_classic.c M cli_output.c A include/cli_output.h M include/flash.h 4 files changed, 35 insertions(+), 9 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/cli_classic.c b/cli_classic.c index f622720..1a0565b 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -26,6 +26,7 @@ #include <stdlib.h> #include <stdint.h> #include <cli_getopt.h> +#include <cli_output.h> #include "flash.h" #include "flashchips.h" #include "fmap.h" diff --git a/cli_output.c b/cli_output.c index 20295b8..a8b8d7c 100644 --- a/cli_output.c +++ b/cli_output.c @@ -15,11 +15,12 @@ * GNU General Public License for more details. */ +#include <cli_output.h> + #include <stdio.h> #include <stdarg.h> #include <string.h> #include <errno.h> -#include "flash.h" enum flashrom_log_level verbose_screen = FLASHROM_MSG_INFO; enum flashrom_log_level verbose_logfile = FLASHROM_MSG_DEBUG2; diff --git a/include/cli_output.h b/include/cli_output.h new file mode 100644 index 0000000..3a3db88 --- /dev/null +++ b/include/cli_output.h @@ -0,0 +1,31 @@ +/* + * This file is part of the flashrom project. + * + * Copyright 2024 Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __CLI_OUTPUT_H__ +#define __CLI_OUTPUT_H__ + +#include <stdarg.h> +#include <flash.h> + +extern enum flashrom_log_level verbose_screen; +extern enum flashrom_log_level verbose_logfile; +int open_logfile(const char * const filename); +int close_logfile(void); +void start_logging(void); +int flashrom_print_cb(enum flashrom_log_level level, const char *fmt, va_list ap); +void flashrom_progress_cb(struct flashrom_flashctx *flashctx); + +#endif /* __CLI_OUTPUT_H__ */ diff --git a/include/flash.h b/include/flash.h index a1f1551..629ef3a 100644 --- a/include/flash.h +++ b/include/flash.h @@ -726,14 +726,7 @@ /* cli_common.c */ void print_chip_support_status(const struct flashchip *chip); -/* cli_output.c */ -extern enum flashrom_log_level verbose_screen; -extern enum flashrom_log_level verbose_logfile; -int open_logfile(const char * const filename); -int close_logfile(void); -void start_logging(void); -int flashrom_print_cb(enum flashrom_log_level level, const char *fmt, va_list ap); -void flashrom_progress_cb(struct flashrom_flashctx *flashctx); +/* libflashrom.c */ /* Let gcc and clang check for correct printf-style format strings. */ int print(enum flashrom_log_level level, const char *fmt, ...) #ifdef __MINGW32__ -- To view, visit https://review.coreboot.org/c/flashrom/+/85134?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I4209d5ed205ca14c39e83aa923e103b7282a7059 Gerrit-Change-Number: 85134 Gerrit-PatchSet: 4 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: Extract cli_output declarations to a separate header.
by Anastasia Klimchuk (Code Review) 06 Dec '24

06 Dec '24

Attention is currently required from: Antonio Vázquez Blanco. Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85134?usp=email ) Change subject: Extract cli_output declarations to a separate header. ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS2: > I leave this unresolved comment as a note this patch will be submitted after v1.5.0 tag is done. […] Done, and I rebased the patch because there was another patch modifying cli_classic -- To view, visit https://review.coreboot.org/c/flashrom/+/85134?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I4209d5ed205ca14c39e83aa923e103b7282a7059 Gerrit-Change-Number: 85134 Gerrit-PatchSet: 3 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Comment-Date: Fri, 06 Dec 2024 06:27:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: doc: Double-clarify that mailing list is public
by Anastasia Klimchuk (Code Review) 06 Dec '24

06 Dec '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85277?usp=email ) Change subject: doc: Double-clarify that mailing list is public ...................................................................... doc: Double-clarify that mailing list is public Change-Id: Id8e0daf75e25e6153a80fb9444547bdf91d1d343 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85277 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M doc/contact.rst 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved diff --git a/doc/contact.rst b/doc/contact.rst index 38888fb..3ddea6e 100644 --- a/doc/contact.rst +++ b/doc/contact.rst @@ -16,6 +16,11 @@ Please note that the list is moderated for non-subscribers and we recommend to subscribe first. +Our mailing list is public and archived, see below for the links to the archives. +There are also a bunch of independent public archives services that are not operated by the flashrom team. +All those archives are also public, everyone on the internet can read them, +please be careful what kind of information you are sending to the mailing list. + Subscription """""""""""" https://mail.coreboot.org/postorius/lists/flashrom.flashrom.org/ -- To view, visit https://review.coreboot.org/c/flashrom/+/85277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id8e0daf75e25e6153a80fb9444547bdf91d1d343 Gerrit-Change-Number: 85277 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: doc: Double-clarify that mailing list is public
by Anastasia Klimchuk (Code Review) 06 Dec '24

06 Dec '24

Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85277?usp=email ) Change subject: doc: Double-clarify that mailing list is public ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Leaving unresolved comment as a note to submit this after v1.5.0 tag is done. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/85277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id8e0daf75e25e6153a80fb9444547bdf91d1d343 Gerrit-Change-Number: 85277 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 06 Dec 2024 06:16:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit