- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: flashchips: Add Spansion S25FS512S
by Anton Samsonov (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Nikolai Artemiev, Stefan Reinauer. Hello Anastasia Klimchuk, Anton Samsonov, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85585?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips: Add Spansion S25FS512S ...................................................................... flashchips: Add Spansion S25FS512S Tested probe, read, erase, write on FS512SAIF01 chips using Linux SPI and DediProg SF100 programmers. This change affects S25FL512S identification as well, so that both chips can be unambiguously detected by probing. Datasheets used: * Infineon-S25FS512S_512_Mb_1-DataSheet-v16_00-EN.pdf at https://www.infineon.com/dgdl/?fileId=8ac78c8c7d0d8da4017d0ed681a356fe * Infineon-S25FL512S_512_Mb_64_MB_FL-S_Flash_SPI_Multi-I_O_3-DataSheet-v21_00-EN.pdf at https://www.infineon.com/dgdl/?fileId=8ac78c8c7d0d8da4017d0ed046ae4b53 Change-Id: I40b6c081ec7d57eac4f6d2b69cea3878bc92bb47 Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> --- M flashchips/spansion.c M include/flashchips.h M s25f.c 3 files changed, 51 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/85585/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85585?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I40b6c081ec7d57eac4f6d2b69cea3878bc92bb47 Gerrit-Change-Number: 85585 Gerrit-PatchSet: 2 Gerrit-Owner: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru>

1 0

[M] Change in flashrom[main]: flashchips: Add Spansion S25FS512S
by Anton Samsonov (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Anton Samsonov. Hello Anton Samsonov, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/85585?usp=email to review the following change. Change subject: flashchips: Add Spansion S25FS512S ...................................................................... flashchips: Add Spansion S25FS512S Tested probe, read, erase, write on FS512SAIF01 chips using Linux SPI and DediProg SF100 programmers. This change affects S25FL512S identification as well, so that both chips can be unambiguously detected by probing. Datasheets used: * Infineon-S25FS512S_512_Mb_1-DataSheet-v16_00-EN.pdf at https://www.infineon.com/dgdl/?fileId=8ac78c8c7d0d8da4017d0ed681a356fe * Infineon-S25FL512S_512_Mb_64_MB_FL-S_Flash_SPI_Multi-I_O_3-DataSheet-v21_00-EN.pdf at https://www.infineon.com/dgdl/?fileId=8ac78c8c7d0d8da4017d0ed046ae4b53 Change-Id: I40b6c081ec7d57eac4f6d2b69cea3878bc92bb47 Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> --- M flashchips.c M include/flashchips.h M s25f.c 3 files changed, 52 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/85585/1 diff --git a/flashchips.c b/flashchips.c index 0e83200..3695622 100644 --- a/flashchips.c +++ b/flashchips.c @@ -19334,7 +19334,7 @@ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_NATIVE | FEATURE_4BA_ENTER_EAR7 | FEATURE_4BA_EAR_1716, .tested = TEST_UNTESTED, - .probe = PROBE_SPI_RDID, + .probe = PROBE_SPI_BIG_SPANSION, .probe_timing = TIMING_ZERO, .block_erasers = { @@ -19422,6 +19422,53 @@ }, { + .vendor = "Spansion", + .name = "S25FS512S", + .bustype = BUS_SPI, + .manufacture_id = SPANSION_ID, + .model_id = SPANSION_S25FS512S, + .total_size = 65536, + .page_size = 256, /* 256 or 512 bytes page programming buffer */ + /* OTP: 1024B total, 32B reserved; read 0x4B; write 0x42 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI | + FEATURE_4BA_NATIVE | FEATURE_4BA_ENTER, + /* Note on FEATURE_4BA_ENTER: the command set only defines command 0xB7 + to enter 4BA mode, but there is no counterpart command "Exit 4BA mode", + and the code 0xE9 is assigned to another command ("Password unlock"). */ + /* Note on FEATURE_4BA_ENTER_EAR7 (not set): the "Extended address mode" bit + is stored in configuration register CR2V[7], which can only be read / written + by generic commands ("Read any register" / "Write any register"), that itself + expect a 3- or 4-byte address of register in question, which in turn depends on + the same register, that is initially set from non-volatile register CR2NV[7] + that defaults to 0, but can be programmed to 1 for starting in 32-bit mode. */ + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_BIG_SPANSION, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { { 256 * 1024, 256} }, + .block_erase = SPI_BLOCK_ERASE_DC, + }, { + .eraseblocks = { { 256 * 1024, 256} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { { 65536 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { { 65536 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP2_EP_SRWD, /* TODO: SR2 and many others */ + .unlock = SPI_DISABLE_BLOCKPROTECT_BP2_SRWD, /* TODO: various other locks */ + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {1700, 2000}, + }, + + + { .vendor = "SyncMOS/MoselVitelic", .name = "{F,S,V}29C51001B", .bustype = BUS_PARALLEL, diff --git a/include/flashchips.h b/include/flashchips.h index 0fea690..26cef4f 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -701,7 +701,7 @@ #define SPANSION_S25FL064A 0x0216 /* Same as S25FL064P, but the latter supports EDI and CFI */ #define SPANSION_S25FL128 0x2018 /* Same ID for various S25FL127S, S25FL128P, S25FL128S and S25FL129P (including dual-die S70FL256P) variants (EDI supported) */ #define SPANSION_S25FL256 0x0219 -#define SPANSION_S25FL512 0x0220 +#define SPANSION_S25FL512 0x02200080 #define SPANSION_S25FL204 0x4013 #define SPANSION_S25FL208 0x4014 #define SPANSION_S25FL216 0x4015 /* Same as S25FL216K, but the latter supports OTP, 3 status regs, quad I/O, SFDP etc. */ @@ -714,6 +714,7 @@ #define SPANSION_S25FS128S_S 0x20180181 /* Small sectors. */ #define SPANSION_S25FS256S_L 0x02190081 /* Large sectors. */ #define SPANSION_S25FS256S_S 0x02190181 /* Small sectors. */ +#define SPANSION_S25FS512S 0x02200081 /* Uniform Large (256kB) sectors */ #define SPANSION_S25FL128S_UL 0x20180080 /* Uniform Large (128kB) sectors */ #define SPANSION_S25FL128S_US 0x20180180 /* Uniform Small (64kB) sectors */ #define SPANSION_S25FL256S_UL 0x02190080 /* Uniform Large (128kB) sectors */ diff --git a/s25f.c b/s25f.c index b0f2438..dc90dc4 100644 --- a/s25f.c +++ b/s25f.c @@ -371,10 +371,8 @@ * * offset value meaning * 00h 01h Manufacturer ID for Spansion - * 01h 20h 128 Mb capacity - * 01h 02h 256 Mb capacity - * 02h 18h 128 Mb capacity - * 02h 19h 256 Mb capacity + * 01h * Memory interface type (02h, 20h, 40h, 60h) + * 02h * Memory capacity (18h = 128 Mb, 19h = 256 Mb, 20h = 512 Mb) * 03h 4Dh Full size of the RDID output (ignored) * 04h 00h FS: 256-kB physical sectors * 04h 01h FS: 64-kB physical sectors -- To view, visit https://review.coreboot.org/c/flashrom/+/85585?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I40b6c081ec7d57eac4f6d2b69cea3878bc92bb47 Gerrit-Change-Number: 85585 Gerrit-PatchSet: 1 Gerrit-Owner: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru>

1 0

[XS] Change in flashrom[main]: Extract programmer declarations to the correct header
by Anastasia Klimchuk (Code Review) 12 Dec '24

12 Dec '24

Attention is currently required from: Antonio Vázquez Blanco. Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85538?usp=email ) Change subject: Extract programmer declarations to the correct header ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: That's a good one, thank you! and all the programmers already include programmer.h -- To view, visit https://review.coreboot.org/c/flashrom/+/85538?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib37b33417154f666d7f72a904381cdf32f6ecc77 Gerrit-Change-Number: 85538 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Comment-Date: Thu, 12 Dec 2024 12:08:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: Extract SPI declarations to the correct header
by Anastasia Klimchuk (Code Review) 12 Dec '24

12 Dec '24

Attention is currently required from: Antonio Vázquez Blanco, David Reguera Garcia (Dreg), Matti Finder, Miklós Márton, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85539?usp=email ) Change subject: Extract SPI declarations to the correct header ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: This is a nice clean up across the tree, thank you everyone! Commit Message: https://review.coreboot.org/c/flashrom/+/85539/comment/659c3b9d_3bd65290?us… : PS2, Line 8: My only comment here is that now that the patch goes across the whole tree, maybe you can add to a commit description, to mention that after moving spi declarations some of the file don't need to include flash.h because spi.h is sufficient, and so includes of flash.h are removed where they are unnecessary. -- To view, visit https://review.coreboot.org/c/flashrom/+/85539?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Gerrit-Change-Number: 85539 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com> Gerrit-Attention: Matti Finder <matti.finder(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 12 Dec 2024 12:00:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: Add Glasgow to supported serprog programmers documentation
by Anastasia Klimchuk (Code Review) 12 Dec '24

12 Dec '24

Attention is currently required from: cattusqq(a)gmail.com. Anastasia Klimchuk has posted comments on this change by cattusqq(a)gmail.com. ( https://review.coreboot.org/c/flashrom/+/85527?usp=email ) Change subject: Add Glasgow to supported serprog programmers documentation ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: One more thing I forgot: in the email from Gerrit your name is "Name of user not set". I think you need to do p.6 from here https://flashrom.org/dev_guide/development_guide.html#creating-an-account -- To view, visit https://review.coreboot.org/c/flashrom/+/85527?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iabcec27dd675485c69875178858c604ce5c3da29 Gerrit-Change-Number: 85527 Gerrit-PatchSet: 1 Gerrit-Owner: cattusqq(a)gmail.com Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: cattusqq(a)gmail.com Gerrit-Comment-Date: Thu, 12 Dec 2024 08:57:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: Add Glasgow to supported serprog programmers documentation
by Anastasia Klimchuk (Code Review) 12 Dec '24

12 Dec '24

Attention is currently required from: cattusqq(a)gmail.com. Anastasia Klimchuk has posted comments on this change by cattusqq(a)gmail.com. ( https://review.coreboot.org/c/flashrom/+/85527?usp=email ) Change subject: Add Glasgow to supported serprog programmers documentation ...................................................................... Patch Set 1: (5 comments) Patchset: PS1: Cattus, thank you for the contribution, and nice to meet you. I read your post, I like it so much, very detailed information, it's just great! - I held my breath when I read that the chip was not recognised... But then I kept reading and there was a happy ending at the end :) - Somewhere in the middle there was a link on how to "write a mapping for flashrom", just wanted to say we also have a doc on this https://flashrom.org/contrib_howtos/how_to_add_new_chip.html. We did split a giant flashchips.c into a per-vendor file recently. - If you want you can try to enable write-protection capability for the chip: because you have the datasheet and the actual chip. There is a section about it in the doc: https://flashrom.org/contrib_howtos/how_to_add_new_chip.html#write-protecti…. For the examples, look for the chip definitions that have test status TEST_OK_PREWB Commit Message: https://review.coreboot.org/c/flashrom/+/85527/comment/1e9bc633_fd397b83?us… : PS1, Line 10: the project wouldnt compile with meson for me (MacOS 15.1) I first thought that flashrom does not compile, but then I read your blog post and now I think maybe that's the documentation did not compile? I downloaded your patch and built with documentation, and so I added two comments (as you see below). https://review.coreboot.org/c/flashrom/+/85527/comment/18e71279_d6bdcb84?us… : PS1, Line 9: Updated the serprog overview page with info about the Glasgow Interface Explorer as a valid programmer. : Wasnt able to test as the project wouldnt compile with meson for me (MacOS 15.1) : but tried to make it as similar as possible to what was already there. We wrap commit message by 72 chars, and I think the first line is longer (maybe the second one too) https://flashrom.org/dev_guide/development_guide.html#commit-message-1 File doc/supported_hw/supported_prog/serprog/overview.rst: https://review.coreboot.org/c/flashrom/+/85527/comment/80bf589f_616b08ef?us… : PS1, Line 105: Source for the Glasgow Project can be found `here <https://github.com/GlasgowEmbedded/glasgow>`_ This gives a warning `WARNING: Duplicate explicit target name: "here".` So maybe you can change slightly, for example Here is the <source for the Glasgow Project> (in <> brackets would be the link text) https://review.coreboot.org/c/flashrom/+/85527/comment/edef2f8e_6a300892?us… : PS1, Line 108: 76hPuPkpDOTAxj7TegVqV8UkmKEjZ8TvLLBoDoVPpw What is this hash? :) I assume that's by mistake? -- To view, visit https://review.coreboot.org/c/flashrom/+/85527?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iabcec27dd675485c69875178858c604ce5c3da29 Gerrit-Change-Number: 85527 Gerrit-PatchSet: 1 Gerrit-Owner: cattusqq(a)gmail.com Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: cattusqq(a)gmail.com Gerrit-Comment-Date: Thu, 12 Dec 2024 08:56:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: Extract SPI declarations to the correct header
by Peter Marheine (Code Review) 09 Dec '24

09 Dec '24

Attention is currently required from: Anastasia Klimchuk, Antonio Vázquez Blanco, David Reguera Garcia (Dreg), Matti Finder, Miklós Márton, Nikolai Artemiev, Sergii Dmytruk. Peter Marheine has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85539?usp=email ) Change subject: Extract SPI declarations to the correct header ...................................................................... Patch Set 2: (2 comments) File edi.c: https://review.coreboot.org/c/flashrom/+/85539/comment/107cd861_f79f24d4?us… : PS2, Line 18: #include <spi.h> These are not system includes, so the newly-added lines should still be quoted (`"spi.h"`). That goes for all of these `<spi.h>` occurrences. File include/spi.h: https://review.coreboot.org/c/flashrom/+/85539/comment/8e57b371_0609e974?us… : PS2, Line 19: #include <flash.h> Same as for `spi.h`, quote this instead of using angle brackets. -- To view, visit https://review.coreboot.org/c/flashrom/+/85539?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Gerrit-Change-Number: 85539 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Matti Finder <matti.finder(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 09 Dec 2024 22:23:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: Extract SPI declarations to the correct header
by Antonio Vázquez Blanco (Code Review) 09 Dec '24

09 Dec '24

Attention is currently required from: Anastasia Klimchuk, David Reguera Garcia (Dreg), Matti Finder, Miklós Márton, Nikolai Artemiev, Peter Marheine, Sergii Dmytruk. Antonio Vázquez Blanco has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85539?usp=email ) Change subject: Extract SPI declarations to the correct header ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Since you moved spi_send_command to spi.h the `#include "flash.h"` from rpmc.c can be removed. […] I hope I did not miss any... Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/85539?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Gerrit-Change-Number: 85539 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Matti Finder <matti.finder(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 09 Dec 2024 20:41:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matti Finder <matti.finder(a)gmail.com>

1 0

[M] Change in flashrom[main]: Extract SPI declarations to the correct header
by Antonio Vázquez Blanco (Code Review) 09 Dec '24

09 Dec '24

Attention is currently required from: Anastasia Klimchuk, Antonio Vázquez Blanco. Hello Anastasia Klimchuk, Matti Finder, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85539?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Extract SPI declarations to the correct header ...................................................................... Extract SPI declarations to the correct header Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M amd_imc.c M at45db.c M bitbang_spi.c M buspirate_spi.c M dediprog.c M dummyflasher.c M edi.c M ft2232_spi.c M ichspi.c M include/flash.h M include/programmer.h M include/spi.h M it87spi.c M jlink_spi.c M linux_spi.c M mediatek_i2c_spi.c M mstarddc_spi.c M ni845x_spi.c M nicintel_eeprom.c M pickit2_spi.c M rpmc.c M sb600spi.c M sfdp.c M spi.c M spi25.c M spi25_statusreg.c M stlinkv3_spi.c M usbblaster_spi.c M wbsio_spi.c M writeprotect.c 30 files changed, 17 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/39/85539/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85539?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Gerrit-Change-Number: 85539 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: Extract SPI declarations to the correct header
by Matti Finder (Code Review) 09 Dec '24

09 Dec '24

Attention is currently required from: Anastasia Klimchuk, Antonio Vázquez Blanco. Matti Finder has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85539?usp=email ) Change subject: Extract SPI declarations to the correct header ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Since you moved spi_send_command to spi.h the `#include "flash.h"` from rpmc.c can be removed. This is probably also the case in edi.c and also a lot of other files within flashrom. I think changing them within this commit would make sense, so that this doesn't get missed later. -- To view, visit https://review.coreboot.org/c/flashrom/+/85539?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Gerrit-Change-Number: 85539 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 09 Dec 2024 13:03:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit