- flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: flashchips: Remove FEATURE_4BA_WREN for MT25QL128 and mark as tested
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Rick Altherr. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71206 ) Change subject: flashchips: Remove FEATURE_4BA_WREN for MT25QL128 and mark as tested ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/71206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6341456c722840a413bd2c51fe9a78bbda5cdbab Gerrit-Change-Number: 71206 Gerrit-PatchSet: 3 Gerrit-Owner: Rick Altherr <kc8apf(a)kc8apf.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rick Altherr <kc8apf(a)kc8apf.net> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:44:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom.c: Guard against sending spi commands on non-spi mst
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Felix Singer, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71269 ) Change subject: flashrom.c: Guard against sending spi commands on non-spi mst ...................................................................... Patch Set 1: (1 comment) File flashrom.c: https://review.coreboot.org/c/flashrom/+/71269/comment/000f2c2a_7211e799 PS1, Line 1937: spi_master_no_4ba_modes Wouldn't it make more sense to add the bustype check inside this function? -- To view, visit https://review.coreboot.org/c/flashrom/+/71269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7cce4f9c032d33c01bf616e27a50b9727a40fe1b Gerrit-Change-Number: 71269 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:19:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: sb600spi.c: Move promontory code into a mmap_read=yes mode
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71565 ) Change subject: sb600spi.c: Move promontory code into a mmap_read=yes mode ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/71565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I13eb5a646d3569170b3911ae7b3127cd3e6022aa Gerrit-Change-Number: 71565 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:14:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashrom.c: Add wrapper function to use the erase algorithm
by Aarya (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Simon Buhrow, Nico Huber, Edward O'Callaghan, Anastasia Klimchuk. Hello build bot (Jenkins), Simon Buhrow, Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66104 to look at the new patch set (#95). Change subject: flashrom.c: Add wrapper function to use the erase algorithm ...................................................................... flashrom.c: Add wrapper function to use the erase algorithm Add a function to call the erase algorithm. Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M erasure_layout.c M erasure_layout.h 2 files changed, 127 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/66104/95 -- To view, visit https://review.coreboot.org/c/flashrom/+/66104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8 Gerrit-Change-Number: 66104 Gerrit-PatchSet: 95 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in flashrom[master]: flashrom.c:Add function to get a flattened view of the chip erase blocks
by Aarya (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Simon Buhrow, Aarya. Hello build bot (Jenkins), Simon Buhrow, Thomas Heijligen, Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/65844 to look at the new patch set (#76). Change subject: flashrom.c:Add function to get a flattened view of the chip erase blocks ...................................................................... flashrom.c:Add function to get a flattened view of the chip erase blocks Add a function to flatten out the addresses of the flash chip as per the different erase functions. This function will return a list of layouts which is dynamically allocated. So after use all the layouts as well as the list itself should be freed. The free_erase_layout function does that. Change-Id: Iafe78de00daa55f7114bd4ce09465dd88074ece4 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> flashrom.c:Add function to align region to sector boundaries Add a function to align start and end address of the region (in struct walk_info) to some erase sector boundaries and modify the region start and end addresses to match nearest erase sector boundaries. This function will be used in the new algorithm for erase function selection. Change-Id: I215ea4986aa23360fc65ff761f4e49c6069160ac Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> flashrom.c:Add a function to get list of sectors that need erasing Add a function that returns a list of sectors (as seen by the first erase function) that need erasing. Change-Id: Ic57ca1cca3d1646543f6b5939ba9c35db8d08256 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- A erasure_layout.c A erasure_layout.h 2 files changed, 298 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/65844/76 -- To view, visit https://review.coreboot.org/c/flashrom/+/65844 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic57ca1cca3d1646543f6b5939ba9c35db8d08256 Gerrit-Change-Number: 65844 Gerrit-PatchSet: 76 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: flashrom.c:Add function to get a flattened view of the chip erase blocks
by Aarya (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Simon Buhrow, Nico Huber, Thomas Heijligen, Paul Menzel, Edward O'Callaghan. Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65879 ) Change subject: flashrom.c:Add function to get a flattened view of the chip erase blocks ...................................................................... Patch Set 56: (5 comments) File erasure_layout.c: https://review.coreboot.org/c/flashrom/+/65879/comment/7706a14b_e51504f3 PS54, Line 34: create_erase_layout > with the comments below I am expecting a few static functions that should be relatively small and th […] Done https://review.coreboot.org/c/flashrom/+/65879/comment/7cc9557c_974cf765 PS54, Line 74: block_num < block_count > No, `block_num` increases. Done https://review.coreboot.org/c/flashrom/+/65879/comment/c14f5e2f_a5d0c621 PS54, Line 86: (layout[layout_idx-1].layout_list[sub_block_index].start_addr >= start_addr && : layout[layout_idx-1].layout_list[sub_block_index].end_addr <= end_addr && : sub_block_index < layout[layout_idx-1].block_count) > in this new function made out of this `if`-block turn this wild predicate into a intermediate with a […] Done File erasure_layout.c: https://review.coreboot.org/c/flashrom/+/65879/comment/2f65a7a0_ff25c2ec PS55, Line 58: chipoff_t addr = 0; : : for (int i = 0; addr < chip->total_size * 1024; i++) { : const struct eraseblock *block = &chip->block_erasers[eraser_idx].eraseblocks[i]; : block_count += block->count; : addr += block->size * block->count; : } > ``` […] Done https://review.coreboot.org/c/flashrom/+/65879/comment/d64aa7e0_d678b46c PS55, Line 82: layout[layout_idx].layout_list[block_num].start_addr = start_addr; : layout[layout_idx].layout_list[block_num].end_addr = end_addr; : layout[layout_idx].layout_list[block_num].selected = false; : layout[layout_idx].layout_list[block_num].block_num = block_num; : if (layout_idx > 0) { : layout[layout_idx].layout_list[block_num].first_sub_block_index = sub_block_index; : while (layout[layout_idx-1].layout_list[sub_block_index].start_addr >= start_addr && : layout[layout_idx-1].layout_list[sub_block_index].end_addr <= end_addr && : sub_block_index < layout[layout_idx-1].block_count) { : sub_block_index++; : } : layout[layout_idx].layout_list[block_num].last_sub_block_index = sub_block_index - 1; : } > ``` […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/65879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iafe78de00daa55f7114bd4ce09465dd88074ece4 Gerrit-Change-Number: 65879 Gerrit-PatchSet: 56 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sun, 01 Jan 2023 16:22:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Aarya <aarya.chaumal(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashrom.c:Add function to get a flattened view of the chip erase blocks
by Aarya (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Simon Buhrow, Nico Huber, Thomas Heijligen, Paul Menzel, Aarya. Hello build bot (Jenkins), Simon Buhrow, Thomas Heijligen, Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/65879 to look at the new patch set (#56). Change subject: flashrom.c:Add function to get a flattened view of the chip erase blocks ...................................................................... flashrom.c:Add function to get a flattened view of the chip erase blocks Add a function to flatten out the addresses of the flash chip as per the different erase functions. This function will return a list of layouts which is dynamically allocated. So after use all the layouts as well as the list itself should be freed. The free_erase_layout function does that. Change-Id: Iafe78de00daa55f7114bd4ce09465dd88074ece4 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- A erasure_layout.c A erasure_layout.h 2 files changed, 176 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/65879/56 -- To view, visit https://review.coreboot.org/c/flashrom/+/65879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iafe78de00daa55f7114bd4ce09465dd88074ece4 Gerrit-Change-Number: 65879 Gerrit-PatchSet: 56 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: sb600spi.c: Move promontory code into a mmap_read=yes mode
by Arthur Heymans (Code Review) 28 Dec '22

28 Dec '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/71565 to look at the new patch set (#2). Change subject: sb600spi.c: Move promontory code into a mmap_read=yes mode ...................................................................... sb600spi.c: Move promontory code into a mmap_read=yes mode The only reason promontory code is handled differently is because memory mapped reads can be faster than manual SPI sequencing. This is not hardware specific so move it to an option 'mmap_read=yes'. Tested on an amd picasso and genoa board. Change-Id: I13eb5a646d3569170b3911ae7b3127cd3e6022aa Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M flashrom.8.tmpl M sb600spi.c 2 files changed, 71 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/65/71565/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/71565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I13eb5a646d3569170b3911ae7b3127cd3e6022aa Gerrit-Change-Number: 71565 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: sb600spi.c: Move promontory code into a mmap_read=yes mode
by Arthur Heymans (Code Review) 28 Dec '22

28 Dec '22

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/71565 ) Change subject: sb600spi.c: Move promontory code into a mmap_read=yes mode ...................................................................... sb600spi.c: Move promontory code into a mmap_read=yes mode The only reason promontory code is handled differently is because memory mapped reads can be faster than manual SPI sequencing. This is not hardware specific so move it to an option 'mmap_read=yes'. Change-Id: I13eb5a646d3569170b3911ae7b3127cd3e6022aa Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M flashrom.8.tmpl M sb600spi.c 2 files changed, 69 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/65/71565/1 diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index 0eabee5..6e2b4eb 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -599,6 +599,15 @@ -The default is to use the frequency that is currently configured. .sp An optional +.B mmap_read +parameter allows to do memory mapped reads instead of through manual SPI sequencing. +This allows the programmer to use faster modes which can be set with the +.B spireadmode +parameter. This mode is however limited to 16MiB flashchips or smaller as more does not get mapped. +.sp +.B " flashrom \-p internal:mmap_read=yes +.sp +An optional .B spireadmode parameter specifies the read mode of the SPI bus where applicable (Bolton or later). Syntax is diff --git a/sb600spi.c b/sb600spi.c index 5b9ac45..3e1339c 100644 --- a/sb600spi.c +++ b/sb600spi.c @@ -572,9 +572,14 @@ return amd_imc_shutdown(dev); } -static int promontory_read_memmapped(struct flashctx *flash, uint8_t *buf, +static int amd_read_memmapped(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len) { + if (flash->chip->total_size > (16 * MiB) / KiB) { + msg_perr("No more than 16 MiB can be memory mapped.\n" + "Try again without mmap_read=yes"); + return -1; + } struct sb600spi_data * data = (struct sb600spi_data *)flash->mst->spi.data; if (!data->flash) { map_flash(flash); @@ -584,6 +589,34 @@ return 0; } +static int handle_mmap_read(const struct programmer_cfg *cfg, + struct spi_master *master) +{ + bool mmap_read = false; + char *param_value = extract_programmer_param_str(cfg, "mmap_read"); + if (param_value && !strcmp(param_value, "yes")) { + mmap_read = true; + msg_pspew("mmap_read enabled.\n"); + } else if (param_value && !strlen(param_value)) { + msg_perr("Missing argument for mmap_read.\n"); + free(param_value); + return 1; + } else if (param_value) { + msg_perr("Unknown argument for mmap_read: \"%s\" (not \"yes\").\n", param_value); + free(param_value); + return 1; + } + free(param_value); + + if (!mmap_read) + return 0; + + master->max_data_read = MAX_DATA_READ_UNLIMITED; + master->read = amd_read_memmapped; + + return 0; +} + static int sb600spi_shutdown(void *data) { struct sb600spi_data *sb600_data = data; @@ -595,7 +628,7 @@ return 0; } -static const struct spi_master spi_master_sb600 = { +static struct spi_master spi_master_sb600 = { .max_data_read = FIFO_SIZE_OLD, .max_data_write = FIFO_SIZE_OLD - 3, .command = sb600_spi_send_command, @@ -608,7 +641,7 @@ .probe_opcode = default_spi_probe_opcode, }; -static const struct spi_master spi_master_yangtze = { +static struct spi_master spi_master_yangtze = { .max_data_read = FIFO_SIZE_YANGTZE - 3, /* Apparently the big SPI 100 buffer is not a ring buffer. */ .max_data_write = FIFO_SIZE_YANGTZE - 3, .command = spi100_spi_send_command, @@ -621,19 +654,6 @@ .probe_opcode = default_spi_probe_opcode, }; -static const struct spi_master spi_master_promontory = { - .max_data_read = MAX_DATA_READ_UNLIMITED, - .max_data_write = FIFO_SIZE_YANGTZE - 3, - .command = spi100_spi_send_command, - .multicommand = default_spi_send_multicommand, - .map_flash_region = physmap, - .unmap_flash_region = physunmap, - .read = promontory_read_memmapped, - .write_256 = default_spi_write_256, - .shutdown = sb600spi_shutdown, - .probe_opcode = default_spi_probe_opcode, -}; - int sb600_probe_spi(const struct programmer_cfg *cfg, struct pci_dev *dev) { struct pci_dev *smbus_dev; @@ -809,13 +829,18 @@ data->flash = NULL; data->spibar = sb600_spibar; + struct spi_master *master; + /* Starting with Yangtze the SPI controller got a different interface with a much bigger buffer. */ if (amd_gen < CHIPSET_YANGTZE) - register_spi_master(&spi_master_sb600, data); - else if (amd_gen == CHIPSET_YANGTZE) - register_spi_master(&spi_master_yangtze, data); - else - register_spi_master(&spi_master_promontory, data); + master = &spi_master_sb600; + else if (amd_gen >= CHIPSET_YANGTZE) + master = &spi_master_yangtze; + + if (handle_mmap_read(cfg, master)) + return ERROR_FLASHROM_FATAL; + + register_spi_master(master, data); return 0; } -- To view, visit https://review.coreboot.org/c/flashrom/+/71565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I13eb5a646d3569170b3911ae7b3127cd3e6022aa Gerrit-Change-Number: 71565 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: flashrom.c:Add function to get a flattened view of the chip erase blocks
by Edward O'Callaghan (Code Review) 28 Dec '22

28 Dec '22

Attention is currently required from: Simon Buhrow, Nico Huber, Thomas Heijligen, Paul Menzel, Aarya. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65879 ) Change subject: flashrom.c:Add function to get a flattened view of the chip erase blocks ...................................................................... Patch Set 55: (1 comment) File erasure_layout.c: https://review.coreboot.org/c/flashrom/+/65879/comment/a77259ce_7a9f939e PS55, Line 58: chipoff_t addr = 0; : : for (int i = 0; addr < chip->total_size * 1024; i++) { : const struct eraseblock *block = &chip->block_erasers[eraser_idx].eraseblocks[i]; : block_count += block->count; : addr += block->size * block->count; : } ``` static size_t calculate_block_count(const struct flashchip *chip, size_t eraser_idx) { size_t block_count = 0; chipoff_t addr = 0; for (size_t i = 0; addr < chip->total_size * 1024; i++) { const struct eraseblock *block = &chip->block_erasers[eraser_idx].eraseblocks[i]; block_count += block->count; addr += block->size * block->count; } return block_count; } ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/65879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iafe78de00daa55f7114bd4ce09465dd88074ece4 Gerrit-Change-Number: 65879 Gerrit-PatchSet: 55 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Wed, 28 Dec 2022 11:22:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit