Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/69047 )
Change subject: chipdrivers: Rename s/erase_sector_stm50/stm50_sector_erase
......................................................................
chipdrivers: Rename s/erase_sector_stm50/stm50_sector_erase
Change-Id: Ia916b5782abf04499ab46a540820acbe4a171068
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M flashrom.c
M include/chipdrivers.h
M stm50.c
3 files changed, 13 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/69047/1
diff --git a/flashrom.c b/flashrom.c
index ec4ddbc..0f10ad4 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -371,7 +371,7 @@
case ERASE_SECTOR_28SF040: return &erase_sector_28sf040;
case ERASE_BLOCK_82802AB: return &erase_block_82802ab;
case ERASE_SECTOR_49LFXXXC: return &erase_sector_49lfxxxc;
- case STM50_SECTOR_ERASE: return &erase_sector_stm50; // TODO rename to &stm50_sector_erase;
+ case STM50_SECTOR_ERASE: return &stm50_sector_erase;
case EDI_CHIP_BLOCK_ERASE: return &edi_chip_block_erase;
case TEST_ERASE_INJECTOR: return g_test_erase_injector;
/* default: total function, 0 indicates no erase function set.
diff --git a/include/chipdrivers.h b/include/chipdrivers.h
index 3b07afe..9d1db76 100644
--- a/include/chipdrivers.h
+++ b/include/chipdrivers.h
@@ -198,7 +198,7 @@
bool w29ee011_can_override(const char *const chip_name, const char *const override_chip);
/* stm50.c */
-int erase_sector_stm50(struct flashctx *flash, unsigned int block, unsigned int blocksize);
+int stm50_sector_erase(struct flashctx *flash, unsigned int block, unsigned int blocksize);
/* en29lv640b.c */
int probe_en29lv640b(struct flashctx *flash);
diff --git a/stm50.c b/stm50.c
index d495e09..9092a0f 100644
--- a/stm50.c
+++ b/stm50.c
@@ -47,7 +47,7 @@
* the block erase function instead. FIXME: This duplicates the behavior of the remaining erasers for blocks and
* might be fixed when flashrom supports multiple functions per eraser or erasers that do erase parts of the
* chip only. */
-int erase_sector_stm50(struct flashctx *flash, unsigned int addr, unsigned int len)
+int stm50_sector_erase(struct flashctx *flash, unsigned int addr, unsigned int len)
{
if (len == 4096)
return stm50_erase_sector(flash, addr);
--
To view, visit https://review.coreboot.org/c/flashrom/+/69047
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia916b5782abf04499ab46a540820acbe4a171068
Gerrit-Change-Number: 69047
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newchange
Attention is currently required from: Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67091 )
Change subject: flashrom.c: Make 'chip_to_probe' a param to probe_flash()
......................................................................
Patch Set 14: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/67091
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifcdace07ea2135d83dea92cfa5c6bec8d7ddf05d
Gerrit-Change-Number: 67091
Gerrit-PatchSet: 14
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Tue, 01 Nov 2022 01:44:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Evan Benn has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/68643 )
Change subject: flashrom_tester: Use Path type for test data
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/flashrom/+/68643
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4a0b25c8c70fa6dfd682fba3db7d3bf06b2eb7ac
Gerrit-Change-Number: 68643
Gerrit-PatchSet: 3
Gerrit-Owner: Evan Benn <evanbenn(a)google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: abandon
Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67091 )
Change subject: flashrom.c: Make 'chip_to_probe' a param to probe_flash()
......................................................................
Patch Set 14: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/67091
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifcdace07ea2135d83dea92cfa5c6bec8d7ddf05d
Gerrit-Change-Number: 67091
Gerrit-PatchSet: 14
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Tue, 01 Nov 2022 01:28:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67091 )
Change subject: flashrom.c: Make 'chip_to_probe' a param to probe_flash()
......................................................................
Patch Set 13:
(2 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/67091/comment/f0177a99_09c3aa40
PS13, Line 868: goto notfound;
> Please a line after that
Done
File w29ee011.c:
https://review.coreboot.org/c/flashrom/+/67091/comment/cdf54eb1_d3b07caa
PS13, Line 25: override_chip || strcmp(override_chip, chip_name)
> Just an idea, a nit: How about moving this to a variable `can_override`? This also would allow us ha […]
I think there is no need to be overly clever here and possibly make bugs unrelated to the objective of this patch. Marking as resolved.
--
To view, visit https://review.coreboot.org/c/flashrom/+/67091
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifcdace07ea2135d83dea92cfa5c6bec8d7ddf05d
Gerrit-Change-Number: 67091
Gerrit-PatchSet: 13
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Tue, 01 Nov 2022 01:25:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk.
Hello Felix Singer, build bot (Jenkins), Nikolai Artemiev, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/67091
to look at the new patch set (#14).
Change subject: flashrom.c: Make 'chip_to_probe' a param to probe_flash()
......................................................................
flashrom.c: Make 'chip_to_probe' a param to probe_flash()
Apart from the very bespoke case of 'probe_w29ee011()'
the override 'chip_to_probe' name is a nature parameter
to 'probe_flash()'. However we can deal with w29ee011
by providing a probe specific validation function to
check if the chip can indeed be overriden.
TEST=`./flashrom -p internal --flash-name`.
Change-Id: Ifcdace07ea2135d83dea92cfa5c6bec8d7ddf05d
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M cli_classic.c
M flashrom.c
M include/chipdrivers.h
M include/flash.h
M libflashrom.c
M w29ee011.c
6 files changed, 45 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/67091/14
--
To view, visit https://review.coreboot.org/c/flashrom/+/67091
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifcdace07ea2135d83dea92cfa5c6bec8d7ddf05d
Gerrit-Change-Number: 67091
Gerrit-PatchSet: 14
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset