Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Piotr Halama, Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513?usp=email )
Change subject: flashchips: Add support for Boya BY25D80A
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
Patchset:
PS7:
> Peter, you have approved (3 months ago, but still :D ) , I just rebased the patch. […]
Diff is unchanged, so no problem here.
--
To view, visit https://review.coreboot.org/c/flashrom/+/73513?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7
Gerrit-Change-Number: 73513
Gerrit-PatchSet: 7
Gerrit-Owner: Piotr Halama <skrzynka(a)halamix2.pl>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Piotr Halama <skrzynka(a)halamix2.pl>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Sun, 04 Jun 2023 23:55:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
David Williams has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878?usp=email )
Change subject: dirtyjtag: Add DirtyJTAG programmer
......................................................................
Patch Set 17:
(1 comment)
Patchset:
PS17:
There's a typo in the Makefile. We should be adding to FEATURE_FLAGS not FEATURE_CFLAGS.
Without this, the interface *is never (has never?) been loaded*
I wrote this up as an issue in github.
https://github.com/flashrom/flashrom/issues/296
Now, when this bug is fixed, the interface doesn't seem to work. I'm reluctant to debug if this has never been run or tested by people more knowledgeable and skilled than me!
--
To view, visit https://review.coreboot.org/c/flashrom/+/67878?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913
Gerrit-Change-Number: 67878
Gerrit-PatchSet: 17
Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: David Williams
Gerrit-Comment-Date: Sun, 04 Jun 2023 23:17:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Miklós Márton, Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email )
Change subject: doc: Add build instructions for NI-845x on Windows
......................................................................
Patch Set 5:
(1 comment)
File doc/dev_guide/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/75270/comment/6c4d629f_c7ac684b :
PS5, Line 17: * linux-headers†
: * libpci†
: * libusb1†
: * libftdi1†
: * libjaylink†
: * NI-845x driver & library package‡
:
: | \* optional, for building unit testing
: | † optional, depending on the selected programmer
: | ‡ optional, proprietary and Windows only. (See Windows build instructions)
> How about using [Footnotes](https://www.sphinx-doc.org/en/master/usage/restructuredtext/basi…. […]
I thought it made more sense to keep these near the list, since it seems unnecessarily difficult to scroll to the bottom of the page for these notes that don't really stand alone. It would be a different story if there were a footnote-but-place-it-after-this-paragraph construct, but there doesn't seem to be any such thing.
The paragraph above does the same thing, so if we wanted to debate such a change it seems like something to do in another commit (and change both of them).
--
To view, visit https://review.coreboot.org/c/flashrom/+/75270?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a
Gerrit-Change-Number: 75270
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Sun, 04 Jun 2023 23:16:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, Miklós Márton, Peter Marheine, Thomas Heijligen.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email )
Change subject: doc: Add build instructions for NI-845x on Windows
......................................................................
Patch Set 5:
(1 comment)
File doc/dev_guide/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/75270/comment/f300a9de_2dc23d3e :
PS5, Line 17: * linux-headers†
: * libpci†
: * libusb1†
: * libftdi1†
: * libjaylink†
: * NI-845x driver & library package‡
:
: | \* optional, for building unit testing
: | † optional, depending on the selected programmer
: | ‡ optional, proprietary and Windows only. (See Windows build instructions)
How about using [Footnotes](https://www.sphinx-doc.org/en/master/usage/restructuredtext/basi… over asterisks / unicode characters?
--
To view, visit https://review.coreboot.org/c/flashrom/+/75270?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a
Gerrit-Change-Number: 75270
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Sat, 03 Jun 2023 11:55:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Lubomir Rintel.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/23337?usp=email )
Change subject: flashchips: reset a M25P10-A before a probe
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Hello people on this patch, I have a question. Is anyone here interested to continue this work? Thanks!
--
To view, visit https://review.coreboot.org/c/flashrom/+/23337?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I19a5332756d15b3cb74609c44a8d3fed2f4a2d68
Gerrit-Change-Number: 23337
Gerrit-PatchSet: 2
Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk>
Gerrit-Reviewer: Carl-Daniel Hailfinger <hailfinger(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Lubomir Rintel <lkundrak(a)v3.sk>
Gerrit-Comment-Date: Sat, 03 Jun 2023 11:06:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, Angel Pons, Edward O'Callaghan, Mario Kicherer, Nico Huber.
Anastasia Klimchuk has uploaded a new patch set (#4) to the change originally created by Mario Kicherer. ( https://review.coreboot.org/c/flashrom/+/68295?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by Anastasia Klimchuk, Verified-1 by build bot (Jenkins)
Change subject: flashchips: add support for ISSI IS25LP016
......................................................................
flashchips: add support for ISSI IS25LP016
I took the original patch from Ondrej Hennel [1] and applied the
requested changes. Reading, erasing and writing works.
[1] https://patchwork.ozlabs.org/project/flashrom/list/?series=261647
Change-Id: Iffd7c4284d4d96b30a94f5dee882b5403fdfc183
Signed-off-by: Mario Kicherer <dev(a)kicherer.org>
Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org>
---
M flashchips.c
M include/flashchips.h
2 files changed, 42 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/68295/4
--
To view, visit https://review.coreboot.org/c/flashrom/+/68295?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iffd7c4284d4d96b30a94f5dee882b5403fdfc183
Gerrit-Change-Number: 68295
Gerrit-PatchSet: 4
Gerrit-Owner: Mario Kicherer
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Mario Kicherer
Gerrit-MessageType: newpatchset
Attention is currently required from: Shreeyash .
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66438?usp=email )
Change subject: flashchips: Add EON EN25T80 and EN25T80
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Shreeyash, hello! I wanted to check, are you still interested to finish this patch?
--
To view, visit https://review.coreboot.org/c/flashrom/+/66438?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie62a08bed242b5b006e4bb2f86eb70c871bd5ed9
Gerrit-Change-Number: 66438
Gerrit-PatchSet: 1
Gerrit-Owner: Shreeyash <shreeyash335(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Shreeyash <shreeyash335(a)gmail.com>
Gerrit-Comment-Date: Sat, 03 Jun 2023 09:12:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment