- flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: doc: Add build instructions for NI-845x on Windows
by Anastasia Klimchuk (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Alexander Goncharov, Miklós Márton, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email ) Change subject: doc: Add build instructions for NI-845x on Windows ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Gerrit-Change-Number: 75270 Gerrit-PatchSet: 7 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Thu, 08 Jun 2023 08:12:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson: Add support for ni845x_spi on Windows
by Anastasia Klimchuk (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Miklós Márton, Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75236?usp=email ) Change subject: meson: Add support for ni845x_spi on Windows ...................................................................... Patch Set 6: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/75236/comment/661b91c8_865c4261 : PS6, Line 12: choise Oh I found typo: choise -> choice Patchset: PS4: > I rebased this branch on top of master (currently b09aad573) and it built successfully for me. […] Miklos, does this work for you? I see you approved documentation patch (next one in the chain), does it mean it builds for you successfully? PS4: > Need testing: what if the include path is not available under windows? will it just ignore the non e […] Thomas, do you plan any more testing? Which include path do you mean, is that the one hardcoded in meson options, `C:\Program Files (x86)\National Instruments\Ni-845x\MS Visual C` ? -- To view, visit https://review.coreboot.org/c/flashrom/+/75236?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d32f11852ac1a5184af8e8683ca1914a6e72973 Gerrit-Change-Number: 75236 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Jun 2023 08:11:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Miklós Márton <martonmiklosqdev(a)gmail.com> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add support for IS25WP016
by Anastasia Klimchuk (Code Review) 08 Jun '23

08 Jun '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/70140?usp=email ) ( 6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: flashchips: Add support for IS25WP016 ...................................................................... flashchips: Add support for IS25WP016 Tested reading, writing and erasing using `linux_spi` programmer on Raspberry Pi CM4. Datasheet: https://web.archive.org/web/20221129211027/https://www.issi.com/WW/pdf/25LP… Change-Id: I2b8caea229ffda72f1b04183c31715faccb64ad5 Signed-off-by: Alex Mikhalev <alex(a)corvus-robotics.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/70140 Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c M include/flashchips.h 2 files changed, 43 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 287e2f5..3e19659 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7645,6 +7645,48 @@ { .vendor = "ISSI", + .name = "IS25WP016", + .bustype = BUS_SPI, + .manufacture_id = ISSI_ID_SPI, + .model_id = ISSI_IS25WP016, + .total_size = 2048, + .page_size = 256, + /* OTP: 1024B total; read 0x48; write 0x42 */ + /* QPI enable 0x35, disable 0xF5 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_D7, + }, { + .eraseblocks = { {32 * 1024, 64} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {1650, 1950}, + }, + + { + .vendor = "ISSI", .name = "IS25WP032", .bustype = BUS_SPI, .manufacture_id = ISSI_ID_SPI, diff --git a/include/flashchips.h b/include/flashchips.h index a0fbf55..dc4a059 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -476,6 +476,7 @@ #define ISSI_IS25LP064 0x6017 #define ISSI_IS25LP128 0x6018 #define ISSI_IS25LP256 0x6019 +#define ISSI_IS25WP016 0x7015 #define ISSI_IS25WP032 0x7016 #define ISSI_IS25WP064 0x7017 #define ISSI_IS25WP128 0x7018 -- To view, visit https://review.coreboot.org/c/flashrom/+/70140?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2b8caea229ffda72f1b04183c31715faccb64ad5 Gerrit-Change-Number: 70140 Gerrit-PatchSet: 9 Gerrit-Owner: Alex Mikhalev <alex(a)corvus-robotics.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: flashchips: Add support for Boya BY25D80A
by Anastasia Klimchuk (Code Review) 08 Jun '23

08 Jun '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/73513?usp=email ) ( 7 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: flashchips: Add support for Boya BY25D80A ...................................................................... flashchips: Add support for Boya BY25D80A Read tested on Raspberry Pico with pico-serprog Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7 Signed-off-by: Piotr Halama <skrzynka(a)halamix2.pl> Reviewed-on: https://review.coreboot.org/c/flashrom/+/73513 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index ccc1e8c..287e2f5 100644 --- a/flashchips.c +++ b/flashchips.c @@ -3530,6 +3530,44 @@ { .vendor = "Boya/BoHong Microelectronics", + .name = "B.25D80A", + .bustype = BUS_SPI, + .manufacture_id = BOYA_BOHONG_ID, + .model_id = BOYA_BOHONG_B__25D80A, + .total_size = 1024, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PR, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 256} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 32} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 16} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {1 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {1 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP2_SRWD, + .unlock = SPI_DISABLE_BLOCKPROTECT_BP2_SRWD, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Boya/BoHong Microelectronics", .name = "B.25Q128AS", .bustype = BUS_SPI, .manufacture_id = BOYA_BOHONG_ID, diff --git a/include/flashchips.h b/include/flashchips.h index aa59a6d..a0fbf55 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -210,6 +210,7 @@ /* Boya/BoHong Microelectronics Inc. */ #define BOYA_BOHONG_ID 0x68 +#define BOYA_BOHONG_B__25D80A 0x4014 #define BOYA_BOHONG_B_25D16A 0x4015 #define BOYA_BOHONG_B_25Q128AS 0x4018 -- To view, visit https://review.coreboot.org/c/flashrom/+/73513?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7 Gerrit-Change-Number: 73513 Gerrit-PatchSet: 9 Gerrit-Owner: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[master]: Replace all flashchips accesses with get functions
by Stefan Reinauer (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75646?usp=email ) Change subject: Replace all flashchips accesses with get functions ...................................................................... Patch Set 5: (6 comments) Patchset: PS5: good thoughts on the simplification.. maybe generally the API should already have an init function at this point that handles a possible failure case (flashchips = NULL) and bails out so we don't have to test for null/0 at various places in the code over and again. File flashchips.c: https://review.coreboot.org/c/flashrom/+/75646/comment/ab2028b4_0acf0ddf : PS5, Line 34: internal_ > no need to rename if it becomes static, also "internal" is a overloaded term with the internal progr […] i understand there is no technical need, but i did it to make it more obvious that it is not coming from the outside. it keeps the code easier to understand https://review.coreboot.org/c/flashrom/+/75646/comment/571ad0b5_ced6bafb : PS5, Line 20844: get_flashchips(void) > you *could* have a signature of: […] sure, but that would be more complex. https://review.coreboot.org/c/flashrom/+/75646/comment/e0d7eb5f_cdff91bf : PS5, Line 20849: unsigned int > should be `size_t` for the size of an array. maybe so. it was unsigned int before, so i didn't change it. if we want to fix that, we could do that in a separate patch that focused on that. trying to keep it to one logical change per patch File ichspi.c: https://review.coreboot.org/c/flashrom/+/75646/comment/3f7ed0e0_aa93c407 : PS5, Line 1469: const struct flashchip *chip; : : struct flashchip *flashchips=get_flashchips(); : : if (!flashchips) : return NULL; > ``` […] very clever. and doesn't check the return value. i suppose we could bail out earlier if we don't have a good database in memory File libflashrom.c: https://review.coreboot.org/c/flashrom/+/75646/comment/39849728_2d12ddb0 : PS5, Line 95: unsigned int > size_t shouldn't then i downstairs also be size_t? not against this, but it seems that is a larger consistency cleanup that needs to happen across the tree separately if this is a notion that is agreed upon. -- To view, visit https://review.coreboot.org/c/flashrom/+/75646?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibc89e32c83975e01c958b8cf0d11dad73c461a53 Gerrit-Change-Number: 75646 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Jun 2023 05:08:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Hook up mjson into build system
by Edward O'Callaghan (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Stefan Reinauer, Thomas Heijligen. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75648?usp=email ) Change subject: Hook up mjson into build system ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/75648/comment/595dadf1_8898f228 : PS5, Line 76: 'mjson.c', : 'flashchips.c', probably the structure should be: ``` imports/mjson/{mjson.c, meson.build} => gen 'mjson.a'. ``` && ``` flashchipdb/{flashchips.c, flashchips.h, meson.build} => gen flashchips.a ``` this affords us the path to having a feature flag for link-time decision to which db to use - builtin or parsed external. WDYT? -- To view, visit https://review.coreboot.org/c/flashrom/+/75648?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I714b35f7c869932924ff50c505ad39cf88cf3950 Gerrit-Change-Number: 75648 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 03:38:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[master]: Plain mjson 1.6
by Edward O'Callaghan (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Stefan Reinauer. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75647?usp=email ) Change subject: Plain mjson 1.6 ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: can we plop this into a directory called 'import/' or something with its own little meson file and it can just be linked to should it be enabled as a feature. -- To view, visit https://review.coreboot.org/c/flashrom/+/75647?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9f770baec883f35507bf3b7b60ef2d581db27002 Gerrit-Change-Number: 75647 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Jun 2023 03:35:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: Replace all flashchips accesses with get functions
by Edward O'Callaghan (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75646?usp=email ) Change subject: Replace all flashchips accesses with get functions ...................................................................... Patch Set 5: (11 comments) Patchset: PS5: I realise this patch was a intermediate step so the comments are just how it should probably look for when the desire to merge comes about. File flashchips.c: https://review.coreboot.org/c/flashrom/+/75646/comment/1a29ee84_6580ba0a : PS5, Line 34: internal_ no need to rename if it becomes static, also "internal" is a overloaded term with the internal programmer. https://review.coreboot.org/c/flashrom/+/75646/comment/efe728fb_a207593b : PS5, Line 20844: get_flashchips(void) you *could* have a signature of: `void get_flashchip_db(struct flashchip **db, size_t *len)` ? https://review.coreboot.org/c/flashrom/+/75646/comment/37be779e_1568c5f4 : PS5, Line 20849: unsigned int should be `size_t` for the size of an array. File ichspi.c: https://review.coreboot.org/c/flashrom/+/75646/comment/94da9d4a_c9a16f09 : PS5, Line 1469: const struct flashchip *chip; : : struct flashchip *flashchips=get_flashchips(); : : if (!flashchips) : return NULL; ``` const struct flashchip *chip = get_flashchips()[0]; for (; chip->vendor; chip++) { ``` File libflashrom.c: https://review.coreboot.org/c/flashrom/+/75646/comment/e7497a3f_73f35ef3 : PS5, Line 95: unsigned int size_t File print.c: https://review.coreboot.org/c/flashrom/+/75646/comment/be9da440_ff4b7a31 : PS5, Line 56: const struct flashchip *chip; delete https://review.coreboot.org/c/flashrom/+/75646/comment/0bc5f4e4_9914ab1d : PS5, Line 62: flashchips chip https://review.coreboot.org/c/flashrom/+/75646/comment/d6c77b67_ecd3cf69 : PS5, Line 65: chip = flashchips delete File print_wiki.c: https://review.coreboot.org/c/flashrom/+/75646/comment/86a26de7_0c05b97b : PS5, Line 294: flashchips get_flashchips() https://review.coreboot.org/c/flashrom/+/75646/comment/a7599e14_85aaabe1 : PS5, Line 310: flashchips get_flashchips() -- To view, visit https://review.coreboot.org/c/flashrom/+/75646?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibc89e32c83975e01c958b8cf0d11dad73c461a53 Gerrit-Change-Number: 75646 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Jun 2023 03:34:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: serprog.c: Replace custom mapper with max_rom_decode
by Jonathon Hall (Code Review) 07 Jun '23

07 Jun '23

Jonathon Hall has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/68093?usp=email ) Change subject: serprog.c: Replace custom mapper with max_rom_decode ...................................................................... Abandoned Couldn't find anyone with serprog hardware to test. -- To view, visit https://review.coreboot.org/c/flashrom/+/68093?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If8b313708a52813b9354cbf45cb91cdd1fe36b13 Gerrit-Change-Number: 68093 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: serprog.c: Replace custom mapper with max_rom_decode
by Jonathon Hall (Code Review) 07 Jun '23

07 Jun '23

Attention is currently required from: Thomas Heijligen. Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68093?usp=email ) Change subject: serprog.c: Replace custom mapper with max_rom_decode ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Abandoning this since I could not find someone with the appropriate hardware to test. -- To view, visit https://review.coreboot.org/c/flashrom/+/68093?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If8b313708a52813b9354cbf45cb91cdd1fe36b13 Gerrit-Change-Number: 68093 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 07 Jun 2023 20:17:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit