- flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: Replace all flashchips accesses with get functions
by Stefan Reinauer (Code Review) 07 Jun '23

07 Jun '23

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75646?usp=email ) Change subject: Replace all flashchips accesses with get functions ...................................................................... Replace all flashchips accesses with get functions Abstract access to struct flashchip flashchips[]. Change-Id: Ibc89e32c83975e01c958b8cf0d11dad73c461a53 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M cli_classic.c M flashchips.c M flashrom.c M ichspi.c M include/flash.h M libflashrom.c M print.c 7 files changed, 37 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/75646/1 diff --git a/cli_classic.c b/cli_classic.c index 60f3fd5..7367825 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -917,6 +917,8 @@ print_version(); print_banner(); + struct flashchip *flashchips = get_flashchips(); + /* FIXME: Delay calibration should happen in programmer code. */ if (flashrom_init(1)) exit(1); diff --git a/flashchips.c b/flashchips.c index ccc1e8c..418f4b9 100644 --- a/flashchips.c +++ b/flashchips.c @@ -31,7 +31,7 @@ * The usual intention is that that this list is sorted by vendor, then chip * family and chip density, which is useful for the output of 'flashrom -L'. */ -const struct flashchip flashchips[] = { +static const struct flashchip internal_flashchips[] = { /* * .vendor = Vendor name @@ -20838,4 +20838,15 @@ {0} }; -const unsigned int flashchips_size = ARRAY_SIZE(flashchips); +static const unsigned int internal_flashchips_size = ARRAY_SIZE(internal_flashchips); + + +struct flashchip *get_flashchips(void) +{ + return (struct flashchip *)&internal_flashchips; +} + +unsigned int get_flashchips_size(void) +{ + return (unsigned int)internal_flashchips_size; +} diff --git a/flashrom.c b/flashrom.c index b6e5cf8..8c79fdb 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1094,6 +1094,10 @@ enum chipbustype buses_common; char *tmp; + struct flashchip *flashchips = get_flashchips(); + if (!flashchips) + return -1; + for (chip = flashchips + startchip; chip && chip->name; chip++) { if (chip_to_probe && strcmp(chip->name, chip_to_probe) != 0) continue; @@ -1885,6 +1889,9 @@ unsigned int i; int ret = 0; + struct flashchip *flashchips = get_flashchips(); + unsigned int flashchips_size = get_flashchips_size(); + for (i = 0; i < programmer_table_size; i++) { const struct programmer_entry *const p = programmer_table[i]; if (p == NULL) { diff --git a/ichspi.c b/ichspi.c index e9668ef..50a1121 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1468,6 +1468,11 @@ { const struct flashchip *chip; + struct flashchip *flashchips=get_flashchips(); + + if (!flashchips) + return NULL; + for (chip = &flashchips[0]; chip->vendor; chip++) { if ((chip->manufacture_id == mfg_id) && (chip->model_id == model_id) && diff --git a/include/flash.h b/include/flash.h index 0eace15..507bd72 100644 --- a/include/flash.h +++ b/include/flash.h @@ -569,8 +569,8 @@ #define TIMING_IGNORED -1 #define TIMING_ZERO -2 -extern const struct flashchip flashchips[]; -extern const unsigned int flashchips_size; +struct flashchip *get_flashchips(void); +unsigned int get_flashchips_size(void); /* parallel.c */ void chip_writeb(const struct flashctx *flash, uint8_t val, chipaddr addr); diff --git a/libflashrom.c b/libflashrom.c index 4a59e2a..1dd4f85 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -91,6 +91,12 @@ struct flashrom_flashchip_info *flashrom_supported_flash_chips(void) { + struct flashchip *flashchips = get_flashchips(); + unsigned int flashchips_size = get_flashchips_size(); + + if (!flashchips) + return NULL; + struct flashrom_flashchip_info *supported_flashchips = malloc(flashchips_size * sizeof(*supported_flashchips)); diff --git a/print.c b/print.c index 0caa0da..93d5242 100644 --- a/print.c +++ b/print.c @@ -59,6 +59,8 @@ char *tmpven, *tmpdev, *tmpven_save, *tmpdev_save; int tmpvenlen, tmpdevlen, curvenlen, curdevlen; + struct flashchip *flashchips = get_flashchips(); + /* calculate maximum column widths and by iterating over all chips */ for (chip = flashchips; chip->name != NULL; chip++) { /* Ignore generic entries. */ -- To view, visit https://review.coreboot.org/c/flashrom/+/75646?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibc89e32c83975e01c958b8cf0d11dad73c461a53 Gerrit-Change-Number: 75646 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: layout.c: Mitigate untrusted FMAP's within fw images address root
by Stefan Reinauer (Code Review) 07 Jun '23

07 Jun '23

Attention is currently required from: Angel Pons, Edward O'Callaghan. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75194?usp=email ) Change subject: layout.c: Mitigate untrusted FMAP's within fw images address root ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75194?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I820ea2dfc25925895b9fb7926d2a337e4f0e3fd2 Gerrit-Change-Number: 75194 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Jun 2023 04:40:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: layout.c: Mitigate untrusted FMAP's within fw images address root
by Edward O'Callaghan (Code Review) 07 Jun '23

07 Jun '23

Attention is currently required from: Angel Pons, Stefan Reinauer. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75194?usp=email ) Change subject: layout.c: Mitigate untrusted FMAP's within fw images address root ...................................................................... Patch Set 2: (5 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/75194/comment/66f2b0c0_59c88885 : PS1, Line 9: elivated > elevated Done https://review.coreboot.org/c/flashrom/+/75194/comment/12222f6b_8add70d4 : PS1, Line 9: privilaged > privileged Done https://review.coreboot.org/c/flashrom/+/75194/comment/9ccd9ec3_a959602e : PS1, Line 13: relative paths however this > Add some punctuation: […] Thanks! Done. https://review.coreboot.org/c/flashrom/+/75194/comment/e3d65221_3b5a8933 : PS1, Line 14: privilaged > privileged Done File layout.c: https://review.coreboot.org/c/flashrom/+/75194/comment/3c547ad8_7d1f1584 : PS1, Line 199: filename[0] == '\\' > If this is meant to secure DOS/Windows paths, you'd also have to check for "[a-zA-Z]:", […] I would imagine this whole effort is pointless. If you are running flashrom with root privileges reading untrusted binaries via untrusted programmers you already failed. The proper fix is to drop privileges from flashrom upon invocation. -- To view, visit https://review.coreboot.org/c/flashrom/+/75194?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I820ea2dfc25925895b9fb7926d2a337e4f0e3fd2 Gerrit-Change-Number: 75194 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Jun 2023 04:29:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: layout.c: Mitigate untrusted FMAP's within fw images address root
by Edward O'Callaghan (Code Review) 07 Jun '23

07 Jun '23

Attention is currently required from: Edward O'Callaghan, Stefan Reinauer. Hello Angel Pons, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75194?usp=email to look at the new patch set (#2). Change subject: layout.c: Mitigate untrusted FMAP's within fw images address root ...................................................................... layout.c: Mitigate untrusted FMAP's within fw images address root A ill informed security engineer running a elevated privileged version of flashrom that parses a embedded FMAP within the image could find themseleves addressing absolute system paths. We can mitigate this by ensuring paths in the FMAP are always relative paths. However, this does not address the deeper issue of parsing untrusted data with a privileged process which is user error. Do not run flashrom as root unless you require the internal programmer in which case the internal image is implicitly trusted. Change-Id: I820ea2dfc25925895b9fb7926d2a337e4f0e3fd2 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M layout.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/94/75194/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75194?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I820ea2dfc25925895b9fb7926d2a337e4f0e3fd2 Gerrit-Change-Number: 75194 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: doc: Add build instructions for NI-845x on Windows
by Peter Marheine (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Miklós Márton, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email ) Change subject: doc: Add build instructions for NI-845x on Windows ...................................................................... Patch Set 7: Code-Review+2 (1 comment) File doc/dev_guide/building_from_source.rst: https://review.coreboot.org/c/flashrom/+/75270/comment/152efa08_868b17a3 : PS5, Line 17: * linux-headers† : * libpci† : * libusb1† : * libftdi1† : * libjaylink† : * NI-845x driver & library package‡ : : | \* optional, for building unit testing : | † optional, depending on the selected programmer : | ‡ optional, proprietary and Windows only. (See Windows build instructions) > This is exactly what Sphinx gives us - `footnote-but-place-it-after-this-paragraph`! I've uploaded t […] Huh, it wasn't clear from the documentation that you can do that (or that it's the normal behavior?). Neat. -- To view, visit https://review.coreboot.org/c/flashrom/+/75270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Gerrit-Change-Number: 75270 Gerrit-PatchSet: 7 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 06 Jun 2023 00:55:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add build instructions for NI-845x on Windows
by Alexander Goncharov (Code Review) 05 Jun '23

05 Jun '23

Attention is currently required from: Anastasia Klimchuk, Miklós Márton, Peter Marheine, Thomas Heijligen. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email ) Change subject: doc: Add build instructions for NI-845x on Windows ...................................................................... Patch Set 7: (1 comment) File doc/dev_guide/building_from_source.rst: https://review.coreboot.org/c/flashrom/+/75270/comment/1cb48366_af287e71 : PS5, Line 17: * linux-headers† : * libpci† : * libusb1† : * libftdi1† : * libjaylink† : * NI-845x driver & library package‡ : : | \* optional, for building unit testing : | † optional, depending on the selected programmer : | ‡ optional, proprietary and Windows only. (See Windows build instructions) > I thought it made more sense to keep these near the list, since it seems unnecessarily difficult to […] This is exactly what Sphinx gives us - `footnote-but-place-it-after-this-paragraph`! I've uploaded the new patchset, please check it out. -- To view, visit https://review.coreboot.org/c/flashrom/+/75270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Gerrit-Change-Number: 75270 Gerrit-PatchSet: 7 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 05 Jun 2023 07:57:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add build instructions for NI-845x on Windows
by Alexander Goncharov (Code Review) 05 Jun '23

05 Jun '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Miklós Márton, Peter Marheine. Alexander Goncharov has uploaded a new patch set (#7) to the change originally created by Thomas Heijligen. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email ) Change subject: doc: Add build instructions for NI-845x on Windows ...................................................................... doc: Add build instructions for NI-845x on Windows Because this patch adds a new footprint level, Sphinx incorrectly interprets the 3 asterisks (***) as the start of a bold block, rather than a footnote marker. To work around this, use sphinx built-in footprints. Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> --- M doc/dev_guide/building_from_source.rst M doc/dev_guide/building_with_make.rst 2 files changed, 25 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/75270/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/75270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Gerrit-Change-Number: 75270 Gerrit-PatchSet: 7 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashchips.c: Add write protect support for W25Q16.V
by Anastasia Klimchuk (Code Review) 05 Jun '23

05 Jun '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/67713?usp=email ) Change subject: flashchips.c: Add write protect support for W25Q16.V ...................................................................... flashchips.c: Add write protect support for W25Q16.V Enable WRSR2 feature flag and define reg_bits and decode_range for W25Q16.V to enable write protect support. Based on W25Q16DV, Revision: 1, Release: Nov 18 2014 datasheet TEST=flashrom --wp-{enable,disable,range,list,status} Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Signed-off-by: Khoa Hoang <admin(a)khoahoang.com> Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/67713 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M flashchips.c 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Sergii Dmytruk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 6a5cf49..ccc1e8c 100644 --- a/flashchips.c +++ b/flashchips.c @@ -17888,8 +17888,8 @@ .page_size = 256, /* supports SFDP */ /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, - .tested = TEST_OK_PREW, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_WRSR2, + .tested = TEST_OK_PREWB, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .block_erasers = @@ -17916,6 +17916,16 @@ .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, .voltage = {2700, 3600}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .srl = {STATUS2, 0, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}}, + .tb = {STATUS1, 5, RW}, + .sec = {STATUS1, 6, RW}, + .cmp = {STATUS2, 6, RW}, + }, + .decode_range = DECODE_RANGE_SPI25, }, { -- To view, visit https://review.coreboot.org/c/flashrom/+/67713?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Gerrit-Change-Number: 67713 Gerrit-PatchSet: 11 Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: doc: Add build instructions for NI-845x on Windows
by Alexander Goncharov (Code Review) 05 Jun '23

05 Jun '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Miklós Márton, Peter Marheine, Thomas Heijligen. Alexander Goncharov has uploaded a new patch set (#6) to the change originally created by Thomas Heijligen. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by Miklós Márton, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: doc: Add build instructions for NI-845x on Windows ...................................................................... doc: Add build instructions for NI-845x on Windows Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> --- M doc/dev_guide/building_from_source.rst M doc/dev_guide/building_with_make.rst 2 files changed, 25 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/75270/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/75270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Gerrit-Change-Number: 75270 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: doc: Add build instructions for NI-845x on Windows
by Miklós Márton (Code Review) 05 Jun '23

05 Jun '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Peter Marheine, Thomas Heijligen. Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email ) Change subject: doc: Add build instructions for NI-845x on Windows ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Gerrit-Change-Number: 75270 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 05 Jun 2023 07:24:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit