Attention is currently required from: Nico Huber, Daniel Maslowski, Sophie van Soest, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56055 )
Change subject: it87spi.c: Enable probing of IT8620
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/56055
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc
Gerrit-Change-Number: 56055
Gerrit-PatchSet: 11
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sat, 15 Apr 2023 22:13:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Miklós Márton, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72160 )
Change subject: ni845x_spi: refactor singleton states into reentrant pattern
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> I tried test it (managed to put togeter a Windows image with the proper mingw, etc. […]
Yes, I remember that thread on the mailing list, I responded into the thread but let's talk here as well, there could be more nuances for Windows.
sphinx-build dependency is optional, and at the moment it is optional when you build with meson. It is unintentionally not optional when you build with make, but this is a bug, will be fixed.
My understanding you can't build ni845 with meson (not yet!) so we have to use make.
In this case, Thomas suggested a solution (on the thread)
comment out Makefile line 1035 'FLASHROM_VERSION=$(VERSION) $(SPHINXBUILD) -b man
doc .'
I hope it will work for you! As a long term end result, we plan to have everything building with meson, and delete makefile. Only in this order: first everything is building with meson, after that delete makefile.
please tell how it goes! thank you so much!
--
To view, visit https://review.coreboot.org/c/flashrom/+/72160
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I45fcb8e20582cb0c532c4a9f0c78543a25f8d484
Gerrit-Change-Number: 72160
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Sat, 15 Apr 2023 09:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Miklós Márton <martonmiklosqdev(a)gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov.
Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72160 )
Change subject: ni845x_spi: refactor singleton states into reentrant pattern
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Miklos, could you please help to review and test this chain of patches? […]
I tried test it (managed to put togeter a Windows image with the proper mingw, etc.) however the make fails due to the lack of sphinx-build (even make flashrom too.). If possible I would avoid going down the rabbit hole to get sphinx-build on the platform. I saw others complaining about it on the mailing list: is the sphinx-build dependency intentional?
--
To view, visit https://review.coreboot.org/c/flashrom/+/72160
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I45fcb8e20582cb0c532c4a9f0c78543a25f8d484
Gerrit-Change-Number: 72160
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Fri, 14 Apr 2023 20:50:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Alexander Goncharov.
Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72154 )
Change subject: ni845x_spi: pass global state through func params
......................................................................
Patch Set 5:
(1 comment)
File ni845x_spi.c:
https://review.coreboot.org/c/flashrom/+/72154/comment/818fa7d6_672dea96
PS2, Line 290: if (set_io_voltage_mV)
> Miklós, how about dropping this condition? Maybe not in this patch, but in the one of the next. […]
I am fine wiht the dropping, I think my intention when adding was something like this: what if at some point I will not care about the voltage set actually and then I could just pass NULL to set_io_voltage_mV.
--
To view, visit https://review.coreboot.org/c/flashrom/+/72154
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61
Gerrit-Change-Number: 72154
Gerrit-PatchSet: 5
Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Fri, 14 Apr 2023 20:29:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen, Peter Marheine.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74157 )
Change subject: tests: Emulate multithreading environment for unit tests
......................................................................
Patch Set 6:
(1 comment)
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/74157/comment/ac261402_08ac1523
PS5, Line 390: printf("I am busy multithreading\n");
> I think we can remove this message.
Done,
I also re-run the tests, still work on all that is listed in commit message.
--
To view, visit https://review.coreboot.org/c/flashrom/+/74157
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3d65c125183e60037ad07b9d54b8fffdece5a4e8
Gerrit-Change-Number: 74157
Gerrit-PatchSet: 6
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Thu, 13 Apr 2023 12:17:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: comment