- flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: Simple, clumsy script to test layout handling
by build bot (Jenkins) (Code Review) 18 Apr '17

18 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19352 ) Change subject: Simple, clumsy script to test layout handling ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/154/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/170/ : SUCCESS -- To view, visit https://review.coreboot.org/19352 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37124455071bf3395384a58ad236c998f738c418 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Simple, clumsy script to test layout handling
by Nico Huber (Code Review) 18 Apr '17

18 Apr '17

Nico Huber has uploaded a new change for review. ( https://review.coreboot.org/19352 ) Change subject: Simple, clumsy script to test layout handling ...................................................................... Simple, clumsy script to test layout handling Not for merge. First parameter are flashrom options, second an optional layout file (if not provided, `--ifd` will be used). e.g. sh util/test_layout "-p dummy:emulate=MX25L6436,image=/tmp/dummy.rom -c MX25L6436E/MX25L6445E/MX25L6465E/MX25L6473E" util/test.layout Change-Id: I37124455071bf3395384a58ad236c998f738c418 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- A util/test.layout A util/test_layout 2 files changed, 48 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/19352/1 diff --git a/util/test.layout b/util/test.layout new file mode 100644 index 0000000..3139f05 --- /dev/null +++ b/util/test.layout @@ -0,0 +1,4 @@ +00000000:00000fff Flash_Descriptor +00001000:00002fff GbE +00003000:0057ffef Intel_ME +0057fff0:007fffff BIOS diff --git a/util/test_layout b/util/test_layout new file mode 100644 index 0000000..d328bcc --- /dev/null +++ b/util/test_layout @@ -0,0 +1,44 @@ +#!/bin/sh + +set -e + +TMP=$(mktemp -d --tmpdir layout-test.XXXXXX) +echo ${TMP} + +FLASHROM_ARGS="$1" +if [ $# -ge 2 ]; then + LAYOUT_ARGS="${FLASHROM_ARGS} --layout $2" +else + LAYOUT_ARGS="${FLASHROM_ARGS} --ifd" +fi + +flashrom() { + echo flashrom $* + ./flashrom -V ${LAYOUT_ARGS} $* 2>&1 | tee -a ${TMP}/layout.log | grep VERIFIED +} + +./flashrom ${FLASHROM_ARGS} -r ${TMP}/backup.rom +dd if=/dev/urandom of=${TMP}/random.rom bs=$(stat -c%s ${TMP}/backup.rom) count=1 + +test_layout() { + all_regions="Flash_Descriptor GbE Intel_ME BIOS" + included="$*" + + for i in $included; do + flashrom -i $i -A -w ${TMP}/random.rom + done + for i in $all_regions; do + if echo $included | grep -q "\<${i}\>"; then + f=${TMP}/random.rom + else + f=${TMP}/backup.rom + fi + flashrom -i $i -v $f + done + ./flashrom ${FLASHROM_ARGS} -w ${TMP}/backup.rom +} + +test_layout GbE +test_layout Intel_ME +test_layout GbE BIOS +test_layout GbE Intel_ME -- To view, visit https://review.coreboot.org/19352 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I37124455071bf3395384a58ad236c998f738c418 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[staging]: dediprog: Fix bug where too many transfers would be queued
by Nico Huber (Code Review) 18 Apr '17

18 Apr '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/19351 ) Change subject: dediprog: Fix bug where too many transfers would be queued ...................................................................... Patch Set 1: Code-Review+2 Already acked on ML. -- To view, visit https://review.coreboot.org/19351 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91a8de47db7107455f5fc63ab2f13a0bd50c5b63 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: dediprog: Reimplement target chip option
by Nico Huber (Code Review) 18 Apr '17

18 Apr '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/19350 ) Change subject: dediprog: Reimplement target chip option ...................................................................... Patch Set 1: Code-Review+2 Already acked on ML. -- To view, visit https://review.coreboot.org/19350 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I594e2a6ee144260f8424d25b304f6ab41a9d3fad Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: dediprog: Fix bug where too many transfers would be queued
by build bot (Jenkins) (Code Review) 18 Apr '17

18 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19351 ) Change subject: dediprog: Fix bug where too many transfers would be queued ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/153/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/169/ : SUCCESS -- To view, visit https://review.coreboot.org/19351 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91a8de47db7107455f5fc63ab2f13a0bd50c5b63 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: dediprog: Reimplement target chip option
by build bot (Jenkins) (Code Review) 18 Apr '17

18 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19350 ) Change subject: dediprog: Reimplement target chip option ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/152/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/168/ : SUCCESS -- To view, visit https://review.coreboot.org/19350 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I594e2a6ee144260f8424d25b304f6ab41a9d3fad Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: dediprog: Fix bug where too many transfers would be queued
by Nico Huber (Code Review) 18 Apr '17

18 Apr '17

Hello David Hendricks, I'd like you to do a code review. Please visit https://review.coreboot.org/19351 to review the following change. Change subject: dediprog: Fix bug where too many transfers would be queued ...................................................................... dediprog: Fix bug where too many transfers would be queued We didn't check the total number of queued transfers in the inner most loop. Up to DEDIPROG_ASYNC_TRANSFERS - 1 invalid transfers could be queued therefore. So add another check on the total number. Change-Id: I91a8de47db7107455f5fc63ab2f13a0bd50c5b63 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Acked-by: David Hendricks <david.hendricks(a)gmail.com> --- M dediprog.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/19351/1 diff --git a/dediprog.c b/dediprog.c index b7276e5..6f82772 100644 --- a/dediprog.c +++ b/dediprog.c @@ -462,7 +462,9 @@ /* Now transfer requested chunks using libusb's asynchronous interface. */ while (!status.error && (status.queued_idx < count)) { - while ((status.queued_idx - status.finished_idx) < DEDIPROG_ASYNC_TRANSFERS) { + while ((status.queued_idx < count) && + (status.queued_idx - status.finished_idx) < DEDIPROG_ASYNC_TRANSFERS) + { transfer = transfers[status.queued_idx % DEDIPROG_ASYNC_TRANSFERS]; libusb_fill_bulk_transfer(transfer, dediprog_handle, 0x80 | dediprog_in_endpoint, (unsigned char *)buf + status.queued_idx * chunksize, chunksize, -- To view, visit https://review.coreboot.org/19351 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I91a8de47db7107455f5fc63ab2f13a0bd50c5b63 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[staging]: dediprog: Reimplement target chip option
by Nico Huber (Code Review) 18 Apr '17

18 Apr '17

Hello David Hendricks, I'd like you to do a code review. Please visit https://review.coreboot.org/19350 to review the following change. Change subject: dediprog: Reimplement target chip option ...................................................................... dediprog: Reimplement target chip option Change-Id: I594e2a6ee144260f8424d25b304f6ab41a9d3fad Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Acked-by: David Hendricks <david.hendricks(a)gmail.com> --- M dediprog.c 1 file changed, 14 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/19350/1 diff --git a/dediprog.c b/dediprog.c index 019de46..b7276e5 100644 --- a/dediprog.c +++ b/dediprog.c @@ -942,7 +942,7 @@ int spispeed_idx = 1; int millivolt = 3500; long usedevice = 0; - long target = 1; + long target = FLASH_TYPE_APPLICATION_FLASH_1; int i, ret; spispeed = extract_programmer_param("spispeed"); @@ -1014,7 +1014,18 @@ free(target_str); return 1; } - msg_pinfo("Using target %li.\n", target); + switch (target) { + case 1: + msg_pinfo("Using target %s.\n", "FLASH_TYPE_APPLICATION_FLASH_1"); + target = FLASH_TYPE_APPLICATION_FLASH_1; + break; + case 2: + msg_pinfo("Using target %s.\n", "FLASH_TYPE_APPLICATION_FLASH_2"); + target = FLASH_TYPE_APPLICATION_FLASH_2; + break; + default: + break; + } } free(target_str); @@ -1073,7 +1084,7 @@ dediprog_set_leds(LED_ALL); /* Select target/socket, frequency and VCC. */ - if (set_target_flash(FLASH_TYPE_APPLICATION_FLASH_1) || + if (set_target_flash(target) || dediprog_set_spi_speed(spispeed_idx) || dediprog_set_spi_voltage(millivolt)) { dediprog_set_leds(LED_ERROR); -- To view, visit https://review.coreboot.org/19350 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I594e2a6ee144260f8424d25b304f6ab41a9d3fad Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[staging]: Enable writes with active ME
by build bot (Jenkins) (Code Review) 18 Apr '17

18 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18740 ) Change subject: Enable writes with active ME ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/151/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/167/ : SUCCESS -- To view, visit https://review.coreboot.org/18740 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94a5e7074b845c227e43d76d04dd1a71082a1cef Gerrit-PatchSet: 6 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add option to read ROM layout from IFD
by build bot (Jenkins) (Code Review) 18 Apr '17

18 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17953 ) Change subject: Add option to read ROM layout from IFD ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/148/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/164/ : SUCCESS -- To view, visit https://review.coreboot.org/17953 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifafff2bf6d5c5e62283416b3269723f81fdc0fa3 Gerrit-PatchSet: 7 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit