- flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: Enable continuous SPI reads
by Urja Rannikko (Code Review) 16 Jun '17

16 Jun '17

Hello Stefan Tauner, David Hendricks, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/20223 to look at the new patch set (#3). Change subject: Enable continuous SPI reads ...................................................................... Enable continuous SPI reads Change-Id: Iadf909c9216578b1c5dacd4c4991bb436e32edc9 Signed-off-by: Urja Rannikko <urjaman(a)gmail.com> --- M serprog.c M spi25.c 2 files changed, 15 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/20223/3 -- To view, visit https://review.coreboot.org/20223 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iadf909c9216578b1c5dacd4c4991bb436e32edc9 Gerrit-Change-Number: 20223 Gerrit-PatchSet: 3 Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: Enable continuous SPI reads
by build bot (Jenkins) (Code Review) 16 Jun '17

16 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20223 ) Change subject: Enable continuous SPI reads ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/flashrom_gerrit/362/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/372/ : SUCCESS -- To view, visit https://review.coreboot.org/20223 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Iadf909c9216578b1c5dacd4c4991bb436e32edc9 Gerrit-Change-Number: 20223 Gerrit-PatchSet: 2 Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Jun 2017 11:20:42 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Enable continuous SPI reads
by Urja Rannikko (Code Review) 16 Jun '17

16 Jun '17

Hello Stefan Tauner, David Hendricks, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/20223 to look at the new patch set (#2). Change subject: Enable continuous SPI reads ...................................................................... Enable continuous SPI reads Change-Id: Iadf909c9216578b1c5dacd4c4991bb436e32edc9 Signed-off-by: Urja Rannikko <urjaman(a)gmail.com> --- M serprog.c M spi25.c 2 files changed, 4 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/20223/2 -- To view, visit https://review.coreboot.org/20223 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iadf909c9216578b1c5dacd4c4991bb436e32edc9 Gerrit-Change-Number: 20223 Gerrit-PatchSet: 2 Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: serial: Support custom baud rates on linux
by Nico Huber (Code Review) 16 Jun '17

16 Jun '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/20224 ) Change subject: serial: Support custom baud rates on linux ...................................................................... Patch Set 3: (3 comments) Looks good :) https://review.coreboot.org/#/c/20224/3/custom_baud.h File custom_baud.h: https://review.coreboot.org/#/c/20224/3/custom_baud.h@31 PS3, Line 31: /* Returns 1 if non-exact rate would be used, and setting a custom rate is supported. */ Maybe mention that baudtable has to be ordered ascendingly. https://review.coreboot.org/#/c/20224/3/custom_baud.c File custom_baud.c: https://review.coreboot.org/#/c/20224/3/custom_baud.c@51 PS3, Line 51: * Could you push the asterisk one char to the right? https://review.coreboot.org/#/c/20224/3/custom_baud.c@74 PS3, Line 74: * here too -- To view, visit https://review.coreboot.org/20224 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I2a20f9182cb85e7bce5d6654a2caf20e6202b195 Gerrit-Change-Number: 20224 Gerrit-PatchSet: 3 Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Jun 2017 10:35:09 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: Enable continuous SPI reads
by Nico Huber (Code Review) 16 Jun '17

16 Jun '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/20223 ) Change subject: Enable continuous SPI reads ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/20223/1/spi25.c File spi25.c: https://review.coreboot.org/#/c/20223/1/spi25.c@951 PS1, Line 951: page_size > I'm thinking of using "area" (as the term for this huge page-like > thing) here. Comments? Sound good. Really, anything but the multiple ambiguous `page` does :) -- To view, visit https://review.coreboot.org/20223 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Iadf909c9216578b1c5dacd4c4991bb436e32edc9 Gerrit-Change-Number: 20223 Gerrit-PatchSet: 1 Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Jun 2017 10:26:17 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: Enable continuous SPI reads
by Urja Rannikko (Code Review) 16 Jun '17

16 Jun '17

Urja Rannikko has posted comments on this change. ( https://review.coreboot.org/20223 ) Change subject: Enable continuous SPI reads ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/20223/1/spi25.c File spi25.c: https://review.coreboot.org/#/c/20223/1/spi25.c@951 PS1, Line 951: page_size > Please don't call it page_size, that's confusing. I'm thinking of using "area" (as the term for this huge page-like-thing) here. Comments? https://review.coreboot.org/#/c/20223/1/spi25.c@951 PS1, Line 951: *1024,16*1024* > Your keyboard does have a space bar, doesn't it? Yes but i dont like using it. Fixed :) -- To view, visit https://review.coreboot.org/20223 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Iadf909c9216578b1c5dacd4c4991bb436e32edc9 Gerrit-Change-Number: 20223 Gerrit-PatchSet: 1 Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Jun 2017 08:36:06 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: serial: Support custom baud rates on linux
by build bot (Jenkins) (Code Review) 16 Jun '17

16 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20224 ) Change subject: serial: Support custom baud rates on linux ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/361/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/371/ : SUCCESS -- To view, visit https://review.coreboot.org/20224 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I2a20f9182cb85e7bce5d6654a2caf20e6202b195 Gerrit-Change-Number: 20224 Gerrit-PatchSet: 3 Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Jun 2017 06:43:46 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: serial: Support custom baud rates on linux
by Urja Rannikko (Code Review) 16 Jun '17

16 Jun '17

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/20224 to look at the new patch set (#3). Change subject: serial: Support custom baud rates on linux ...................................................................... serial: Support custom baud rates on linux The function to do this is contained in custom_baud.c because of broken include stuff. Change-Id: I2a20f9182cb85e7bce5d6654a2caf20e6202b195 Signed-off-by: Urja Rannikko <urjaman(a)gmail.com> --- M Makefile A custom_baud.c A custom_baud.h M serial.c 4 files changed, 135 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/20224/3 -- To view, visit https://review.coreboot.org/20224 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2a20f9182cb85e7bce5d6654a2caf20e6202b195 Gerrit-Change-Number: 20224 Gerrit-PatchSet: 3 Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: serial: Support custom baud rates on linux
by Nico Huber (Code Review) 15 Jun '17

15 Jun '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/20224 ) Change subject: serial: Support custom baud rates on linux ...................................................................... Patch Set 2: (5 comments) https://review.coreboot.org/#/c/20224/2/custom_baud.c File custom_baud.c: https://review.coreboot.org/#/c/20224/2/custom_baud.c@56 PS2, Line 56: (void)baud; Do we have warnings for unused parameters enabled? I'm really curious, usually I have to do with compilers that warn about statements with no effect. ;) https://review.coreboot.org/#/c/20224/2/custom_baud.c@57 PS2, Line 57: return 0; `return -1;`? Just in case somebody calls it by accident? I wouldn't expect it, just an idea to set a good pattern. https://review.coreboot.org/#/c/20224/2/serial.c File serial.c: https://review.coreboot.org/#/c/20224/2/serial.c@145 PS2, Line 145: Superfluous space. (yeah, I know you just copied it) https://review.coreboot.org/#/c/20224/2/serial.c@155 PS2, Line 155: #endif You might have noticed that I'm not a fan of guards in code files... I would accept it as is, but here's another idea: Make that baudtable a parameter and move the whole function into custom_baud.c where we already have the Linux/non-Linux separation. Also, grouping the stubs together, would make it more obvious why the set_custom_baudrate() stub is never called. https://review.coreboot.org/#/c/20224/2/serial.c@218 PS2, Line 218: msg_perr_strerror("Could not set custom baudrate: "); We should bail out or fallback? -- To view, visit https://review.coreboot.org/20224 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I2a20f9182cb85e7bce5d6654a2caf20e6202b195 Gerrit-Change-Number: 20224 Gerrit-PatchSet: 2 Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Jun 2017 19:56:38 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: serial: Support custom baud rates on linux
by build bot (Jenkins) (Code Review) 15 Jun '17

15 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20224 ) Change subject: serial: Support custom baud rates on linux ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/360/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/370/ : SUCCESS -- To view, visit https://review.coreboot.org/20224 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I2a20f9182cb85e7bce5d6654a2caf20e6202b195 Gerrit-Change-Number: 20224 Gerrit-PatchSet: 2 Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Jun 2017 16:22:05 +0000 Gerrit-HasComments: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit