- flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: Whitelist Roda/RV11 laptop
by Nico Huber (Code Review) 20 Apr '17

20 Apr '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/18739 ) Change subject: Whitelist Roda/RV11 laptop ...................................................................... Patch Set 6: > Also needed for Roda/RW11? Yep, that's on another branch. Both need the layout patches due to the ME lock btw. -- To view, visit https://review.coreboot.org/18739 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I036c1f8cb914c8e3cca9d17eb221b582d7414ae9 Gerrit-PatchSet: 6 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Whitelist Roda/RV11 laptop
by Arthur Heymans (Code Review) 20 Apr '17

20 Apr '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18739 ) Change subject: Whitelist Roda/RV11 laptop ...................................................................... Patch Set 6: Code-Review+2 Also needed for Roda/RW11? -- To view, visit https://review.coreboot.org/18739 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I036c1f8cb914c8e3cca9d17eb221b582d7414ae9 Gerrit-PatchSet: 6 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Move register decodes into enable_flash_ich_handle_gcs()
by Arthur Heymans (Code Review) 20 Apr '17

20 Apr '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18882 ) Change subject: Move register decodes into enable_flash_ich_handle_gcs() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/18882 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40addec98cb6840763adad30f9d0e27dadce6d1e Gerrit-PatchSet: 2 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: make args for -r/-w/-v non-positional and optional
by David Hendricks (Code Review) 20 Apr '17

20 Apr '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/19387 ) Change subject: make args for -r/-w/-v non-positional and optional ...................................................................... Patch Set 1: Code-Review-1 needs polish, mostly just uploaded for convenience. -- To view, visit https://review.coreboot.org/19387 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: layout: Add -i <region>[:<file>] support.
by David Hendricks (Code Review) 20 Apr '17

20 Apr '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/19342 ) Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... Patch Set 3: Code-Review-1 (3 comments) still need to address Nico's comments https://review.coreboot.org/#/c/19342/1/flashrom.c File flashrom.c: PS1, Line 1330: /** : * @brief Writes included layout regions into buffer(s) : * : * If partial read to file is to be done (-i <region>[:<regionfile>] syntax : * used) then this will write to corresponding region-sized files. If an : * argument to -r/-w/-v is specified then it will write a chip-sized file. Both : * partial read/writes and full read/write may be done at once. : * : * @param buf Buffer with data to write : * @param size Size of buffer : * @param filename Filename corresponding to optional argument to -r/-w/-v : * @return 0 on success, : * 1 if any read fails. : */ This can be deleted. Line 1444: extra line https://review.coreboot.org/#/c/19342/2/layout.h File layout.h: PS2, Line 43: chip > `const char`? we'd never want to change it, would we? Yeah, there seems to have been something lost in translation. The original chromiumos version uses a statically allocated buffer and copies the filename into it, the ported version changes the 'region:file' string so that the colon is replaced by '\0' and file points at the first character in the filename. Bear in mind that name and file both come from optarg which we currently strdup(). I think the cleaner way to do this would be to: 1. Pass optarg into register_include_arg() 2. Find the colon 3. strdup() the region name and file name. 4. free() the two strings as needed in layout_cleanup(). And yes, const is a good idea (for both of them, I think). -- To view, visit https://review.coreboot.org/19342 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-PatchSet: 3 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: layout: Add -i <region>[:<file>] support.
by build bot (Jenkins) (Code Review) 20 Apr '17

20 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19342 ) Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/161/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/177/ : SUCCESS -- To view, visit https://review.coreboot.org/19342 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-PatchSet: 3 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Guard x86-specific IFD stuff
by build bot (Jenkins) (Code Review) 20 Apr '17

20 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19339 ) Change subject: Guard x86-specific IFD stuff ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/157/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/175/ : SUCCESS -- To view, visit https://review.coreboot.org/19339 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5abe84e47112fef0e3576045510b34ce94e6a4d Gerrit-PatchSet: 2 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: make args for -r/-w/-v non-positional and optional
by build bot (Jenkins) (Code Review) 20 Apr '17

20 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19387 ) Change subject: make args for -r/-w/-v non-positional and optional ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/160/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/176/ : SUCCESS -- To view, visit https://review.coreboot.org/19387 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Hack up test_v2.sh to work better with upstream
by build bot (Jenkins) (Code Review) 20 Apr '17

20 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19341 ) Change subject: Hack up test_v2.sh to work better with upstream ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/159/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/174/ : SUCCESS -- To view, visit https://review.coreboot.org/19341 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ace99fdb8d779804fe1887fe49f6409f8aff02e Gerrit-PatchSet: 2 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Copy test_v2 directory from chromiumos branch
by build bot (Jenkins) (Code Review) 20 Apr '17

20 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19340 ) Change subject: Copy test_v2 directory from chromiumos branch ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/158/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/173/ : SUCCESS -- To view, visit https://review.coreboot.org/19340 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41bef98d32df61af400ecac46ea9571e722b2ac6 Gerrit-PatchSet: 2 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit