David Hendricks has uploaded a new change for review. ( https://review.coreboot.org/19406 )
Change subject: test_v2.sh: Copy layout to local tempdir in local-layout mode
......................................................................
test_v2.sh: Copy layout to local tempdir in local-layout mode
The layout file wasn't being copied to the local tempdir when using
layout as the region mode and doing the test entirely locally.
BUG=none
BRANCH=none
TEST=ran test in layout mode locally
Change-Id: Ia2328d367ee3df5ac1c481c16e4502a81d69fd98
Signed-off-by: David Hendricks <dhendrix(a)chromium.org>
---
M tests/tests_v2/test_v2.sh
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/19406/1
diff --git a/tests/tests_v2/test_v2.sh b/tests/tests_v2/test_v2.sh
index 4c15c36..766f9ab 100755
--- a/tests/tests_v2/test_v2.sh
+++ b/tests/tests_v2/test_v2.sh
@@ -386,6 +386,8 @@
if [ $DO_REMOTE -eq 1 ]; then
scp root@"${REMOTE_HOST}:$LAYOUT_FILE" "${LOCAL_TMPDIR}/" 2>&1 >/dev/null
+ else
+ cp "$LAYOUT_FILE" "${LOCAL_TMPDIR}/"
fi
fi
elif [ $TEST_TYPE -eq $TEST_TYPE_WRITEPROTECT ]; then
--
To view, visit https://review.coreboot.org/19406
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2328d367ee3df5ac1c481c16e4502a81d69fd98
Gerrit-PatchSet: 1
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19341
to look at the new patch set (#3).
Change subject: Hack up test_v2.sh to work better with upstream
......................................................................
Hack up test_v2.sh to work better with upstream
Hacks applied on top of chromiumos version of test_v2.sh to get the
script running.
Change-Id: I9ace99fdb8d779804fe1887fe49f6409f8aff02e
Signed-off-by: David Hendricks <dhendricks(a)fb.com>
---
M tests/tests_v2/test_v2.sh
1 file changed, 39 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/41/19341/3
--
To view, visit https://review.coreboot.org/19341
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9ace99fdb8d779804fe1887fe49f6409f8aff02e
Gerrit-PatchSet: 3
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19340
to look at the new patch set (#3).
Change subject: Copy test_v2 directory from chromiumos branch
......................................................................
Copy test_v2 directory from chromiumos branch
This is a straight copy and should not be merged. The full patch
series will eventually be imported, but for now this is just a hack
to get stuff working.
Change-Id: I41bef98d32df61af400ecac46ea9571e722b2ac6
Signed-off-by: David Hendricks <dhendricks(a)fb.com>
---
A tests/tests_v2/cmd.sh
A tests/tests_v2/servo_hooks.sh
A tests/tests_v2/test_v2.sh
3 files changed, 1,371 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/19340/3
--
To view, visit https://review.coreboot.org/19340
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I41bef98d32df61af400ecac46ea9571e722b2ac6
Gerrit-PatchSet: 3
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19339
to look at the new patch set (#3).
Change subject: Guard x86-specific IFD stuff
......................................................................
Guard x86-specific IFD stuff
This will get squashed into a preceeding patch.
Change-Id: If5abe84e47112fef0e3576045510b34ce94e6a4d
Signed-off-by: David Hendricks <dhendricks(a)fb.com>
---
M libflashrom.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/39/19339/3
--
To view, visit https://review.coreboot.org/19339
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5abe84e47112fef0e3576045510b34ce94e6a4d
Gerrit-PatchSet: 3
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Hello Louis Yung-Chieh Lo, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19387
to look at the new patch set (#2).
Change subject: make args for -r/-w/-v non-positional and optional
......................................................................
make args for -r/-w/-v non-positional and optional
Ported from chromiumos:
https://chromium-review.googlesource.com/#/c/60515/
This makes a filename following -r, -w, and -v operations non-
positional. The first argument that does not begin with a hyphen (-)
is the filename for -r/-w/-v. If no such argument exists, then
-r/-w/-v options apply to files specified for individually included
regions via -i.
This has a few side-effects:
1. It allows us to omit the ROM-sized filename entirely when a
filename is provided for a particular region when using -i. For
example, "flashrom -i FOO:foo.bin -r".
2. It allows, for better or worse, the filename be specified anywhere
on the command line after the program name. Our scripts and docs
should still specify the file after -r/-w/-v for clarity.
For our purposes, if a filename is given for every included region
(-i region:filename) then the user does not need to specify a filename
after -r/-w/-v. However, if any -i option does not specify a filename,
then a file must be specified after -r/-w/-v.
The syntax will be backwards compatible for now so that one can still
mix -i options with and without the added filename specifier for each
region.
BUG=chromium:263495
BRANCH=none
TEST=manual (see notes below)
1. Write random data to RW_UNUSED region (on snow in this case)
without requiring an argument to -w. See that only RW_UNUSED
is erased and written, and that verify works:
dd if=/dev/urandom of=rw_unused.bin bs=1k count=1 conv=notrunc
flashrom -p host -i RW_UNUSED:rw_unused.bin -w -V
flashrom -p host -i RW_UNUSED:rw_unused.bin -v -V
2. Same as above, but specify a dummy file to test syntax
backwards compatibility:
dd if=/dev/urandom of=rw_unused.bin bs=1k count=1 conv=notrunc
dd if=/dev/urandom of=random_4M.bin bs=1M count=4
flashrom -p host -i RW_UNUSED:rw_unused.bin -w random_4M.bin -V
flashrom -p host -i RW_UNUSED:rw_unused.bin -v random_4M.bin -V
3. Test that dumping RW_UNUSED and GBB regions without -r arg dumps
two files and that they can be used to verify the content:
flashrom -p host -i RW_UNUSED:rw_unused.bin -i GBB:gbb.bin -r
flashrom -p host -i RW_UNUSED:rw_unused.bin -i GBB:gbb.bin -v
4. Same as above, but with dummy file:
flashrom -p host -i RW_UNUSED:rw_unused.bin -i GBB:gbb.bin -r x.bin
flashrom -p host -i RW_UNUSED:rw_unused.bin -i GBB:gbb.bin -v x.bin
Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803
Reviewed-on: https://gerrit.chromium.org/gerrit/60515
Reviewed-by: Yung-Chieh Lo <yjlou(a)chromium.org>
Commit-Queue: David Hendricks <dhendrix(a)chromium.org>
Tested-by: David Hendricks <dhendrix(a)chromium.org>
---
M cli_classic.c
M flashrom.c
M layout.c
M layout.h
4 files changed, 209 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/19387/2
--
To view, visit https://review.coreboot.org/19387
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803
Gerrit-PatchSet: 2
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
David Hendricks has posted comments on this change. ( https://review.coreboot.org/17944 )
Change subject: Give layouts their own type
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/17944
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icea1a58c283131cc9c5fde6f16d783538dc1a4c7
Gerrit-PatchSet: 4
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No
David Hendricks has posted comments on this change. ( https://review.coreboot.org/18740 )
Change subject: Enable writes with active ME
......................................................................
Patch Set 6:
er-- "a message at the end warning the user that the image is incomplete (skipped the ME region)" would apply only if we take the chromiumos approach and allow the user to read/write/verify a ROM-sized image (without specifying -i options) that just ignores the ME region.
--
To view, visit https://review.coreboot.org/18740
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94a5e7074b845c227e43d76d04dd1a71082a1cef
Gerrit-PatchSet: 6
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No
David Hendricks has posted comments on this change. ( https://review.coreboot.org/18740 )
Change subject: Enable writes with active ME
......................................................................
Patch Set 6:
Yeah, I think the huge message should be replaced with:
- If --noverify-all is not enabled automatically, an error telling the user they must enable that option.
or
- A warning that --noverify-all is being enabled on the user's behalf, and a message at the end warning the user that the image is incomplete (skipped the ME region).
Unless the user specifies --force in which case it should just try and fail as normal.
--
To view, visit https://review.coreboot.org/18740
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94a5e7074b845c227e43d76d04dd1a71082a1cef
Gerrit-PatchSet: 6
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No
David Hendricks has posted comments on this change. ( https://review.coreboot.org/18738 )
Change subject: Fix linking with libpayload
......................................................................
Patch Set 6: Code-Review-1
(2 comments)
The patch is OK, I'm just curious why we don't move flashbuses_to_text() into flashrom.c so the print can work consistently.
https://review.coreboot.org/#/c/18738/6//COMMIT_MSG
Commit Message:
PS6, Line 9: o flashbuses_to_text() is a cli function and should actually be moved
: or not be called from flashrom.c.
Why not move flashbuses_to_text() to flashrom.c?
https://review.coreboot.org/#/c/18738/6/helpers.c
File helpers.c:
Line 95: #if defined(__DJGPP__)
Hmm, I wonder if it's still useful to have a check for glibc compatibility while we're at it. According to the man page:
Since glibc 2.10:
_POSIX_C_SOURCE >= 200809L
Before glibc 2.10:
_GNU_SOURCE
--
To view, visit https://review.coreboot.org/18738
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I561135209b819361d125eeaeef9ff886d6bae987
Gerrit-PatchSet: 6
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes