- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: [WIP] flashchips: Revise all 4BA chips
by David Hendricks (Code Review) 12 Dec '17

12 Dec '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22423 ) Change subject: [WIP] flashchips: Revise all 4BA chips ...................................................................... Patch Set 3: Code-Review+1 FYI, I've tested this on W25Q256FV and MX66L51235F and it seems to work fine. Would love to see it go in soon (without the [WIP] in the summary of course) -- To view, visit https://review.coreboot.org/22423 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0598496ee7058e3b170684d366f58e4014e0e871 Gerrit-Change-Number: 22423 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Dec 2017 08:18:51 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: flashchips: Add ISSI IS25WP128
by David Hendricks (Code Review) 12 Dec '17

12 Dec '17

David Hendricks has abandoned this change. ( https://review.coreboot.org/19532 ) Change subject: flashchips: Add ISSI IS25WP128 ...................................................................... Abandoned superseded by https://review.coreboot.org/22784 -- To view, visit https://review.coreboot.org/19532 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: abandon Gerrit-Change-Id: Ia31764f0bf3ba1ed609f83b95e21343d7c23a508 Gerrit-Change-Number: 19532 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: Enable writes with active ME
by David Hendricks (Code Review) 12 Dec '17

12 Dec '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/18740 ) Change subject: Enable writes with active ME ...................................................................... Patch Set 15: Code-Review+2 I made an attempt to address this a couple months ago, but it turned out to be kinda messy. Basically, the programmer/chip code needs to be able to read the layout in order to determine what operations are possible in the user-specified region(s). Or, the layout code needs to know about any restrictions from the programmer/chip. Long story short, a real fix might be a ways off and this removes a barrier for people doing things the right way. So LGTM. -- To view, visit https://review.coreboot.org/18740 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I94a5e7074b845c227e43d76d04dd1a71082a1cef Gerrit-Change-Number: 18740 Gerrit-PatchSet: 15 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Dec 2017 07:44:08 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: Added support for GigaDevices GD25Q256C (4-byte addressing), Tested PREW
by build bot (Jenkins) (Code Review) 12 Dec '17

12 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22824 ) Change subject: Added support for GigaDevices GD25Q256C (4-byte addressing), Tested PREW ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/928/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/806/ : SUCCESS -- To view, visit https://review.coreboot.org/22824 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie73de31748f767bae2455bd809209721d698803d Gerrit-Change-Number: 22824 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Dec 2017 07:29:49 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: Added support for GigaDevices GD25Q256C (4-byte addressing), Tested PREW
by David Hendricks (Code Review) 12 Dec '17

12 Dec '17

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/22824 Change subject: Added support for GigaDevices GD25Q256C (4-byte addressing), Tested PREW ...................................................................... Added support for GigaDevices GD25Q256C (4-byte addressing), Tested PREW Change-Id: Ie73de31748f767bae2455bd809209721d698803d --- M flashchips.c M flashchips.h 2 files changed, 48 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/22824/1 diff --git a/flashchips.c b/flashchips.c index 77fcb90..4e6d350 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6257,6 +6257,53 @@ { .vendor = "GigaDevice", + .name = "GD25Q256C", + .bustype = BUS_SPI, + .manufacture_id = GIGADEVICE_ID, + .model_id = GIGADEVICE_GD25Q256C, + .total_size = 32768, + .page_size = 256, + /* OTP: 768B total; read 0x48; write 0x42, erase 0x44 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI | FEATURE_4BA_SUPPORT, + .four_bytes_addr_funcs = + { + .set_4ba = spi_enter_4ba_b7, /* enter 4-bytes addressing mode by CMD B7 */ + .read_nbyte = spi_nbyte_read_4ba, /* read from 4-bytes addressing mode */ + .program_byte = spi_byte_program_4ba, /* write from 4-bytes addressing mode */ + .program_nbyte = spi_nbyte_program_4ba /* write from 4-bytes addressing mode */ + }, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 8192} }, + .block_erase = spi_block_erase_20_4ba, + }, { + .eraseblocks = { {32 * 1024, 1024} }, + .block_erase = spi_block_erase_52_4ba, + }, { + .eraseblocks = { {64 * 1024, 512} }, + .block_erase = spi_block_erase_d8_4ba, + }, { + .eraseblocks = { {32 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {32 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + /* TODO: 2nd status reg (read 0x35, write 0x31) and 3rd status reg (read 0x15, write 0x11) */ + .printlock = spi_prettyprint_status_register_bp4_srwd, + .unlock = spi_disable_blockprotect_bp4_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {2700, 3600}, + }, + + { + .vendor = "GigaDevice", .name = "GD25T80", .bustype = BUS_SPI, .manufacture_id = GIGADEVICE_ID, diff --git a/flashchips.h b/flashchips.h index 6a7b0ae..46172fe 100644 --- a/flashchips.h +++ b/flashchips.h @@ -372,6 +372,7 @@ #define GIGADEVICE_GD25Q32 0x4016 /* Same as GD25Q32B */ #define GIGADEVICE_GD25Q64 0x4017 /* Same as GD25Q64B */ #define GIGADEVICE_GD25Q128 0x4018 /* GD25Q128B and GD25Q128C only, can be distinguished by SFDP */ +#define GIGADEVICE_GD25Q256C 0x4019 #define GIGADEVICE_GD25VQ21B 0x4212 #define GIGADEVICE_GD25VQ41B 0x4213 /* Same as GD25VQ40C, can be distinguished by SFDP */ #define GIGADEVICE_GD25VQ80C 0x4214 -- To view, visit https://review.coreboot.org/22824 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie73de31748f767bae2455bd809209721d698803d Gerrit-Change-Number: 22824 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[staging]: Enable writes with active ME
by Nico Huber (Code Review) 11 Dec '17

11 Dec '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/18740 ) Change subject: Enable writes with active ME ...................................................................... Patch Set 15: > Did we ever come to a conclusion? Kind of: As I don't want to add more globals to flashrom, I'll do it after I figured out how to handle the state in libflashrom ;) it's not a big issue as you can already write with active ME, just needs another commandline switch atm. -- To view, visit https://review.coreboot.org/18740 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I94a5e7074b845c227e43d76d04dd1a71082a1cef Gerrit-Change-Number: 18740 Gerrit-PatchSet: 15 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Dec 2017 18:29:41 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: flashchips: Add ISSI IS25LP128 and IS25WP128
by build bot (Jenkins) (Code Review) 11 Dec '17

11 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22784 ) Change subject: flashchips: Add ISSI IS25LP128 and IS25WP128 ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/flashrom-customrules/927/ : SUCCESS -- To view, visit https://review.coreboot.org/22784 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1c7a9a950043c30b7525196e03ee394689e89a5 Gerrit-Change-Number: 22784 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Dec 2017 18:21:13 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: flashchips: Add ISSI IS25LP128 and IS25WP128
by Nico Huber (Code Review) 11 Dec '17

11 Dec '17

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/22784 ) Change subject: flashchips: Add ISSI IS25LP128 and IS25WP128 ...................................................................... flashchips: Add ISSI IS25LP128 and IS25WP128 IS25LP128 is the 3.3V variant, IS25WP128 is the 1.8V variant. Tested read, erase, and write using Dediprog SF600 on each. Change-Id: Ia1c7a9a950043c30b7525196e03ee394689e89a5 Signed-off-by: David Hendricks <dhendricks(a)fb.com> Reviewed-on: https://review.coreboot.org/22784 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c M flashchips.h 2 files changed, 85 insertions(+), 0 deletions(-) Approvals: Nico Huber: Looks good to me, approved build bot (Jenkins): Verified diff --git a/flashchips.c b/flashchips.c index 749e96e..77fcb90 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7082,6 +7082,88 @@ { .vendor = "ISSI", + .name = "IS25LP128", + .bustype = BUS_SPI, + .manufacture_id = ISSI_ID_SPI, + .model_id = ISSI_IS25LP128, + .total_size = 16384, + .page_size = 256, + /* OTP: 1024B total; read 0x48; write 0x42 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = spi_block_erase_d7, + }, { + .eraseblocks = { {32 * 1024, 512} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2300, 3600}, + }, + + { + .vendor = "ISSI", + .name = "IS25WP128", + .bustype = BUS_SPI, + .manufacture_id = ISSI_ID_SPI, + .model_id = ISSI_IS25WP128, + .total_size = 16384, + .page_size = 256, + /* OTP: 1024B total; read 0x48; write 0x42 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = spi_block_erase_d7, + }, { + .eraseblocks = { {32 * 1024, 512} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {1650, 1950}, + }, + + { + .vendor = "ISSI", .name = "IS29GL064B", .bustype = BUS_PARALLEL, .manufacture_id = ISSI_ID, diff --git a/flashchips.h b/flashchips.h index 62eb9a5..6a7b0ae 100644 --- a/flashchips.h +++ b/flashchips.h @@ -452,6 +452,9 @@ #define SHARP_LH28F008SC 0xA6 /* Sharp chip, Intel Vendor ID */ #define ISSI_ID 0xD5 /* ISSI Integrated Silicon Solutions, see also PMC. */ +#define ISSI_ID_SPI 0x9D /* ISSI ID used for SPI flash, see also PMC_ID_NOPREFIX */ +#define ISSI_IS25LP128 0x6018 +#define ISSI_IS25WP128 0x7018 #define ISSI_PMC_IS29GL032B 0xF9 #define ISSI_PMC_IS29GL032T 0xF6 #define ISSI_PMC_IS29GL064B 0x7E1000 -- To view, visit https://review.coreboot.org/22784 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia1c7a9a950043c30b7525196e03ee394689e89a5 Gerrit-Change-Number: 22784 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: Add ISSI IS25LP128 and IS25WP128
by build bot (Jenkins) (Code Review) 11 Dec '17

11 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22784 ) Change subject: flashchips: Add ISSI IS25LP128 and IS25WP128 ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/805/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/926/ : SUCCESS -- To view, visit https://review.coreboot.org/22784 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1c7a9a950043c30b7525196e03ee394689e89a5 Gerrit-Change-Number: 22784 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Dec 2017 18:20:30 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: flashchips: Add ISSI IS25LP128 and IS25WP128
by Nico Huber (Code Review) 11 Dec '17

11 Dec '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22784 ) Change subject: flashchips: Add ISSI IS25LP128 and IS25WP128 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/22784 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1c7a9a950043c30b7525196e03ee394689e89a5 Gerrit-Change-Number: 22784 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Dec 2017 18:19:17 +0000 Gerrit-HasComments: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit