- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: internal: Fix warnings about unused constants
by Nico Huber (Code Review) 09 Dec '17

09 Dec '17

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/22669 ) Change subject: internal: Fix warnings about unused constants ...................................................................... internal: Fix warnings about unused constants By adding more #if guards, fix warnings about unused constants that are enabled by default in newer GCC versions. Change-Id: Ib3b6d7c0c2fadc4faeab971673bfadb1a6d25919 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/22669 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> Reviewed-by: Patrick Rudolph <siro(a)das-labor.org> --- M internal.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Patrick Rudolph: Looks good to me, approved diff --git a/internal.c b/internal.c index 4062b64..276e14b 100644 --- a/internal.c +++ b/internal.c @@ -131,6 +131,7 @@ int is_laptop = 0; int laptop_ok = 0; +#if IS_X86 || IS_MIPS static void internal_chip_writeb(const struct flashctx *flash, uint8_t val, chipaddr addr); static void internal_chip_writew(const struct flashctx *flash, uint16_t val, @@ -155,6 +156,7 @@ .chip_writel = internal_chip_writel, .chip_writen = fallback_chip_writen, }; +#endif enum chipbustype internal_buses_supported = BUS_NONE; @@ -358,6 +360,7 @@ } #endif +#if IS_X86 || IS_MIPS static void internal_chip_writeb(const struct flashctx *flash, uint8_t val, chipaddr addr) { @@ -400,3 +403,4 @@ mmio_readn((void *)addr, buf, len); return; } +#endif -- To view, visit https://review.coreboot.org/22669 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib3b6d7c0c2fadc4faeab971673bfadb1a6d25919 Gerrit-Change-Number: 22669 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[stable]: Fix some whitespace and parentheses recently introduced
by Nico Huber (Code Review) 09 Dec '17

09 Dec '17

Nico Huber has abandoned this change. ( https://review.coreboot.org/21982 ) Change subject: Fix some whitespace and parentheses recently introduced ...................................................................... Abandoned Abandoning sable branch. -- To view, visit https://review.coreboot.org/21982 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: abandon Gerrit-Change-Id: I4dd7af338596584b678a915e3b0dc57520be01bc Gerrit-Change-Number: 21982 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[stable]: Add modification date to manpage header instead of the section
by Nico Huber (Code Review) 09 Dec '17

09 Dec '17

Nico Huber has abandoned this change. ( https://review.coreboot.org/21941 ) Change subject: Add modification date to manpage header instead of the section ...................................................................... Abandoned Abandoning stable branch. -- To view, visit https://review.coreboot.org/21941 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: abandon Gerrit-Change-Id: I45c5d6a2316c51a57a49fd010682dc3f0f915382 Gerrit-Change-Number: 21941 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[stable]: nicintel_spi: Define BIT() macro
by Nico Huber (Code Review) 09 Dec '17

09 Dec '17

Nico Huber has abandoned this change. ( https://review.coreboot.org/21940 ) Change subject: nicintel_spi: Define BIT() macro ...................................................................... Abandoned Abandoning stable branch. -- To view, visit https://review.coreboot.org/21940 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: abandon Gerrit-Change-Id: I07cd1180aa290303705730d381e32d4c09df1ae5 Gerrit-Change-Number: 21940 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[stable]: nicintel_spi: Support for I210/I211 cards
by Nico Huber (Code Review) 09 Dec '17

09 Dec '17

Nico Huber has abandoned this change. ( https://review.coreboot.org/21939 ) Change subject: nicintel_spi: Support for I210/I211 cards ...................................................................... Abandoned Abandoning stable branch. -- To view, visit https://review.coreboot.org/21939 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: abandon Gerrit-Change-Id: Ie1e5127cd3efdfef3489ef85a5f48a58deb37f8a Gerrit-Change-Number: 21939 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[stable]: nicintel_eeprom: Support for I210 emulated EEprom
by Nico Huber (Code Review) 09 Dec '17

09 Dec '17

Nico Huber has abandoned this change. ( https://review.coreboot.org/21938 ) Change subject: nicintel_eeprom: Support for I210 emulated EEprom ...................................................................... Abandoned Abandoning stable branch. -- To view, visit https://review.coreboot.org/21938 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: abandon Gerrit-Change-Id: I96f294eec42fd7609b27b76853e61a9bf18f7079 Gerrit-Change-Number: 21938 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[stable]: sb600spi: Add support for Merlin Falcon Chipset
by Nico Huber (Code Review) 09 Dec '17

09 Dec '17

Nico Huber has abandoned this change. ( https://review.coreboot.org/21937 ) Change subject: sb600spi: Add support for Merlin Falcon Chipset ...................................................................... Abandoned Abandoning stable branch. -- To view, visit https://review.coreboot.org/21937 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: abandon Gerrit-Change-Id: I44e55fe9bdb5ac00ed118d1d3cdc2c80b5e997cf Gerrit-Change-Number: 21937 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[stable]: ich_descriptors: Use MAX_NUM_FLREGS for entries[]
by Nico Huber (Code Review) 09 Dec '17

09 Dec '17

Nico Huber has abandoned this change. ( https://review.coreboot.org/21821 ) Change subject: ich_descriptors: Use MAX_NUM_FLREGS for entries[] ...................................................................... Abandoned Abandoning stable branch. -- To view, visit https://review.coreboot.org/21821 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: abandon Gerrit-Change-Id: Ic6b658a1625620009ffd23e526093609a6b0baf8 Gerrit-Change-Number: 21821 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[stable]: Move ich_layout from layout.h to ich_descriptors.h
by Nico Huber (Code Review) 09 Dec '17

09 Dec '17

Nico Huber has abandoned this change. ( https://review.coreboot.org/21820 ) Change subject: Move ich_layout from layout.h to ich_descriptors.h ...................................................................... Abandoned Abandoning stable branch. -- To view, visit https://review.coreboot.org/21820 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: abandon Gerrit-Change-Id: Ibcdf8ad694e88ffb14f70bb830ebd2a13d6cced8 Gerrit-Change-Number: 21820 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[stable]: chipset_enable: Add support for C620-series Lewisburg PCH
by Nico Huber (Code Review) 09 Dec '17

09 Dec '17

Nico Huber has abandoned this change. ( https://review.coreboot.org/21819 ) Change subject: chipset_enable: Add support for C620-series Lewisburg PCH ...................................................................... Abandoned Abandoning stable branch. -- To view, visit https://review.coreboot.org/21819 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: abandon Gerrit-Change-Id: Ia93f4616c9279173b5cd47be1999939aa2f02379 Gerrit-Change-Number: 21819 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit