- flashrom-gerrit - mail.coreboot.org

Change in flashrom[1.0.x]: ichspi: Fix 100 series PCH (Skylake) support
by Nico Huber (Code Review) 19 Dec '17

19 Dec '17

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/22944 ) Change subject: ichspi: Fix 100 series PCH (Skylake) support ...................................................................... ichspi: Fix 100 series PCH (Skylake) support Pretty subtle missing `else` made flashrom treat Skylake like older chipsets. Change-Id: I14bf578964124d4677cb5dfca01c9d1b0d279c9c Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reported-by: Youness Alaoui <kakaroto(a)kakaroto.homelinux.net> Reviewed-on: https://review.coreboot.org/22832 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Youness Alaoui <snifikino(a)gmail.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> (cherry picked from commit 19eb0792b8439198d7ef0077b8f79f275fa39a9d) Reviewed-on: https://review.coreboot.org/22944 --- M ichspi.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/ichspi.c b/ichspi.c index 859d55f..c7bda92 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1715,7 +1715,7 @@ hwseq_data.addr_mask = PCH100_FADDR_FLA; hwseq_data.only_4k = true; hwseq_data.hsfc_fcycle = PCH100_HSFC_FCYCLE; - } if (ich_generation == CHIPSET_C620_SERIES_LEWISBURG) { + } else if (ich_generation == CHIPSET_C620_SERIES_LEWISBURG) { num_freg = 12; /* 12 MMIO regs, but 16 regions in FD spec */ num_pr = 6; /* Includes GPR0 */ reg_pr0 = PCH100_REG_FPR0; -- To view, visit https://review.coreboot.org/22944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: merged Gerrit-Change-Id: I14bf578964124d4677cb5dfca01c9d1b0d279c9c Gerrit-Change-Number: 22944 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[1.0.x]: ichspi: Fix 100 series PCH (Skylake) support
by Nico Huber (Code Review) 19 Dec '17

19 Dec '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22944 ) Change subject: ichspi: Fix 100 series PCH (Skylake) support ...................................................................... Patch Set 1: Code-Review+2 Already reviewed for master. -- To view, visit https://review.coreboot.org/22944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: comment Gerrit-Change-Id: I14bf578964124d4677cb5dfca01c9d1b0d279c9c Gerrit-Change-Number: 22944 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Dec 2017 12:30:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[1.0.x]: ichspi: Fix 100 series PCH (Skylake) support
by build bot (Jenkins) (Code Review) 19 Dec '17

19 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22944 ) Change subject: ichspi: Fix 100 series PCH (Skylake) support ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/817/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/942/ : SUCCESS -- To view, visit https://review.coreboot.org/22944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: comment Gerrit-Change-Id: I14bf578964124d4677cb5dfca01c9d1b0d279c9c Gerrit-Change-Number: 22944 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Dec 2017 12:30:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: ichspi: Fix 100 series PCH (Skylake) support
by build bot (Jenkins) (Code Review) 19 Dec '17

19 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22832 ) Change subject: ichspi: Fix 100 series PCH (Skylake) support ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/flashrom-customrules/941/ : SUCCESS -- To view, visit https://review.coreboot.org/22832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14bf578964124d4677cb5dfca01c9d1b0d279c9c Gerrit-Change-Number: 22832 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Dec 2017 12:30:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: ichspi: Fix 100 series PCH (Skylake) support
by Nico Huber (Code Review) 19 Dec '17

19 Dec '17

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/22832 ) Change subject: ichspi: Fix 100 series PCH (Skylake) support ...................................................................... ichspi: Fix 100 series PCH (Skylake) support Pretty subtle missing `else` made flashrom treat Skylake like older chipsets. Change-Id: I14bf578964124d4677cb5dfca01c9d1b0d279c9c Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reported-by: Youness Alaoui <kakaroto(a)kakaroto.homelinux.net> Reviewed-on: https://review.coreboot.org/22832 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Youness Alaoui <snifikino(a)gmail.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> --- M ichspi.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Youness Alaoui: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve David Hendricks: Looks good to me, approved diff --git a/ichspi.c b/ichspi.c index 859d55f..c7bda92 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1715,7 +1715,7 @@ hwseq_data.addr_mask = PCH100_FADDR_FLA; hwseq_data.only_4k = true; hwseq_data.hsfc_fcycle = PCH100_HSFC_FCYCLE; - } if (ich_generation == CHIPSET_C620_SERIES_LEWISBURG) { + } else if (ich_generation == CHIPSET_C620_SERIES_LEWISBURG) { num_freg = 12; /* 12 MMIO regs, but 16 regions in FD spec */ num_pr = 6; /* Includes GPR0 */ reg_pr0 = PCH100_REG_FPR0; -- To view, visit https://review.coreboot.org/22832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I14bf578964124d4677cb5dfca01c9d1b0d279c9c Gerrit-Change-Number: 22832 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: ichspi: Fix 100 series PCH (Skylake) support
by David Hendricks (Code Review) 18 Dec '17

18 Dec '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22832 ) Change subject: ichspi: Fix 100 series PCH (Skylake) support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14bf578964124d4677cb5dfca01c9d1b0d279c9c Gerrit-Change-Number: 22832 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Dec 2017 03:04:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: ichspi: Fix 100 series PCH (Skylake) support
by Paul Menzel (Code Review) 13 Dec '17

13 Dec '17

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/22832 ) Change subject: ichspi: Fix 100 series PCH (Skylake) support ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/22832 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14bf578964124d4677cb5dfca01c9d1b0d279c9c Gerrit-Change-Number: 22832 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Dec 2017 07:17:23 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: ichspi: Fix 100 series PCH (Skylake) support
by Youness Alaoui (Code Review) 12 Dec '17

12 Dec '17

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/22832 ) Change subject: ichspi: Fix 100 series PCH (Skylake) support ...................................................................... Patch Set 1: Code-Review+2 I can't test it now, but looks good to me. -- To view, visit https://review.coreboot.org/22832 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14bf578964124d4677cb5dfca01c9d1b0d279c9c Gerrit-Change-Number: 22832 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Dec 2017 22:53:27 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: ichspi: Fix 100 series PCH (Skylake) support
by build bot (Jenkins) (Code Review) 12 Dec '17

12 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22832 ) Change subject: ichspi: Fix 100 series PCH (Skylake) support ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/940/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/816/ : SUCCESS -- To view, visit https://review.coreboot.org/22832 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14bf578964124d4677cb5dfca01c9d1b0d279c9c Gerrit-Change-Number: 22832 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Dec 2017 22:41:21 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: ichspi: Fix 100 series PCH (Skylake) support
by Nico Huber (Code Review) 12 Dec '17

12 Dec '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22832 Change subject: ichspi: Fix 100 series PCH (Skylake) support ...................................................................... ichspi: Fix 100 series PCH (Skylake) support Pretty subtle missing `else` made flashrom treat Skylake like older chipsets. Change-Id: I14bf578964124d4677cb5dfca01c9d1b0d279c9c Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reported-by: Youness Alaoui <kakaroto(a)kakaroto.homelinux.net> --- M ichspi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/22832/1 diff --git a/ichspi.c b/ichspi.c index 859d55f..c7bda92 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1715,7 +1715,7 @@ hwseq_data.addr_mask = PCH100_FADDR_FLA; hwseq_data.only_4k = true; hwseq_data.hsfc_fcycle = PCH100_HSFC_FCYCLE; - } if (ich_generation == CHIPSET_C620_SERIES_LEWISBURG) { + } else if (ich_generation == CHIPSET_C620_SERIES_LEWISBURG) { num_freg = 12; /* 12 MMIO regs, but 16 regions in FD spec */ num_pr = 6; /* Includes GPR0 */ reg_pr0 = PCH100_REG_FPR0; -- To view, visit https://review.coreboot.org/22832 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I14bf578964124d4677cb5dfca01c9d1b0d279c9c Gerrit-Change-Number: 22832 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit