- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: chipset_enable: Mark VX855 as tested
by build bot (Jenkins) (Code Review) 08 Jan '18

08 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23158 ) Change subject: chipset_enable: Mark VX855 as tested ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/863/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1013/ : SUCCESS -- To view, visit https://review.coreboot.org/23158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f48b49ccb760f69d676ec6cbb233e532b12fbe8 Gerrit-Change-Number: 23158 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 08 Jan 2018 08:24:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: chipset_enable: Mark VX855 as tested
by Lubomir Rintel (Code Review) 08 Jan '18

08 Jan '18

Lubomir Rintel has uploaded this change for review. ( https://review.coreboot.org/23158 Change subject: chipset_enable: Mark VX855 as tested ...................................................................... chipset_enable: Mark VX855 as tested I can confirm a successful reading and writing of SST49LF080A (LPC) on a Wyse Cx0 Thin Client (Phoenix BIOS 1.0G). Change-Id: I8f48b49ccb760f69d676ec6cbb233e532b12fbe8 Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk> --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/58/23158/1 diff --git a/chipset_enable.c b/chipset_enable.c index a46651f..8243455 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1713,7 +1713,7 @@ {0x1106, 0x8231, NT, "VIA", "VT8231", enable_flash_vt823x}, {0x1106, 0x8324, OK, "VIA", "CX700", enable_flash_vt823x}, {0x1106, 0x8353, NT, "VIA", "VX800/VX820", enable_flash_vt_vx}, - {0x1106, 0x8409, NT, "VIA", "VX855/VX875", enable_flash_vt_vx}, + {0x1106, 0x8409, OK, "VIA", "VX855/VX875", enable_flash_vt_vx}, {0x1106, 0x8410, OK, "VIA", "VX900", enable_flash_vt_vx}, {0x1166, 0x0200, OK, "Broadcom", "OSB4", enable_flash_osb4}, {0x1166, 0x0205, OK, "Broadcom", "HT-1000", enable_flash_ht1000}, -- To view, visit https://review.coreboot.org/23158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8f48b49ccb760f69d676ec6cbb233e532b12fbe8 Gerrit-Change-Number: 23158 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk>

1 0

Change in flashrom[master]: board_enable: Wyse Cx0 thin client is not a laptop
by Lubomir Rintel (Code Review) 08 Jan '18

08 Jan '18

Lubomir Rintel has uploaded this change for review. ( https://review.coreboot.org/23157 Change subject: board_enable: Wyse Cx0 thin client is not a laptop ...................................................................... board_enable: Wyse Cx0 thin client is not a laptop Add it to the whitelist. The subsystem IDs no the machine look completely random. Hopefully they're stable across the boards. The PCI gigabit ethernet is external to the chipset. Change-Id: Icc9d48c61680f2dc6818b4dc7e1e721a97f0c0bb Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk> --- M board_enable.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/23157/1 diff --git a/board_enable.c b/board_enable.c index b6e17ef..83d16a0 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2471,6 +2471,7 @@ {0x1106, 0x0259, 0x1106, 0xAA07, 0x1106, 0x3227, 0x1106, 0xAA07, NULL, NULL, NULL, P3, "VIA", "EPIA EK", 0, NT, via_vt823x_gpio9_raise}, {0x1106, 0x3177, 0x1106, 0xAA01, 0x1106, 0x3123, 0x1106, 0xAA01, NULL, NULL, NULL, P3, "VIA", "EPIA M/MII/...", 0, OK, via_vt823x_gpio15_raise}, {0x1106, 0x0259, 0x1106, 0x3227, 0x1106, 0x3065, 0x1106, 0x3149, NULL, NULL, NULL, P3, "VIA", "EPIA-N/NL", 0, OK, via_vt823x_gpio9_raise}, + {0x1106, 0x0409, 0x6334, 0x0920, 0x1106, 0x3119, 0x1106, 0x0110, "^C CLASS$", NULL, NULL, P2, "Wyse", "Cx0", 0, OK, p2_not_a_laptop}, #endif { 0, 0, 0, 0, 0, 0, 0, 0, NULL, NULL, NULL, P3, NULL, NULL, 0, NT, NULL}, /* end marker */ }; -- To view, visit https://review.coreboot.org/23157 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icc9d48c61680f2dc6818b4dc7e1e721a97f0c0bb Gerrit-Change-Number: 23157 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk>

1 0

Change in flashrom[master]: layout: Add -i <region>[:<file>] support.
by Nico Huber (Code Review) 08 Jan '18

08 Jan '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23021 ) Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... Patch Set 5: (15 comments) https://review.coreboot.org/#/c/23021/5/cli_classic.c File cli_classic.c: https://review.coreboot.org/#/c/23021/5/cli_classic.c@61 PS5, Line 61: <: rather :< https://review.coreboot.org/#/c/23021/5/flashrom.c File flashrom.c: https://review.coreboot.org/#/c/23021/5/flashrom.c@1320 PS5, Line 1320: const char *filename, const char *size_msg) Line limit is 112 chars for flashrom. (not my first choice, though hadn't time to look at the discussion, back in 2011~2012 iirc) https://review.coreboot.org/#/c/23021/5/flashrom.c@1364 PS5, Line 1364: #ifdef __LIBPAYLOAD__ : msg_gerr("Error: No file I/O support in libpayload\n"); : return 1; : #else Seems unnecessary, now that we use read_buf_from_file(). https://review.coreboot.org/#/c/23021/5/flashrom.c@1368 PS5, Line 1368: int ret = 0, i; `ret` is not used (as a variable) anymore. https://review.coreboot.org/#/c/23021/5/flashrom.c@1379 PS5, Line 1379: } I'm a bit confused here. Do we allow such layouts at all? Will try to investigate myself... https://review.coreboot.org/#/c/23021/5/flashrom.c@1387 PS5, Line 1387: if ((entry->start > size) || (entry->end > size)) { Checking `entry->end` should suffice. https://review.coreboot.org/#/c/23021/5/flashrom.c@1391 PS5, Line 1391: } Again, do we allow such layouts? https://review.coreboot.org/#/c/23021/5/flashrom.c@1484 PS5, Line 1484: #ifdef __LIBPAYLOAD__ : msg_gerr("Error: No file I/O support in libpayload\n"); : return 1; : #else Should be kept in do_write_buf_to_file() where the actual file handling happens. It also shows that flashrom.c is not the right place for this maybe worth a follow-up. https://review.coreboot.org/#/c/23021/5/flashrom.c@1502 PS5, Line 1502: msg_gdbg("\n"); /* avoid printing in caller's output */ `i == 0` isn't always the first included region https://review.coreboot.org/#/c/23021/5/flashrom.c@2660 PS5, Line 2660: /* : * This must be done before any files specified by -i arguments are : * processed and merged into newcontents since -i files take priority. : * See http://crbug.com/263495. : */ I don't understand it. The comment seems to assume that we call both after another? Also we should catch it in the CLI in the next patch. So we have a proper error message in case both a -w filename and -i :files are given. Same for -v. https://review.coreboot.org/#/c/23021/5/layout.c File layout.c: https://review.coreboot.org/#/c/23021/5/layout.c@175 PS5, Line 175: -l/--layout This list might get very long... https://review.coreboot.org/#/c/23021/5/layout.c@189 PS5, Line 189: /* Quotes or whitespace are not allowed in region names. */ why test it here? why add it now? https://review.coreboot.org/#/c/23021/5/layout.c@202 PS5, Line 202: found++; As we bail out otherwise, `found` will always be `num_include_args` in the end? https://review.coreboot.org/#/c/23021/5/layout.c@213 PS5, Line 213: #ifdef __LIBPAYLOAD__ : msg_gerr("Error: No file I/O support in libpayload\n"); : return 1; : #else libflashrom doesn't call it anyway, does it? The original guards only exist to make it compile (i.e. hide calls to i/o stream functions). https://review.coreboot.org/#/c/23021/5/layout.c@217 PS5, Line 217: file = strdup(file); why? is it necessary? doesn't `file` point into `argv` of main()? -- To view, visit https://review.coreboot.org/23021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 5 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 08 Jan 2018 00:13:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: [NOTFORMERGE] X200 SPI hack
by build bot (Jenkins) (Code Review) 08 Jan '18

08 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23151 ) Change subject: [NOTFORMERGE] X200 SPI hack ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/862/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1012/ : SUCCESS -- To view, visit https://review.coreboot.org/23151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28f2e06c5b919bc08ea33ec15713e4dc3b183edd Gerrit-Change-Number: 23151 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 07 Jan 2018 23:29:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [NOTFORMERGE] X200 SPI hack
by Nico Huber (Code Review) 08 Jan '18

08 Jan '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/23151 Change subject: [NOTFORMERGE] X200 SPI hack ...................................................................... [NOTFORMERGE] X200 SPI hack Send a dummy READ command before any other command. Change-Id: I28f2e06c5b919bc08ea33ec15713e4dc3b183edd Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M spi.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/23151/1 diff --git a/spi.c b/spi.c index 56f1fdf..4338124 100644 --- a/spi.c +++ b/spi.c @@ -34,6 +34,9 @@ unsigned int readcnt, const unsigned char *writearr, unsigned char *readarr) { + unsigned char dummy[256]; + const unsigned char readcmd[JEDEC_READ_OUTSIZE] = { JEDEC_READ, }; + flash->mst->spi.command(flash, sizeof(readcmd), sizeof(dummy), readcmd, dummy); return flash->mst->spi.command(flash, writecnt, readcnt, writearr, readarr); } -- To view, visit https://review.coreboot.org/23151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I28f2e06c5b919bc08ea33ec15713e4dc3b183edd Gerrit-Change-Number: 23151 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: layout: Add -i <region>[:<file>] support.
by Nicola Corna (Code Review) 08 Jan '18

08 Jan '18

Nicola Corna has posted comments on this change. ( https://review.coreboot.org/23021 ) Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/#/c/23021/5/cli_classic.c File cli_classic.c: https://review.coreboot.org/#/c/23021/5/cli_classic.c@61 PS5, Line 61: flash read/write -- To view, visit https://review.coreboot.org/23021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 5 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 07 Jan 2018 23:12:01 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Hack up test_v2.sh to work better with upstream
by David Hendricks (Code Review) 07 Jan '18

07 Jan '18

David Hendricks has restored this change. ( https://review.coreboot.org/23025 ) Change subject: Hack up test_v2.sh to work better with upstream ...................................................................... Restored switching over to development on master -- To view, visit https://review.coreboot.org/23025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: restore Gerrit-Change-Id: I9ace99fdb8d779804fe1887fe49f6409f8aff02e Gerrit-Change-Number: 23025 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: test_v2.sh: Copy layout to local tempdir in local-layout mode
by David Hendricks (Code Review) 07 Jan '18

07 Jan '18

David Hendricks has restored this change. ( https://review.coreboot.org/23024 ) Change subject: test_v2.sh: Copy layout to local tempdir in local-layout mode ...................................................................... Restored switching over to development on master -- To view, visit https://review.coreboot.org/23024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: restore Gerrit-Change-Id: Ia2328d367ee3df5ac1c481c16e4502a81d69fd98 Gerrit-Change-Number: 23024 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Copy test_v2 directory from chromiumos branch
by David Hendricks (Code Review) 07 Jan '18

07 Jan '18

David Hendricks has restored this change. ( https://review.coreboot.org/23023 ) Change subject: Copy test_v2 directory from chromiumos branch ...................................................................... Restored switching over to development on master -- To view, visit https://review.coreboot.org/23023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: restore Gerrit-Change-Id: I41bef98d32df61af400ecac46ea9571e722b2ac6 Gerrit-Change-Number: 23023 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit