- flashrom-gerrit - mail.coreboot.org

Change in flashrom[refs/meta/config]: Make Stefan, David and myself flashrom Owners
by build bot (Jenkins) (Code Review) 07 Nov '17

07 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22357 ) Change subject: Make Stefan, David and myself flashrom Owners ...................................................................... Patch Set 1: Build Failed https://qa.coreboot.org/job/flashrom_gerrit/731/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/839/ : SUCCESS -- To view, visit https://review.coreboot.org/22357 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: comment Gerrit-Change-Id: Ia8945aced4984dd84a7cc6db50adf1b486edf915 Gerrit-Change-Number: 22357 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 06 Nov 2017 17:26:31 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[refs/meta/config]: Make Stefan, David and myself flashrom Owners
by Nico Huber (Code Review) 07 Nov '17

07 Nov '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22357 Change subject: Make Stefan, David and myself flashrom Owners ...................................................................... Make Stefan, David and myself flashrom Owners Change-Id: Ia8945aced4984dd84a7cc6db50adf1b486edf915 --- M project.config 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/22357/1 diff --git a/project.config b/project.config index 3ff4784..157e80a 100644 --- a/project.config +++ b/project.config @@ -35,6 +35,9 @@ label-Verified = -1..+1 group user/Stefan Tauner (stefanct) submit = group user/Stefan Tauner (stefanct) label-Code-Review = -2..+2 group user/Stefan Tauner (stefanct) + owner = group user/David Hendricks (dhendrix) + owner = group user/Nico Huber (Nico) + owner = group user/Stefan Tauner (stefanct) [access "refs/heads/*"] exclusiveGroupPermissions = create delete create = group user/David Hendricks (dhendrix) -- To view, visit https://review.coreboot.org/22357 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: newchange Gerrit-Change-Id: Ia8945aced4984dd84a7cc6db50adf1b486edf915 Gerrit-Change-Number: 22357 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[staging]: print: Update Asus URLs to use more secure HTTPS
by David Hendricks (Code Review) 06 Nov '17

06 Nov '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22354 ) Change subject: print: Update Asus URLs to use more secure HTTPS ...................................................................... Patch Set 3: Code-Review-1 (1 comment) Minor nit in the commit message, otherwise LGTM. https://review.coreboot.org/#/c/22354/3//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/22354/3//COMMIT_MSG@26 PS3, Line 26: git grep -l 'http://www.asus.com' | xargs Mind if we shorten this or break in into two lines? To shorten it, you can remove everything before the `sed` command and add print.c as an argument then it's functionally equivalent, at least for the purposes of this patch. -- To view, visit https://review.coreboot.org/22354 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I62319bfbf39c73f98ed3f865a11f4fe870befee4 Gerrit-Change-Number: 22354 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 06 Nov 2017 08:21:16 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[master]: print: Update Asus URLs to use more secure HTTPS
by David Hendricks (Code Review) 06 Nov '17

06 Nov '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21874 ) Change subject: print: Update Asus URLs to use more secure HTTPS ...................................................................... Patch Set 1: Out of curiosity I tried the URLs (firefox-bin --new-tab $URL in a script) and found that 31 out of 113 URLs are broken, regardless of whether we try to use https or not. The broken ones also auto-redirect to https, even if the page doesn't exist. -- To view, visit https://review.coreboot.org/21874 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62319bfbf39c73f98ed3f865a11f4fe870befee4 Gerrit-Change-Number: 21874 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 06 Nov 2017 08:06:35 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: print: Update Asus URLs to use more secure HTTPS
by build bot (Jenkins) (Code Review) 06 Nov '17

06 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22354 ) Change subject: print: Update Asus URLs to use more secure HTTPS ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/730/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/838/ : SUCCESS -- To view, visit https://review.coreboot.org/22354 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I62319bfbf39c73f98ed3f865a11f4fe870befee4 Gerrit-Change-Number: 22354 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 06 Nov 2017 07:38:47 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: print: Update Asus URLs to use more secure HTTPS
by David Hendricks (Code Review) 06 Nov '17

06 Nov '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22354 to look at the new patch set (#3). Change subject: print: Update Asus URLs to use more secure HTTPS ...................................................................... print: Update Asus URLs to use more secure HTTPS Asus set up HTTPS for their site, and redirects to that by default. So, use this by default, which also saves one redirect. ``` $ curl -I http://www.asus.com/ HTTP/1.1 301 Moved Permanently Content-Length: 0 Location: https://www.asus.com/ Date: Wed, 04 Oct 2017 11:15:14 GMT Connection: keep-alive X-Akamai-Device-Characteristics: desktop X-Akamai-Device-Model: ; ; cURL; cURL ``` Use the command below to change the occurrences. ``` git grep -l 'http://www.asus.com' | xargs sed -i 's,http://www.asus.com,https://www.asus.com,g' ``` Change-Id: I62319bfbf39c73f98ed3f865a11f4fe870befee4 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M print.c 1 file changed, 113 insertions(+), 113 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/22354/3 -- To view, visit https://review.coreboot.org/22354 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: I62319bfbf39c73f98ed3f865a11f4fe870befee4 Gerrit-Change-Number: 22354 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: print: Update Asus URLs to use more secure HTTPS
by build bot (Jenkins) (Code Review) 06 Nov '17

06 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22354 ) Change subject: print: Update Asus URLs to use more secure HTTPS ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/837/ : SUCCESS -- To view, visit https://review.coreboot.org/22354 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I62319bfbf39c73f98ed3f865a11f4fe870befee4 Gerrit-Change-Number: 22354 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 06 Nov 2017 07:37:00 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: print: Update Asus URLs to use more secure HTTPS
by David Hendricks (Code Review) 06 Nov '17

06 Nov '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22354 to look at the new patch set (#2). Change subject: print: Update Asus URLs to use more secure HTTPS ...................................................................... print: Update Asus URLs to use more secure HTTPS Asus set up HTTPS for their site, and redirects to that by default. So, use this by default, which also saves one redirect. ``` $ curl -I http://www.asus.com/ HTTP/1.1 301 Moved Permanently Content-Length: 0 Location: https://www.asus.com/ Date: Wed, 04 Oct 2017 11:15:14 GMT Connection: keep-alive X-Akamai-Device-Characteristics: desktop X-Akamai-Device-Model: ; ; cURL; cURL ``` Use the command below to change the occurrences. ``` git grep -l 'http://www.asus.com' | xargs sed -i 's,http://www.asus.com,https://www.asus.com,g' ``` Change-Id: Ib7a0e608aa0b310dd94e1d3ce26e63eb612c1861 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M print.c 1 file changed, 113 insertions(+), 113 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/22354/2 -- To view, visit https://review.coreboot.org/22354 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: I62319bfbf39c73f98ed3f865a11f4fe870befee4 Gerrit-Change-Number: 22354 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: print: Update Asus URLs to use more secure HTTPS
by David Hendricks (Code Review) 06 Nov '17

06 Nov '17

David Hendricks has restored this change. ( https://review.coreboot.org/22354 ) Change subject: print: Update Asus URLs to use more secure HTTPS ...................................................................... Restored -- To view, visit https://review.coreboot.org/22354 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: restore Gerrit-Change-Id: I62319bfbf39c73f98ed3f865a11f4fe870befee4 Gerrit-Change-Number: 22354 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: print: Update Asus URLs to use more secure HTTPS
by David Hendricks (Code Review) 06 Nov '17

06 Nov '17

David Hendricks has abandoned this change. ( https://review.coreboot.org/22354 ) Change subject: print: Update Asus URLs to use more secure HTTPS ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/22354 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: abandon Gerrit-Change-Id: I62319bfbf39c73f98ed3f865a11f4fe870befee4 Gerrit-Change-Number: 22354 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit