- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Whitelist Lenovo Thinkpad X220
by Arthur Heymans (Code Review) 14 Jan '18

14 Jan '18

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23225 to look at the new patch set (#2). Change subject: Whitelist Lenovo Thinkpad X220 ...................................................................... Whitelist Lenovo Thinkpad X220 Change-Id: Idd667da8209a664469c1a909a549d2b625714a78 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M board_enable.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/23225/2 -- To view, visit https://review.coreboot.org/23225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idd667da8209a664469c1a909a549d2b625714a78 Gerrit-Change-Number: 23225 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: buspirate_spi: Add support for variable serial speeds
by build bot (Jenkins) (Code Review) 13 Jan '18

13 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23057 ) Change subject: buspirate_spi: Add support for variable serial speeds ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/872/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1023/ : SUCCESS -- To view, visit https://review.coreboot.org/23057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3706f17a94fdf056063f2ad4a5f0a219665cdcbf Gerrit-Change-Number: 23057 Gerrit-PatchSet: 4 Gerrit-Owner: Shawn Anastasio <shawnanastasio(a)yahoo.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shawn Anastasio <shawnanastasio(a)yahoo.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 13 Jan 2018 01:07:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: buspirate_spi: Add support for variable serial speeds
by Shawn Anastasio (Code Review) 13 Jan '18

13 Jan '18

Hello David Hendricks, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23057 to look at the new patch set (#4). Change subject: buspirate_spi: Add support for variable serial speeds ...................................................................... buspirate_spi: Add support for variable serial speeds This patch sets the default baud rate for communication between the host device and the Bus Pirate for hardware versions 3.0 and greater to 2M baud. It also introduces the ability to manually set the baud rate via the added 'serialspeed' programmer parameter. This is done in two parts. Firstly, the requested serial speed is looked up in a table to determine the appropriate clock divisor and the divisor is sent to the bus pirate. Then, the system's baud rate for the selected serial port is set using serial.c's 'serialport_config'. This function's prototype had to be added to programmer.h. In testing, using the 2M baud rate was able to significantly decrease flash times (down from 20+ minutes to less than 2 minutes for an 8MB flash). Change-Id: I3706f17a94fdf056063f2ad4a5f0a219665cdcbf Signed-off-by: Shawn Anastasio <shawnanastasio(a)yahoo.com> --- M buspirate_spi.c M flashrom.8.tmpl M programmer.h 3 files changed, 136 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/23057/4 -- To view, visit https://review.coreboot.org/23057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3706f17a94fdf056063f2ad4a5f0a219665cdcbf Gerrit-Change-Number: 23057 Gerrit-PatchSet: 4 Gerrit-Owner: Shawn Anastasio <shawnanastasio(a)yahoo.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shawn Anastasio <shawnanastasio(a)yahoo.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: buspirate_spi: Add support for variable serial speeds
by Shawn Anastasio (Code Review) 13 Jan '18

13 Jan '18

Shawn Anastasio has posted comments on this change. ( https://review.coreboot.org/23057 ) Change subject: buspirate_spi: Add support for variable serial speeds ...................................................................... Patch Set 3: Fair enough. I think a good compromise is to remove all speeds < 115200 and keep spispeed so that users can specify an intermediate value. I'll also change the check to allow BP < v3.0 owners manually set the speed (and display a warning). -- To view, visit https://review.coreboot.org/23057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3706f17a94fdf056063f2ad4a5f0a219665cdcbf Gerrit-Change-Number: 23057 Gerrit-PatchSet: 3 Gerrit-Owner: Shawn Anastasio <shawnanastasio(a)yahoo.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shawn Anastasio <shawnanastasio(a)yahoo.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 12 Jan 2018 23:21:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: [UNTESTED] Whitelist Lenovo X220 Thinkpad
by build bot (Jenkins) (Code Review) 11 Jan '18

11 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23225 ) Change subject: [UNTESTED] Whitelist Lenovo X220 Thinkpad ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/871/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1022/ : SUCCESS -- To view, visit https://review.coreboot.org/23225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd667da8209a664469c1a909a549d2b625714a78 Gerrit-Change-Number: 23225 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 11 Jan 2018 22:32:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [UNTESTED] Whitelist Lenovo X220 Thinkpad
by Arthur Heymans (Code Review) 11 Jan '18

11 Jan '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23225 Change subject: [UNTESTED] Whitelist Lenovo X220 Thinkpad ...................................................................... [UNTESTED] Whitelist Lenovo X220 Thinkpad Change-Id: Idd667da8209a664469c1a909a549d2b625714a78 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M board_enable.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/23225/1 diff --git a/board_enable.c b/board_enable.c index b6e17ef..625ed88 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2434,6 +2434,7 @@ {0x8086, 0x27a0, 0x17aa, 0x2017, 0x8086, 0x27b9, 0x17aa, 0x2009, "^ThinkPad T60", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad T60(s)", 0, OK, p2_whitelist_laptop}, {0x8086, 0x2917, 0x17AA, 0x20F5, 0x8086, 0x2930, 0x17AA, 0x20F9, "^ThinkPad X200", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X200", 0, OK, p2_whitelist_laptop}, {0x8086, 0x3B07, 0x17AA, 0x2166, 0x8086, 0x3B30, 0x17AA, 0x2167, "^Lenovo X201", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X201", 0, OK, p2_whitelist_laptop}, + {0x8086, 0x1C22, 0x17AA, 0x21DA, 0x8086, 0x1C45, 0x17AA, 0x21DA, "^ThinkPad X220", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X220", 0, OK, p2_whitelist_laptop}, {0x8086, 0x1E22, 0x17AA, 0x21FA, 0x8086, 0x1E55, 0x17AA, 0x21FA, "^ThinkPad X230", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X230", 0, OK, p2_whitelist_laptop}, {0x8086, 0x27A0, 0x17AA, 0x2017, 0x8086, 0x27B9, 0x17AA, 0x2009, "^ThinkPad X60", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X60(s)", 0, OK, p2_whitelist_laptop}, {0x8086, 0x2411, 0x8086, 0x2411, 0x8086, 0x7125, 0x0e11, 0xb165, NULL, NULL, NULL, P3, "Mitac", "6513WU", 0, OK, board_mitac_6513wu}, -- To view, visit https://review.coreboot.org/23225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idd667da8209a664469c1a909a549d2b625714a78 Gerrit-Change-Number: 23225 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in flashrom[master]: make args for -r/-w/-v non-positional and optional
by Nico Huber (Code Review) 10 Jan '18

10 Jan '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23022 ) Change subject: make args for -r/-w/-v non-positional and optional ...................................................................... Patch Set 6: Code-Review-2 I'm missing a check for spurious arguments. I have no idea how to implement it (straightforward) together with the non-positional file names. Currently, if you have a typo in your command line (e.g. forget a dash before an option), things may just be ignored... So why make it non-positional? -- To view, visit https://review.coreboot.org/23022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803 Gerrit-Change-Number: 23022 Gerrit-PatchSet: 6 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 10 Jan 2018 12:48:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: layout: Add -i <region>[:<file>] support.
by Nico Huber (Code Review) 10 Jan '18

10 Jan '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23021 ) Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... Patch Set 7: (10 comments) There are still some issues when it comes to the updated behaviour due to that http://crbug.com/263495 * Manpage needs update. * Separation of this and the next commit makes no sense because the introduced if/else relies on the file arguments to -w/-v being optional. * I think we need a check for the case that both files to -w/-v and to -i are given (it seems to me the latter would be silently ignored, didn't test though). https://review.coreboot.org/#/c/23021/7/flashrom.8.tmpl File flashrom.8.tmpl: https://review.coreboot.org/#/c/23021/7/flashrom.8.tmpl@227 PS7, Line 227: write spurious https://review.coreboot.org/#/c/23021/7/flashrom.8.tmpl@229 PS7, Line 229: For write operations, files specified using : .B "\-i" : take precedence over content from the argument to : .B "\-w." That's no more true. -i and -w filenames are mutually exclusive, right? https://review.coreboot.org/#/c/23021/7/flashrom.8.tmpl@252 PS7, Line 252: .B " flashrom \-p prog \-l <layout> \-i foo:foo.bin -i bar:bar.bin -w rom.bin Hmmm, just realized that this doesn't work. The -i files are just ignored when -w gets a file passed. I'd be fine if you document the final behaviour here. But maybe it's yet easier to squash the two commits... https://review.coreboot.org/#/c/23021/7/flashrom.c File flashrom.c: https://review.coreboot.org/#/c/23021/7/flashrom.c@1380 PS7, Line 1380: if (!entry->included || !entry->file) : continue; Optionally: if (!entry->included) continue; if (!entry->file) { msg_gerr("Error: No image file given for region \"%s\".\n", entry->name); return 1; } I know this is already covered in the next commit for the CLI, but I would feel much better if the code here looks consistent. https://review.coreboot.org/#/c/23021/7/flashrom.c@1383 PS7, Line 1383: buf + entry->start ? https://review.coreboot.org/#/c/23021/7/flashrom.c@1464 PS7, Line 1464: const char *filename) Should fit a single line. https://review.coreboot.org/#/c/23021/7/flashrom.c@2647 PS7, Line 2647: * processed and merged into newcontents since -i files take priority. This comment still makes no sense to me. I'd guess it was written before the if / else decision was introduced. https://review.coreboot.org/#/c/23021/7/layout.c File layout.c: https://review.coreboot.org/#/c/23021/7/layout.c@239 PS7, Line 239: 0 i + 1 ? https://review.coreboot.org/#/c/23021/7/layout.c@244 PS7, Line 244: continue; Not needed if we start with `j > i`. https://review.coreboot.org/#/c/23021/7/layout.c@272 PS7, Line 272: for (i = 0; i < layout.num_entries; i++) { : free(layout.entries[i].file); : layout.entries[i].file = NULL; : layout.entries[i].included = 0; : } : layout.num_entries = 0; This should actually be done in flashrom_layout_release() (before the `if (layout == get_global_layout())` check). It's a bit ugly atm, because nobody took the time yet, to untangle the CLI parts and the static layout struct here. Hmmm, now it doesn't look like much work: read_romlayout() would allocate a new layout, normalize_romentries() should work on the layout linked to the `flashctx`. Everything else doesn't seem to use the static struct. -- To view, visit https://review.coreboot.org/23021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 7 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 10 Jan 2018 12:29:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: [WIP]Add support to get layout from a binary fmap file
by build bot (Jenkins) (Code Review) 10 Jan '18

10 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23203 ) Change subject: [WIP]Add support to get layout from a binary fmap file ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/870/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1021/ : SUCCESS -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 10 Jan 2018 11:58:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [WIP]Add support to get layout from a binary fmap file
by Arthur Heymans (Code Review) 10 Jan '18

10 Jan '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23203 to look at the new patch set (#2). Change subject: [WIP]Add support to get layout from a binary fmap file ...................................................................... [WIP]Add support to get layout from a binary fmap file Already seems to mostly work, but needs to be cleaned up. Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile M cli_classic.c A fmap.c A fmap.h M layout.c 5 files changed, 166 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/23203/2 -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit