- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: spi: Move ICH BBAR quirk out of the way
by Nico Huber (Code Review) 14 Nov '17

14 Nov '17

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22396 to look at the new patch set (#3). Change subject: spi: Move ICH BBAR quirk out of the way ...................................................................... spi: Move ICH BBAR quirk out of the way Get rid of the layering violations around ICH's BBAR. Move all the weird address handling into (surprise, surprise) `ichspi.c`. Might fix writes for the `BBAR != 0` case by accident. Background: Some ICHs have a BBAR (BIOS Base Address Configuration Register) that, if set, limits the valid address range to [BBAR, 2^24). Current code lifted addresses for REMS, RES and READ operations by BBAR, now we do it for all addresses in ichspi. Special care has to be taken if the BBAR is not aligned by the flash chip's size. In this case, the lower part of the chip (from BBAR aligned down, up to BBAR) is inacces- sible (this seems to be the original intend behind BBAR) and has to be left out in the address offset calculation. Change-Id: Icbac513c5339e8aff624870252133284ef85ab73 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flash.h M ichspi.c M programmer.h M spi.c M spi25.c 5 files changed, 29 insertions(+), 85 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/22396/3 -- To view, visit https://review.coreboot.org/22396 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icbac513c5339e8aff624870252133284ef85ab73 Gerrit-Change-Number: 22396 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: spi25: Use common code for nbyte read/write and block erase
by Nico Huber (Code Review) 14 Nov '17

14 Nov '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22383 ) Change subject: spi25: Use common code for nbyte read/write and block erase ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/22383/1/spi25.c File spi25.c: https://review.coreboot.org/#/c/22383/1/spi25.c@384 PS1, Line 384: if > `iff` is short for `if and only if`... I can write it out ofc. Done -- To view, visit https://review.coreboot.org/22383 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc1ae48acbfbd427a30bcd64bdc080dc3dc20503 Gerrit-Change-Number: 22383 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 13 Nov 2017 19:16:50 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[master]: README: Update packaging section for Git repositories
by Nico Huber (Code Review) 14 Nov '17

14 Nov '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22454 ) Change subject: README: Update packaging section for Git repositories ...................................................................... Patch Set 1: I'd like to have this for the 1.0.x branch ofc. -- To view, visit https://review.coreboot.org/22454 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d9c56be8c1381b175ce7695c53f31b1767d9d17 Gerrit-Change-Number: 22454 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 13 Nov 2017 19:14:12 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: README: Update packaging section for Git repositories
by build bot (Jenkins) (Code Review) 14 Nov '17

14 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22454 ) Change subject: README: Update packaging section for Git repositories ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/759/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/869/ : SUCCESS -- To view, visit https://review.coreboot.org/22454 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d9c56be8c1381b175ce7695c53f31b1767d9d17 Gerrit-Change-Number: 22454 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 13 Nov 2017 19:12:55 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: spi25: Use common code for nbyte read/write and block erase
by build bot (Jenkins) (Code Review) 14 Nov '17

14 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22383 ) Change subject: spi25: Use common code for nbyte read/write and block erase ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/758/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/868/ : SUCCESS -- To view, visit https://review.coreboot.org/22383 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc1ae48acbfbd427a30bcd64bdc080dc3dc20503 Gerrit-Change-Number: 22383 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 13 Nov 2017 19:12:28 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: README: Update packaging section for Git repositories
by Nico Huber (Code Review) 14 Nov '17

14 Nov '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22454 Change subject: README: Update packaging section for Git repositories ...................................................................... README: Update packaging section for Git repositories Change-Id: I8d9c56be8c1381b175ce7695c53f31b1767d9d17 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M README 1 file changed, 10 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/22454/1 diff --git a/README b/README index ab761f7..449103d 100644 --- a/README +++ b/README @@ -24,20 +24,22 @@ Packaging --------- -To package flashrom and remove dependencies on subversion, either use +To package flashrom and remove dependencies on Git, either use make export or make tarball -make export will export all flashrom files from the subversion repository at -revision BASE into a directory named $EXPORTDIR/flashrom-$VERSION-r$SVNREVISION -and will additionally modify the Makefile in that directory to contain the svn -revision of the exported tree. +'make export' will export all flashrom files from the Git repository at +revision HEAD into a directory named "$EXPORTDIR/flashrom-$RELEASENAME" +and will additionally add a "versioninfo.inc" file in that directory to +contain the Git revision of the exported tree and a date for the manual +page. -make tarball will simply tar up the result of make export and gzip compress it. +'make tarball' will simply tar up the result of make export and compress +it with bzip2. -The snapshot tarballs are the result of make tarball and require no further -processing. +The snapshot tarballs are the result of 'make tarball' and require no +further processing. Build Instructions -- To view, visit https://review.coreboot.org/22454 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8d9c56be8c1381b175ce7695c53f31b1767d9d17 Gerrit-Change-Number: 22454 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: spi25: Use common code for nbyte read/write and block erase
by Nico Huber (Code Review) 14 Nov '17

14 Nov '17

Hello David Hendricks, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22383 to look at the new patch set (#2). Change subject: spi25: Use common code for nbyte read/write and block erase ...................................................................... spi25: Use common code for nbyte read/write and block erase Introduce spi_prepare_address() and spi_write_cmd() and use them in nbyte_program, nbyte_read and block-erase procedures. The former abstracts over the address part of a SPI command to make it exten- sible for 4-byte adressing. spi_write_cmd() implements a WREN + write operation with address and optionally up to 256 bytes of data. It provides a common path to reduce overall redundancy. Also, reduce the polling delay in spi_block_erase_c4() from 500s to 500ms as the comment suggests. Change-Id: Ibc1ae48acbfbd427a30bcd64bdc080dc3dc20503 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M chipdrivers.h M spi.h M spi25.c 3 files changed, 105 insertions(+), 429 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/22383/2 -- To view, visit https://review.coreboot.org/22383 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibc1ae48acbfbd427a30bcd64bdc080dc3dc20503 Gerrit-Change-Number: 22383 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: linux_spi: Dynamically detect max buffer size
by Nico Huber (Code Review) 14 Nov '17

14 Nov '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22441 ) Change subject: linux_spi: Dynamically detect max buffer size ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22441 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic541e548ced8488f074d388f1c92174cad123064 Gerrit-Change-Number: 22441 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 13 Nov 2017 18:55:34 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: linux_spi: Dynamically detect max buffer size
by Nico Huber (Code Review) 14 Nov '17

14 Nov '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22344 ) Change subject: linux_spi: Dynamically detect max buffer size ...................................................................... Patch Set 6: Verified-1 Code-Review+2 (3 comments) https://review.coreboot.org/#/c/22344/5/linux_spi.c File linux_spi.c: https://review.coreboot.org/#/c/22344/5/linux_spi.c@143 PS5, Line 143: if (feof(fp)) > In any case, I went ahead and added an feof() to check for this > condition. I was thinking of using stat(), but that would add a few > more lines and seemed redundant with fopen() error handling in this > case. LMK if you have a preference. feof() is fine. stat() seems overkill and I'm not sure how well it is implemented for sysfs ;) > > BTW - It may be worth moving all this logic to a file handling > library some day, especially as we improve support for Linux > interfaces that involve searching thru sysfs and proc and > potentially opening/closing a lot of files. Sounds good, especially if we hit the same pattern (e.g. reading an unsigned) from a file again. https://review.coreboot.org/#/c/22344/5/linux_spi.c@154 PS5, Line 154: msg_pwarn("Buffer size %ld from %s seems wrong.\n", tmp, BUF_SIZE_FROM_SYSFS); > Yeah, that's certainly an assumption that I suppose language lawyers may ta Same for the part of the string we didn't read, e.g. what if we don't hit EOF after 10 chars oO https://review.coreboot.org/#/c/22344/5/linux_spi.c@163 PS5, Line 163: > Should I follow-up with a patch to use sysconf(_SC_PAGESIZE) instead, as su Not a big issue, IMO. But if you do, I'm happy to review. -- To view, visit https://review.coreboot.org/22344 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ic541e548ced8488f074d388f1c92174cad123064 Gerrit-Change-Number: 22344 Gerrit-PatchSet: 6 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: david.hendricks(a)gmail.com Gerrit-Comment-Date: Mon, 13 Nov 2017 18:55:07 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[master]: spi25: Use common code for nbyte read/write and block erase
by Nico Huber (Code Review) 13 Nov '17

13 Nov '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22383 ) Change subject: spi25: Use common code for nbyte read/write and block erase ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/22383/1/spi25.c File spi25.c: https://review.coreboot.org/#/c/22383/1/spi25.c@384 PS1, Line 384: iff > if `iff` is short for `if and only if`... I can write it out ofc. -- To view, visit https://review.coreboot.org/22383 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc1ae48acbfbd427a30bcd64bdc080dc3dc20503 Gerrit-Change-Number: 22383 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 13 Nov 2017 09:00:26 +0000 Gerrit-HasComments: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit