- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs
by Nico Huber (Code Review) 11 May '18

11 May '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26232 Change subject: chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs ...................................................................... chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs The Kaby Lake "200 Series" PCHs [1,2] share the register layout of their Skylake "100 Series" siblings. [1] Intel® 200 Series (including X299) Chipset Family Platform Controller Hub (PCH) Datasheet - Volume 1 of 2 Revision 002 Document Number 335192 [2] Intel® 200 Series (including X299) Chipset Family Platform Controller Hub (PCH) Datasheet - Volume 2 of 2 Revision 003 Document Number 335193 Change-Id: Ida545d69ec998a5d3ae4dc88e76adbb13952bceb Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M chipset_enable.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/26232/1 diff --git a/chipset_enable.c b/chipset_enable.c index 15b760b..72d5de0 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1945,6 +1945,12 @@ {0x8086, 0xa245, NT, "Intel", "C627 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa246, NT, "Intel", "C628 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa247, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, + {0x8086, 0xa2c4, NT, "Intel", "H270", enable_flash_pch100}, + {0x8086, 0xa2c5, NT, "Intel", "Z270", enable_flash_pch100}, + {0x8086, 0xa2c6, NT, "Intel", "Q270", enable_flash_pch100}, + {0x8086, 0xa2c7, NT, "Intel", "Q250", enable_flash_pch100}, + {0x8086, 0xa2c8, NT, "Intel", "B250", enable_flash_pch100}, + {0x8086, 0xa2d2, NT, "Intel", "X299", enable_flash_pch100}, #endif {0}, }; -- To view, visit https://review.coreboot.org/26232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ida545d69ec998a5d3ae4dc88e76adbb13952bceb Gerrit-Change-Number: 26232 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ...
by Miklós Márton (Code Review) 07 May '18

07 May '18

Miklós Márton has posted comments on this change. ( https://review.coreboot.org/23865 ) Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too. ...................................................................... Patch Set 1: (1 comment) > > > Patch Set 1: > > > > > > (7 comments) > > Thank you very much for the review Nico! > > > > Actually tgotic proposed a much simpler (and I think better) > > approach for checking the MingW environment: > > https://github.com/flashrom/flashrom/pull/33 > > > > Is it possible to upload a new patchset if I am not an owner at > the > > gerrit? > > Hi Márton, > Did you plan to upload a revision to address Nico's comments? It > would be great to get this merged soon and reduce the patch queue. I have not been able to find where can I update my patchset. Could you please upload this as a new version of the patchset: https://patch-diff.githubusercontent.com/raw/flashrom/flashrom/pull/33.diff I have simplified the check to make it not depending on bash neither using regexps so it should address Nico comments. https://review.coreboot.org/#/c/23865/1/Makefile File Makefile: https://review.coreboot.org/#/c/23865/1/Makefile@104 PS1, Line 104: ifeq ($(shell if [[ $$(uname) =~ ^MINGW[0-9]{0,2}_NT-[0-9]{1,2}.[0-9]{1,2}$$ ]]; then echo yes; else echo no; fi), yes) > I'm not familiar with the syntax. […] Well kind of. It is a regular expression, inspiration came from here: https://stackoverflow.com/questions/31111360/how-to-use-regular-expression-… If you have any recommendation how to make a better conditional check based on a regexp please let me know. -- To view, visit https://review.coreboot.org/23865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Gerrit-Change-Number: 23865 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Mon, 07 May 2018 18:51:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: improve termios settings on some OSes
by build bot (Jenkins) (Code Review) 07 May '18

07 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23693 ) Change subject: improve termios settings on some OSes ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1287/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1068/ : SUCCESS -- To view, visit https://review.coreboot.org/23693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5da80f541e02c3b8e676e47a45388bfb115b4762 Gerrit-Change-Number: 23693 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jonathan A. Kollasch <jakllsch(a)kollasch.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 May 2018 17:56:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ...
by David Hendricks (Code Review) 06 May '18

06 May '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23865 ) Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too. ...................................................................... Patch Set 1: > > Patch Set 1: > > > > (7 comments) > Thank you very much for the review Nico! > > Actually tgotic proposed a much simpler (and I think better) > approach for checking the MingW environment: > https://github.com/flashrom/flashrom/pull/33 > > Is it possible to upload a new patchset if I am not an owner at the > gerrit? Hi Márton, Did you plan to upload a revision to address Nico's comments? It would be great to get this merged soon and reduce the patch queue. -- To view, visit https://review.coreboot.org/23865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Gerrit-Change-Number: 23865 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Mon, 07 May 2018 02:26:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: buspirate_spi: Tristate IOs when using using pullup=on
by David Hendricks (Code Review) 06 May '18

06 May '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23864 ) Change subject: buspirate_spi: Tristate IOs when using using pullup=on ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/23864/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23864/2//COMMIT_MSG@12 PS2, Line 12: Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> It's a tiny patch submitted via Github so I think it's safe to just add this. -- To view, visit https://review.coreboot.org/23864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f Gerrit-Change-Number: 23864 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 May 2018 02:01:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: buspirate_spi: Tristate IOs when using using pullup=on
by build bot (Jenkins) (Code Review) 06 May '18

06 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23864 ) Change subject: buspirate_spi: Tristate IOs when using using pullup=on ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1286/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1067/ : SUCCESS -- To view, visit https://review.coreboot.org/23864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f Gerrit-Change-Number: 23864 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 May 2018 02:00:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: buspirate_spi: Tristate IOs when using using pullup=on
by David Hendricks (Code Review) 06 May '18

06 May '18

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23864 to look at the new patch set (#2). Change subject: buspirate_spi: Tristate IOs when using using pullup=on ...................................................................... buspirate_spi: Tristate IOs when using using pullup=on Avoid putting 3.3V on IO pins when pullup=on to avoid damage to 1.8V chips. Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f --- M buspirate_spi.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/64/23864/2 -- To view, visit https://review.coreboot.org/23864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f Gerrit-Change-Number: 23864 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: Add Winbond 25Q40EW and rename 25Q40.W
by build bot (Jenkins) (Code Review) 06 May '18

06 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25462 ) Change subject: flashchips: Add Winbond 25Q40EW and rename 25Q40.W ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1285/ : SUCCESS -- To view, visit https://review.coreboot.org/25462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib610b0d6f3a5561b2ac3505ef15bdee8b0edae25 Gerrit-Change-Number: 25462 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 06 May 2018 21:00:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Add Microchip SST26VF016B
by David Hendricks (Code Review) 06 May '18

06 May '18

David Hendricks has abandoned this change. ( https://review.coreboot.org/25465 ) Change subject: flashchips: Add Microchip SST26VF016B ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/25465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ia7659e3db3168254b7f34959eece0f8df3142ab9 Gerrit-Change-Number: 25465 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: Add Winbond 25Q40EW and rename 25Q40.W
by David Hendricks (Code Review) 06 May '18

06 May '18

David Hendricks has submitted this change and it was merged. ( https://review.coreboot.org/25462 ) Change subject: flashchips: Add Winbond 25Q40EW and rename 25Q40.W ...................................................................... flashchips: Add Winbond 25Q40EW and rename 25Q40.W Same story as for 25Q80BW/EW, 25Q40EW has a new ID and the only known chip with the old ID is the BW variant. Change-Id: Ib610b0d6f3a5561b2ac3505ef15bdee8b0edae25 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/25462 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 44 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 3c04533..8eda608 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15137,10 +15137,10 @@ { .vendor = "Winbond", - .name = "W25Q40.W", + .name = "W25Q40BW", .bustype = BUS_SPI, .manufacture_id = WINBOND_NEX_ID, - .model_id = WINBOND_NEX_W25Q40_W, + .model_id = WINBOND_NEX_W25Q40BW, .total_size = 512, .page_size = 256, /* OTP: 256B total; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ @@ -15212,6 +15212,46 @@ .read = spi_chip_read, .voltage = {1700, 1950}, /* Fast read (0x0B) and multi I/O supported */ }, + + { + .vendor = "Winbond", + .name = "W25Q40EW", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25Q40EW, + .total_size = 512, + .page_size = 256, + /* OTP: 3*256B total; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 128} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 16} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 8} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {1650, 1950}, /* Fast read (0x0B) and multi I/O supported */ + }, + { .vendor = "Winbond", .name = "W25Q80EW", diff --git a/flashchips.h b/flashchips.h index 348f2fd..f00be3b 100644 --- a/flashchips.h +++ b/flashchips.h @@ -908,8 +908,9 @@ #define WINBOND_NEX_W25Q128_V 0x4018 /* W25Q128BV; W25Q128FV in SPI mode (default) */ #define WINBOND_NEX_W25Q256_V 0x4019 /* W25Q256FV */ #define WINBOND_NEX_W25Q20_W 0x5012 /* W25Q20BW */ -#define WINBOND_NEX_W25Q40_W 0x5013 /* W25Q40BW */ +#define WINBOND_NEX_W25Q40BW 0x5013 /* W25Q40BW */ #define WINBOND_NEX_W25Q80BW 0x5014 /* W25Q80BW */ +#define WINBOND_NEX_W25Q40EW 0x6013 /* W25Q40EW */ #define WINBOND_NEX_W25Q80EW 0x6014 /* W25Q80EW */ #define WINBOND_NEX_W25Q16_W 0x6015 /* W25Q16DW */ #define WINBOND_NEX_W25Q32_W 0x6016 /* W25Q32DW; W25Q32FV in QPI mode */ -- To view, visit https://review.coreboot.org/25462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib610b0d6f3a5561b2ac3505ef15bdee8b0edae25 Gerrit-Change-Number: 25462 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit