- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: linux_mtd: Initial import
by Nico Huber (Code Review) 13 May '18

13 May '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25706 ) Change subject: linux_mtd: Initial import ...................................................................... Patch Set 4: Manpage should be updated, too. -- To view, visit https://review.coreboot.org/25706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d6bb282863a5cf69909e28a1fc752b35f1b9599 Gerrit-Change-Number: 25706 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 May 2018 12:35:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[staging]: Enable writes with active ME
by Philipp Deppenwiese (Code Review) 13 May '18

13 May '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/18740 ) Change subject: Enable writes with active ME ...................................................................... Patch Set 15: yo guys. Rebase and gonna get it merged. -- To view, visit https://review.coreboot.org/18740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I94a5e7074b845c227e43d76d04dd1a71082a1cef Gerrit-Change-Number: 18740 Gerrit-PatchSet: 15 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Comment-Date: Sun, 13 May 2018 10:18:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: linux_mtd: Initial import
by Nico Huber (Code Review) 11 May '18

11 May '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25706 ) Change subject: linux_mtd: Initial import ...................................................................... Patch Set 4: (17 comments) Looks good over all. The only real issues that have to be fixed is a leaked `FILE *` and internal URLs, IIRC. Mostly everything else is in the "we can do better" category ;) https://review.coreboot.org/#/c/25706/4/Makefile File Makefile: https://review.coreboot.org/#/c/25706/4/Makefile@346 PS4, Line 346: # Android is handled internally as separate OS, but it supports CONFIG_LINUX_SPI and CONFIG_MSTARDDC_SPI sigh, outdated comment (I hate comments) https://review.coreboot.org/#/c/25706/4/internal.c File internal.c: https://review.coreboot.org/#/c/25706/4/internal.c@241 PS4, Line 241: #if CONFIG_LINUX_MTD == 1 A little nicer would be an inline stub in the header file in case of !CONFIG_LINUX_MTD. Then we wouldn't clutter the C file with #if. https://review.coreboot.org/#/c/25706/4/linux_mtd.c File linux_mtd.c: https://review.coreboot.org/#/c/25706/4/linux_mtd.c@59 PS4, Line 59: read Using low-level read() might be ok here together with sysfs. But I'm not inclined to check and would prefer stream functions (fread()) instead. https://review.coreboot.org/#/c/25706/4/linux_mtd.c@94 PS4, Line 94: endptr != &buf[strlen(buf)] Nit, same as `*endptr`? https://review.coreboot.org/#/c/25706/4/linux_mtd.c@131 PS4, Line 131: __builtin_popcount How portable is this? https://review.coreboot.org/#/c/25706/4/linux_mtd.c@152 PS4, Line 152: msg_pspew("%s: device_name: \"%s\", is_writeable: %d, " This only runs once on init, right? msg_pdbg() would be more appropriate, IMHO. https://review.coreboot.org/#/c/25706/4/linux_mtd.c@167 PS4, Line 167: flash->chip->block_erasers[0].eraseblocks[0].count = Nit, line break seems unnecessary. https://review.coreboot.org/#/c/25706/4/linux_mtd.c@187 PS4, Line 187: See, for example, : * https://b/35573113 I doubt, my browser would find much there. https://review.coreboot.org/#/c/25706/4/linux_mtd.c@193 PS4, Line 193: if (read(dev_fd, buf + i, step) != step) { Again, fread() is generally preferred. read() doesn't retry if it's interrupted and may return a short byte count even if more data is available. As we loop here anyway, this could also be solved by not bailing out on a short byte count. More specifically if ((step = read(...)) <= 0 && errno != EINTR) { ... return 1; } IIRC (I usually just use fread() if available). https://review.coreboot.org/#/c/25706/4/linux_mtd.c@224 PS4, Line 224: See, for example, : * https://b/35573113 ... https://review.coreboot.org/#/c/25706/4/linux_mtd.c@231 PS4, Line 231: write Same as for read(). https://review.coreboot.org/#/c/25706/4/linux_mtd.c@256 PS4, Line 256: use MEMGETREGIONCOUNT/MEMGETREGIONINFO ioctls */ Bail out like above? https://review.coreboot.org/#/c/25706/4/linux_mtd.c@294 PS4, Line 294: FILE *fp; Never closed? I would move it on top, initialize to `NULL` and below linux_mtd_setup_exit: `if (fp != NULL) fclose(fp);`. Hmm, actually that might be overkill, we'd only need 2x fclose() after the fread(). Or just use read_sysfs_string()? https://review.coreboot.org/#/c/25706/4/linux_mtd.c@320 PS4, Line 320: return 1; `goto linux_mtd_setup_exit;` https://review.coreboot.org/#/c/25706/4/linux_mtd.c@326 PS4, Line 326: (const char *) Nit, why cast? https://review.coreboot.org/#/c/25706/4/linux_mtd.c@361 PS4, Line 361: (param == endptr) `*endptr` would also cover trailing data. https://review.coreboot.org/#/c/25706/4/linux_mtd.c@364 PS4, Line 364: "device number\n", param); Nits, missing full-stop, output should be broken before 80 chars. -- To view, visit https://review.coreboot.org/25706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d6bb282863a5cf69909e28a1fc752b35f1b9599 Gerrit-Change-Number: 25706 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 May 2018 19:03:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: ch341a_spi: Avoid deprecated libusb functions
by build bot (Jenkins) (Code Review) 11 May '18

11 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25681 ) Change subject: ch341a_spi: Avoid deprecated libusb functions ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/1070/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1289/ : SUCCESS -- To view, visit https://review.coreboot.org/25681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib71ebe812316eaf49136979a942a946ef9e4d487 Gerrit-Change-Number: 25681 Gerrit-PatchSet: 3 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 May 2018 16:58:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: ch341a_spi: Avoid deprecated libusb functions
by build bot (Jenkins) (Code Review) 11 May '18

11 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25681 ) Change subject: ch341a_spi: Avoid deprecated libusb functions ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1291/ : SUCCESS -- To view, visit https://review.coreboot.org/25681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib71ebe812316eaf49136979a942a946ef9e4d487 Gerrit-Change-Number: 25681 Gerrit-PatchSet: 4 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 May 2018 16:32:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: ch341a_spi: Avoid deprecated libusb functions
by Nico Huber (Code Review) 11 May '18

11 May '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/25681 ) Change subject: ch341a_spi: Avoid deprecated libusb functions ...................................................................... ch341a_spi: Avoid deprecated libusb functions libusb 1.0.22 marked libusb_set_debug as deprecated. For such versions of libusb, use libusb_set_option instead. Change-Id: Ib71ebe812316eaf49136979a942a946ef9e4d487 Signed-off-by: Alex James <theracermaster(a)gmail.com> Reviewed-on: https://review.coreboot.org/25681 Tested-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> --- M ch341a_spi.c 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Nico Huber: Verified David Hendricks: Looks good to me, approved diff --git a/ch341a_spi.c b/ch341a_spi.c index 95e9c95..ee18624 100644 --- a/ch341a_spi.c +++ b/ch341a_spi.c @@ -441,7 +441,12 @@ return -1; } - libusb_set_debug(NULL, 3); // Enable information, warning and error messages (only). + /* Enable information, warning, and error messages (only). */ +#if LIBUSB_API_VERSION < 0x01000106 + libusb_set_debug(NULL, 3); +#else + libusb_set_option(NULL, LIBUSB_OPTION_LOG_LEVEL, LIBUSB_LOG_LEVEL_INFO); +#endif uint16_t vid = devs_ch341a_spi[0].vendor_id; uint16_t pid = devs_ch341a_spi[0].device_id; -- To view, visit https://review.coreboot.org/25681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib71ebe812316eaf49136979a942a946ef9e4d487 Gerrit-Change-Number: 25681 Gerrit-PatchSet: 4 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: ch341a_spi: Avoid deprecated libusb functions
by Nico Huber (Code Review) 11 May '18

11 May '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25681 ) Change subject: ch341a_spi: Avoid deprecated libusb functions ...................................................................... Patch Set 3: Verified+1 Hello, Jenkins? -- To view, visit https://review.coreboot.org/25681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib71ebe812316eaf49136979a942a946ef9e4d487 Gerrit-Change-Number: 25681 Gerrit-PatchSet: 3 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 May 2018 16:32:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: buspirate_spi: Tristate IOs when using using pullup=on
by build bot (Jenkins) (Code Review) 11 May '18

11 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23864 ) Change subject: buspirate_spi: Tristate IOs when using using pullup=on ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1290/ : SUCCESS -- To view, visit https://review.coreboot.org/23864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f Gerrit-Change-Number: 23864 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 May 2018 16:15:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: buspirate_spi: Tristate IOs when using using pullup=on
by Nico Huber (Code Review) 11 May '18

11 May '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/23864 ) Change subject: buspirate_spi: Tristate IOs when using using pullup=on ...................................................................... buspirate_spi: Tristate IOs when using using pullup=on Avoid putting 3.3V on IO pins when pullup=on to avoid damage to 1.8V chips. Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f Reviewed-on: https://review.coreboot.org/23864 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M buspirate_spi.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved diff --git a/buspirate_spi.c b/buspirate_spi.c index db8b310..fad309f 100644 --- a/buspirate_spi.c +++ b/buspirate_spi.c @@ -543,6 +543,10 @@ /* Set SPI config: output type, idle, clock edge, sample */ bp_commbuf[0] = 0x80 | 0xa; + if (pullup == 1) { + bp_commbuf[0] &= ~(1 << 3); + msg_pdbg("Pull-ups enabled, so using HiZ pin output! (Open-Drain mode)\n"); + } ret = buspirate_sendrecv(bp_commbuf, 1, 1); if (ret) return 1; -- To view, visit https://review.coreboot.org/23864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f Gerrit-Change-Number: 23864 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs
by build bot (Jenkins) (Code Review) 11 May '18

11 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26232 ) Change subject: chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/1069/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1288/ : SUCCESS -- To view, visit https://review.coreboot.org/26232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida545d69ec998a5d3ae4dc88e76adbb13952bceb Gerrit-Change-Number: 26232 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 May 2018 14:44:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit