- flashrom-gerrit - mail.coreboot.org

Change in flashrom[1.0.x]: internal: Fix #if guards for big-endian mips
by Nico Huber (Code Review) 28 Dec '17

28 Dec '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23003 to look at the new patch set (#2). Change subject: internal: Fix #if guards for big-endian mips ...................................................................... internal: Fix #if guards for big-endian mips Newer GCC still warns on big-endian mips, cf. 60210de (internal: Fix warnings about unused constants). Change-Id: Id0508c5241a7bd61b8d92d631cdf42ef7829a8a9 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M internal.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/23003/2 -- To view, visit https://review.coreboot.org/23003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id0508c5241a7bd61b8d92d631cdf42ef7829a8a9 Gerrit-Change-Number: 23003 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[1.0.x]: internal: Fix #if guards for big-endian mips
by build bot (Jenkins) (Code Review) 28 Dec '17

28 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23003 ) Change subject: internal: Fix #if guards for big-endian mips ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/951/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/821/ : SUCCESS -- To view, visit https://review.coreboot.org/23003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: comment Gerrit-Change-Id: Id0508c5241a7bd61b8d92d631cdf42ef7829a8a9 Gerrit-Change-Number: 23003 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Dec 2017 20:17:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[1.0.x]: internal: Fix #if guards for big-endian mips
by Nico Huber (Code Review) 28 Dec '17

28 Dec '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/23003 Change subject: internal: Fix #if guards for big-endian mips ...................................................................... internal: Fix #if guards for big-endian mips Newer GCC still warns on big-endian mips, cf. 60210de (internal: Fix warnings about unused constants). Change-Id: Id0508c5241a7bd61b8d92d631cdf42ef7829a8a9 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M internal.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/23003/1 diff --git a/internal.c b/internal.c index 276e14b..88f17a4 100644 --- a/internal.c +++ b/internal.c @@ -131,7 +131,7 @@ int is_laptop = 0; int laptop_ok = 0; -#if IS_X86 || IS_MIPS +#if (IS_X86 || IS_MIPS) && __FLASHROM_LITTLE_ENDIAN__ static void internal_chip_writeb(const struct flashctx *flash, uint8_t val, chipaddr addr); static void internal_chip_writew(const struct flashctx *flash, uint16_t val, @@ -360,7 +360,7 @@ } #endif -#if IS_X86 || IS_MIPS +#if (IS_X86 || IS_MIPS) && __FLASHROM_LITTLE_ENDIAN__ static void internal_chip_writeb(const struct flashctx *flash, uint8_t val, chipaddr addr) { -- To view, visit https://review.coreboot.org/23003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: newchange Gerrit-Change-Id: Id0508c5241a7bd61b8d92d631cdf42ef7829a8a9 Gerrit-Change-Number: 23003 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: git-hooks: Fix install script for various git versions
by build bot (Jenkins) (Code Review) 26 Dec '17

26 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22971 ) Change subject: git-hooks: Fix install script for various git versions ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/950/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/820/ : SUCCESS -- To view, visit https://review.coreboot.org/22971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ee8d4d54db48f7207fe8abf895c7fbba7685ad2 Gerrit-Change-Number: 22971 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 25 Dec 2017 20:47:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: git-hooks: Fix install script for various git versions
by Nico Huber (Code Review) 26 Dec '17

26 Dec '17

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22971 to look at the new patch set (#2). Change subject: git-hooks: Fix install script for various git versions ...................................................................... git-hooks: Fix install script for various git versions There are older versions of git-rev-parse that don't understand the `--git-path` switch. Also, when the install script was written, git- rev-parse had a bug when it wasn't run from the root directory. They fixed the behaviour by now. To simplify things and not have to account for that too, we just bail out when the script is run from a sub- directory. Change-Id: I7ee8d4d54db48f7207fe8abf895c7fbba7685ad2 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/git-hooks/install.sh 1 file changed, 15 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/71/22971/2 -- To view, visit https://review.coreboot.org/22971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ee8d4d54db48f7207fe8abf895c7fbba7685ad2 Gerrit-Change-Number: 22971 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: spi_master: Introduce SPI_MASTER_4BA feature flag
by Nico Huber (Code Review) 25 Dec '17

25 Dec '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22421 ) Change subject: spi_master: Introduce SPI_MASTER_4BA feature flag ...................................................................... Patch Set 6: > I think I get what you were saying earlier... I don't know if it's > worth blocking this patch, though. If you have time to implement > the better approach by all means do so and I'll be happy to review > it. I can take a swing at it too, but I probably won't get around > to it for another month. Well, it's not that this path introduces any problem that doesn't already exist. It's just more visible what can go wrong, IMO. Let's just merge it (maybe after you gave it a final test round). -- To view, visit https://review.coreboot.org/22421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c Gerrit-Change-Number: 22421 Gerrit-PatchSet: 6 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 25 Dec 2017 12:09:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: spi_master: Introduce SPI_MASTER_4BA feature flag
by David Hendricks (Code Review) 25 Dec '17

25 Dec '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22421 ) Change subject: spi_master: Introduce SPI_MASTER_4BA feature flag ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/22421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c Gerrit-Change-Number: 22421 Gerrit-PatchSet: 6 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 25 Dec 2017 10:09:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: spi_master: Introduce SPI_MASTER_4BA feature flag
by David Hendricks (Code Review) 25 Dec '17

25 Dec '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22421 ) Change subject: spi_master: Introduce SPI_MASTER_4BA feature flag ...................................................................... Patch Set 6: (1 comment) I think I get what you were saying earlier... I don't know if it's worth blocking this patch, though. If you have time to implement the better approach by all means do so and I'll be happy to review it. I can take a swing at it too, but I probably won't get around to it for another month. https://review.coreboot.org/#/c/22421/5/spi25.c File spi25.c: https://review.coreboot.org/#/c/22421/5/spi25.c@380 PS5, Line 380: return -1; > I'm talking about the block erase commands. If the core read/erase/write […] I'm not sure what the best solution will look like exactly... It seems sensible to build/maintain separate lists of commands that the chip and programmer support. The chips already do that, so it might not be much more effort to have the programmers do so. Most programmers won't be affected, but it makes sense to do it and also helps keep error handling tidy. -- To view, visit https://review.coreboot.org/22421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c Gerrit-Change-Number: 22421 Gerrit-PatchSet: 6 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 25 Dec 2017 10:08:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Revise all 4BA chips
by Stefan Reinauer (Code Review) 24 Dec '17

24 Dec '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/22423 ) Change subject: flashchips: Revise all 4BA chips ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/22423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0598496ee7058e3b170684d366f58e4014e0e871 Gerrit-Change-Number: 22423 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Dec 2017 05:26:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: spi25: Revise decision when to enter/exit 4BA mode
by Stefan Reinauer (Code Review) 24 Dec '17

24 Dec '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/22422 ) Change subject: spi25: Revise decision when to enter/exit 4BA mode ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/22422 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I877fe817f801fc54bd0ee2ce4e3ead324cbb3673 Gerrit-Change-Number: 22422 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Dec 2017 05:25:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit