- flashrom-gerrit - mail.coreboot.org

[L] Change in flashrom[main]: udelay: only use OS time for delays, except on DOS
by Anastasia Klimchuk (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Brian Norris, Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81545?usp=email ) Change subject: udelay: only use OS time for delays, except on DOS ...................................................................... Patch Set 7: (5 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/81545/comment/ccd19393_e76a5d95 : PS7, Line 10: ) you can also add the link to archive (keep the title) https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/HFH6… File include/programmer.h: https://review.coreboot.org/c/flashrom/+/81545/comment/9d01fccc_bfddca33 : PS7, Line 222: void myusec_delay(unsigned int usecs); I am wondering, why `myusec_delay` was here in the first place? It wasn't used anywhere outside udelay.c. File tests/udelay.c: https://review.coreboot.org/c/flashrom/+/81545/comment/ebf04ffe_2553bf5c : PS7, Line 47: default_delay(100); I thought for a moment we can afford a long delay test, for usec = 100001, but I don't know would it be useful test? Maybe it belongs better to a next patch where you can verify nanosleep was called / not called depending on the length of the sleep? File udelay.c: https://review.coreboot.org/c/flashrom/+/81545/comment/77dc43b4_fc7866da : PS7, Line 33: #ifdef _POSIX_MONOTONIC_CLOCK : static clockid_t clock_id = CLOCK_MONOTONIC; : #else : static clockid_t clock_id = CLOCK_REALTIME; : #endif This is only used inside `clock_usec_delay` now, can it be locally defined inside the function? It will be easier to read too. https://review.coreboot.org/c/flashrom/+/81545/comment/6f8bb5ec_181589c6 : PS7, Line 62: inline For my education, why the function is inline only for this case and not the above? -- To view, visit https://review.coreboot.org/c/flashrom/+/81545?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7ac5450d194a475143698d65d64d8bcd2fd25e3f Gerrit-Change-Number: 81545 Gerrit-PatchSet: 7 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 08 Apr 2024 12:34:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: flashchips: Add write-protect support for MX25L12833F
by Hsuan-ting Chen (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Hsuan Ting Chen. Hello Hsuan Ting Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/81792?usp=email to review the following change. Change subject: flashchips: Add write-protect support for MX25L12833F ...................................................................... flashchips: Add write-protect support for MX25L12833F datasheet: https://www.macronix.com/Lists/Datasheet/Attachments/8934/MX25L12833F,%203V… BUG=b:332486637 TEST=TBU Change-Id: I379c833eea3ed3487504126f45c6df672a772ddc Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> --- M flashchips.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/81792/1 diff --git a/flashchips.c b/flashchips.c index 7a40f07..c0518cb 100644 --- a/flashchips.c +++ b/flashchips.c @@ -9041,6 +9041,14 @@ .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, /* Fast read (0x0B) supported */ .voltage = {2700, 3600}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}, {STATUS1, 5, RW}}, + .tb = {CONFIG, 3, OTP}, + .wps = {SECURITY, 7, OTP}, /* This bit is set by WPSEL command */ + }, + .decode_range = DECODE_RANGE_SPI25, }, { -- To view, visit https://review.coreboot.org/c/flashrom/+/81792?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I379c833eea3ed3487504126f45c6df672a772ddc Gerrit-Change-Number: 81792 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[main]: meson: Update CI script to enforce building man pages and docs
by Martin L Roth (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Thomas Heijligen. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81665?usp=email ) Change subject: meson: Update CI script to enforce building man pages and docs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/81665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Gerrit-Change-Number: 81665 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Sat, 06 Apr 2024 14:14:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: meson: Update CI script to enforce building man pages and docs
by Anastasia Klimchuk (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Anton Samsonov, Martin L Roth, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81665?usp=email ) Change subject: meson: Update CI script to enforce building man pages and docs ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > One thing left to test: have a run on clean environment. And I have discovered that my changes to doc/meson.build are not needed because the first line in the file handles it! so now the patch is smaller :) -- To view, visit https://review.coreboot.org/c/flashrom/+/81665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Gerrit-Change-Number: 81665 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Sat, 06 Apr 2024 13:36:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: meson: Update CI script to enforce building man pages and docs
by Anastasia Klimchuk (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Anton Samsonov, Martin L Roth, Thomas Heijligen. Hello Anton Samsonov, Martin L Roth, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/81665?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: meson: Update CI script to enforce building man pages and docs ...................................................................... meson: Update CI script to enforce building man pages and docs `test_build.sh` is used by Jenkins, therefore it should build everything. Docker container for Jenkins is expected to have all the dependencies installed, and if some of them are missing, script should fail. Recently we had a situation when docker image was missing sphinx and flashrom Jenkins was silently skipping building man-pages and documentation. This patch prevents this happening again, because building man pages and docs will be enforced. Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M test_build.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/65/81665/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/81665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Gerrit-Change-Number: 81665 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[main]: meson: Update CI script to enforce building man pages and docs
by Anastasia Klimchuk (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Anton Samsonov, Martin L Roth, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81665?usp=email ) Change subject: meson: Update CI script to enforce building man pages and docs ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: One thing left to test: have a run on clean environment. -- To view, visit https://review.coreboot.org/c/flashrom/+/81665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Gerrit-Change-Number: 81665 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Thu, 04 Apr 2024 07:44:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: meson: Update CI script to enforce building man pages and docs
by Anastasia Klimchuk (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen. Hello Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/81665?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: meson: Update CI script to enforce building man pages and docs ...................................................................... meson: Update CI script to enforce building man pages and docs `test_build.sh` is used by Jenkins, therefore it should build everything. Docker container for Jenkins is expected to have all the dependencies installed, and if some of them are missing, script should fail. Recently we had a situation when docker image was missing sphinx and flashrom Jenkins was silently skipping building man-pages and documentation. This patch prevents this happening again, because building man pages and docs will be enforced. Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/meson.build M test_build.sh 2 files changed, 9 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/65/81665/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/81665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Gerrit-Change-Number: 81665 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[main]: meson: Update CI script to enforce building man pages and docs
by Anastasia Klimchuk (Code Review) 04 Apr '24

04 Apr '24

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/81665?usp=email ) Change subject: meson: Update CI script to enforce building man pages and docs ...................................................................... meson: Update CI script to enforce building man pages and docs `test_build.sh` is used by Jenkins, therefore it should build everything. Docker container for Jenkins is expected to have all the dependencies installed, and if some of them are missing, script should fail. Recently we had a situation when docker image was missing sphinx and flashrom Jenkins was silently skipping building man-pages and documentation. This patch prevents this happening again, because building man pages and docs will be enforced. Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/meson.build M test_build.sh 2 files changed, 9 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/65/81665/1 diff --git a/doc/meson.build b/doc/meson.build index 5bc57b9..a2dad0e 100644 --- a/doc/meson.build +++ b/doc/meson.build @@ -34,4 +34,12 @@ ) endif +else # sphinx-build not found + if get_option('man-pages').enabled() + error('Cannot build man-pages because sphinx-build is missing.') + endif + + if get_option('documentation').enabled() + error('Cannot build documentation because sphinx-build is missing.') + endif endif diff --git a/test_build.sh b/test_build.sh index 9b490dc..081738b 100755 --- a/test_build.sh +++ b/test_build.sh @@ -51,7 +51,7 @@ build_meson () { build_dir=out - meson_opts="-Dtests=enabled" + meson_opts="-Dtests=enabled -Dman-pages-enabled -Ddocumentation=enabled" ninja_opts="-j $(nproc)" rm -rf ${build_dir} -- To view, visit https://review.coreboot.org/c/flashrom/+/81665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Gerrit-Change-Number: 81665 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[main]: flashchips: Add support for Boya BY25D40
by Anastasia Klimchuk (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Dmitry Mikushin, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81605?usp=email ) Change subject: flashchips: Add support for Boya BY25D40 ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/81605/comment/42dbbc60_9060d74b : PS1, Line 9: tested on YW500U3M industrial camera Wow this is unusual! Which programmer were you using? Patchset: PS1: Thank you for contribution! Do you have a link to the datasheet for the chip? -- To view, visit https://review.coreboot.org/c/flashrom/+/81605?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I9e07a48dce3988e9d75cf02fca1f4a048c2e0cad Gerrit-Change-Number: 81605 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Mikushin <dmitry(a)kernelgen.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Dmitry Mikushin <dmitry(a)kernelgen.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 04 Apr 2024 03:15:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in flashrom[main]: [WIP] tests: Add tests for erasing chip with protected region
by Anastasia Klimchuk (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81664?usp=email ) Change subject: [WIP] tests: Add tests for erasing chip with protected region ...................................................................... Patch Set 1: (1 comment) This change is ready for review. File tests/erase_func_algo.c: https://review.coreboot.org/c/flashrom/+/81664/comment/97765eb6_3a1ae879 : PS1, Line 130: TEST_ERASE_INJECTOR One thing I haven't figured yet how to do in this test: It is important to distinguish which erasefn has been selected, however there is only one TEST_ERASE_INJECTOR value for all tests. So one and the same erasefn for all sizes of eraseblocks (as you can see in the code below), while in real chip that would be different functions. If we can distinguish which eraseblock fn has been selected , that would be last remaining bit to fully test CB:81385 -- To view, visit https://review.coreboot.org/c/flashrom/+/81664?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I1e7cfd027d37437c917c054f30f3be59b76b0069 Gerrit-Change-Number: 81664 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 04 Apr 2024 02:40:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit