- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: nicintel_spi.c: Cache FLA register value
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/55720?usp=email ) Change subject: nicintel_spi.c: Cache FLA register value ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/55720?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I4013a71ec498be977f62fe2531ac8770bfffadcd Gerrit-Change-Number: 55720 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[main]: mcp6x_spi.c: Implement `set_sck_set_mosi`
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49266?usp=email ) Change subject: mcp6x_spi.c: Implement `set_sck_set_mosi` ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/49266?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie86cc9d4df6c7f0609c30ff00d6f2d77fbb8b836 Gerrit-Change-Number: 49266 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[main]: rayer_spi.c: Implement `set_sck_set_mosi`
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49265?usp=email ) Change subject: rayer_spi.c: Implement `set_sck_set_mosi` ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/49265?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ieb05a35967685c2444d064cb61cec98e2a00f590 Gerrit-Change-Number: 49265 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[main]: bitbang_spi: Drop `set_mosi` and `get_miso` operations
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49268?usp=email ) Change subject: bitbang_spi: Drop `set_mosi` and `get_miso` operations ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/49268?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id6b1edb1e01330feffc5f1ed2ca2c2ebc4fb3b66 Gerrit-Change-Number: 49268 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[main]: ft2232_spi.c: Split out most programmer param parsing
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67908?usp=email ) Change subject: ft2232_spi.c: Split out most programmer param parsing ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/67908?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I25faac1060fc2bcd6042e34802e5bc493c936377 Gerrit-Change-Number: 67908 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[main]: ft2232_spi.c: Add struct for programmer params
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67906?usp=email ) Change subject: ft2232_spi.c: Add struct for programmer params ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/67906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I36b9f5f8481907bd605e9310bef08592bb7d9827 Gerrit-Change-Number: 67906 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[main]: flashchips: Add write-protect support for MX25L12833F
by Hsuan-ting Chen (Code Review) 11 Apr '24

11 Apr '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Hello Anastasia Klimchuk, Hsuan Ting Chen, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/81792?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips: Add write-protect support for MX25L12833F ...................................................................... flashchips: Add write-protect support for MX25L12833F datasheet: https://www.macronix.com/Lists/Datasheet/Attachments/8934/MX25L12833F,%203V… BUG=b:332486637 TEST=Test flashrom --wp-disable with MX25L12833FZNI-10 on ChromeOS Change-Id: I379c833eea3ed3487504126f45c6df672a772ddc Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> --- M flashchips.c 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/81792/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/81792?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I379c833eea3ed3487504126f45c6df672a772ddc Gerrit-Change-Number: 81792 Gerrit-PatchSet: 2 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[main]: Add support for Idaville HCC platform and iRC regions
by Kevin Yu (Code Review) 10 Apr '24

10 Apr '24

Attention is currently required from: Angel Pons, Paul Menzel. Kevin Yu has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81327?usp=email ) Change subject: Add support for Idaville HCC platform and iRC regions ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hi Paul and Angel Could you help on this? Thanks Kevin Yu -- To view, visit https://review.coreboot.org/c/flashrom/+/81327?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I39e7fa56b1b1de429f413ce32e69c8d8c769b6a9 Gerrit-Change-Number: 81327 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Yu <ykevin(a)celestica.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 10 Apr 2024 08:41:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: flashchips: Add support for MXIC MX25L3273F
by Anastasia Klimchuk (Code Review) 10 Apr '24

10 Apr '24

Attention is currently required from: DZ, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81562?usp=email ) Change subject: flashchips: Add support for MXIC MX25L3273F ...................................................................... Patch Set 9: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/81562/comment/c683b659_d143aaa5 : PS7, Line 9522: 1024B > Same as other patch: datasheet says 4K-bit secured OTP, so maybe 512B ? Daniel, I noticed that you updated the patch but didn't mark comment as fixed. Is that you forgot to resolve the comment or you are still want to do some more on the patch? -- To view, visit https://review.coreboot.org/c/flashrom/+/81562?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I4adaaa796d1db34702e7b0ed8e6fb167a3a5f6d7 Gerrit-Change-Number: 81562 Gerrit-PatchSet: 9 Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: DZ <danielzhang(a)mxic.com.cn> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 10 Apr 2024 03:05:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: meson: Update CI script to enforce building man pages and docs
by Anastasia Klimchuk (Code Review) 10 Apr '24

10 Apr '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/81665?usp=email ) Change subject: meson: Update CI script to enforce building man pages and docs ...................................................................... meson: Update CI script to enforce building man pages and docs `test_build.sh` is used by Jenkins, therefore it should build everything. Docker container for Jenkins is expected to have all the dependencies installed, and if some of them are missing, script should fail. Recently we had a situation when docker image was missing sphinx and flashrom Jenkins was silently skipping building man-pages and documentation. This patch prevents this happening again, because building man pages and docs will be enforced. Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/81665 Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anton Samsonov <avscomputing(a)gmail.com> --- M test_build.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved Anton Samsonov: Looks good to me, but someone else must approve diff --git a/test_build.sh b/test_build.sh index 9b490dc..ee86496 100755 --- a/test_build.sh +++ b/test_build.sh @@ -51,7 +51,7 @@ build_meson () { build_dir=out - meson_opts="-Dtests=enabled" + meson_opts="-Dtests=enabled -Dman-pages=enabled -Ddocumentation=enabled" ninja_opts="-j $(nproc)" rm -rf ${build_dir} -- To view, visit https://review.coreboot.org/c/flashrom/+/81665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Gerrit-Change-Number: 81665 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit