Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/83131?usp=email )
Change subject: print.c: Print B (block-protect) test status of the chips
......................................................................
print.c: Print B (block-protect) test status of the chips
This also expands the column for test status by 1 more char, since
now maximum status is longer, PREWB vs PREW.
print.c runs when command line option `flashrom -L` is invoked.
Change-Id: If697fe3ba93dbe34bb8f7a9a4b1686fdb8b3ee58
Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org>
---
M print.c
1 file changed, 13 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/83131/1
diff --git a/print.c b/print.c
index 0caa0da..d05f7bf 100644
--- a/print.c
+++ b/print.c
@@ -122,7 +122,7 @@
for (i = strlen("Device"); i < maxchiplen; i++)
msg_ginfo(" ");
- msg_ginfo("Test");
+ msg_ginfo("Test ");
for (i = 0; i < border; i++)
msg_ginfo(" ");
msg_ginfo("Known");
@@ -140,7 +140,7 @@
for (i = 0; i < maxvendorlen + maxchiplen; i++)
msg_ginfo(" ");
- msg_ginfo("OK ");
+ msg_ginfo("OK ");
for (i = 0; i < border; i++)
msg_ginfo(" ");
msg_ginfo("Broken");
@@ -151,7 +151,7 @@
msg_ginfo(" ");
msg_gdbg("range [V]");
msg_ginfo("\n\n");
- msg_ginfo("(P = PROBE, R = READ, E = ERASE, W = WRITE, - = N/A)\n\n");
+ msg_ginfo("(P = PROBE, R = READ, E = ERASE, W = WRITE, B = block-protect, - = N/A)\n\n");
for (chip = flashchips; chip->name != NULL; chip++) {
/* Don't print generic entries. */
@@ -242,6 +242,12 @@
msg_ginfo("-");
else
msg_ginfo(" ");
+ if (chip->tested.wp == OK)
+ msg_ginfo("B");
+ else if (chip->tested.wp == NA)
+ msg_ginfo("-");
+ else
+ msg_ginfo(" ");
for (i = 0; i < border; i++)
msg_ginfo(" ");
@@ -261,6 +267,10 @@
msg_ginfo("W");
else
msg_ginfo(" ");
+ if (chip->tested.wp == BAD)
+ msg_ginfo("B");
+ else
+ msg_ginfo(" ");
for (i = 0; i < border + 1; i++)
msg_ginfo(" ");
--
To view, visit https://review.coreboot.org/c/flashrom/+/83131?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: If697fe3ba93dbe34bb8f7a9a4b1686fdb8b3ee58
Gerrit-Change-Number: 83131
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/83130?usp=email )
Change subject: doc: Add current numbers of supported devices to the intro page
......................................................................
doc: Add current numbers of supported devices to the intro page
Current numbers are taken from the output of `flashrom -L` command.
Intro page still has a room for improvement, but as a first step the
numbers need to be updated. In future, maybe there is a way to update
the numbers less manually.
Change-Id: I7531521955dcf01348ed2ba9c54316b32b9cd925
Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org>
---
M doc/intro.rst
1 file changed, 12 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/30/83130/1
diff --git a/doc/intro.rst b/doc/intro.rst
index b1fe99a..b9a2c97 100644
--- a/doc/intro.rst
+++ b/doc/intro.rst
@@ -2,20 +2,30 @@
chips. It is designed to flash BIOS/EFI/coreboot/firmware/optionROM images on mainboards,
network/graphics/storage controller cards, and various other programmer devices.
-* Supports more than 476 flash chips, 291 chipsets, 500 mainboards, 79 PCI devices,
- 17 USB devices and various parallel/serial port-based programmers.
+* Supports more than 627 flash chips, 407 chipsets, 539 mainboards, 94 PCI devices,
+ 30 USB devices and various parallel/serial port-based programmers.
+ For more information, see the pages under :doc:`/supported_hw/index`.
+
* Supports parallel, LPC, FWH and SPI flash interfaces and various chip packages (DIP32,
PLCC32, DIP8, SO8/SOIC8, TSOP32, TSOP40, TSOP48, BGA and more).
+
* No physical access needed, root access is sufficient (not needed for some programmers).
+
* No bootable floppy disk, bootable CD-ROM or other media needed.
+
* No keyboard or monitor needed. Simply reflash remotely via SSH.
+
* No instant reboot needed. Reflash your chip in a running system, verify it, be happy.
The new firmware will be present next time you boot.
+
* Crossflashing and hotflashing is possible as long as the flash chips are electrically
and logically compatible (same protocol). Great for recovery.
+
* Scriptability. Reflash a whole pool of identical machines at the same time from the
command line. It is recommended to check flashrom output and error codes.
+
* Speed. flashrom is often much faster than most vendor flash tools.
+
* Portability. Supports DOS, Linux, FreeBSD (including Debian/kFreeBSD), NetBSD, OpenBSD,
DragonFlyBSD, anything Solaris-like, Mac OS X, and other Unix-like OSes as well as GNU Hurd.
Partial Windows support is available (no internal programmer support at the moment, hence
--
To view, visit https://review.coreboot.org/c/flashrom/+/83130?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I7531521955dcf01348ed2ba9c54316b32b9cd925
Gerrit-Change-Number: 83130
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/83129?usp=email )
Change subject: print.c: Print total numbers of supported USB and PCI devices
......................................................................
print.c: Print total numbers of supported USB and PCI devices
This adds two lines at the very end of the section with supported
deviced per programmer. At the moment of this patch, numbers are:
Supported USB devices, total 30
Supported PCI devices, total 94
All other sections print total numbers, this was only one missing.
Change-Id: Ie011db3985172d05f5160d1cb1cc39a4422a5750
Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org>
---
M print.c
1 file changed, 13 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/29/83129/1
diff --git a/print.c b/print.c
index 0caa0da..015f4a8 100644
--- a/print.c
+++ b/print.c
@@ -444,7 +444,8 @@
}
#endif
-static void print_supported_devs(const struct programmer_entry *const prog, const char *const type)
+static void print_supported_devs(const struct programmer_entry *const prog, const char *const type,
+ int* num_devs)
{
const struct dev_entry *const devs = prog->devs.dev;
msg_ginfo("\nSupported %s devices for the %s programmer:\n", type, prog->name);
@@ -480,12 +481,17 @@
msg_pinfo(" %04x:%04x %s\n", devs[i].vendor_id, devs[i].device_id,
test_state_to_text(devs[i].status));
+ if (devs[i].status == OK || devs[i].status == NT || devs[i].status == DEP)
+ *num_devs += 1;
}
}
int print_supported(void)
{
unsigned int i;
+ int num_pci_devs = 0;
+ int num_usb_devs = 0;
+
if (print_supported_chips())
return 1;
@@ -504,10 +510,10 @@
const struct programmer_entry *const prog = programmer_table[i];
switch (prog->type) {
case USB:
- print_supported_devs(prog, "USB");
+ print_supported_devs(prog, "USB", &num_usb_devs);
break;
case PCI:
- print_supported_devs(prog, "PCI");
+ print_supported_devs(prog, "PCI", &num_pci_devs);
break;
case OTHER:
if (prog->devs.note != NULL) {
@@ -521,6 +527,10 @@
break;
}
}
+
+ msg_ginfo("\nSupported USB devices, total %d\nSupported PCI devices, total %d\n",
+ num_usb_devs, num_pci_devs);
+
return 0;
}
--
To view, visit https://review.coreboot.org/c/flashrom/+/83129?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ie011db3985172d05f5160d1cb1cc39a4422a5750
Gerrit-Change-Number: 83129
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Attention is currently required from: Paul Menzel, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change by Thomas Heijligen. ( https://review.coreboot.org/c/flashrom/+/83121?usp=email )
Change subject: MAINTAINERS: Remove Thomas Heijligen from build system and sphinx docs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/83121?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I775d2dca95ee6f6d565a24f1622ee70554e9d4f5
Gerrit-Change-Number: 83121
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 19 Jun 2024 03:58:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Paul Menzel, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change by Thomas Heijligen. ( https://review.coreboot.org/c/flashrom/+/83121?usp=email )
Change subject: MAINTAINERS: Remove Thomas Heijligen from build system and sphinx docs
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
I rebased on head
Commit Message:
https://review.coreboot.org/c/flashrom/+/83121/comment/6b20f861_8d80894e?us… :
PS1, Line 7: myself
> The author is not visibale in `git log --oneline`, so I’d use the full name: […]
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/83121?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I775d2dca95ee6f6d565a24f1622ee70554e9d4f5
Gerrit-Change-Number: 83121
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Wed, 19 Jun 2024 03:58:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen.
Anastasia Klimchuk has uploaded a new patch set (#2) to the change originally created by Thomas Heijligen. ( https://review.coreboot.org/c/flashrom/+/83121?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: MAINTAINERS: Remove Thomas Heijligen from build system and sphinx docs
......................................................................
MAINTAINERS: Remove Thomas Heijligen from build system and sphinx docs
Change-Id: I775d2dca95ee6f6d565a24f1622ee70554e9d4f5
Signed-off-by: Thomas Heijligen <src(a)posteo.de>
Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org>
---
M MAINTAINERS
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/83121/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/83121?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I775d2dca95ee6f6d565a24f1622ee70554e9d4f5
Gerrit-Change-Number: 83121
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen.
Paul Menzel has posted comments on this change by Thomas Heijligen. ( https://review.coreboot.org/c/flashrom/+/83121?usp=email )
Change subject: MAINTAINERS: Remove myself
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/83121/comment/1affd8d5_c8eb501d?us… :
PS1, Line 7: myself
The author is not visibale in `git log --oneline`, so I’d use the full name:
> Remove Thomas Heijligen from build system and sphinx doc
--
To view, visit https://review.coreboot.org/c/flashrom/+/83121?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I775d2dca95ee6f6d565a24f1622ee70554e9d4f5
Gerrit-Change-Number: 83121
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Tue, 18 Jun 2024 19:27:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No