May 2023 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: amd_imc.c: Cleanup C89ism and redundant NULL check
by Angel Pons (Code Review) 25 May '23

25 May '23

Attention is currently required from: Edward O'Callaghan, Martin Roth. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75359 ) Change subject: amd_imc.c: Cleanup C89ism and redundant NULL check ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File amd_imc.c: https://review.coreboot.org/c/flashrom/+/75359/comment/c496752b_ed30f8e9 PS2, Line 39: if (!dev) { : return 0; : } We should keep this check. Let's re-add it in `imc_resume()` and `amd_imc_shutdown()` to be safe, the other functions should only called from within this file. -- To view, visit https://review.coreboot.org/c/flashrom/+/75359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1dbae500010fa50a67609efb3cbb5778b684ad04 Gerrit-Change-Number: 75359 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Thu, 25 May 2023 09:25:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: chipset_enable.c: Drop `_LARGEFILE64_SOURCE`
by Angel Pons (Code Review) 25 May '23

25 May '23

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75271 ) Change subject: chipset_enable.c: Drop `_LARGEFILE64_SOURCE` ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Thanks Angel for explanation. […] Commit link doesn't work because it's a pre-Gerrit commit (it's actually from the days when flashrom used subversion). Haven't tested if binary stays reproducible. -- To view, visit https://review.coreboot.org/c/flashrom/+/75271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I866cfa2f996eeea5846e5d9189647ad7a4a4e3e4 Gerrit-Change-Number: 75271 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 25 May 2023 09:21:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: git-hooks: echo back the commit message on failure
by Peter Marheine (Code Review) 24 May '23

24 May '23

Attention is currently required from: Miklós Márton. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62879 ) Change subject: git-hooks: echo back the commit message on failure ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I13289f81b3fa92640aecc43eae28c1643cd7c247 Gerrit-Change-Number: 62879 Gerrit-PatchSet: 3 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Wed, 24 May 2023 23:41:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: hwaccess_x86_io: Improve IO permission error messages
by Anastasia Klimchuk (Code Review) 24 May '23

24 May '23

Attention is currently required from: Miklós Márton, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62878 ) Change subject: hwaccess_x86_io: Improve IO permission error messages ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6a6f60a5f0ac8f2b51c74661f7dad30571819680 Gerrit-Change-Number: 62878 Gerrit-PatchSet: 6 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 24 May 2023 22:57:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: hwaccess_x86_io: Improve IO permission error messages
by Miklós Márton (Code Review) 24 May '23

24 May '23

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62878 ) Change subject: hwaccess_x86_io: Improve IO permission error messages ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62878/comment/8cd43ce6_5068c879 PS2, Line 7: Improve IO permission error messages > We typically add prefix to commit title, so here it can be […] Done https://review.coreboot.org/c/flashrom/+/62878/comment/596bdba6_5854a0cd PS2, Line 9: - Display the BSD hints only when compiled for a specific BSD : - On Linux check the user's uid to see if flashrom run with root privileges : - Add a note about the dmesg check if the flashrom run as root and have no : IO privilege > Seems like lines are longer than 72 chars and wrap. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/62878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6a6f60a5f0ac8f2b51c74661f7dad30571819680 Gerrit-Change-Number: 62878 Gerrit-PatchSet: 5 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 24 May 2023 19:06:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: hwaccess_x86_io: Improve IO permission error messages
by Miklós Márton (Code Review) 24 May '23

24 May '23

Attention is currently required from: Miklós Márton, Thomas Heijligen. Hello build bot (Jenkins), Thomas Heijligen, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62878 to look at the new patch set (#5). Change subject: hwaccess_x86_io: Improve IO permission error messages ...................................................................... hwaccess_x86_io: Improve IO permission error messages - Display the BSD hints only when compiled for a specific BSD - On Linux check the user's uid to see if flashrom run with root privileges - Add a note about the dmesg check if the flashrom run as root and have no IO privilege TEST=Run flashrom with internal programmed on a Secure boot enabled machine. You should not get the privilege level error, but rather a suggestion about the security policies. Change-Id: I6a6f60a5f0ac8f2b51c74661f7dad30571819680 Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com> --- M hwaccess_x86_io.c 1 file changed, 35 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/62878/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/62878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6a6f60a5f0ac8f2b51c74661f7dad30571819680 Gerrit-Change-Number: 62878 Gerrit-PatchSet: 5 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: hwaccess_x86_io: Improve IO permission error messages
by Miklós Márton (Code Review) 24 May '23

24 May '23

Attention is currently required from: Miklós Márton, Thomas Heijligen. Hello build bot (Jenkins), Thomas Heijligen, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62878 to look at the new patch set (#4). Change subject: hwaccess_x86_io: Improve IO permission error messages ...................................................................... hwaccess_x86_io: Improve IO permission error messages - Display the BSD hints only when compiled for a specific BSD - On Linux check the user's uid to see if flashrom run with root privileges - Add a note about the dmesg check if the flashrom run as root and have no IO privilege Change-Id: I6a6f60a5f0ac8f2b51c74661f7dad30571819680 Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com> --- M hwaccess_x86_io.c 1 file changed, 30 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/62878/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/62878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6a6f60a5f0ac8f2b51c74661f7dad30571819680 Gerrit-Change-Number: 62878 Gerrit-PatchSet: 4 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: hwaccess_x86_io: Improve IO permission error messages
by Miklós Márton (Code Review) 24 May '23

24 May '23

Attention is currently required from: Miklós Márton, Thomas Heijligen. Hello build bot (Jenkins), Thomas Heijligen, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62878 to look at the new patch set (#3). Change subject: hwaccess_x86_io: Improve IO permission error messages ...................................................................... hwaccess_x86_io: Improve IO permission error messages - Display the BSD hints only when compiled for a specific BSD - On Linux check the user's uid to see if flashrom run with root privileges - Add a note about the dmesg check if the flashrom run as root and have no IO privilege Change-Id: I6a6f60a5f0ac8f2b51c74661f7dad30571819680 Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com> --- M hwaccess_x86_io.c 1 file changed, 29 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/62878/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/62878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6a6f60a5f0ac8f2b51c74661f7dad30571819680 Gerrit-Change-Number: 62878 Gerrit-PatchSet: 3 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: git-hooks: echo back the commit message on failure
by Anastasia Klimchuk (Code Review) 24 May '23

24 May '23

Attention is currently required from: Miklós Márton, Peter Marheine. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62879 ) Change subject: git-hooks: echo back the commit message on failure ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I13289f81b3fa92640aecc43eae28c1643cd7c247 Gerrit-Change-Number: 62879 Gerrit-PatchSet: 3 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 24 May 2023 12:33:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Improve IO permission error messages
by Anastasia Klimchuk (Code Review) 24 May '23

24 May '23

Attention is currently required from: Miklós Márton, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62878 ) Change subject: Improve IO permission error messages ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62878/comment/6dfb9196_c7a076a6 PS2, Line 7: Improve IO permission error messages We typically add prefix to commit title, so here it can be `hwaccess_x86_io:<the rest of title>` https://review.coreboot.org/c/flashrom/+/62878/comment/b7eb4333_04e2cb67 PS2, Line 9: - Display the BSD hints only when compiled for a specific BSD : - On Linux check the user's uid to see if flashrom run with root privileges : - Add a note about the dmesg check if the flashrom run as root and have no : IO privilege Seems like lines are longer than 72 chars and wrap. We have max line length 72 chars for commit message. Patchset: PS2: Thanks for the patch! I am wondering if you can add testing info in commit message? (if you did testing) -- To view, visit https://review.coreboot.org/c/flashrom/+/62878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6a6f60a5f0ac8f2b51c74661f7dad30571819680 Gerrit-Change-Number: 62878 Gerrit-PatchSet: 2 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 24 May 2023 12:31:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2023