May 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: doc: Add Windows MSYS2 build instructions
by Alexander Goncharov (Code Review) 30 May '23

30 May '23

Attention is currently required from: Peter Marheine, Thomas Heijligen. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75189?usp=email ) Change subject: doc: Add Windows MSYS2 build instructions ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75189?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I847428535547242ff32af92c4fe8477241826814 Gerrit-Change-Number: 75189 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 30 May 2023 12:03:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: tests/io_mock.h: add missing includes
by Alexander Goncharov (Code Review) 30 May '23

30 May '23

Attention is currently required from: Peter Marheine, Thomas Heijligen. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75235?usp=email ) Change subject: tests/io_mock.h: add missing includes ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/75235?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic76653c8f3b5d7043ab6080d4e2e1748590ad070 Gerrit-Change-Number: 75235 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 30 May 2023 11:25:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc/classic_cli_manpage: Mark progress feature as experimental
by Alexander Goncharov (Code Review) 30 May '23

30 May '23

Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Thomas Heijligen. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75439?usp=email ) Change subject: doc/classic_cli_manpage: Mark progress feature as experimental ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9cacc60cb357c29f6625126d22a67a56de560887 Gerrit-Change-Number: 75439 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 30 May 2023 11:21:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ni845x_spi: refactor singleton states into reentrant pattern
by Alexander Goncharov (Code Review) 30 May '23

30 May '23

Attention is currently required from: Anastasia Klimchuk, Miklós Márton. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72160?usp=email ) Change subject: ni845x_spi: refactor singleton states into reentrant pattern ...................................................................... Patch Set 4: (5 comments) File ni845x_spi.c: https://review.coreboot.org/c/flashrom/+/72160/comment/fc503d6d_4cca0e3e : PS3, Line 432: const struct ni845x_spi_data *data = flash->mst->spi.data; > I think data shall not be const here. See comments below. Done https://review.coreboot.org/c/flashrom/+/72160/comment/7c683915_2979443d : PS3, Line 456: &io_voltage_in_mV, > The io_voltage_in_mV is not defined anymore. […] Done https://review.coreboot.org/c/flashrom/+/72160/comment/63708814_cb1f4b41 : PS3, Line 481: &io_voltage_in_mV, > Same as in line 456 Done https://review.coreboot.org/c/flashrom/+/72160/comment/2ce447bd_3de0209a : PS3, Line 566: unsigned char CS_number; > The CS_number shall be initialized with 0, io_voltage_in_mV could be removed. Done https://review.coreboot.org/c/flashrom/+/72160/comment/7add950a_7193b240 : PS3, Line 635: data->io_voltage_in_mV = io_voltage_in_mV; > data->io_voltage_in_mV = requested_io_voltage_mV; […] I've just dropped this line, because `io_voltage_in_mV` will be set in the `usb8452_spi_set_io_voltage()` -- To view, visit https://review.coreboot.org/c/flashrom/+/72160?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I45fcb8e20582cb0c532c4a9f0c78543a25f8d484 Gerrit-Change-Number: 72160 Gerrit-PatchSet: 4 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 30 May 2023 11:17:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: ni845x_spi: pass global state through func params
by Alexander Goncharov (Code Review) 30 May '23

30 May '23

Attention is currently required from: Miklós Márton. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72154?usp=email ) Change subject: ni845x_spi: pass global state through func params ...................................................................... Patch Set 6: (1 comment) File ni845x_spi.c: https://review.coreboot.org/c/flashrom/+/72154/comment/32fab993_fbe14304 : PS5, Line 131: static int32 ni845x_spi_open_resource(char *resource_handle, uInt32 *opened_handle, enum USB845x_type device_pid) > The compilation fails with: […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/72154?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61 Gerrit-Change-Number: 72154 Gerrit-PatchSet: 6 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Tue, 30 May 2023 11:16:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ni845x_spi: refactor singleton states into reentrant pattern
by Alexander Goncharov (Code Review) 30 May '23

30 May '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk. Hello Anastasia Klimchuk, Miklós Márton, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/72160?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: ni845x_spi: refactor singleton states into reentrant pattern ...................................................................... ni845x_spi: refactor singleton states into reentrant pattern Move global singleton states into a struct and store within the spi_master data field for the life-time of the driver. TOPIC=register_master_api Change-Id: I45fcb8e20582cb0c532c4a9f0c78543a25f8d484 Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> Ticket: https://ticket.coreboot.org/issues/391 --- M ni845x_spi.c 1 file changed, 62 insertions(+), 39 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/60/72160/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/72160?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I45fcb8e20582cb0c532c4a9f0c78543a25f8d484 Gerrit-Change-Number: 72160 Gerrit-PatchSet: 4 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: ni845x_spi: pass global state through func params
by Alexander Goncharov (Code Review) 30 May '23

30 May '23

Attention is currently required from: Alexander Goncharov. Hello Anastasia Klimchuk, Miklós Márton, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/72154?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: ni845x_spi: pass global state through func params ...................................................................... ni845x_spi: pass global state through func params Instead of relying on global variables, pass and use their value or pointer to functions where possible. The usage of `io_voltage_in_mV` global var in `usb8452_spi_set_io_voltage` function is replaced with existing function argument `set_io_voltage_mV` since `set_io_voltage_mV` already contains the pointer to global var. This patch prepares the programmer to move global singleton states into a struct. TOPIC=register_master_api Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61 Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> Ticket: https://ticket.coreboot.org/issues/391 --- M ni845x_spi.c 1 file changed, 22 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/72154/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/72154?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61 Gerrit-Change-Number: 72154 Gerrit-PatchSet: 6 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: meson: improve error message for unsupported systems
by Anastasia Klimchuk (Code Review) 30 May '23

30 May '23

Attention is currently required from: Miklós Márton, Miklós Márton, Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75490?usp=email ) Change subject: meson: improve error message for unsupported systems ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS4: That will go after CB:75270 right? -- To view, visit https://review.coreboot.org/c/flashrom/+/75490?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c8a8b47505f7a239160d565463ce7262fe5d5d6 Gerrit-Change-Number: 75490 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 30 May 2023 10:54:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: meson: improve error message for unsupported systems
by Peter Marheine (Code Review) 30 May '23

30 May '23

Attention is currently required from: Anastasia Klimchuk, Miklós Márton, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75490?usp=email ) Change subject: meson: improve error message for unsupported systems ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/75490/comment/c6c37e6f_4cb791f6 : PS3, Line 9: This adds the current and supported system information to the error message : when an unsupported programmer is requested, making it easier to tell what : the incompatibility is. : : TEST=(in mingw-ucrt64) meson setup -Dprogrammer=ni845x_spi build, : error message says the programmer needs `['windows']/['x86']` but the : system is `windows/x86_64`. > Can you wrap this at 72 chars? Thanks! Done -- To view, visit https://review.coreboot.org/c/flashrom/+/75490?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c8a8b47505f7a239160d565463ce7262fe5d5d6 Gerrit-Change-Number: 75490 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 29 May 2023 23:45:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: meson: improve error message for unsupported systems
by Peter Marheine (Code Review) 30 May '23

30 May '23

Attention is currently required from: Miklós Márton, Peter Marheine, Thomas Heijligen. Hello Anastasia Klimchuk, Miklós Márton, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75490?usp=email to look at the new patch set (#4). Change subject: meson: improve error message for unsupported systems ...................................................................... meson: improve error message for unsupported systems This adds the current and supported system information to the error message when an unsupported programmer is requested, making it easier to tell what the incompatibility is. TEST=(in mingw-ucrt64) meson setup -Dprogrammer=ni845x_spi build, error message says the programmer needs `['windows']/['x86']` but the system is `windows/x86_64`. Change-Id: I6c8a8b47505f7a239160d565463ce7262fe5d5d6 Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> --- M meson.build 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/75490/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/75490?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c8a8b47505f7a239160d565463ce7262fe5d5d6 Gerrit-Change-Number: 75490 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2023