May 2023 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[master]: MAINTAINERS: Add Stefan Reinauer for docker container
by Stefan Reinauer (Code Review) 26 May '23

26 May '23

Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75458?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Anastasia Klimchuk, Verified+1 by build bot (Jenkins) Change subject: MAINTAINERS: Add Stefan Reinauer for docker container ...................................................................... MAINTAINERS: Add Stefan Reinauer for docker container Change-Id: I771c6f67e0ed9beee50e8b142c34d24e96614c32 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M MAINTAINERS 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/58/75458/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75458?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I771c6f67e0ed9beee50e8b142c34d24e96614c32 Gerrit-Change-Number: 75458 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: git-hooks: echo back the commit message on failure
by Anastasia Klimchuk (Code Review) 26 May '23

26 May '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/62879?usp=email ) Change subject: git-hooks: echo back the commit message on failure ...................................................................... git-hooks: echo back the commit message on failure When using nano as a git commit message editor the contents of the commit message could get lost if the git commit hook fails due to the lack of Signed-off-by line. To prevent this unpleasant effect for new contributors the commit hook was modified to echo back the commit message to allow the user to copy-paste it to the message of the next commit attempt. Change-Id: I13289f81b3fa92640aecc43eae28c1643cd7c247 Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/62879 Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/git-hooks/commit-msg 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Peter Marheine: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/util/git-hooks/commit-msg b/util/git-hooks/commit-msg index d43eb45..e2f5de5 100755 --- a/util/git-hooks/commit-msg +++ b/util/git-hooks/commit-msg @@ -196,6 +196,7 @@ test_signoff() { if ! grep -qi '^[[:space:]]*\+Signed-off-by:' "$MSG"; then + cat "$MSG" printf "\nError: No Signed-off-by line in the commit message.\n" printf "See: ${DEV_GUIDELINES_URL}\n" exit 1 @@ -206,6 +207,7 @@ test_duplicate_signoffs_acks() { test "" = "$(grep -i '^(Signed-off-by|Acked-by): ' "$MSG" | sort | uniq -c | sed -e '/^[[:space:]]*1[[:space:]]/d')" || { + cat "$MSG" echo "Duplicate Signed-off-by or Acked-by lines." >&2 exit 1 } -- To view, visit https://review.coreboot.org/c/flashrom/+/62879?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I13289f81b3fa92640aecc43eae28c1643cd7c247 Gerrit-Change-Number: 62879 Gerrit-PatchSet: 4 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Stefan Reinauer for docker container
by Anastasia Klimchuk (Code Review) 26 May '23

26 May '23

Attention is currently required from: Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75458?usp=email ) Change subject: MAINTAINERS: Add Stefan Reinauer for docker container ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: Thank you so much for the patch! File MAINTAINERS: https://review.coreboot.org/c/flashrom/+/75458/comment/5f4d0478_62eb4762 : PS1, Line 198: DOCUMENTATION The title says "documentation docker", but file path is for all dockers. You need to either: - remove the word "documentation", title this "FLASHROM DOCKER" and then you will be maintaining all the dockers. that would be fantastic! ;) - change the file path to point to documentation docker only I have fingers crossed for the former :) -- To view, visit https://review.coreboot.org/c/flashrom/+/75458?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I771c6f67e0ed9beee50e8b142c34d24e96614c32 Gerrit-Change-Number: 75458 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 26 May 2023 04:57:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Stefan Reinauer for docker container
by Stefan Reinauer (Code Review) 26 May '23

26 May '23

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75458?usp=email ) Change subject: MAINTAINERS: Add Stefan Reinauer for docker container ...................................................................... MAINTAINERS: Add Stefan Reinauer for docker container Change-Id: I771c6f67e0ed9beee50e8b142c34d24e96614c32 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M MAINTAINERS 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/58/75458/1 diff --git a/MAINTAINERS b/MAINTAINERS index f32fbf6..8d77b62 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -194,3 +194,8 @@ R: Evan Benn <evanbenn(a)gmail.com> S: Supported F: util/flashrom_tester/ + +FLASHROM DOCUMENTATION DOCKER +M: Stefan Reinauer <stefan.reinauer(a)coreboot.org> +S: Maintained +F: util/docker/ -- To view, visit https://review.coreboot.org/c/flashrom/+/75458?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I771c6f67e0ed9beee50e8b142c34d24e96614c32 Gerrit-Change-Number: 75458 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: doc/classic_cli_manpage: Mark progress feature as experimental
by Stefan Reinauer (Code Review) 26 May '23

26 May '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Edward O'Callaghan, Thomas Heijligen. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75439?usp=email ) Change subject: doc/classic_cli_manpage: Mark progress feature as experimental ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/75439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9cacc60cb357c29f6625126d22a67a56de560887 Gerrit-Change-Number: 75439 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 26 May 2023 03:57:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc/contact: Fix the nesting level of FAQ item
by Stefan Reinauer (Code Review) 26 May '23

26 May '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Thomas Heijligen. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75437?usp=email ) Change subject: doc/contact: Fix the nesting level of FAQ item ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/75437?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idff89710c065cbe4fe3f2946d92ca7446f3e3663 Gerrit-Change-Number: 75437 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 26 May 2023 03:56:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: linux_mtd.c: Optimise linux_mtd_wp_read_cfg() ioctl() calls
by Edward O'Callaghan (Code Review) 26 May '23

26 May '23

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75476?usp=email ) Change subject: linux_mtd.c: Optimise linux_mtd_wp_read_cfg() ioctl() calls ...................................................................... linux_mtd.c: Optimise linux_mtd_wp_read_cfg() ioctl() calls The linux_mtd_wp_read_cfg() function makes excessive ioctl() calls as it sweeps on a per-eraseblock basis. Instead employ a bisection algorithm to optimise the number of user to kernel interactions to a minimum. Change-Id: I7ae3816598b74f0db7ac7d564391e69cfb8b1f79 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> Co-Authored-by: Damien Zammit <damien(a)zamaudio.com> --- M linux_mtd.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/75476/1 diff --git a/linux_mtd.c b/linux_mtd.c index 495db9a..bc07dfa 100644 --- a/linux_mtd.c +++ b/linux_mtd.c @@ -323,7 +323,8 @@ cfg->range.len = 0; /* Check protection status of each block */ - for (size_t u = 0; u < data->total_size; u += data->erasesize) { + uint32_t erase_boundary = total_size/2; + for (size_t u = 0; u < data->total_size; u += erase_boundary) { struct erase_info_user erase_info = { .start = u, .length = data->erasesize, @@ -339,13 +340,15 @@ } else if (ret == 1) { /* Block is protected. */ - if (end_found) { + if (end_found && (erase_boundary < data->erasesize)) { /* * We already found the end of another * protection range, so this is the start of a * new one. */ return FLASHROM_WP_ERR_OTHER; + } else { /* hole to bisect */ + erase_boundary = max(erase_boundary/2, data->erasesize); } if (!start_found) { cfg->range.start = erase_info.start; -- To view, visit https://review.coreboot.org/c/flashrom/+/75476?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ae3816598b74f0db7ac7d564391e69cfb8b1f79 Gerrit-Change-Number: 75476 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: doc/classic_cli_manpage: Mark progress feature as experimental
by Anastasia Klimchuk (Code Review) 25 May '23

25 May '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75439 ) Change subject: doc/classic_cli_manpage: Mark progress feature as experimental ...................................................................... doc/classic_cli_manpage: Mark progress feature as experimental The feature will have patches coming soon and not completely ready yet. Change-Id: I9cacc60cb357c29f6625126d22a67a56de560887 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M doc/classic_cli_manpage.rst 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/39/75439/1 diff --git a/doc/classic_cli_manpage.rst b/doc/classic_cli_manpage.rst index a8ac6da..8deb5ce 100644 --- a/doc/classic_cli_manpage.rst +++ b/doc/classic_cli_manpage.rst @@ -323,7 +323,7 @@ **--progress** - Show progress percentage of operations on the standard output. + [Experimental feature WIP] Show progress percentage of operations on the standard output. **-R, --version** -- To view, visit https://review.coreboot.org/c/flashrom/+/75439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9cacc60cb357c29f6625126d22a67a56de560887 Gerrit-Change-Number: 75439 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: doc/contact: Fix the nesting level of FAQ item
by Anastasia Klimchuk (Code Review) 25 May '23

25 May '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75437 ) Change subject: doc/contact: Fix the nesting level of FAQ item ...................................................................... doc/contact: Fix the nesting level of FAQ item Change-Id: Idff89710c065cbe4fe3f2946d92ca7446f3e3663 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M doc/contact.rst 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/75437/1 diff --git a/doc/contact.rst b/doc/contact.rst index 3411ce0..dc89063 100644 --- a/doc/contact.rst +++ b/doc/contact.rst @@ -127,7 +127,7 @@ This is because daylight saving time changes are happening on different dates in different locations, and setting up meeting time becomes too complicated. FAQ ---- +""" **When is the next meeting?** Look into the meeting notes `document <https://docs.google.com/document/d/18qKvEbfPszjsJJGJhwi8kRVDUG3GZkADzQSH6WF…>`_. -- To view, visit https://review.coreboot.org/c/flashrom/+/75437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idff89710c065cbe4fe3f2946d92ca7446f3e3663 Gerrit-Change-Number: 75437 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: amd_imc.c: Cleanup C89ism and redundant NULL check
by Angel Pons (Code Review) 25 May '23

25 May '23

Attention is currently required from: Edward O'Callaghan, Martin Roth. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75359 ) Change subject: amd_imc.c: Cleanup C89ism and redundant NULL check ...................................................................... Patch Set 2: (1 comment) File amd_imc.c: https://review.coreboot.org/c/flashrom/+/75359/comment/1802e019_bd79a952 PS2, Line 39: if (!dev) { : return 0; : } > We should keep this check. […] Or just one check in `imc_send_cmd()`. -- To view, visit https://review.coreboot.org/c/flashrom/+/75359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1dbae500010fa50a67609efb3cbb5778b684ad04 Gerrit-Change-Number: 75359 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Thu, 25 May 2023 09:26:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2023