May 2023 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[master]: meson: improve error message for unsupported systems
by Anastasia Klimchuk (Code Review) 30 May '23

30 May '23

Attention is currently required from: Miklós Márton, Miklós Márton, Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75490?usp=email ) Change subject: meson: improve error message for unsupported systems ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS4: That will go after CB:75270 right? -- To view, visit https://review.coreboot.org/c/flashrom/+/75490?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c8a8b47505f7a239160d565463ce7262fe5d5d6 Gerrit-Change-Number: 75490 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 30 May 2023 10:54:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: meson: improve error message for unsupported systems
by Peter Marheine (Code Review) 29 May '23

29 May '23

Attention is currently required from: Anastasia Klimchuk, Miklós Márton, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75490?usp=email ) Change subject: meson: improve error message for unsupported systems ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/75490/comment/c6c37e6f_4cb791f6 : PS3, Line 9: This adds the current and supported system information to the error message : when an unsupported programmer is requested, making it easier to tell what : the incompatibility is. : : TEST=(in mingw-ucrt64) meson setup -Dprogrammer=ni845x_spi build, : error message says the programmer needs `['windows']/['x86']` but the : system is `windows/x86_64`. > Can you wrap this at 72 chars? Thanks! Done -- To view, visit https://review.coreboot.org/c/flashrom/+/75490?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c8a8b47505f7a239160d565463ce7262fe5d5d6 Gerrit-Change-Number: 75490 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 29 May 2023 23:45:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: meson: improve error message for unsupported systems
by Peter Marheine (Code Review) 29 May '23

29 May '23

Attention is currently required from: Miklós Márton, Peter Marheine, Thomas Heijligen. Hello Anastasia Klimchuk, Miklós Márton, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75490?usp=email to look at the new patch set (#4). Change subject: meson: improve error message for unsupported systems ...................................................................... meson: improve error message for unsupported systems This adds the current and supported system information to the error message when an unsupported programmer is requested, making it easier to tell what the incompatibility is. TEST=(in mingw-ucrt64) meson setup -Dprogrammer=ni845x_spi build, error message says the programmer needs `['windows']/['x86']` but the system is `windows/x86_64`. Change-Id: I6c8a8b47505f7a239160d565463ce7262fe5d5d6 Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> --- M meson.build 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/75490/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/75490?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c8a8b47505f7a239160d565463ce7262fe5d5d6 Gerrit-Change-Number: 75490 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: doc/classic_cli_manpage: Mark progress feature as experimental
by Stefan Reinauer (Code Review) 29 May '23

29 May '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Edward O'Callaghan, Thomas Heijligen. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75439?usp=email ) Change subject: doc/classic_cli_manpage: Mark progress feature as experimental ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9cacc60cb357c29f6625126d22a67a56de560887 Gerrit-Change-Number: 75439 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 29 May 2023 19:44:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: meson: improve error message for unsupported systems
by Anastasia Klimchuk (Code Review) 29 May '23

29 May '23

Attention is currently required from: Miklós Márton, Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75490?usp=email ) Change subject: meson: improve error message for unsupported systems ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/75490/comment/8adc2e56_b2184f3e : PS3, Line 9: This adds the current and supported system information to the error message : when an unsupported programmer is requested, making it easier to tell what : the incompatibility is. : : TEST=(in mingw-ucrt64) meson setup -Dprogrammer=ni845x_spi build, : error message says the programmer needs `['windows']/['x86']` but the : system is `windows/x86_64`. Can you wrap this at 72 chars? Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/75490?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c8a8b47505f7a239160d565463ce7262fe5d5d6 Gerrit-Change-Number: 75490 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 29 May 2023 12:00:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add Windows MSYS2 build instructions
by Anastasia Klimchuk (Code Review) 29 May '23

29 May '23

Attention is currently required from: Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75189?usp=email ) Change subject: doc: Add Windows MSYS2 build instructions ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75189?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I847428535547242ff32af92c4fe8477241826814 Gerrit-Change-Number: 75189 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 29 May 2023 11:56:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc/classic_cli_manpage: Mark progress feature as experimental
by Anastasia Klimchuk (Code Review) 29 May '23

29 May '23

Attention is currently required from: Alexander Goncharov, Edward O'Callaghan, Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75439?usp=email ) Change subject: doc/classic_cli_manpage: Mark progress feature as experimental ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/75439/comment/c0cea9a6_93c19b4d : PS1, Line 10: ready > s/ready/ideal/ […] Done File doc/classic_cli_manpage.rst: https://review.coreboot.org/c/flashrom/+/75439/comment/7a434ea5_b83abe26 : PS1, Line 326: WIP > Just drop the 'WIP' part. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/75439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9cacc60cb357c29f6625126d22a67a56de560887 Gerrit-Change-Number: 75439 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 29 May 2023 09:25:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc/classic_cli_manpage: Mark progress feature as experimental
by Anastasia Klimchuk (Code Review) 29 May '23

29 May '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Edward O'Callaghan, Stefan Reinauer, Thomas Heijligen. Hello Alexander Goncharov, Edward O'Callaghan, Stefan Reinauer, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75439?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Stefan Reinauer, Code-Review+2 by Edward O'Callaghan, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: doc/classic_cli_manpage: Mark progress feature as experimental ...................................................................... doc/classic_cli_manpage: Mark progress feature as experimental The feature will have patches coming soon and not completely ideal yet. At the moment, read and verify operations can show progress, erase and write are not completely ready yet. Change-Id: I9cacc60cb357c29f6625126d22a67a56de560887 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M doc/classic_cli_manpage.rst 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/39/75439/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9cacc60cb357c29f6625126d22a67a56de560887 Gerrit-Change-Number: 75439 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: doc/contact: Fix the nesting level of FAQ item
by Anastasia Klimchuk (Code Review) 29 May '23

29 May '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75437?usp=email ) Change subject: doc/contact: Fix the nesting level of FAQ item ...................................................................... doc/contact: Fix the nesting level of FAQ item Change-Id: Idff89710c065cbe4fe3f2946d92ca7446f3e3663 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/75437 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M doc/contact.rst 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Stefan Reinauer: Looks good to me, but someone else must approve diff --git a/doc/contact.rst b/doc/contact.rst index 3411ce0..dc89063 100644 --- a/doc/contact.rst +++ b/doc/contact.rst @@ -127,7 +127,7 @@ This is because daylight saving time changes are happening on different dates in different locations, and setting up meeting time becomes too complicated. FAQ ---- +""" **When is the next meeting?** Look into the meeting notes `document <https://docs.google.com/document/d/18qKvEbfPszjsJJGJhwi8kRVDUG3GZkADzQSH6WF…>`_. -- To view, visit https://review.coreboot.org/c/flashrom/+/75437?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idff89710c065cbe4fe3f2946d92ca7446f3e3663 Gerrit-Change-Number: 75437 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: doc/contact: Fix the nesting level of FAQ item
by Edward O'Callaghan (Code Review) 29 May '23

29 May '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Thomas Heijligen. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75437?usp=email ) Change subject: doc/contact: Fix the nesting level of FAQ item ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75437?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idff89710c065cbe4fe3f2946d92ca7446f3e3663 Gerrit-Change-Number: 75437 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 29 May 2023 05:33:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2023