December 2023 - flashrom-gerrit

[XS] Change in flashrom[main]: amd_spi.c: Everything after rev 0x4a is a SPI100 ctrl
by Anastasia Klimchuk (Code Review) 08 Dec '23

08 Dec '23

Attention is currently required from: Arthur Heymans, Edward O'Callaghan, Felix Held, Jason Glenesk, Marshall Dawson, Martin Roth, Paul Menzel. Anastasia Klimchuk has uploaded a new patch set (#4) to the change originally created by Edward O'Callaghan. ( https://review.coreboot.org/c/flashrom/+/65237?usp=email ) Change subject: amd_spi.c: Everything after rev 0x4a is a SPI100 ctrl ...................................................................... amd_spi.c: Everything after rev 0x4a is a SPI100 ctrl Technically `CHIPSET_YANGTZE` and `CHIPSET_PROMONTORY` should be combined. However just deal with Promontory here. BUG=b:228502547 https://ticket.coreboot.org/issues/370 Change-Id: Id1c526e04ef4cf1f9a036328cbfb0d14ec310116 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M amd_spi.c 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/65237/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/65237?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id1c526e04ef4cf1f9a036328cbfb0d14ec310116 Gerrit-Change-Number: 65237 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[main]: tree: Update 'sb600' references to 'amd'
by Anastasia Klimchuk (Code Review) 08 Dec '23

08 Dec '23

Attention is currently required from: Anastasia Klimchuk, Martin L Roth, Thomas Heijligen. Anastasia Klimchuk has uploaded a new patch set (#2) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/flashrom/+/74953?usp=email ) Change subject: tree: Update 'sb600' references to 'amd' ...................................................................... tree: Update 'sb600' references to 'amd' This goes along with renaming the sb600 file to better reflect the current situation with AMD chipsets and SoCs. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I1200ef25b6765f809c754ae0adcdcfe680c202fd Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M amd_spi.c M chipset_enable.c M doc/classic_cli_manpage.rst M include/programmer.h 4 files changed, 90 insertions(+), 90 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/74953/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/74953?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I1200ef25b6765f809c754ae0adcdcfe680c202fd Gerrit-Change-Number: 74953 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[main]: tree: rename sb600spi.c to amd_spi.c
by Anastasia Klimchuk (Code Review) 08 Dec '23

08 Dec '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Arthur Heymans, Martin L Roth, Martin Roth, Nico Huber, Thomas Heijligen. Anastasia Klimchuk has uploaded a new patch set (#2) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/flashrom/+/74952?usp=email ) Change subject: tree: rename sb600spi.c to amd_spi.c ...................................................................... tree: rename sb600spi.c to amd_spi.c The modern AMD platforms all use the code in sb600spi.c, but no longer have any relationship to that name. This makes the name more generic and easier to figure out what's in the file from the name. Change-Id: I13859de27e602cc6496684e6cb66b2dc2e21531a Signed-off-by: Martin Roth <gaumless(a)gmail.com> Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M MAINTAINERS M Makefile R amd_spi.c M include/programmer.h M meson.build 5 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/74952/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/74952?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13859de27e602cc6496684e6cb66b2dc2e21531a Gerrit-Change-Number: 74952 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[main]: flashrom_tester: Fix partial_lock_test on libflashrom
by David Wu (Code Review) 08 Dec '23

08 Dec '23

Attention is currently required from: Edward O'Callaghan, Evan Benn, Hsuan-ting Chen. David Wu has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79304?usp=email ) Change subject: flashrom_tester: Fix partial_lock_test on libflashrom ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/79304?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7a8ac0c0984fef3cd9e73ed8d8097ddf429e54b2 Gerrit-Change-Number: 79304 Gerrit-PatchSet: 2 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Evan Benn <evanbenn(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-CC: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Evan Benn <evanbenn(a)gmail.com> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Fri, 08 Dec 2023 04:51:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: flashrom_tester: Drop technical debt
by David Wu (Code Review) 08 Dec '23

08 Dec '23

Attention is currently required from: Edward O'Callaghan, Hsuan Ting Chen, Hsuan-ting Chen. David Wu has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79303?usp=email ) Change subject: flashrom_tester: Drop technical debt ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/79303?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I1ea174c1760fee3e41a2ef0e9779badf0c51298d Gerrit-Change-Number: 79303 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Evan Benn <evanbenn(a)gmail.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Fri, 08 Dec 2023 04:51:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: meson/: Add missing config for NI845_SPI drv
by Anastasia Klimchuk (Code Review) 08 Dec '23

08 Dec '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/54849?usp=email ) Change subject: meson/: Add missing config for NI845_SPI drv ...................................................................... Abandoned done in CB:75236 -- To view, visit https://review.coreboot.org/c/flashrom/+/54849?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I85387e94f1b159733d0124f1a6dfde1e3d16827f Gerrit-Change-Number: 54849 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: it85spi.c: Kill off dead code system() hack
by Edward O'Callaghan (Code Review) 08 Dec '23

08 Dec '23

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46547 ) Change subject: it85spi.c: Kill off dead code system() hack ...................................................................... it85spi.c: Kill off dead code system() hack This is dead code sitting under a 'if 0' and is extremely hacky. One could argue this patch perhaps should include a update to documentation to stop powerd instead of keeping this rot around? BUG=none BRANCH=none TEST=builds Change-Id: I5761dea48d553b1334eef3c9cf0ad79cedbd7806 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M it85spi.c 1 file changed, 0 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/46547/1 diff --git a/it85spi.c b/it85spi.c index b998790..1d93a5b 100644 --- a/it85spi.c +++ b/it85spi.c @@ -114,15 +114,6 @@ if (it85xx_scratch_rom_reenter > 0) return; -#if 0 - /* FIXME: this a workaround for the bug that SMBus signal would - * interfere the EC firmware update. Should be removed if - * we find out the root cause. */ - ret = system("stop powerd >&2"); - if (ret) - msg_perr("Cannot stop powerd.\n"); -#endif - for (tries = 0; tries < MAX_TRY; ++tries) { /* Wait until IBF (input buffer) is not full. */ if (wait_for(KB_IBF, 0, MAX_TIMEOUT, @@ -165,9 +156,6 @@ static void it85xx_exit_scratch_rom(void) { -#if 0 - int ret; -#endif int tries; msg_pdbg("%s():%d was called ...\n", __func__, __LINE__); @@ -204,15 +192,6 @@ } else { msg_perr("%s():%d * Max try reached.\n", __func__, __LINE__); } - -#if 0 - /* FIXME: this a workaround for the bug that SMBus signal would - * interfere the EC firmware update. Should be removed if - * we find out the root cause. */ - ret = system("start powerd >&2"); - if (ret) - msg_perr("Cannot start powerd again.\n"); -#endif } static int it85xx_shutdown(void *data) -- To view, visit https://review.coreboot.org/c/flashrom/+/46547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5761dea48d553b1334eef3c9cf0ad79cedbd7806 Gerrit-Change-Number: 46547 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

4 8

[M] Change in flashrom[main]: dmi: Scan in sysfs first
by Anastasia Klimchuk (Code Review) 08 Dec '23

08 Dec '23

Attention is currently required from: Patrick Rudolph. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78302?usp=email ) Change subject: dmi: Scan in sysfs first ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/78302/comment/c6c8c767_22307b27 : PS2, Line 12: Needs tests on internal programmer A comment, not to forget this File dmi.c: https://review.coreboot.org/c/flashrom/+/78302/comment/1669a484_c6a6b539 : PS2, Line 48: #define LINUX_DMI_SYSFS_TABLE_3 "/sys/firmware/dmi/entries/3-0/raw" Can this also go under `#if !IS_WINDOWS` ? https://review.coreboot.org/c/flashrom/+/78302/comment/59d3f2a0_13640934 : PS2, Line 448: #if !IS_WINDOWS Maybe you can create a function which checks `#if !IS_WINDOWS` inside, and does nothing for windows case? And here you can call it. For example `scan_dmi_table`, or some other name. That would be less of pre-processor instructions. -- To view, visit https://review.coreboot.org/c/flashrom/+/78302?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0d0f461b64a6f6ed6c1a3a62d759b9c395ad0ec8 Gerrit-Change-Number: 78302 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Comment-Date: Fri, 08 Dec 2023 01:29:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: erasure_layout: Remove redundant `verify_range` call from `erase_write`
by Anastasia Klimchuk (Code Review) 08 Dec '23

08 Dec '23

Attention is currently required from: Aarya, Carly Zlabek, Vincent Fazio. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79354?usp=email ) Change subject: erasure_layout: Remove redundant `verify_range` call from `erase_write` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > In order to keep the code consistent, I think we can drop #2 […] That's a good observation about using `get_flash_region` with potential shorter end range. I will look closer into this. There is `check_for_unwritable_regions` earlier, however inside it calls `get_flash_region` as well, so same question applies. I made a note, I will look into this later. Thank you for your observations! This is really useful. -- To view, visit https://review.coreboot.org/c/flashrom/+/79354?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I638835facd9311979c4991cc4ca41a4b9e174bd5 Gerrit-Change-Number: 79354 Gerrit-PatchSet: 1 Gerrit-Owner: Carly Zlabek <carlyzlabek(a)gmail.com> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Vincent Fazio <vfazio(a)gmail.com> Gerrit-Attention: Carly Zlabek <carlyzlabek(a)gmail.com> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Vincent Fazio <vfazio(a)gmail.com> Gerrit-Comment-Date: Fri, 08 Dec 2023 01:01:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Vincent Fazio <vfazio(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: buspirate_spi: add support for hiz output with pullups=off
by David Reguera Garcia (Code Review) 07 Dec '23

07 Dec '23

Attention is currently required from: Thomas Heijligen. David Reguera Garcia has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79299?usp=email ) Change subject: buspirate_spi: add support for hiz output with pullups=off ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: > Thank you David for your patience, all looks good. Thank you for your patience; I'm a bit of a mess with these things. -- To view, visit https://review.coreboot.org/c/flashrom/+/79299?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I6d9909b23782ef3fcb1428fd127dae0d6b211855 Gerrit-Change-Number: 79299 Gerrit-PatchSet: 11 Gerrit-Owner: David Reguera Garcia <dreg(a)rootkit.es> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia <dreg(a)rootkit.es> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Thu, 07 Dec 2023 04:03:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit December 2023