[M] Change in flashrom[main]: dmi: Scan in sysfs first

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Patrick Rudolph.

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78302?usp=email )

Change subject: dmi: Scan in sysfs first
......................................................................


Patch Set 2:

(3 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/78302/comment/c6c8c767_22307b27 :
PS2, Line 12: Needs tests on internal programmer
A comment, not to forget this


File dmi.c:

https://review.coreboot.org/c/flashrom/+/78302/comment/1669a484_c6a6b539 :
PS2, Line 48: #define LINUX_DMI_SYSFS_TABLE_3		"/sys/firmware/dmi/entries/3-0/raw"
Can this also go under `#if !IS_WINDOWS` ?


https://review.coreboot.org/c/flashrom/+/78302/comment/59d3f2a0_13640934 :
PS2, Line 448: #if !IS_WINDOWS
Maybe you can create a function which checks `#if !IS_WINDOWS` inside, and does nothing for windows case? And here you can call it. For example `scan_dmi_table`, or some other name.
That would be less of pre-processor instructions.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/78302?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I0d0f461b64a6f6ed6c1a3a62d759b9c395ad0ec8
Gerrit-Change-Number: 78302
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Patrick Rudolph <[e-mail]>
Gerrit-Attention: Patrick Rudolph <[e-mail]>
Gerrit-Comment-Date: Fri, 08 Dec 2023 01:29:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment