Attention is currently required from: David Reguera Garcia, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79299?usp=email )
Change subject: buspirate_spi: Add support for hiz output with pullups=off
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
David, thank you for the patch! I have a question.
I read the commit message, which is explaining everything really well. It seems like having `pullups=on` and `hiz=on` at the same time is potentially error prone (human error as you said). Maybe we should restrict having these both params on? What could be the use case to have them both on?
--
To view, visit https://review.coreboot.org/c/flashrom/+/79299?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I6d9909b23782ef3fcb1428fd127dae0d6b211855
Gerrit-Change-Number: 79299
Gerrit-PatchSet: 6
Gerrit-Owner: David Reguera Garcia <dreg(a)rootkit.es>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: David Reguera Garcia <dreg(a)rootkit.es>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: David Reguera Garcia <dreg(a)rootkit.es>
Gerrit-Comment-Date: Fri, 01 Dec 2023 10:05:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hsuan-ting Chen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79319?usp=email )
Change subject: MAINTAINERS: Add roccochen as supporter for flashrom_tester
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/79319/comment/496395fe_c957079a :
PS1, Line 7: as supporter
remove "as supporter"
https://review.coreboot.org/c/flashrom/+/79319/comment/f07127a7_830a570c :
PS1, Line 7: roccochen
replace with: Hsuan-Ting Chen
We use full names for commit titles in this file, so that it's easier to read commit history without looking into commit description.
Patchset:
PS1:
Thank you Hsuan-Ting, and welcome to maintainers!
Also have a read on Team page (if you haven't done this already)
https://www.flashrom.org/about_flashrom/team.html
especially the intro which applies to everyone and the section about "flashrom reviewers" group.
File MAINTAINERS:
https://review.coreboot.org/c/flashrom/+/79319/comment/36ada540_0cc358f1 :
PS1, Line 199: M: Hsuan-ting Chen <roccochen(a)google.com>
Put this line above previous, `M` entries come before `R` entries. `M` entry means stronger commitment: you subscribe to all code reviews for your area (which is flashrom_tester in this case), `R` entry means you are CCed to patches.
--
To view, visit https://review.coreboot.org/c/flashrom/+/79319?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I71139401b5f2c7c1b4e76ba67ff774e030a343aa
Gerrit-Change-Number: 79319
Gerrit-PatchSet: 1
Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Evan Benn <evanbenn(a)gmail.com>
Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Comment-Date: Fri, 01 Dec 2023 08:30:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Aarya, Carly Zlabek, Vincent Fazio.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79354?usp=email )
Change subject: erasure_layout: Remove redundant `verify_range` call from `erase_write`
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Carly, thank you so much for the patch! You are right, there is a redundant verification. Which is partially my mistake, because I removed redundant erase earlier (in CB:77747 ) and forgot to remove the correspondent redundant verification.
Your idea is very good, but I think we need to remove a different verification instead, the one which corresponds to erase invocation removed in CB:77747. Which is in this Patchset 1 lines #353-359.
Just to be clear: I think to remove lines #353-359 *instead*, so return back lines #388-394.
It should have the same effect: one less verification, but logically removing the "orphaned" verification, and keep the one which follows the write.
Would it be possible for you to re-run the test 3. with this?
Thank you!
PS1:
> Testing Summary: […]
This is great, I really appreciate detailed testing info.
--
To view, visit https://review.coreboot.org/c/flashrom/+/79354?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I638835facd9311979c4991cc4ca41a4b9e174bd5
Gerrit-Change-Number: 79354
Gerrit-PatchSet: 1
Gerrit-Owner: Carly Zlabek <carlyzlabek(a)gmail.com>
Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Vincent Fazio <vfazio(a)gmail.com>
Gerrit-Attention: Carly Zlabek <carlyzlabek(a)gmail.com>
Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Attention: Vincent Fazio <vfazio(a)gmail.com>
Gerrit-Comment-Date: Fri, 01 Dec 2023 08:16:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Carly Zlabek <carlyzlabek(a)gmail.com>
Gerrit-MessageType: comment