Attention is currently required from: Nico Huber, Edward O'Callaghan.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67004 )
Change subject: Use chipsize_t (uint32_t) for all range types
......................................................................
Patch Set 3:
(2 comments)
This change is ready for review.
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/67004/comment/08067e28_39fd805d
PS3, Line 852: const chipsize_t region_start = entry->start;
I removed chipoff_t during this migration, as I did not understand the use case for having two types. I think they would never be different sizes. Maybe it was for documentation?
File util/flashrom_tester/flashrom/src/flashromlib.rs:
https://review.coreboot.org/c/flashrom/+/67004/comment/220653b8_a71c532c
PS3, Line 124: let libflashrom::Range { start, end } = layout.get_region_range(region)?;
having the rust API return u32 makes this code much more ugly. But it does mean pushing error handling to the user which allows them to make the appropriate choice.
--
To view, visit https://review.coreboot.org/c/flashrom/+/67004
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I31348806b7ea92a6ea8391a735f722a63aa7e488
Gerrit-Change-Number: 67004
Gerrit-PatchSet: 3
Gerrit-Owner: Evan Benn <evanbenn(a)google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Wed, 07 Sep 2022 04:59:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67391 )
Change subject: drivers/: Make 'internal_delay' the default unless defined
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/flashrom/+/67391
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I17460bc2c0aebcbb48c8dfa052b260991525cc49
Gerrit-Change-Number: 67391
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 04:34:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66875 )
Change subject: pony_spi.c: Retype appropriate variables with bool
......................................................................
Patch Set 15: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/66875
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iecd98c391a74794647caeeb2715707ccd681463c
Gerrit-Change-Number: 66875
Gerrit-PatchSet: 15
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Wed, 07 Sep 2022 04:31:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66870 )
Change subject: internal.c: Retype appropriate variables with bool
......................................................................
Patch Set 13: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/66870
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I159d789112d7a778744b59b45133df3928b8445e
Gerrit-Change-Number: 66870
Gerrit-PatchSet: 13
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Wed, 07 Sep 2022 04:27:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Hello build bot (Jenkins), Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/66903
to look at the new patch set (#16).
Change subject: dmi.c: Retype variable `anchored` with bool
......................................................................
dmi.c: Retype variable `anchored` with bool
Use the bool type instead of an integer for the variable `anchored`,
since this represents its purpose much better.
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I5bedaf47cdd2fd5d152f69b6b02aab69fd1285c6
---
M dmi.c
1 file changed, 17 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/66903/16
--
To view, visit https://review.coreboot.org/c/flashrom/+/66903
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5bedaf47cdd2fd5d152f69b6b02aab69fd1285c6
Gerrit-Change-Number: 66903
Gerrit-PatchSet: 16
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer.
Hello build bot (Jenkins), Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/66901
to look at the new patch set (#14).
Change subject: dummyflasher.c: Retype appropriate variables and attributes with bool
......................................................................
dummyflasher.c: Retype appropriate variables and attributes with bool
Use the bool type instead of an integer for appropriate variables and
attributes, since this represents their purpose much better.
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I712b1ef7e1ad74d3e004dcf36c82898c88072c63
---
M dummyflasher.c
1 file changed, 25 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/66901/14
--
To view, visit https://review.coreboot.org/c/flashrom/+/66901
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I712b1ef7e1ad74d3e004dcf36c82898c88072c63
Gerrit-Change-Number: 66901
Gerrit-PatchSet: 14
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer.
Hello build bot (Jenkins), Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/66900
to look at the new patch set (#14).
Change subject: it87spi.c: Retype attribute `fast_spi` with bool
......................................................................
it87spi.c: Retype attribute `fast_spi` with bool
Use the bool type instead of an integer for the attribute `fast_spi`,
since this represents its purpose much better.
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: Id28c2c9043dda7a400b8c4e9ca218cb445e97d24
---
M it87spi.c
1 file changed, 17 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/66900/14
--
To view, visit https://review.coreboot.org/c/flashrom/+/66900
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id28c2c9043dda7a400b8c4e9ca218cb445e97d24
Gerrit-Change-Number: 66900
Gerrit-PatchSet: 14
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer.
Hello build bot (Jenkins), Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/66899
to look at the new patch set (#14).
Change subject: ich_descriptors.c: Retype variable `has_forbidden_opcode` with bool
......................................................................
ich_descriptors.c: Retype variable `has_forbidden_opcode` with bool
Use the bool type instead of an integer for the variable
`has_forbidden_opcode`, since this represents its purpose much better.
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I6214956e377547b894fc76237832b6f7b2db41dd
---
M ich_descriptors.c
1 file changed, 17 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/66899/14
--
To view, visit https://review.coreboot.org/c/flashrom/+/66899
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6214956e377547b894fc76237832b6f7b2db41dd
Gerrit-Change-Number: 66899
Gerrit-PatchSet: 14
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer.
Hello build bot (Jenkins), Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/66896
to look at the new patch set (#14).
Change subject: fmap.c: Retype appropriate variables with bool
......................................................................
fmap.c: Retype appropriate variables with bool
Use the bool type instead of an integer for appropriate variables, since
this represents their purpose much better.
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I323d40cabe9c580057d870e742b3b55942c78321
---
M fmap.c
1 file changed, 21 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/66896/14
--
To view, visit https://review.coreboot.org/c/flashrom/+/66896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I323d40cabe9c580057d870e742b3b55942c78321
Gerrit-Change-Number: 66896
Gerrit-PatchSet: 14
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer.
Hello build bot (Jenkins), Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/66895
to look at the new patch set (#14).
Change subject: ft2232_spi.c: Retype variable `clock_5x` with bool
......................................................................
ft2232_spi.c: Retype variable `clock_5x` with bool
Use the bool type instead of an integer for the variable `clock_5x`,
since this represents its purpose much better.
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: Ie3005f9dcb2dcfe63261c52a36d865d175a0a75c
---
M ft2232_spi.c
1 file changed, 16 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/66895/14
--
To view, visit https://review.coreboot.org/c/flashrom/+/66895
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie3005f9dcb2dcfe63261c52a36d865d175a0a75c
Gerrit-Change-Number: 66895
Gerrit-PatchSet: 14
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newpatchset