September 2022 - flashrom-gerrit

[S] Change in flashrom[master]: ichspi.c: Retype appropriate variables with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Nico Huber, Angel Pons. Hello build bot (Jenkins), Nico Huber, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66892 to look at the new patch set (#12). Change subject: ichspi.c: Retype appropriate variables with bool ...................................................................... ichspi.c: Retype appropriate variables with bool Use the bool type instead of an integer for appropriate variables, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: If7eeacc44921f52aa593ab1302f17a5c5190f830 --- M ichspi.c 1 file changed, 24 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/66892/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/66892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If7eeacc44921f52aa593ab1302f17a5c5190f830 Gerrit-Change-Number: 66892 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: tree: Retype variable `programmer_may_write` with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66885 to look at the new patch set (#13). Change subject: tree: Retype variable `programmer_may_write` with bool ...................................................................... tree: Retype variable `programmer_may_write` with bool Use the bool type instead of an integer for the variable `programmer_may_write`, since this represents its purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I69958527ae018a92f1c42734a7990d0c532dee0c --- M chipset_enable.c M flashrom.c M gfxnvidia.c M include/programmer.h M sb600spi.c 5 files changed, 22 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/66885/13 -- To view, visit https://review.coreboot.org/c/flashrom/+/66885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I69958527ae018a92f1c42734a7990d0c532dee0c Gerrit-Change-Number: 66885 Gerrit-PatchSet: 13 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashrom.c: Retype appropriate variables with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer, Thomas Heijligen. Hello build bot (Jenkins), Thomas Heijligen, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66883 to look at the new patch set (#11). Change subject: flashrom.c: Retype appropriate variables with bool ...................................................................... flashrom.c: Retype appropriate variables with bool Use the bool type instead of an integer for appropriate variables, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I6629f391284c8f1266e4ba66c9976f3df43955d4 --- M flashrom.c 1 file changed, 19 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/66883/11 -- To view, visit https://review.coreboot.org/c/flashrom/+/66883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6629f391284c8f1266e4ba66c9976f3df43955d4 Gerrit-Change-Number: 66883 Gerrit-PatchSet: 11 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: linux_mtd.c: Retype appropriate attributes with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Nikolai Artemiev. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66881 to look at the new patch set (#11). Change subject: linux_mtd.c: Retype appropriate attributes with bool ...................................................................... linux_mtd.c: Retype appropriate attributes with bool Use the bool type instead of an integer for appropriate attributes, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I8be4e08e714047d155dcc032cc3d8dabb422b27f --- M linux_mtd.c 1 file changed, 18 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/66881/11 -- To view, visit https://review.coreboot.org/c/flashrom/+/66881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8be4e08e714047d155dcc032cc3d8dabb422b27f Gerrit-Change-Number: 66881 Gerrit-PatchSet: 11 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: 82802ab.c: Retype appropriate variables with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66879 to look at the new patch set (#11). Change subject: 82802ab.c: Retype appropriate variables with bool ...................................................................... 82802ab.c: Retype appropriate variables with bool Use the bool type instead of an integer for appropriate variables, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I5dfd9ed4856c37dd70706b2dd71fbb9a8acbdf4c --- M 82802ab.c 1 file changed, 21 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/66879/11 -- To view, visit https://review.coreboot.org/c/flashrom/+/66879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5dfd9ed4856c37dd70706b2dd71fbb9a8acbdf4c Gerrit-Change-Number: 66879 Gerrit-PatchSet: 11 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: serprog.c: Retype variable `have_device` with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer, Angel Pons. Hello build bot (Jenkins), Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66878 to look at the new patch set (#16). Change subject: serprog.c: Retype variable `have_device` with bool ...................................................................... serprog.c: Retype variable `have_device` with bool Use the bool type instead of an integer for the variable `have_device`, since this represents its purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Ia12f1503ae3f7be20a065f22b4ab84c4140cd23e --- M serprog.c 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/66878/16 -- To view, visit https://review.coreboot.org/c/flashrom/+/66878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia12f1503ae3f7be20a065f22b4ab84c4140cd23e Gerrit-Change-Number: 66878 Gerrit-PatchSet: 16 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: raiden_debug_spi.c: Retype variable `found` with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer, Edward O'Callaghan. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66877 to look at the new patch set (#16). Change subject: raiden_debug_spi.c: Retype variable `found` with bool ...................................................................... raiden_debug_spi.c: Retype variable `found` with bool Use the bool type instead of an integer for the variable `found`, since this represents its purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I18c69e678017a9c0655a31c0487fd1fb0d85ecf2 --- M raiden_debug_spi.c 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/77/66877/16 -- To view, visit https://review.coreboot.org/c/flashrom/+/66877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I18c69e678017a9c0655a31c0487fd1fb0d85ecf2 Gerrit-Change-Number: 66877 Gerrit-PatchSet: 16 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: pony_spi.c: Retype appropriate variables with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66875 to look at the new patch set (#15). Change subject: pony_spi.c: Retype appropriate variables with bool ...................................................................... pony_spi.c: Retype appropriate variables with bool Use the bool type instead of an integer for appropriate variables and attributes, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Iecd98c391a74794647caeeb2715707ccd681463c --- M pony_spi.c 1 file changed, 42 insertions(+), 28 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/66875/15 -- To view, visit https://review.coreboot.org/c/flashrom/+/66875 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iecd98c391a74794647caeeb2715707ccd681463c Gerrit-Change-Number: 66875 Gerrit-PatchSet: 15 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: mstarddc_spi.c: Retype appropriate variables with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer, Edward O'Callaghan. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66874 to look at the new patch set (#14). Change subject: mstarddc_spi.c: Retype appropriate variables with bool ...................................................................... mstarddc_spi.c: Retype appropriate variables with bool Use the bool type instead of an integer for appropriate variables, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I3a72a0877b47f67f8984c28cbf5b5d429ec1534e --- M mstarddc_spi.c 1 file changed, 19 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/66874/14 -- To view, visit https://review.coreboot.org/c/flashrom/+/66874 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3a72a0877b47f67f8984c28cbf5b5d429ec1534e Gerrit-Change-Number: 66874 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: internal.c: Retype appropriate variables with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66870 to look at the new patch set (#13). Change subject: internal.c: Retype appropriate variables with bool ...................................................................... internal.c: Retype appropriate variables with bool Use the bool type instead of an integer for the variables `force_laptop`, `not_a_laptop`, `force_boardenable` and `force_boardmismatch` since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I159d789112d7a778744b59b45133df3928b8445e --- M include/programmer.h M internal.c 2 files changed, 30 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/66870/13 -- To view, visit https://review.coreboot.org/c/flashrom/+/66870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I159d789112d7a778744b59b45133df3928b8445e Gerrit-Change-Number: 66870 Gerrit-PatchSet: 13 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022