September 2022 - flashrom-gerrit

[S] Change in flashrom[master]: flashrom.c: Retype appropriate variables with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer, Thomas Heijligen. Hello build bot (Jenkins), Thomas Heijligen, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66883 to look at the new patch set (#12). Change subject: flashrom.c: Retype appropriate variables with bool ...................................................................... flashrom.c: Retype appropriate variables with bool Use the bool type instead of an integer for appropriate variables, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I6629f391284c8f1266e4ba66c9976f3df43955d4 --- M flashrom.c 1 file changed, 19 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/66883/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/66883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6629f391284c8f1266e4ba66c9976f3df43955d4 Gerrit-Change-Number: 66883 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: linux_mtd.c: Retype appropriate attributes with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Nikolai Artemiev. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66881 to look at the new patch set (#12). Change subject: linux_mtd.c: Retype appropriate attributes with bool ...................................................................... linux_mtd.c: Retype appropriate attributes with bool Use the bool type instead of an integer for appropriate attributes, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I8be4e08e714047d155dcc032cc3d8dabb422b27f --- M linux_mtd.c 1 file changed, 18 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/66881/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/66881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8be4e08e714047d155dcc032cc3d8dabb422b27f Gerrit-Change-Number: 66881 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: dmi.c: Retype variable `anchored` with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66903 to look at the new patch set (#14). Change subject: dmi.c: Retype variable `anchored` with bool ...................................................................... dmi.c: Retype variable `anchored` with bool Use the bool type instead of an integer for the variable `anchored`, since this represents the purpose of it much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I5bedaf47cdd2fd5d152f69b6b02aab69fd1285c6 --- M dmi.c 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/66903/14 -- To view, visit https://review.coreboot.org/c/flashrom/+/66903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5bedaf47cdd2fd5d152f69b6b02aab69fd1285c6 Gerrit-Change-Number: 66903 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: dummyflasher.c: Retype appropriate variables and attributes with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66901 to look at the new patch set (#12). Change subject: dummyflasher.c: Retype appropriate variables and attributes with bool ...................................................................... dummyflasher.c: Retype appropriate variables and attributes with bool Use the bool type instead of an integer for appropriate variables and attributes, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I712b1ef7e1ad74d3e004dcf36c82898c88072c63 --- M dummyflasher.c 1 file changed, 25 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/66901/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/66901 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I712b1ef7e1ad74d3e004dcf36c82898c88072c63 Gerrit-Change-Number: 66901 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: it87spi.c: Retype attribute `fast_spi` with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66900 to look at the new patch set (#12). Change subject: it87spi.c: Retype attribute `fast_spi` with bool ...................................................................... it87spi.c: Retype attribute `fast_spi` with bool Use the bool type instead of an integer for the attribute `fast_spi`, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Id28c2c9043dda7a400b8c4e9ca218cb445e97d24 --- M it87spi.c 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/66900/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/66900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id28c2c9043dda7a400b8c4e9ca218cb445e97d24 Gerrit-Change-Number: 66900 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: ich_descriptors.c: Retype variable `has_forbidden_opcode` with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66899 to look at the new patch set (#12). Change subject: ich_descriptors.c: Retype variable `has_forbidden_opcode` with bool ...................................................................... ich_descriptors.c: Retype variable `has_forbidden_opcode` with bool Use the bool type instead of an integer for the variable `has_forbidden_opcode`, since this represents its purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I6214956e377547b894fc76237832b6f7b2db41dd --- M ich_descriptors.c 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/66899/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/66899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6214956e377547b894fc76237832b6f7b2db41dd Gerrit-Change-Number: 66899 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: fmap.c: Retype appropriate variables with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66896 to look at the new patch set (#12). Change subject: fmap.c: Retype appropriate variables with bool ...................................................................... fmap.c: Retype appropriate variables with bool Use the bool type instead of an integer for appropriate variables, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I323d40cabe9c580057d870e742b3b55942c78321 --- M fmap.c 1 file changed, 21 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/66896/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/66896 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I323d40cabe9c580057d870e742b3b55942c78321 Gerrit-Change-Number: 66896 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: ft2232_spi.c: Retype variable `clock_5x` with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66895 to look at the new patch set (#12). Change subject: ft2232_spi.c: Retype variable `clock_5x` with bool ...................................................................... ft2232_spi.c: Retype variable `clock_5x` with bool Use the bool type instead of an integer for the variable `clock_5x`, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Ie3005f9dcb2dcfe63261c52a36d865d175a0a75c --- M ft2232_spi.c 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/66895/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/66895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie3005f9dcb2dcfe63261c52a36d865d175a0a75c Gerrit-Change-Number: 66895 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: spi25.c: Retype appropriate variables with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66890 to look at the new patch set (#12). Change subject: spi25.c: Retype appropriate variables with bool ...................................................................... spi25.c: Retype appropriate variables with bool Use the bool type instead of an integer for appropriate variables, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Icd7e6478848c6f72817da16a5350d450bcc0bb5d --- M spi25.c 1 file changed, 18 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/66890/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/66890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icd7e6478848c6f72817da16a5350d450bcc0bb5d Gerrit-Change-Number: 66890 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: tree: Retype variable `laptop_ok` with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66891 to look at the new patch set (#12). Change subject: tree: Retype variable `laptop_ok` with bool ...................................................................... tree: Retype variable `laptop_ok` with bool Use the bool type instead of an integer for the variable `laptop_ok`, since this represents its purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I5d9fc3516bc2d29f11b056e35b3e5e324ce93423 --- M board_enable.c M chipset_enable.c M include/programmer.h M internal.c 4 files changed, 21 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/66891/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/66891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5d9fc3516bc2d29f11b056e35b3e5e324ce93423 Gerrit-Change-Number: 66891 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022