September 2022 - flashrom-gerrit

[S] Change in flashrom[master]: dummyflasher.c: Retype appropriate variables and attributes with bool
by Angel Pons (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66901 ) Change subject: dummyflasher.c: Retype appropriate variables and attributes with bool ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/66901 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I712b1ef7e1ad74d3e004dcf36c82898c88072c63 Gerrit-Change-Number: 66901 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 07 Sep 2022 10:57:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: it87spi.c: Retype attribute `fast_spi` with bool
by Angel Pons (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66900 ) Change subject: it87spi.c: Retype attribute `fast_spi` with bool ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/66900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id28c2c9043dda7a400b8c4e9ca218cb445e97d24 Gerrit-Change-Number: 66900 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 07 Sep 2022 10:57:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: ich_descriptors.c: Retype variable `has_forbidden_opcode` with bool
by Angel Pons (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66899 ) Change subject: ich_descriptors.c: Retype variable `has_forbidden_opcode` with bool ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/66899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6214956e377547b894fc76237832b6f7b2db41dd Gerrit-Change-Number: 66899 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 07 Sep 2022 10:55:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: fmap.c: Retype appropriate variables with bool
by Angel Pons (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66896 ) Change subject: fmap.c: Retype appropriate variables with bool ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/66896 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I323d40cabe9c580057d870e742b3b55942c78321 Gerrit-Change-Number: 66896 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 07 Sep 2022 10:55:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: ft2232_spi.c: Retype variable `clock_5x` with bool
by Angel Pons (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66895 ) Change subject: ft2232_spi.c: Retype variable `clock_5x` with bool ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/66895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie3005f9dcb2dcfe63261c52a36d865d175a0a75c Gerrit-Change-Number: 66895 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 07 Sep 2022 10:55:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: spi25.c: Retype appropriate variables with bool
by Angel Pons (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66890 ) Change subject: spi25.c: Retype appropriate variables with bool ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/66890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icd7e6478848c6f72817da16a5350d450bcc0bb5d Gerrit-Change-Number: 66890 Gerrit-PatchSet: 13 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 07 Sep 2022 10:54:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: tree: Retype variable `laptop_ok` with bool
by Angel Pons (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66891 ) Change subject: tree: Retype variable `laptop_ok` with bool ...................................................................... Patch Set 13: Code-Review+2 (1 comment) File board_enable.c: https://review.coreboot.org/c/flashrom/+/66891/comment/b732dec0_6f6170ff PS13, Line 2295: is_laptop = 1; For another patch: please consider turning `is_laptop` into an enum. -- To view, visit https://review.coreboot.org/c/flashrom/+/66891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5d9fc3516bc2d29f11b056e35b3e5e324ce93423 Gerrit-Change-Number: 66891 Gerrit-PatchSet: 13 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 07 Sep 2022 10:28:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom.c: Retype appropriate variables with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Thomas Heijligen. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66883 ) Change subject: flashrom.c: Retype appropriate variables with bool ...................................................................... Patch Set 12: (1 comment) File flashrom.c: https://review.coreboot.org/c/flashrom/+/66883/comment/990219eb_3e2c7646 PS12, Line 151: programmer_may_write = 1; Right, I have done it in a follow up since multiple files need to be adjusted and so the commit title can't just be like > flashrom.c: retype some variables It would have to be something like > tree: retype some variables but this was too "much" for me and too unspecific. So I splitted up. -- To view, visit https://review.coreboot.org/c/flashrom/+/66883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6629f391284c8f1266e4ba66c9976f3df43955d4 Gerrit-Change-Number: 66883 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 07 Sep 2022 10:26:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: ichspi.c: Retype appropriate variables with bool
by Angel Pons (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66892 ) Change subject: ichspi.c: Retype appropriate variables with bool ...................................................................... Patch Set 13: Code-Review+1 (3 comments) File ichspi.c: https://review.coreboot.org/c/flashrom/+/66892/comment/d9ccfdf8_ed3736c9 PS13, Line 259: ichspi_lock Hmmm, maybe `ichspi_is_locked`? https://review.coreboot.org/c/flashrom/+/66892/comment/f9ec89fd_ecc38ca1 PS13, Line 863: write_cmd This should be renamed, `is_write_cmd` for example. https://review.coreboot.org/c/flashrom/+/66892/comment/b7bb9686_143f8943 PS13, Line 980: write_cmd Ditto, `is_write_cmd` -- To view, visit https://review.coreboot.org/c/flashrom/+/66892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If7eeacc44921f52aa593ab1302f17a5c5190f830 Gerrit-Change-Number: 66892 Gerrit-PatchSet: 13 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 07 Sep 2022 10:26:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: 82802ab.c: Retype appropriate variables with bool
by Felix Singer (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66879 ) Change subject: 82802ab.c: Retype appropriate variables with bool ...................................................................... Patch Set 11: (1 comment) File 82802ab.c: https://review.coreboot.org/c/flashrom/+/66879/comment/ead4376a_77e874af PS11, Line 25: #include <stdbool.h> > I wonder why this file doesn't include other headers like <stdint. […] Anything to do here? Or can this comment be marked as resolved? -- To view, visit https://review.coreboot.org/c/flashrom/+/66879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5dfd9ed4856c37dd70706b2dd71fbb9a8acbdf4c Gerrit-Change-Number: 66879 Gerrit-PatchSet: 11 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Sep 2022 10:21:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022