September 2022 - flashrom-gerrit

[S] Change in flashrom[master]: ichspi.c: Rename some variables
by Felix Singer (Code Review) 08 Sep '22

08 Sep '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/67431 ) Change subject: ichspi.c: Rename some variables ...................................................................... ichspi.c: Rename some variables WIP. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Icb724a58dd4a1375a2c0a660484cb646f162f5be --- M ichspi.c 1 file changed, 28 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/67431/1 diff --git a/ichspi.c b/ichspi.c index f5876b7..7ab7434 100644 --- a/ichspi.c +++ b/ichspi.c @@ -256,7 +256,7 @@ }; /* ICH SPI configuration lock-down. May be set during chipset enabling. */ -static bool ichspi_lock = false; +static bool is_ichspi_locked = false; static enum ich_chipset ich_generation = CHIPSET_ICH_UNKNOWN; static uint32_t ichspi_bbar; @@ -860,7 +860,7 @@ static int ich7_run_opcode(OPCODE op, uint32_t offset, uint8_t datalength, uint8_t * data, int maxdata) { - bool write_cmd = false; + bool is_write_cmd = false; int timeout; uint32_t temp32; uint16_t temp16; @@ -870,7 +870,7 @@ /* Is it a write command? */ if ((op.spi_type == SPI_OPCODE_TYPE_WRITE_NO_ADDRESS) || (op.spi_type == SPI_OPCODE_TYPE_WRITE_WITH_ADDRESS)) { - write_cmd = true; + is_write_cmd = true; } timeout = 100 * 60; /* 60 ms are 9.6 million cycles at 16 MHz. */ @@ -887,7 +887,7 @@ REGWRITE32(ICH7_REG_SPIA, (offset & 0x00FFFFFF) | temp32); /* Program data into SPID0 to N */ - if (write_cmd && (datalength != 0)) + if (is_write_cmd && (datalength != 0)) ich_fill_data(data, datalength, ICH7_REG_SPID0); /* Assemble SPIS */ @@ -968,7 +968,7 @@ return 1; } - if ((!write_cmd) && (datalength != 0)) + if ((!is_write_cmd) && (datalength != 0)) ich_read_data(data, datalength, ICH7_REG_SPID0); return 0; @@ -977,7 +977,7 @@ static int ich9_run_opcode(OPCODE op, uint32_t offset, uint8_t datalength, uint8_t * data) { - bool write_cmd = false; + bool is_write_cmd = false; int timeout; uint32_t temp32; uint64_t opmenu; @@ -986,7 +986,7 @@ /* Is it a write command? */ if ((op.spi_type == SPI_OPCODE_TYPE_WRITE_NO_ADDRESS) || (op.spi_type == SPI_OPCODE_TYPE_WRITE_WITH_ADDRESS)) { - write_cmd = true; + is_write_cmd = true; } timeout = 100 * 60; /* 60 ms are 9.6 million cycles at 16 MHz. */ @@ -1004,7 +1004,7 @@ REGWRITE32(ICH9_REG_FADDR, (offset & 0x00FFFFFF) | temp32); /* Program data into FDATA0 to N */ - if (write_cmd && (datalength != 0)) + if (is_write_cmd && (datalength != 0)) ich_fill_data(data, datalength, ICH9_REG_FDATA0); /* Assemble SSFS + SSFC */ @@ -1091,7 +1091,7 @@ return 1; } - if ((!write_cmd) && (datalength != 0)) + if ((!is_write_cmd) && (datalength != 0)) ich_read_data(data, datalength, ICH9_REG_FDATA0); return 0; @@ -1142,7 +1142,7 @@ /* find cmd in opcodes-table */ opcode_index = find_opcode(curopcodes, cmd); if (opcode_index == -1) { - if (!ichspi_lock) + if (!is_ichspi_locked) opcode_index = reprogram_opcode_on_the_fly(cmd, writecnt, readcnt); if (opcode_index == SPI_INVALID_LENGTH) { msg_pdbg("OPCODE 0x%02x has unsupported length, will not execute.\n", cmd); @@ -1655,7 +1655,7 @@ * during execution of the next command anyway. * No need to bother with fixups. */ - if (!ichspi_lock) { + if (!is_ichspi_locked) { oppos = reprogram_opcode_on_the_fly((cmds + 1)->writearr[0], (cmds + 1)->writecnt, (cmds + 1)->readcnt); if (oppos == -1) continue; @@ -1858,7 +1858,7 @@ } if (mmio_readw(spibar) & (1 << 15)) { msg_pwarn("WARNING: SPI Configuration Lockdown activated.\n"); - ichspi_lock = true; + is_ichspi_locked = true; } ich_init_opcodes(ich_gen); ich_set_bbar(0, ich_gen); @@ -1987,7 +1987,7 @@ prettyprint_ich9_reg_hsfs(tmp2, ich_gen); if (tmp2 & HSFS_FLOCKDN) { msg_pinfo("SPI Configuration is locked down.\n"); - ichspi_lock = true; + is_ichspi_locked = true; } if (tmp2 & HSFS_FDV) desc_valid = true; @@ -2046,7 +2046,7 @@ /* Handle PR registers */ for (i = 0; i < num_pr; i++) { /* if not locked down try to disable PR locks first */ - if (!ichspi_lock) + if (!is_ichspi_locked) ich9_set_pr(reg_pr0, i, 0, 0); ich_spi_rw_restricted |= ich9_handle_pr(reg_pr0, i); } @@ -2157,7 +2157,7 @@ } } - if (ich_spi_mode == ich_auto && ichspi_lock && + if (ich_spi_mode == ich_auto && is_ichspi_locked && ich_missing_opcodes()) { msg_pinfo("Enabling hardware sequencing because " "some important opcode is locked.\n"); @@ -2279,7 +2279,7 @@ msg_pdbg("0x6c: 0x%04x (CLOCK/DEBUG)\n", mmio_readw(ich_spibar + 0x6c)); if (mmio_readw(ich_spibar) & (1 << 15)) { msg_pwarn("Warning: SPI Configuration Lockdown activated.\n"); - ichspi_lock = true; + is_ichspi_locked = true; } ich_set_bbar(0, ich_generation); -- To view, visit https://review.coreboot.org/c/flashrom/+/67431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icb724a58dd4a1375a2c0a660484cb646f162f5be Gerrit-Change-Number: 67431 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: usb_device.c: detach/attach usb kernel driver explicitly
by Peter Marheine (Code Review) 08 Sep '22

08 Sep '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67073 ) Change subject: usb_device.c: detach/attach usb kernel driver explicitly ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/67073 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1363fea13368b7ac1e9a3829864d06d123c4e157 Gerrit-Change-Number: 67073 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Sep 2022 00:17:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: drivers/: Make 'fallback_{un}map' the default unless defined
by Peter Marheine (Code Review) 08 Sep '22

08 Sep '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67404 ) Change subject: drivers/: Make 'fallback_{un}map' the default unless defined ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/67404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5ea7bd68f7ae2cd4af9902ef07255ab6ce0bfdb3 Gerrit-Change-Number: 67404 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 08 Sep 2022 00:16:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: tree/: plumb flashctx into programmer_delay()
by Peter Marheine (Code Review) 08 Sep '22

08 Sep '22

Attention is currently required from: Felix Singer, Edward O'Callaghan. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67392 ) Change subject: tree/: plumb flashctx into programmer_delay() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/67392 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I51792168525c145092f78236265ba43acf70bfad Gerrit-Change-Number: 67392 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Sep 2022 00:15:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: tests: Add workaround to allow tests mock fileno on FreeBSD
by Peter Marheine (Code Review) 08 Sep '22

08 Sep '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67312 ) Change subject: tests: Add workaround to allow tests mock fileno on FreeBSD ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/67312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3789ea9107a4cf8033cf59bb96d3c82aa58de026 Gerrit-Change-Number: 67312 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Sep 2022 00:13:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: ichspi.c: Retype appropriate variables with bool
by Angel Pons (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66892 ) Change subject: ichspi.c: Retype appropriate variables with bool ...................................................................... Patch Set 13: (1 comment) File ichspi.c: https://review.coreboot.org/c/flashrom/+/66892/comment/b25dabc7_4b40cb49 PS7, Line 872: write_cmd = true; Thanks for your response, Nico. > > > And there is really no need to write walls of text because of this change. > > > Especially not when it's repeating generic arguments that don't even apply > > > to this case. > > > > I'm not sure if this is about my wall of text. I tried to de-escalate the situation, let me know what I could've done better. I don't mind writing walls of text, anyway. > > No, not your wall in particular. But now that I thought about it, you could > have moved the discussion elsewhere. It has nothing to do anymore with the > original comment. Having such discussions on Gerrit makes it harder to work > on Gerrit, I believe. Ack. Now that I think of it, I agree I could've moved the discussion elsewhere. The mailing list, for example? I'll keep this in mind for the future (and hope I don't need to do it). > What I meant was generally the relation of this change and the initial comment > to all the text people had to read after. This is and has for a long time been > a (maybe the) weak spot of the project: People complain that the few experienced > developers would become a bottleneck, at the same time they cause exactly that > by keeping the experienced developers busy for naught. When I start a thread, > I feel obliged to read all the following messages. Again, not pointing to any > wall of text in particular, every one of them is somehow only a consequence > of the message(s) before. It's the whole situation. I too feel the same. If I don't read all the review comments, I often end up asking about things that were discussed already. Anyway, let's not belabor the point any further. > The "Especially not[...]" part was more about the claims that anything would > have to be rebased (that doesn't) or re-tested (that most likely wasn't). Yes, I'm not sure what I wanted to say with that. -- To view, visit https://review.coreboot.org/c/flashrom/+/66892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If7eeacc44921f52aa593ab1302f17a5c5190f830 Gerrit-Change-Number: 66892 Gerrit-PatchSet: 13 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 07 Sep 2022 14:44:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom.c: Make programmer_{un}map_flash_region() static
by Angel Pons (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66677 ) Change subject: flashrom.c: Make programmer_{un}map_flash_region() static ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/66677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic02092ce23c5b3233aad38343b888e3fa7e5bcf9 Gerrit-Change-Number: 66677 Gerrit-PatchSet: 5 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 07 Sep 2022 14:08:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom.c: create is_internal_programmer() helper
by Angel Pons (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66684 ) Change subject: flashrom.c: create is_internal_programmer() helper ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/66684 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I43243b990192077583a9a3a95d35844923d9c158 Gerrit-Change-Number: 66684 Gerrit-PatchSet: 6 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 07 Sep 2022 14:07:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: ichspi.c: Retype appropriate variables with bool
by Nico Huber (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Felix Singer, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66892 ) Change subject: ichspi.c: Retype appropriate variables with bool ...................................................................... Patch Set 13: (1 comment) File ichspi.c: https://review.coreboot.org/c/flashrom/+/66892/comment/5ff42176_cd0f0e76 PS7, Line 872: write_cmd = true; > > And there is really no need to write walls of text because of this change. > > Especially not when it's repeating generic arguments that don't even apply > > to this case. > > I'm not sure if this is about my wall of text. I tried to de-escalate the situation, let me know what I could've done better. I don't mind writing walls of text, anyway. No, not your wall in particular. But now that I thought about it, you could have moved the discussion elsewhere. It has nothing to do anymore with the original comment. Having such discussions on Gerrit makes it harder to work on Gerrit, I believe. What I meant was generally the relation of this change and the initial comment to all the text people had to read after. This is and has for a long time been a (maybe the) weak spot of the project: People complain that the few experienced developers would become a bottleneck, at the same time they cause exactly that by keeping the experienced developers busy for naught. When I start a thread, I feel obliged to read all the following messages. Again, not pointing to any wall of text in particular, every one of them is somehow only a consequence of the message(s) before. It's the whole situation. The "Especially not[...]" part was more about the claims that anything would have to be rebased (that doesn't) or re-tested (that most likely wasn't). -- To view, visit https://review.coreboot.org/c/flashrom/+/66892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If7eeacc44921f52aa593ab1302f17a5c5190f830 Gerrit-Change-Number: 66892 Gerrit-PatchSet: 13 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Sep 2022 13:08:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: tests: Add workaround to allow tests mock fileno on FreeBSD
by Edward O'Callaghan (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Peter Marheine. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67312 ) Change subject: tests: Add workaround to allow tests mock fileno on FreeBSD ...................................................................... Patch Set 4: (1 comment) File tests/chip.c: https://review.coreboot.org/c/flashrom/+/67312/comment/a54d940a_4027e1b4 PS2, Line 161: __isthreaded = 0; > Okay there are three points here and at the moment I did one (in the latest PS), the other two I wou […] 2) that is correct. 3) I agree with aklm, that seems like a much more substantive change that is orthogonal to fixing the immediate issue this patch is addressing. -- To view, visit https://review.coreboot.org/c/flashrom/+/67312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3789ea9107a4cf8033cf59bb96d3c82aa58de026 Gerrit-Change-Number: 67312 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 07 Sep 2022 12:29:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022