September 2022 - flashrom-gerrit

[S] Change in flashrom[master]: 82802ab.c: Retype appropriate variables with bool
by Anastasia Klimchuk (Code Review) 08 Sep '22

08 Sep '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66879 ) Change subject: 82802ab.c: Retype appropriate variables with bool ...................................................................... 82802ab.c: Retype appropriate variables with bool Use the bool type instead of an integer for appropriate variables, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I5dfd9ed4856c37dd70706b2dd71fbb9a8acbdf4c Reviewed-on: https://review.coreboot.org/c/flashrom/+/66879 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M 82802ab.c 1 file changed, 25 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/82802ab.c b/82802ab.c index 1db69e6..0b4de49 100644 --- a/82802ab.c +++ b/82802ab.c @@ -22,6 +22,7 @@ * - Order number: 290658-004 */ +#include <stdbool.h> #include "flash.h" #include "chipdrivers.h" @@ -144,7 +145,8 @@ int unlock_28f004s5(struct flashctx *flash) { chipaddr bios = flash->virtual_memory; - uint8_t mcfg, bcfg, need_unlock = 0, can_unlock = 0; + uint8_t mcfg, bcfg; + bool need_unlock = false, can_unlock = false; unsigned int i; /* Clear status register */ @@ -160,7 +162,7 @@ msg_cdbg("locked!\n"); } else { msg_cdbg("unlocked!\n"); - can_unlock = 1; + can_unlock = true; } /* Read block lock-bits */ @@ -168,7 +170,7 @@ bcfg = chip_readb(flash, bios + i + 2); // read block lock config msg_cdbg("block lock at %06x is %slocked!\n", i, bcfg ? "" : "un"); if (bcfg) { - need_unlock = 1; + need_unlock = true; } } @@ -197,7 +199,7 @@ { chipaddr bios = flash->virtual_memory; uint8_t mcfg, bcfg; - uint8_t need_unlock = 0, can_unlock = 0; + bool need_unlock = false, can_unlock = false; unsigned int i; /* Wait if chip is busy */ @@ -213,7 +215,7 @@ msg_cdbg("locked!\n"); } else { msg_cdbg("unlocked!\n"); - can_unlock = 1; + can_unlock = true; } /* Read block lock-bits, 8 * 8 KB + 15 * 64 KB */ @@ -223,7 +225,7 @@ msg_cdbg("block lock at %06x is %slocked!\n", i, bcfg ? "" : "un"); if (bcfg) - need_unlock = 1; + need_unlock = true; } /* Reset chip */ -- To view, visit https://review.coreboot.org/c/flashrom/+/66879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5dfd9ed4856c37dd70706b2dd71fbb9a8acbdf4c Gerrit-Change-Number: 66879 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: serprog.c: Retype variable `have_device` with bool
by Anastasia Klimchuk (Code Review) 08 Sep '22

08 Sep '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66878 ) Change subject: serprog.c: Retype variable `have_device` with bool ...................................................................... serprog.c: Retype variable `have_device` with bool Use the bool type instead of an integer for the variable `have_device`, since this represents its purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Ia12f1503ae3f7be20a065f22b4ab84c4140cd23e Reviewed-on: https://review.coreboot.org/c/flashrom/+/66878 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M serprog.c 1 file changed, 21 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/serprog.c b/serprog.c index c68449a..57196a9 100644 --- a/serprog.c +++ b/serprog.c @@ -15,6 +15,7 @@ * GNU General Public License for more details. */ +#include <stdbool.h> #include <stdio.h> #if ! IS_WINDOWS /* stuff (presumably) needed for sockets only */ #include <stdlib.h> @@ -571,7 +572,7 @@ unsigned char rbuf[3]; unsigned char c; char *device; - int have_device = 0; + bool have_device = false; /* the parameter is either of format "dev=/dev/device[:baud]" or "ip=ip:port" */ device = extract_programmer_param_str(cfg, "dev"); @@ -598,7 +599,7 @@ free(device); return 1; } - have_device++; + have_device = true; } } @@ -637,7 +638,7 @@ free(device); return 1; } - have_device++; + have_device = true; } } if (device && !strlen(device)) { -- To view, visit https://review.coreboot.org/c/flashrom/+/66878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia12f1503ae3f7be20a065f22b4ab84c4140cd23e Gerrit-Change-Number: 66878 Gerrit-PatchSet: 17 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: raiden_debug_spi.c: Retype variable `found` with bool
by Anastasia Klimchuk (Code Review) 08 Sep '22

08 Sep '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66877 ) Change subject: raiden_debug_spi.c: Retype variable `found` with bool ...................................................................... raiden_debug_spi.c: Retype variable `found` with bool Use the bool type instead of an integer for the variable `found`, since this represents its purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I18c69e678017a9c0655a31c0487fd1fb0d85ecf2 Reviewed-on: https://review.coreboot.org/c/flashrom/+/66877 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M raiden_debug_spi.c 1 file changed, 21 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index 161471c..28cab06 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -343,6 +343,7 @@ #include "usb_device.h" #include <libusb.h> +#include <stdbool.h> #include <stdint.h> #include <stdio.h> #include <stdlib.h> @@ -1488,7 +1489,7 @@ char *serial = extract_programmer_param_str(cfg, "serial"); struct usb_device *current; struct usb_device *device = NULL; - int found = 0; + bool found = false; int ret; int request_enable = get_target(cfg); @@ -1535,7 +1536,7 @@ } if (!serial) { - found = 1; + found = true; goto loop_end; } else { unsigned char dev_serial[32] = { 0 }; @@ -1560,7 +1561,7 @@ } else { msg_pinfo("Raiden: Serial number %s matched device", serial); usb_device_show(" ", current); - found = 1; + found = true; } } } -- To view, visit https://review.coreboot.org/c/flashrom/+/66877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I18c69e678017a9c0655a31c0487fd1fb0d85ecf2 Gerrit-Change-Number: 66877 Gerrit-PatchSet: 17 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[master]: pony_spi.c: Retype appropriate variables with bool
by Anastasia Klimchuk (Code Review) 08 Sep '22

08 Sep '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66875 ) Change subject: pony_spi.c: Retype appropriate variables with bool ...................................................................... pony_spi.c: Retype appropriate variables with bool Use the bool type instead of an integer for appropriate variables and attributes, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Iecd98c391a74794647caeeb2715707ccd681463c Reviewed-on: https://review.coreboot.org/c/flashrom/+/66875 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M pony_spi.c 1 file changed, 46 insertions(+), 28 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/pony_spi.c b/pony_spi.c index 04c3236..ebeac94 100644 --- a/pony_spi.c +++ b/pony_spi.c @@ -36,6 +36,7 @@ * DCE >-------> DSR */ +#include <stdbool.h> #include <stdlib.h> #include <strings.h> #include <string.h> @@ -51,11 +52,11 @@ struct pony_spi_data { /* Pins for master->slave direction */ - int negate_cs; - int negate_sck; - int negate_mosi; + bool negate_cs; + bool negate_sck; + bool negate_mosi; /* Pins for slave->master direction */ - int negate_miso; + bool negate_miso; }; static void pony_bitbang_set_cs(int val, void *spi_data) @@ -120,14 +121,14 @@ return ret; } -static int get_params(const struct programmer_cfg *cfg, enum pony_type *type, int *have_device) +static int get_params(const struct programmer_cfg *cfg, enum pony_type *type, bool *have_device) { char *arg = NULL; int ret = 0; /* defaults */ *type = TYPE_SI_PROG; - *have_device = 0; + *have_device = false; /* The parameter is in format "dev=/dev/device,type=serbang" */ arg = extract_programmer_param_str(cfg, "dev"); @@ -136,7 +137,7 @@ if (sp_fd == SER_INV_FD) ret = 1; else - (*have_device)++; + *have_device = true; } free(arg); @@ -164,8 +165,8 @@ int i, data_out; enum pony_type type; const char *name; - int have_device; - int have_prog = 0; + bool have_device; + bool have_prog = false; if (get_params(cfg, &type, &have_device)) { serialport_shutdown(NULL); @@ -184,10 +185,10 @@ serialport_shutdown(NULL); return 1; } - data->negate_cs = 1; - data->negate_sck = 0; - data->negate_mosi = 0; - data->negate_miso = 0; + data->negate_cs = true; + data->negate_sck = false; + data->negate_mosi = false; + data->negate_miso = false; if (register_shutdown(pony_spi_shutdown, data) != 0) { free(data); @@ -200,25 +201,25 @@ */ switch (type) { case TYPE_AJAWE: - data->negate_cs = 1; - data->negate_sck = 1; - data->negate_mosi = 1; - data->negate_miso = 1; + data->negate_cs = true; + data->negate_sck = true; + data->negate_mosi = true; + data->negate_miso = true; name = "AJAWe"; break; case TYPE_SERBANG: - data->negate_cs = 0; - data->negate_sck = 0; - data->negate_mosi = 0; - data->negate_miso = 1; + data->negate_cs = false; + data->negate_sck = false; + data->negate_mosi = false; + data->negate_miso = true; name = "serbang"; break; default: case TYPE_SI_PROG: - data->negate_cs = 1; - data->negate_sck = 0; - data->negate_mosi = 0; - data->negate_miso = 0; + data->negate_cs = true; + data->negate_sck = false; + data->negate_mosi = false; + data->negate_miso = false; name = "SI-Prog"; break; } @@ -233,12 +234,12 @@ switch (type) { case TYPE_AJAWE: - have_prog = 1; + have_prog = true; break; case TYPE_SI_PROG: case TYPE_SERBANG: default: - have_prog = 1; + have_prog = true; /* We toggle RTS/SCK a few times and see if DSR changes too. */ for (i = 1; i <= 10; i++) { data_out = i & 1; @@ -247,7 +248,7 @@ /* If DSR does not change, we are not connected to what we think */ if (data_out != sp_get_pin(PIN_DSR)) { - have_prog = 0; + have_prog = false; break; } } -- To view, visit https://review.coreboot.org/c/flashrom/+/66875 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iecd98c391a74794647caeeb2715707ccd681463c Gerrit-Change-Number: 66875 Gerrit-PatchSet: 16 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: mstarddc_spi.c: Retype appropriate variables with bool
by Anastasia Klimchuk (Code Review) 08 Sep '22

08 Sep '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66874 ) Change subject: mstarddc_spi.c: Retype appropriate variables with bool ...................................................................... mstarddc_spi.c: Retype appropriate variables with bool Use the bool type instead of an integer for appropriate variables, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I3a72a0877b47f67f8984c28cbf5b5d429ec1534e Reviewed-on: https://review.coreboot.org/c/flashrom/+/66874 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M mstarddc_spi.c 1 file changed, 23 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/mstarddc_spi.c b/mstarddc_spi.c index ee5779c..af46b24 100644 --- a/mstarddc_spi.c +++ b/mstarddc_spi.c @@ -15,6 +15,7 @@ #include <stdio.h> #include <string.h> +#include <stdbool.h> #include <stdlib.h> #include <ctype.h> #include <sys/types.h> @@ -32,7 +33,7 @@ struct mstarddc_spi_data { int fd; int addr; - int doreset; + bool doreset; }; // MSTAR DDC Commands @@ -47,7 +48,7 @@ struct mstarddc_spi_data *mstarddc_data = data; // Reset, disables ISP mode - if (mstarddc_data->doreset == 1) { + if (mstarddc_data->doreset) { uint8_t cmd = MSTARDDC_SPI_RESET; if (write(mstarddc_data->fd, &cmd, 1) < 0) { msg_perr("Error sending reset command: errno %d.\n", @@ -129,7 +130,7 @@ /* Do not reset if something went wrong, as it might prevent from * retrying flashing. */ if (ret != 0) - mstarddc_data->doreset = 0; + mstarddc_data->doreset = false; if (cmd) free(cmd); @@ -155,7 +156,7 @@ int ret = 0; int mstarddc_fd = -1; int mstarddc_addr; - int mstarddc_doreset = 1; + bool mstarddc_doreset = true; struct mstarddc_spi_data *mstarddc_data; // Get device, address from command-line @@ -184,7 +185,7 @@ // Get noreset=1 option from command-line char *noreset = extract_programmer_param_str(cfg, "noreset"); if (noreset != NULL && noreset[0] == '1') - mstarddc_doreset = 0; + mstarddc_doreset = false; free(noreset); msg_pinfo("Info: Will %sreset the device at the end.\n", mstarddc_doreset ? "" : "NOT "); // Open device -- To view, visit https://review.coreboot.org/c/flashrom/+/66874 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3a72a0877b47f67f8984c28cbf5b5d429ec1534e Gerrit-Change-Number: 66874 Gerrit-PatchSet: 15 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: internal.c: Retype appropriate variables with bool
by Anastasia Klimchuk (Code Review) 08 Sep '22

08 Sep '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66870 ) Change subject: internal.c: Retype appropriate variables with bool ...................................................................... internal.c: Retype appropriate variables with bool Use the bool type instead of an integer for the variables `force_laptop`, `not_a_laptop`, `force_boardenable` and `force_boardmismatch` since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I159d789112d7a778744b59b45133df3928b8445e Reviewed-on: https://review.coreboot.org/c/flashrom/+/66870 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M include/programmer.h M internal.c 2 files changed, 34 insertions(+), 14 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/include/programmer.h b/include/programmer.h index 5331a12..776ac21 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -20,6 +20,7 @@ #ifndef __PROGRAMMER_H__ #define __PROGRAMMER_H__ 1 +#include <stdbool.h> #include <stdint.h> #include "flash.h" /* for chipaddr and flashctx */ @@ -265,8 +266,8 @@ #if CONFIG_INTERNAL == 1 extern int is_laptop; extern int laptop_ok; -extern int force_boardenable; -extern int force_boardmismatch; +extern bool force_boardenable; +extern bool force_boardmismatch; void probe_superio(void); int register_superio(struct superio s); extern enum chipbustype internal_buses_supported; diff --git a/internal.c b/internal.c index 426730f..ce1debe 100644 --- a/internal.c +++ b/internal.c @@ -16,6 +16,7 @@ #include <strings.h> #include <string.h> +#include <stdbool.h> #include <stdlib.h> #include "flash.h" #include "programmer.h" @@ -29,8 +30,8 @@ int is_laptop = 0; int laptop_ok = 0; -int force_boardenable = 0; -int force_boardmismatch = 0; +bool force_boardenable = false; +bool force_boardmismatch = false; enum chipbustype internal_buses_supported = BUS_NONE; @@ -117,21 +118,21 @@ }; static int get_params(const struct programmer_cfg *cfg, - int *boardenable, int *boardmismatch, - int *force_laptop, int *not_a_laptop, + bool *boardenable, bool *boardmismatch, + bool *force_laptop, bool *not_a_laptop, char **board_vendor, char **board_model) { char *arg; /* default values. */ - *force_laptop = 0; - *not_a_laptop = 0; + *force_laptop = false; + *not_a_laptop = false; *board_vendor = NULL; *board_model = NULL; arg = extract_programmer_param_str(cfg, "boardenable"); if (arg && !strcmp(arg,"force")) { - *boardenable = 1; + *boardenable = true; } else if (arg && !strlen(arg)) { msg_perr("Missing argument for boardenable.\n"); free(arg); @@ -145,7 +146,7 @@ arg = extract_programmer_param_str(cfg, "boardmismatch"); if (arg && !strcmp(arg,"force")) { - *boardmismatch = 1; + *boardmismatch = true; } else if (arg && !strlen(arg)) { msg_perr("Missing argument for boardmismatch.\n"); free(arg); @@ -159,9 +160,9 @@ arg = extract_programmer_param_str(cfg, "laptop"); if (arg && !strcmp(arg, "force_I_want_a_brick")) - *force_laptop = 1; + *force_laptop = true; else if (arg && !strcmp(arg, "this_is_not_a_laptop")) - *not_a_laptop = 1; + *not_a_laptop = true; else if (arg && !strlen(arg)) { msg_perr("Missing argument for laptop.\n"); free(arg); @@ -192,8 +193,8 @@ static int internal_init(const struct programmer_cfg *cfg) { int ret = 0; - int force_laptop; - int not_a_laptop; + bool force_laptop; + bool not_a_laptop; char *board_vendor; char *board_model; #if defined(__i386__) || defined(__x86_64__) -- To view, visit https://review.coreboot.org/c/flashrom/+/66870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I159d789112d7a778744b59b45133df3928b8445e Gerrit-Change-Number: 66870 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: buspirate_spi.c: Retype appropriate variables with bool
by Anastasia Klimchuk (Code Review) 08 Sep '22

08 Sep '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66868 ) Change subject: buspirate_spi.c: Retype appropriate variables with bool ...................................................................... buspirate_spi.c: Retype appropriate variables with bool Use the bool type instead of integer for appropriate variables, since this represents their purpose much better. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I245616168796f2c7fe99388688b0f606bd3405bf Reviewed-on: https://review.coreboot.org/c/flashrom/+/66868 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M buspirate_spi.c 1 file changed, 25 insertions(+), 7 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/buspirate_spi.c b/buspirate_spi.c index 8fa60f6..0704887 100644 --- a/buspirate_spi.c +++ b/buspirate_spi.c @@ -16,6 +16,7 @@ #include <stdio.h> #include <strings.h> #include <string.h> +#include <stdbool.h> #include <stdlib.h> #include <ctype.h> #include <unistd.h> @@ -327,8 +328,8 @@ int spispeed = 0x7; int serialspeed_index = -1; int ret = 0; - int pullup = 0; - int psu = 0; + bool pullup = false; + bool psu = false; unsigned char *bp_commbuf; int bp_commbufsize; @@ -372,7 +373,7 @@ tmp = extract_programmer_param_str(cfg, "pullups"); if (tmp) { if (strcasecmp("on", tmp) == 0) - pullup = 1; + pullup = true; else if (strcasecmp("off", tmp) == 0) ; // ignore else @@ -383,7 +384,7 @@ tmp = extract_programmer_param_str(cfg, "psus"); if (tmp) { if (strcasecmp("on", tmp) == 0) - psu = 1; + psu = true; else if (strcasecmp("off", tmp) == 0) ; // ignore else @@ -646,11 +647,11 @@ /* Initial setup (SPI peripherals config): Enable power, CS high, AUX */ bp_commbuf[0] = 0x40 | 0x0b; - if (pullup == 1) { + if (pullup) { bp_commbuf[0] |= (1 << 2); msg_pdbg("Enabling pull-up resistors.\n"); } - if (psu == 1) { + if (psu) { bp_commbuf[0] |= (1 << 3); msg_pdbg("Enabling PSUs.\n"); } @@ -676,7 +677,7 @@ /* Set SPI config: output type, idle, clock edge, sample */ bp_commbuf[0] = 0x80 | 0xa; - if (pullup == 1) { + if (pullup) { bp_commbuf[0] &= ~(1 << 3); msg_pdbg("Pull-ups enabled, so using HiZ pin output! (Open-Drain mode)\n"); } -- To view, visit https://review.coreboot.org/c/flashrom/+/66868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I245616168796f2c7fe99388688b0f606bd3405bf Gerrit-Change-Number: 66868 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: ichspi.c: Rename bool variables accordingly
by Felix Singer (Code Review) 08 Sep '22

08 Sep '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67431 to look at the new patch set (#3). Change subject: ichspi.c: Rename bool variables accordingly ...................................................................... ichspi.c: Rename bool variables accordingly Rename bool variables accordingly so that they sound like that and it's better understandable for the reader. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Icb724a58dd4a1375a2c0a660484cb646f162f5be --- M ichspi.c 1 file changed, 30 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/67431/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/67431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icb724a58dd4a1375a2c0a660484cb646f162f5be Gerrit-Change-Number: 67431 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: ichspi.c: Rename some variables
by Felix Singer (Code Review) 08 Sep '22

08 Sep '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67431 to look at the new patch set (#2). Change subject: ichspi.c: Rename some variables ...................................................................... ichspi.c: Rename some variables WIP. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Icb724a58dd4a1375a2c0a660484cb646f162f5be --- M ichspi.c 1 file changed, 29 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/67431/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icb724a58dd4a1375a2c0a660484cb646f162f5be Gerrit-Change-Number: 67431 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: ichspi.c: Retype appropriate variables with bool
by Felix Singer (Code Review) 08 Sep '22

08 Sep '22

Attention is currently required from: Nico Huber, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66892 ) Change subject: ichspi.c: Retype appropriate variables with bool ...................................................................... Patch Set 13: (3 comments) File ichspi.c: https://review.coreboot.org/c/flashrom/+/66892/comment/b6835d0e_a46461a5 PS13, Line 259: ichspi_lock > Hmmm, maybe `ichspi_is_locked`? CB:67431 https://review.coreboot.org/c/flashrom/+/66892/comment/2687b0bd_398c5257 PS13, Line 863: write_cmd > This should be renamed, `is_write_cmd` for example. CB:67431 https://review.coreboot.org/c/flashrom/+/66892/comment/adb207a1_50529bdc PS13, Line 980: write_cmd > Ditto, `is_write_cmd` CB:67431 -- To view, visit https://review.coreboot.org/c/flashrom/+/66892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If7eeacc44921f52aa593ab1302f17a5c5190f830 Gerrit-Change-Number: 66892 Gerrit-PatchSet: 13 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 08 Sep 2022 00:52:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022