September 2022 - flashrom-gerrit

[S] Change in flashrom[master]: flashrom.c: create is_internal_programmer() helper
by Anastasia Klimchuk (Code Review) 08 Sep '22

08 Sep '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66684 ) Change subject: flashrom.c: create is_internal_programmer() helper ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Patchset: PS6: I am wondering about testing. The branch on writing can be tested with running internal and non-internal (dummy). The other branch with emergency and non-emergency help message, is it possible to run it with dummy? I can try thinking if a unit test can be implemented for it. The case of "emergency and non-emergency help message" is an interesting example, because it can be hard to repro on a real hardware, but can be decently tested via unit test (emulating broken hardware). I am very open to ideas. It is not just for this one patch, having the unit test covering [non]emergency help message is a good investment for a long-term. -- To view, visit https://review.coreboot.org/c/flashrom/+/66684 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I43243b990192077583a9a3a95d35844923d9c158 Gerrit-Change-Number: 66684 Gerrit-PatchSet: 6 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Sep 2022 09:52:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: spi.c: Move spi_get_erasefn_from_opcode to spi.c
by Thomas Heijligen (Code Review) 08 Sep '22

08 Sep '22

Attention is currently required from: Simon Buhrow, Nico Huber, Aarya. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67368 ) Change subject: spi.c: Move spi_get_erasefn_from_opcode to spi.c ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Simon, you updated the wrong Patch. -- To view, visit https://review.coreboot.org/c/flashrom/+/67368 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3263b7642c35e7fd1da0002175123e5560d94752 Gerrit-Change-Number: 67368 Gerrit-PatchSet: 2 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Thu, 08 Sep 2022 09:50:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: spi.c: Move spi_get_erasefn_from_opcode to spi.c
by Simon Buhrow (Code Review) 08 Sep '22

08 Sep '22

Attention is currently required from: Nico Huber, Aarya. Simon Buhrow has uploaded a new patch set (#2) to the change originally created by Aarya. ( https://review.coreboot.org/c/flashrom/+/67368 ) Change subject: spi.c: Move spi_get_erasefn_from_opcode to spi.c ...................................................................... spi.c: Move spi_get_erasefn_from_opcode to spi.c Move spi_get_erasefn_from_opcode and spi_get_opcode_from_erasefn to spi.c. Change-Id: I3263b7642c35e7fd1da0002175123e5560d94752 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M TEST_ERASE_ALGO.md M spi.c M spi25.c 3 files changed, 75 insertions(+), 57 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/67368/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67368 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3263b7642c35e7fd1da0002175123e5560d94752 Gerrit-Change-Number: 67368 Gerrit-PatchSet: 2 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashrom.c: Make programmer_{un}map_flash_region() static
by Anastasia Klimchuk (Code Review) 08 Sep '22

08 Sep '22

Attention is currently required from: Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66677 ) Change subject: flashrom.c: Make programmer_{un}map_flash_region() static ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/66677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic02092ce23c5b3233aad38343b888e3fa7e5bcf9 Gerrit-Change-Number: 66677 Gerrit-PatchSet: 5 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Sep 2022 09:26:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: ichspi: Add Intel Idaville HCC support
by Kevin Yu (Code Review) 08 Sep '22

08 Sep '22

Kevin Yu has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/66635 ) Change subject: ichspi: Add Intel Idaville HCC support ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/66635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I36fe5d296ed65547fbd5130abe1a0c8dd291e920 Gerrit-Change-Number: 66635 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Yu <ykevin(a)celestica.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: ichspi: Add Intel Idaville HCC support
by Kevin Yu (Code Review) 08 Sep '22

08 Sep '22

Kevin Yu has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/67438 ) Change subject: ichspi: Add Intel Idaville HCC support ...................................................................... ichspi: Add Intel Idaville HCC support Add CDF PCH device IDs to enable flashrom on Idaville HCC platforms. TEST=read/write BIOS on Intel Morocity CRB Board. Signed-off-by: Kevin Yu <ykevin(a)celestica.com> Change-Id: I3d73b4796f610953d38506794eb20791871ec31f --- M chipset_enable.c 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/67438/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3d73b4796f610953d38506794eb20791871ec31f Gerrit-Change-Number: 67438 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Yu <ykevin(a)celestica.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: ichspi: Add Intel Iadville HCC support
by Kevin Yu (Code Review) 08 Sep '22

08 Sep '22

Kevin Yu has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/67438 ) Change subject: ichspi: Add Intel Iadville HCC support ...................................................................... ichspi: Add Intel Iadville HCC support Change-Id: I3d73b4796f610953d38506794eb20791871ec31f --- M chipset_enable.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/67438/1 diff --git a/chipset_enable.c b/chipset_enable.c index d6103c1..82e0c04 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -2125,6 +2125,7 @@ {0x8086, 0xa248, B_S, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa249, B_S, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0x1bca, B_S, NT, "Intel", "Emmitsburg Chipset SKU", enable_flash_c620}, + {0x8086, 0x18dc, B_S, NT, "Intel", "Idaville HCC SKU", enable_flash_c620}, {0x8086, 0xa2c4, B_S, NT, "Intel", "H270", enable_flash_pch100}, {0x8086, 0xa2c5, B_S, NT, "Intel", "Z270", enable_flash_pch100}, {0x8086, 0xa2c6, B_S, NT, "Intel", "Q270", enable_flash_pch100}, -- To view, visit https://review.coreboot.org/c/flashrom/+/67438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3d73b4796f610953d38506794eb20791871ec31f Gerrit-Change-Number: 67438 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Yu <ykevin(a)celestica.com> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: spi.c: Move spi_get_erasefn_from_opcode to spi.c
by Simon Buhrow (Code Review) 08 Sep '22

08 Sep '22

Attention is currently required from: Nico Huber, Aarya. Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67368 ) Change subject: spi.c: Move spi_get_erasefn_from_opcode to spi.c ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/67368 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3263b7642c35e7fd1da0002175123e5560d94752 Gerrit-Change-Number: 67368 Gerrit-PatchSet: 1 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Thu, 08 Sep 2022 07:02:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: test_build.sh: Enforce tests to be enabled
by Anastasia Klimchuk (Code Review) 08 Sep '22

08 Sep '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/67243 ) ( 5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: test_build.sh: Enforce tests to be enabled ...................................................................... test_build.sh: Enforce tests to be enabled Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I00c23a17926ed112522b083f8594596d051cf9f8 Reviewed-on: https://review.coreboot.org/c/flashrom/+/67243 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M test_build.sh 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Thomas Heijligen: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, approved diff --git a/test_build.sh b/test_build.sh index 68b00ad..b2320b8 100755 --- a/test_build.sh +++ b/test_build.sh @@ -38,7 +38,7 @@ build_meson () { builddir=out - meson $builddir + meson $builddir -Dtests=enabled ninja -C $builddir ninja -C $builddir test } -- To view, visit https://review.coreboot.org/c/flashrom/+/67243 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I00c23a17926ed112522b083f8594596d051cf9f8 Gerrit-Change-Number: 67243 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: Revert "cmocka: Drop as meson subproject"
by Anastasia Klimchuk (Code Review) 08 Sep '22

08 Sep '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/67345 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Revert "cmocka: Drop as meson subproject" ...................................................................... Revert "cmocka: Drop as meson subproject" This reverts commit 99eca0899b931b21b7c44ed1753c5f01b35798af. The environment provided by our Jenkins builder doesn't have cmocka. It's not exactly known why it worked as a subproject. However, if it allows us to enforce tests in the CI, we should revert now and drop the subproject again once the environment is updated. Change-Id: Iafdab92eb8ab96d02fb2c29524d785bdc7a54034 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/67345 Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M meson.build A subprojects/cmocka.wrap M tests/meson.build 3 files changed, 40 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Thomas Heijligen: Looks good to me, approved Angel Pons: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/meson.build b/meson.build index 3a60f92..366ce18 100644 --- a/meson.build +++ b/meson.build @@ -500,7 +500,11 @@ # `.allowed()` gets introduced in 0.59.0 if get_option('tests').auto() or get_option('tests').enabled() # unit-test framework - cmocka = dependency('cmocka', required : get_option('tests')) + cmocka_dep = dependency( + 'cmocka', + fallback: ['cmocka', 'cmocka_dep'], + required : get_option('tests') + ) flashrom_test_dep = declare_dependency( include_directories : include_dir, @@ -519,7 +523,7 @@ ], ) - if cmocka.found() + if cmocka_dep.found() subdir('tests') endif endif diff --git a/subprojects/cmocka.wrap b/subprojects/cmocka.wrap new file mode 100644 index 0000000..21e84f9 --- /dev/null +++ b/subprojects/cmocka.wrap @@ -0,0 +1,10 @@ +[wrap-file] +directory = cmocka-1.1.5 + +source_url = https://cmocka.org/files/1.1/cmocka-1.1.5.tar.xz +source_filename = cmocka-1.1.5.tar.xz +source_hash = f0ccd8242d55e2fd74b16ba518359151f6f8383ff8aef4976e48393f77bba8b6 + +patch_url = https://wrapdb.mesonbuild.com/v1/projects/cmocka/1.1.5/3/get_zip +patch_filename = cmocka-1.1.5-3-wrap.zip +patch_hash = 81ce48613680d3c3a0b396ac570c852b290adcd18202fb16aaf703a9493f4348 diff --git a/tests/meson.build b/tests/meson.build index 2f4e33d..b629998 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -114,6 +114,6 @@ ], export_dynamic : true, link_args : mocks, - dependencies : [cmocka, flashrom_test_dep], + dependencies : [cmocka_dep, flashrom_test_dep], ) test('cmocka test flashrom', flashrom_tests) -- To view, visit https://review.coreboot.org/c/flashrom/+/67345 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iafdab92eb8ab96d02fb2c29524d785bdc7a54034 Gerrit-Change-Number: 67345 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022