Attention is currently required from: Simon Buhrow, Nico Huber, Aarya.
Hello build bot (Jenkins), Simon Buhrow, Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/65879
to look at the new patch set (#27).
Change subject: flashrom.c:Add function to get a flattened view of the chip erase blocks
......................................................................
flashrom.c:Add function to get a flattened view of the chip erase blocks
Add a function to flatten out the addresses of the flash chip as per the
different erase functions. This function will return a list of layouts
which is dynamically allocated. So after use all the layouts as well as
the list itself should be freed. The free_erase_layout function does
that.
Change-Id: Iafe78de00daa55f7114bd4ce09465dd88074ece4
Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com>
---
M flashrom.c
M include/flash.h
2 files changed, 111 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/65879/27
--
To view, visit https://review.coreboot.org/c/flashrom/+/65879
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iafe78de00daa55f7114bd4ce09465dd88074ece4
Gerrit-Change-Number: 65879
Gerrit-PatchSet: 27
Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Simon Buhrow, Nico Huber.
Hello build bot (Jenkins), Simon Buhrow, Nico Huber, Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/66717
to look at the new patch set (#8).
Change subject: flashrom.c: Update check_block_eraser function to use probe opcode
......................................................................
flashrom.c: Update check_block_eraser function to use probe opcode
Update the check_block_eraser function to use probe_opcode to see if the
given block_eraser is supported by the spi master. This will help to get
a real count of usable block_erasers.
Change-Id: I6591a84ae1fe5bc1648051cc30b9393450033852
Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com>
---
M dummyflasher.c
M flashrom.c
M ichspi.c
M include/programmer.h
M spi.c
5 files changed, 29 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/17/66717/8
--
To view, visit https://review.coreboot.org/c/flashrom/+/66717
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6591a84ae1fe5bc1648051cc30b9393450033852
Gerrit-Change-Number: 66717
Gerrit-PatchSet: 8
Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Simon Buhrow, Aarya.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66718 )
Change subject: TEST_ERASE_ALGO: A list of test cases (patch not to be merged)
......................................................................
Patch Set 39:
(4 comments)
File TEST_ERASE_ALGO.md:
https://review.coreboot.org/c/flashrom/+/66718/comment/7ab80a60_53197b87
PS39, Line 5: ### Also check the date of the latest patchset and the date of test done.</br>
### Legend: R2R - random to random
### t_diff - time diff to prior implementation (negative value -> new is faster)
https://review.coreboot.org/c/flashrom/+/66718/comment/d8602cf7_cbc61185
PS39, Line 66: - [ ] Full chip erase
```
- [x] Full chip erase
* CMD: ./flashrom -p ft2232_spi:type=2232H,port=A -E
* Date: 08.09.2022 - commit: 7bc4a47
* Comments: Successful. Chip: IS25LP064; t_diff with VM setup: -3:00 min
```
Thanks Simon
https://review.coreboot.org/c/flashrom/+/66718/comment/65a0b42a_92759ab0
PS39, Line 120:
```
- [x] Partial chip write data from R2R on one continous region
* CMD: ./flashrom -p ft2232_spi:type=2232H,port=A -w random_8MB_02.bin
./flashrom -p ft2232_spi:type=2232H,port=A -w random_8MB_01.bin --layout layout_64Mb -i 64kB_second2fourth
* Date: 08.09.2022 - commit: 7bc4a47
* Comments: Successful. Chip: IS25LP064; t_diff with VM setup: -0:30 min
```
Thanks Simon
https://review.coreboot.org/c/flashrom/+/66718/comment/276e54fd_27ace774
PS39, Line 120:
```
- [x] Partial chip write data from R2R on one continous region
* CMD: ./flashrom -p ft2232_spi:type=2232H,port=A -w random_8MB_02.bin
./flashrom -p ft2232_spi:type=2232H,port=A -w random_8MB_01.bin --layout layout_64Mb -i 64kB_second2fourth
* Date: 08.09.2022 - commit: 7bc4a47
* Comments: Successful. Chip: IS25LP064; t_diff with VM setup: -0:30 min
```
Thanks Simon
--
To view, visit https://review.coreboot.org/c/flashrom/+/66718
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5e961752b9d24d28fdd3487a1a121391f149928b
Gerrit-Change-Number: 66718
Gerrit-PatchSet: 39
Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 12:32:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Simon Buhrow, Thomas Heijligen, Aarya.
Hello Simon Buhrow, build bot (Jenkins), Nico Huber, Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/67354
to look at the new patch set (#3).
Change subject: spi.c: Add erasefn and opcodes for AT45 and S25F to lookup list
......................................................................
spi.c: Add erasefn and opcodes for AT45 and S25F to lookup list
Add opcode and erasefn for AT45 and S25F to the
spi_get_[opcode/erasefn]_from[erasefn/opcode] lookup list.
Change-Id: Ief25932120f940dea0ffe161a79219deecb2e8ab
Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com>
---
M spi.c
1 file changed, 24 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/67354/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/67354
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ief25932120f940dea0ffe161a79219deecb2e8ab
Gerrit-Change-Number: 67354
Gerrit-PatchSet: 3
Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Simon Buhrow, Nico Huber, Aarya.
Hello build bot (Jenkins), Simon Buhrow, Nico Huber, Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/67368
to look at the new patch set (#4).
Change subject: spi.c: Move spi_get_erasefn_from_opcode to spi.c
......................................................................
spi.c: Move spi_get_erasefn_from_opcode to spi.c
Move spi_get_erasefn_from_opcode and spi_get_opcode_from_erasefn to
spi.c.
Change-Id: I3263b7642c35e7fd1da0002175123e5560d94752
Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com>
---
M spi.c
M spi25.c
2 files changed, 58 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/67368/4
--
To view, visit https://review.coreboot.org/c/flashrom/+/67368
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3263b7642c35e7fd1da0002175123e5560d94752
Gerrit-Change-Number: 67368
Gerrit-PatchSet: 4
Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Simon Buhrow, Nico Huber, Paul Menzel, Aarya.
Hello build bot (Jenkins), Simon Buhrow, Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/66104
to look at the new patch set (#45).
Change subject: flashrom.c: Add wrapper function to use the erase algorithm
......................................................................
flashrom.c: Add wrapper function to use the erase algorithm
Add a function to call the erase algorithm.
Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com>
---
M flashrom.c
1 file changed, 127 insertions(+), 346 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/66104/45
--
To view, visit https://review.coreboot.org/c/flashrom/+/66104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Gerrit-Change-Number: 66104
Gerrit-PatchSet: 45
Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Paul Menzel, Aarya.
Simon Buhrow has uploaded a new patch set (#44) to the change originally created by Aarya. ( https://review.coreboot.org/c/flashrom/+/66104 )
Change subject: flashrom.c: Add wrapper function to use the erase algorithm
......................................................................
flashrom.c: Add wrapper function to use the erase algorithm
Add a function to call the erase algorithm.
Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com>
---
M flashrom.c
1 file changed, 122 insertions(+), 348 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/66104/44
--
To view, visit https://review.coreboot.org/c/flashrom/+/66104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Gerrit-Change-Number: 66104
Gerrit-PatchSet: 44
Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Paul Menzel, Aarya.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66104 )
Change subject: flashrom.c: Add wrapper function to use the erase algorithm
......................................................................
Patch Set 43:
(7 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66104/comment/acba3b97_7d3946f9
PS43, Line 1054: assert(!ret);
```
if (ret) {
msg_cerr("Failed to execute erase command for offset %#x to %#x.\n", start_addr, end_addr);
return -1;
}
```
https://review.coreboot.org/c/flashrom/+/66104/comment/7adf04b3_224d43cb
PS43, Line 1055: //verify erase
: ret = check_erased_range(flashctx, start_addr, block_len);
: assert(!ret);
: //if erase fail??
: //
This is not needed, there is a verify command at the end.
https://review.coreboot.org/c/flashrom/+/66104/comment/5f66e748_159c9682
PS43, Line 1065: msg_cinfo
s/msg_cdbg/
https://review.coreboot.org/c/flashrom/+/66104/comment/71a023b6_71f261ef
PS43, Line 1076: assert(!ret);
```
if (ret) {
msg_cerr("Write failed at %#x, Abort.\n", i);
return -1;
}
```
https://review.coreboot.org/c/flashrom/+/66104/comment/f54c5f41_fb3e9f65
PS43, Line 1078: ret = verify_range(flashctx, newcontents + i, i, flashctx->chip->page_size);
: assert(!ret);
This is not needed, there is a verify command at the end.
https://review.coreboot.org/c/flashrom/+/66104/comment/ba2b1ffb_94ec0338
PS43, Line 1082: msg_cinfo
s/msg_cdbg/
https://review.coreboot.org/c/flashrom/+/66104/comment/c2c22c1e_57208830
PS43, Line 1088: assert(!ret);
```
if (ret) {
msg_cerr("Verifying flash failed failed for range %#x : %#x, Abort.\n", region_start, region_end);
return -1;
}
```
--
To view, visit https://review.coreboot.org/c/flashrom/+/66104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Gerrit-Change-Number: 66104
Gerrit-PatchSet: 43
Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 10:14:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment