May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: meson: relocate source file list
by Angel Pons (Code Review) 03 May '22

03 May '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Peter Marheine. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64026 ) Change subject: meson: relocate source file list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I921be8a8a99b93d23c1dbd4ea54672ba9998558d Gerrit-Change-Number: 64026 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 03 May 2022 09:37:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: util/ich_descriptors_tool: Remove unneeded meson dependencies
by Angel Pons (Code Review) 03 May '22

03 May '22

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63757 ) Change subject: util/ich_descriptors_tool: Remove unneeded meson dependencies ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ice1437cb294729b6af0e24f0a02692459b7a1412 Gerrit-Change-Number: 63757 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 03 May 2022 09:36:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [WIP] meson: rework the programmer selection
by Thomas Heijligen (Code Review) 03 May '22

03 May '22

Attention is currently required from: Edward O'Callaghan. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63724 ) Change subject: [WIP] meson: rework the programmer selection ...................................................................... Patch Set 13: (1 comment) Patchset: PS13: Fails to build cmocka tests after rebase. ../tests/lifecycle.c:419:12: error: ‘realtek_mst_read’ defined but not used [-Werror=unused-function] -- To view, visit https://review.coreboot.org/c/flashrom/+/63724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1 Gerrit-Change-Number: 63724 Gerrit-PatchSet: 13 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 03 May 2022 08:34:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [UGLY HACK] move structs and probe_variable_size() out of dummyflasher.c
by Thomas Heijligen (Code Review) 03 May '22

03 May '22

Attention is currently required from: Nico Huber, Namyoon Woo, Edward O'Callaghan. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63831 ) Change subject: [UGLY HACK] move structs and probe_variable_size() out of dummyflasher.c ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I'm not happy with this and would like to see it fixed instead of merging this hack. -- To view, visit https://review.coreboot.org/c/flashrom/+/63831 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic93c8b9ba7b9f7ce5fe49326c8de34070ca83a2e Gerrit-Change-Number: 63831 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Namyoon Woo <namyoon(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 03 May 2022 08:33:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: add option to disable tests
by Thomas Heijligen (Code Review) 03 May '22

03 May '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63832 ) Change subject: meson: add option to disable tests ...................................................................... Patch Set 6: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63832/comment/cd696fd1_38644a62 PS4, Line 9: usefull > useful Done https://review.coreboot.org/c/flashrom/+/63832/comment/01f53bd6_d5339830 PS4, Line 10: build > built Done File meson.build: https://review.coreboot.org/c/flashrom/+/63832/comment/97c98fdd_9a57ec2a PS1, Line 522: if cmocka_dep.found() > I found what I was remembering, this commit 16c62a791d0a311bb040812b03c33881ab641a8e […] Now we have 3 options, `auto` - the old behavior, which is default, `enabled` - enforces tests and `disabled` - disable all tests. Is this fine for you? -- To view, visit https://review.coreboot.org/c/flashrom/+/63832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I384c904c577b265dfe36bf46bf07c641bc29de9b Gerrit-Change-Number: 63832 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 03 May 2022 08:30:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: add option to disable tests
by Thomas Heijligen (Code Review) 03 May '22

03 May '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63832 to look at the new patch set (#6). Change subject: meson: add option to disable tests ...................................................................... meson: add option to disable tests During development it can be useful to disable unit testing. By default tests are built if cmocka is found. To force enable tests run `meson build -Dtests=enable`. to disable tests run `meson build -Dtests=disabled` Change-Id: I384c904c577b265dfe36bf46bf07c641bc29de9b Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build M meson_options.txt 2 files changed, 27 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/63832/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/63832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I384c904c577b265dfe36bf46bf07c641bc29de9b Gerrit-Change-Number: 63832 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: [UGLY HACK] move structs and probe_variable_size() out of dummyflasher.c
by Thomas Heijligen (Code Review) 03 May '22

03 May '22

Attention is currently required from: Nico Huber, Namyoon Woo, Thomas Heijligen, Edward O'Callaghan. Hello build bot (Jenkins), Namyoon Woo, Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63831 to look at the new patch set (#4). Change subject: [UGLY HACK] move structs and probe_variable_size() out of dummyflasher.c ...................................................................... [UGLY HACK] move structs and probe_variable_size() out of dummyflasher.c This makes flashrom buildable without the dummy programmer. It does NOT fix the underlaying bug. * BUG: https://ticket.coreboot.org/issues/365 * COMMIT: https://review.coreboot.org/c/flashrom/+/44879 * COMMIT: https://review.coreboot.org/c/flashrom/+/46536 Change-Id: Ic93c8b9ba7b9f7ce5fe49326c8de34070ca83a2e Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile M dummyflasher.c M include/chipdrivers.h A include/you_need_to_fix_me.h M meson.build A you_need_to_fix_me.c 6 files changed, 113 insertions(+), 81 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/63831/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/63831 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic93c8b9ba7b9f7ce5fe49326c8de34070ca83a2e Gerrit-Change-Number: 63831 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Namyoon Woo <namyoon(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: [WIP] meson: rework the programmer selection
by Thomas Heijligen (Code Review) 03 May '22

03 May '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63724 to look at the new patch set (#13). Change subject: [WIP] meson: rework the programmer selection ...................................................................... [WIP] meson: rework the programmer selection This is a WIP implementation for a new programmer selection. It should work by now but has some known and unknown bugs. (see Gerrit Comments) - Each dependency is optional and gets mandatory when the programmer is selected as active. - Each programmer is defined through an entry in the programmer dictionary - The entry lists systems & cpu_families where the programmer is supported; Dependencies, sources and flags. The group parameter is for selecting a set of programmer, the default parameter is to include the programmer to the `all` and `auto` set. - If the programmer gets selected the `active` entry is set to true. The `active` entry can be used afterwards to determine if the programmer should be included in sources, config, documentation - Needed system headers are represended through a pseudo dependency. - The programmer's `srcs` attribute contains all files which are needed to build the programmer. Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build M meson_options.txt 2 files changed, 411 insertions(+), 340 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/63724/13 -- To view, visit https://review.coreboot.org/c/flashrom/+/63724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1 Gerrit-Change-Number: 63724 Gerrit-PatchSet: 13 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: meson: use `platform/` as subdir()
by Thomas Heijligen (Code Review) 03 May '22

03 May '22

Attention is currently required from: Felix Singer, Anastasia Klimchuk, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63826 ) Change subject: meson: use `platform/` as subdir() ...................................................................... Patch Set 4: (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63826/comment/f3a00d35_03b29698 PS3, Line 7: outsource > I would use "move" Entirely new commit message https://review.coreboot.org/c/flashrom/+/63826/comment/e61fc457_801f5a73 PS3, Line 8: > Please state the reason for this change. […] Is it more obvious now? File meson.build: https://review.coreboot.org/c/flashrom/+/63826/comment/3ec270c3_7afcd5bf PS2, Line 80: host_is_x86 = ['x86', 'x86_64'].contains(host_machine.cpu_family()) > Okay so maybe you can update commit message and add more info about future plans? Is the single sentence enough? https://review.coreboot.org/c/flashrom/+/63826/comment/44807d66_41bbeb73 PS2, Line 133: if host_machine.system() in ['cygwin', 'windows'] > Yes, we can move it here first. […] I've decided against putting IS_WINDOWS here and only put stuff from the `platform/` directory there. OK? -- To view, visit https://review.coreboot.org/c/flashrom/+/63826 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I88044a3f903f316138483dd872a6d95f8686ae69 Gerrit-Change-Number: 63826 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 03 May 2022 08:24:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: relocate source file list
by Thomas Heijligen (Code Review) 03 May '22

03 May '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64026 ) Change subject: meson: relocate source file list ...................................................................... meson: relocate source file list Change-Id: I921be8a8a99b93d23c1dbd4ea54672ba9998558d Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build 1 file changed, 34 insertions(+), 34 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/26/64026/1 diff --git a/meson.build b/meson.build index 222f7c1..6b088f0 100644 --- a/meson.build +++ b/meson.build @@ -86,7 +86,40 @@ cargs = [] deps = [] -srcs = [] +srcs = files( + '82802ab.c', + 'at45db.c', + 'bitbang_spi.c', + 'edi.c', + 'en29lv640b.c', + 'flashchips.c', + 'flashrom.c', + 'fmap.c', + 'helpers.c', + 'ich_descriptors.c', + 'jedec.c', + 'layout.c', + 'libflashrom.c', + 'opaque.c', + 'print.c', + 'programmer.c', + 'programmer_table.c', + 's25f.c', + 'sfdp.c', + 'spi25.c', + 'spi25_statusreg.c', + 'spi95.c', + 'spi.c', + 'sst28sf040.c', + 'sst49lfxxxc.c', + 'sst_fwhub.c', + 'stm50.c', + 'udelay.c', + 'w29ee011.c', + 'w39.c', + 'writeprotect.c', + 'writeprotect_ranges.c', +) host_is_x86 = ['x86', 'x86_64'].contains(host_machine.cpu_family()) @@ -392,39 +425,6 @@ include_dir = include_directories('include') -# core modules needed by both the library and the CLI -srcs += '82802ab.c' -srcs += 'at45db.c' -srcs += 'edi.c' -srcs += 'en29lv640b.c' -srcs += 'flashchips.c' -srcs += 'flashrom.c' -srcs += 'fmap.c' -srcs += 'helpers.c' -srcs += 'ich_descriptors.c' -srcs += 'jedec.c' -srcs += 'layout.c' -srcs += 'libflashrom.c' -srcs += 'opaque.c' -srcs += 'print.c' -srcs += 'programmer.c' -srcs += 'programmer_table.c' -srcs += 's25f.c' -srcs += 'sfdp.c' -srcs += 'spi25.c' -srcs += 'spi25_statusreg.c' -srcs += 'spi95.c' -srcs += 'spi.c' -srcs += 'sst28sf040.c' -srcs += 'sst49lfxxxc.c' -srcs += 'sst_fwhub.c' -srcs += 'stm50.c' -srcs += 'udelay.c' -srcs += 'w29ee011.c' -srcs += 'w39.c' -srcs += 'writeprotect.c' -srcs += 'writeprotect_ranges.c' - mapfile = 'libflashrom.map' vflag = '-Wl,--version-script,@0@/@1@'.format(meson.current_source_dir(), mapfile) flashrom = library( -- To view, visit https://review.coreboot.org/c/flashrom/+/64026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I921be8a8a99b93d23c1dbd4ea54672ba9998558d Gerrit-Change-Number: 64026 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022