May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: meson: add option to disable tests
by Felix Singer (Code Review) 03 May '22

03 May '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63832 ) Change subject: meson: add option to disable tests ...................................................................... Patch Set 6: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63832/comment/9a2fc7a0_810b4e56 PS6, Line 11: to To https://review.coreboot.org/c/flashrom/+/63832/comment/3f72e220_43eea6bf PS6, Line 12: - Add a dot at the end. File meson.build: https://review.coreboot.org/c/flashrom/+/63832/comment/0d6c5e4c_212972fd PS6, Line 509: # .allowed() is introduced in 0.59.0 Rather put this in the commit message instead here. -- To view, visit https://review.coreboot.org/c/flashrom/+/63832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I384c904c577b265dfe36bf46bf07c641bc29de9b Gerrit-Change-Number: 63832 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 03 May 2022 15:40:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: link flashrom binary against static libflashrom
by Thomas Heijligen (Code Review) 03 May '22

03 May '22

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64030 ) Change subject: meson: link flashrom binary against static libflashrom ...................................................................... Patch Set 1: (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/64030/comment/bbfcec33_be7b301b PS1, Line 431: lib must stay 'flashrom', now it's liblibflashrom -- To view, visit https://review.coreboot.org/c/flashrom/+/64030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic522610f59e00299ebfa1bd29482ff92120ec52b Gerrit-Change-Number: 64030 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 03 May 2022 11:20:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: use static library for tests
by Thomas Heijligen (Code Review) 03 May '22

03 May '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64031 ) Change subject: meson: use static library for tests ...................................................................... meson: use static library for tests Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build M tests/chip.c M tests/flashrom.c M tests/helpers.c M tests/lifecycle.c M tests/meson.build M tests/tests.c 7 files changed, 39 insertions(+), 55 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/64031/1 diff --git a/meson.build b/meson.build index dbee971..aee07b7 100644 --- a/meson.build +++ b/meson.build @@ -492,32 +492,5 @@ subdir('util') if get_option('tests').auto() or get_option('tests').enabled() # .allowed() is introduced in 0.59.0 -# unit-test framework -cmocka_dep = dependency( - 'cmocka', - fallback: ['cmocka', 'cmocka_dep'], - required : get_option('tests') - ) - - flashrom_test_dep = declare_dependency( - include_directories : include_dir, - sources : [ - srcs, - 'cli_common.c', - 'cli_output.c', - 'flashrom.c', - ], - compile_args : [ - '-includestdlib.h', - '-includeunittest_env.h', - '-includehwaccess_x86_io_unittest.h' - ], - dependencies : [ - deps, - ], - ) - - if cmocka_dep.found() - subdir('tests') - endif + subdir('tests') endif diff --git a/tests/chip.c b/tests/chip.c index 6f03172..ce6b53c 100644 --- a/tests/chip.c +++ b/tests/chip.c @@ -27,6 +27,7 @@ #include <include/test.h> #include <stdio.h> +#include <stdlib.h> #include <string.h> #include "tests.h" diff --git a/tests/flashrom.c b/tests/flashrom.c index cc88831..ecab69c 100644 --- a/tests/flashrom.c +++ b/tests/flashrom.c @@ -12,7 +12,7 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ - +#include <stdlib.h> #include <include/test.h> #include "tests.h" diff --git a/tests/helpers.c b/tests/helpers.c index e2e652e..81cb1cd 100644 --- a/tests/helpers.c +++ b/tests/helpers.c @@ -19,6 +19,7 @@ #include "flash.h" #include <stdint.h> +#include <stdlib.h> void address_to_bits_test_success(void **state) { diff --git a/tests/lifecycle.c b/tests/lifecycle.c index 63fcc3c..99c360a 100644 --- a/tests/lifecycle.c +++ b/tests/lifecycle.c @@ -14,6 +14,7 @@ */ #include <include/test.h> +#include <stdlib.h> #include <string.h> #include <linux/spi/spidev.h> diff --git a/tests/meson.build b/tests/meson.build index d3b46b1..a2ac78e 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -11,20 +11,6 @@ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -root_includes = include_directories('../subprojects') - -srcs = [ - 'io_mock.c', - 'tests.c', - 'libusb_wraps.c', - 'helpers.c', - 'flashrom.c', - 'spi25.c', - 'lifecycle.c', - 'layout.c', - 'chip.c', -] - mocks = [ '-Wl,--wrap=strdup', '-Wl,--wrap=physunmap', @@ -95,16 +81,37 @@ '-Wl,--gc-sections', ] -flashrom_tests = executable('flashrom_unit_tests', - srcs, - include_directories : root_includes, - c_args : [ - cargs, - '-ffunction-sections', - '-fdata-sections', - ], - export_dynamic : true, - link_args : mocks, - dependencies : [cmocka_dep, flashrom_test_dep], +cmocka = dependency( + 'cmocka', + fallback: ['cmocka', 'cmocka_dep'], + required : get_option('tests'), ) -test('cmocka test flashrom', flashrom_tests) + +if cmocka.found() + flashrom_tests = executable( + 'flashrom_unit_tests', + files( + 'io_mock.c', + 'tests.c', + 'libusb_wraps.c', + 'helpers.c', + 'flashrom.c', + 'spi25.c', + 'lifecycle.c', + 'layout.c', + 'chip.c', + ), + c_args : [ + cargs, + '-ffunction-sections', + '-fdata-sections', + ], + dependencies : [ cmocka, deps ], + export_dynamic : true, + include_directories : include_dir, + link_args : mocks, + link_with : libflashrom.get_static_lib(), + ) + + test('cmocka test flashrom', flashrom_tests) +endif \ No newline at end of file diff --git a/tests/tests.c b/tests/tests.c index 6aabd90..d0fc6af 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -20,6 +20,7 @@ #include <stdio.h> #include <string.h> +#include <stdlib.h> #include <stdint.h> void *not_null(void) -- To view, visit https://review.coreboot.org/c/flashrom/+/64031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd Gerrit-Change-Number: 64031 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: meson: link flashrom binary against static libflashrom
by Thomas Heijligen (Code Review) 03 May '22

03 May '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64030 ) Change subject: meson: link flashrom binary against static libflashrom ...................................................................... meson: link flashrom binary against static libflashrom Change-Id: Ic522610f59e00299ebfa1bd29482ff92120ec52b Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build 1 file changed, 11 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/30/64030/1 diff --git a/meson.build b/meson.build index 3018c17..dbee971 100644 --- a/meson.build +++ b/meson.build @@ -7,7 +7,9 @@ 'c_std=c99', 'werror=true', 'optimization=s', - 'debug=false'], + 'debug=false', + 'default_library=both', + ], ) # libtool versioning @@ -425,8 +427,8 @@ mapfile = 'libflashrom.map' vflag = '-Wl,--version-script,@0@/@1@'.format(meson.current_source_dir(), mapfile) -flashrom = library( - 'flashrom', +libflashrom = library( + 'libflashrom', sources : [ srcs, ], @@ -455,7 +457,7 @@ pkgg = import('pkgconfig') pkgg.generate( - libraries : flashrom, + libraries : libflashrom, version : version, name : 'flashrom', filebase : 'flashrom', @@ -472,31 +474,19 @@ install_dir: join_paths(get_option('mandir'), 'man8'), ) -flashrom_dep = declare_dependency( - link_with : flashrom, - include_directories : include_dir, - dependencies : deps -) - # we can't just link_with libflashrom as we require all the internal symbols... executable( 'flashrom', - sources : [ - srcs, + files( 'cli_classic.c', 'cli_common.c', 'cli_output.c', - 'flashrom.c', - ], + ), + c_args : cargs, include_directories : include_dir, - dependencies : [ - deps, - ], - c_args : [ - cargs - ], install : true, - install_dir : get_option('sbindir') + install_dir : get_option('sbindir'), + link_with : libflashrom.get_static_lib(), # flashrom needs internal symbols of libflashrom ) subdir('util') -- To view, visit https://review.coreboot.org/c/flashrom/+/64030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic522610f59e00299ebfa1bd29482ff92120ec52b Gerrit-Change-Number: 64030 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: meson: relocate config_print_wiki & config_default_programmer_*
by Thomas Heijligen (Code Review) 03 May '22

03 May '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64029 ) Change subject: meson: relocate config_print_wiki & config_default_programmer_* ...................................................................... meson: relocate config_print_wiki & config_default_programmer_* Change-Id: I9538b0aee31b294844d4f4ca0396334a81dfb498 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build 1 file changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/29/64029/1 diff --git a/meson.build b/meson.build index cfb353f..3018c17 100644 --- a/meson.build +++ b/meson.build @@ -403,6 +403,19 @@ endif endif +if config_print_wiki + srcs += 'print_wiki.c' + cargs += '-DCONFIG_PRINT_WIKI=1' +endif + +if config_default_programmer_name != '' + cargs += '-DCONFIG_DEFAULT_PROGRAMMER_NAME=&programmer_' + config_default_programmer_name +else + cargs += '-DCONFIG_DEFAULT_PROGRAMMER_NAME=NULL' +endif + +cargs += '-DCONFIG_DEFAULT_PROGRAMMER_ARGS="' + config_default_programmer_args + '"' + install_headers([ 'include/libflashrom.h', ], @@ -465,19 +478,6 @@ dependencies : deps ) -if config_print_wiki - srcs += 'print_wiki.c' - cargs += '-DCONFIG_PRINT_WIKI=1' -endif - -if config_default_programmer_name != '' - cargs += '-DCONFIG_DEFAULT_PROGRAMMER_NAME=&programmer_' + config_default_programmer_name -else - cargs += '-DCONFIG_DEFAULT_PROGRAMMER_NAME=NULL' -endif - -cargs += '-DCONFIG_DEFAULT_PROGRAMMER_ARGS="' + config_default_programmer_args + '"' - # we can't just link_with libflashrom as we require all the internal symbols... executable( 'flashrom', -- To view, visit https://review.coreboot.org/c/flashrom/+/64029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9538b0aee31b294844d4f4ca0396334a81dfb498 Gerrit-Change-Number: 64029 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: meson: use build in options for install paths
by Thomas Heijligen (Code Review) 03 May '22

03 May '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64028 ) Change subject: meson: use build in options for install paths ...................................................................... meson: use build in options for install paths The install functions of meson can take an relative path and join the prefix automaticly. Change-Id: I9cb9faf4bdbcfd66098478cc3a260eb3b664a2e6 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build 1 file changed, 2 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/28/64028/1 diff --git a/meson.build b/meson.build index 38354dd..cfb353f 100644 --- a/meson.build +++ b/meson.build @@ -403,11 +403,6 @@ endif endif -prefix = get_option('prefix') -sbindir = join_paths(prefix, get_option('sbindir')) -libdir = join_paths(prefix, get_option('libdir')) -mandir = join_paths(prefix, get_option('mandir')) - install_headers([ 'include/libflashrom.h', ], @@ -461,7 +456,7 @@ output : 'flashrom.8', configuration : conf, install: true, - install_dir: join_paths(mandir, 'man8'), + install_dir: join_paths(get_option('mandir'), 'man8'), ) flashrom_dep = declare_dependency( @@ -501,7 +496,7 @@ cargs ], install : true, - install_dir : sbindir, + install_dir : get_option('sbindir') ) subdir('util') -- To view, visit https://review.coreboot.org/c/flashrom/+/64028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9cb9faf4bdbcfd66098478cc3a260eb3b664a2e6 Gerrit-Change-Number: 64028 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashrom: Drop read_flash_to_file() usage
by Angel Pons (Code Review) 03 May '22

03 May '22

Attention is currently required from: Nico Huber, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59291 ) Change subject: flashrom: Drop read_flash_to_file() usage ...................................................................... Patch Set 14: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/59291 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4b690b688acf9d5deb46e8642a252a2132ea8c73 Gerrit-Change-Number: 59291 Gerrit-PatchSet: 14 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 03 May 2022 09:42:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [UGLY HACK] move structs and probe_variable_size() out of dummyflasher.c
by Angel Pons (Code Review) 03 May '22

03 May '22

Attention is currently required from: Nico Huber, Namyoon Woo, Thomas Heijligen, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63831 ) Change subject: [UGLY HACK] move structs and probe_variable_size() out of dummyflasher.c ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/63831 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic93c8b9ba7b9f7ce5fe49326c8de34070ca83a2e Gerrit-Change-Number: 63831 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Namyoon Woo <namyoon(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 03 May 2022 09:41:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: add option to disable tests
by Angel Pons (Code Review) 03 May '22

03 May '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63832 ) Change subject: meson: add option to disable tests ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/63832/comment/10683d50_e50a8741 PS4, Line 10: musst > musst -> must (typo) Gone -- To view, visit https://review.coreboot.org/c/flashrom/+/63832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I384c904c577b265dfe36bf46bf07c641bc29de9b Gerrit-Change-Number: 63832 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 03 May 2022 09:40:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: use `platform/` as subdir()
by Angel Pons (Code Review) 03 May '22

03 May '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk, Peter Marheine. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63826 ) Change subject: meson: use `platform/` as subdir() ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63826/comment/e18def6d_1cee0058 PS3, Line 8: > Is it more obvious now? IMHO it is, I'll let Felix decide. Commit Message: https://review.coreboot.org/c/flashrom/+/63826/comment/5d1fa470_4b4de4c4 PS4, Line 15: a no `a`: underlying -- To view, visit https://review.coreboot.org/c/flashrom/+/63826 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I88044a3f903f316138483dd872a6d95f8686ae69 Gerrit-Change-Number: 63826 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 03 May 2022 09:38:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022