April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Introduce an `include` directory for header files
by Thomas Heijligen (Code Review) 17 Apr '22

17 Apr '22

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen. Thomas Heijligen has uploaded a new patch set (#3) to the change originally created by Felix Singer. ( https://review.coreboot.org/c/flashrom/+/58622 ) Change subject: Introduce an `include` directory for header files ...................................................................... Introduce an `include` directory for header files Move all header files to the new `include` dicrectory. Adapt all `#include`s and the buildsystems to the new directory. Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf Signed-off-by: Felix Singer <felix.singer(a)secunet.com> Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile R include/chipdrivers.h R include/coreboot_tables.h R include/custom_baud.h R include/edi.h R include/ene.h R include/flash.h R include/flashchips.h R include/fmap.h R include/hwaccess_physmap.h R include/hwaccess_x86_io.h R include/hwaccess_x86_msr.h R include/i2c_helper.h R include/ich_descriptors.h R include/layout.h R include/libflashrom.h R include/platform.h R include/platform/pci.h R include/programmer.h R include/spi.h R include/usb_device.h R include/writeprotect.h M meson.build M platform/endian_big.c M platform/endian_little.c M platform/memaccess.c M util/ich_descriptors_tool/Makefile M util/ich_descriptors_tool/meson.build 28 files changed, 14 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/58622/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf Gerrit-Change-Number: 58622 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: sdfp.c: fixed initalization warining in probe_spi_sfdp serprog.c: fix...
by Aayush Kashyap (Code Review) 17 Apr '22

17 Apr '22

Aayush Kashyap has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63674 ) Change subject: sdfp.c: fixed initalization warining in probe_spi_sfdp serprog.c: fixed expected nonnull value warning in sp_stream_buffer_op ...................................................................... sdfp.c: fixed initalization warining in probe_spi_sfdp serprog.c: fixed expected nonnull value warning in sp_stream_buffer_op This patch fixes warnings relating to accessing uninitialized memory in sfdp.c and calling a function that expects non-NULL parameters with a NULL value in serprog.c. Change-Id: Ifa03d439e3cb572a708ff30834bc237500efedd5 Signed-off-by: Aayush Kashyap <kashyapaayush32(a)gmail.com> --- M serprog.c M sfdp.c 2 files changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/63674/1 diff --git a/serprog.c b/serprog.c index 2bbf44b..3c5d28b 100644 --- a/serprog.c +++ b/serprog.c @@ -291,7 +291,8 @@ return 1; } sp[0] = cmd; - memcpy(&(sp[1]), parms, parmlen); + if(parms) + memcpy(&(sp[1]), parms, parmlen); if (sp_streamed_transmit_bytes >= (1 + parmlen + sp_device_serbuf_size)) { if (sp_flush_stream() != 0) { diff --git a/sfdp.c b/sfdp.c index b549417..fbbe803 100644 --- a/sfdp.c +++ b/sfdp.c @@ -295,8 +295,8 @@ nph + 1, nph); /* Fetch all parameter headers, even if we don't use them all (yet). */ - hbuf = malloc((nph + 1) * 8); - hdrs = malloc((nph + 1) * sizeof(*hdrs)); + hbuf = calloc((nph + 1), 8); + hdrs = calloc((nph + 1), sizeof(*hdrs)); if (hbuf == NULL || hdrs == NULL ) { msg_gerr("Out of memory!\n"); goto cleanup_hdrs; -- To view, visit https://review.coreboot.org/c/flashrom/+/63674 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifa03d439e3cb572a708ff30834bc237500efedd5 Gerrit-Change-Number: 63674 Gerrit-PatchSet: 1 Gerrit-Owner: Aayush Kashyap <kashyapaayush32(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: [WIP] add me_unlock_tool
by Sergii Dmytruk (Code Review) 17 Apr '22

17 Apr '22

Attention is currently required from: Sergii Dmytruk. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63416 to look at the new patch set (#3). Change subject: [WIP] add me_unlock_tool ...................................................................... [WIP] add me_unlock_tool This is an alternative take on CB:56023 that implement ME unlocking in a separate tool. The only problem is: it links to a half of flashrom sources... Another issue is creation of a fake programmer for register_shutdown() to work. With the current state of the codebase, it's virtually impossible to do better. Check SVG file in the commit for a graph depicting import/export of function symbols from a subset of object files used by this tool. Change-Id: Ie8d66f1ee449ce8f2cbdc8c744e9b70428de533d Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M .gitignore M Makefile M board_enable.c M ichspi.c M programmer.h A util/me_unlock_tool/Makefile A util/me_unlock_tool/call-deps.svg A util/me_unlock_tool/me_unlock_tool.c A util/me_unlock_tool/meson.build M util/meson.build 10 files changed, 2,345 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/16/63416/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/63416 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie8d66f1ee449ce8f2cbdc8c744e9b70428de533d Gerrit-Change-Number: 63416 Gerrit-PatchSet: 3 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Close GitHub PRs and issues automatically
by Felix Singer (Code Review) 16 Apr '22

16 Apr '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63671 ) Change subject: Close GitHub PRs and issues automatically ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: An example implementation can be found here https://github.com/felixsinger/awesome-repo -- To view, visit https://review.coreboot.org/c/flashrom/+/63671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8076f0fb964970ffd05f355b9d1e33a65aa7a3c8 Gerrit-Change-Number: 63671 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 16 Apr 2022 20:32:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Close GitHub PRs and issues automatically
by Felix Singer (Code Review) 16 Apr '22

16 Apr '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63671 ) Change subject: Close GitHub PRs and issues automatically ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/flashrom/+/63671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8076f0fb964970ffd05f355b9d1e33a65aa7a3c8 Gerrit-Change-Number: 63671 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 16 Apr 2022 20:30:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ich_descriptors.c: Initialize structures
by Light (Code Review) 15 Apr '22

15 Apr '22

Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62763 ) Change subject: ich_descriptors.c: Initialize structures ...................................................................... Patch Set 11: (1 comment) File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/62763/comment/870886ea_d55ebc25 PS7, Line 1364: int ret = read_ich_descriptors_from_dump(dump, len, &cs, &desc); > I am inclined to go with this fix. What about you Nico? -- To view, visit https://review.coreboot.org/c/flashrom/+/62763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6e5bc84c6199a0731db0a9c8ef56f1215686dab2 Gerrit-Change-Number: 62763 Gerrit-PatchSet: 11 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 15 Apr 2022 19:25:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Light <aarya.chaumal(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Refactor Flashrom HW Sequencing Operation
by Subrata Banik (Code Review) 15 Apr '22

15 Apr '22

Attention is currently required from: Nico Huber, Subrata Banik, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62869 to look at the new patch set (#13). Change subject: ichspi: Refactor Flashrom HW Sequencing Operation ...................................................................... ichspi: Refactor Flashrom HW Sequencing Operation List of changes: 1. Add a unified `execute SPI flash transfer` function that does: - Check the SCIP bit prior initiate new operation. - Start the transfer by setting address and length for transfer, finally set FGO bit. - Wait for the transaction to get completed/failed/timed out. 2. All HW Sequencing SPI operation uses `execute SPI flash transfer` function BUG=b:223630977 TEST=Able to perform read/write/erase operation on PCH 600 series chipset (board name: Brya). Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ic9fd50841449e02f476a8834f4642d6ecad36dc3 --- M ichspi.c 1 file changed, 42 insertions(+), 55 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/62869/13 -- To view, visit https://review.coreboot.org/c/flashrom/+/62869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic9fd50841449e02f476a8834f4642d6ecad36dc3 Gerrit-Change-Number: 62869 Gerrit-PatchSet: 13 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ichspi: Refactor Flashrom HW Sequencing Operation
by Subrata Banik (Code Review) 15 Apr '22

15 Apr '22

Attention is currently required from: Nico Huber, Subrata Banik, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62869 to look at the new patch set (#12). Change subject: ichspi: Refactor Flashrom HW Sequencing Operation ...................................................................... ichspi: Refactor Flashrom HW Sequencing Operation List of changes: 1. Add a unified `execute SPI flash transfer` function that does: - Check the SCIP bit prior initiate new operation. - Start the transfer by setting address and length for transfer, finally set FGO bit. - Wait for the transaction to get completed/failed/timed out. 2. All HW Sequencing SPI operation uses `execute SPI flash transfer` function BUG=b:223630977 TEST=Able to perform read/write/erase operation on PCH 600 series chipset (board name: Brya). Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ic9fd50841449e02f476a8834f4642d6ecad36dc3 --- M ichspi.c 1 file changed, 42 insertions(+), 55 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/62869/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/62869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic9fd50841449e02f476a8834f4642d6ecad36dc3 Gerrit-Change-Number: 62869 Gerrit-PatchSet: 12 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ichspi: Introduce HSFC CYCLE READ/WRITE/ERASE macros
by Subrata Banik (Code Review) 15 Apr '22

15 Apr '22

Attention is currently required from: Subrata Banik, Nico Huber, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62868 to look at the new patch set (#16). Change subject: ichspi: Introduce HSFC CYCLE READ/WRITE/ERASE macros ...................................................................... ichspi: Introduce HSFC CYCLE READ/WRITE/ERASE macros This patch introduces useful macros (read/write/erase) and uses these macros throughout the SPI operations. Additionally, implicitly using the HSFC_CYCLE_READ macro for the SPI read operation. BUG=b:223630977 TEST=Able to perform read/write/erase operation on PCH 600 series chipset (board name: Brya). Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I3ea74b668e5f8d8e4b3da2a8ad8b81f1813e1e80 --- M ichspi.c 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/62868/16 -- To view, visit https://review.coreboot.org/c/flashrom/+/62868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3ea74b668e5f8d8e4b3da2a8ad8b81f1813e1e80 Gerrit-Change-Number: 62868 Gerrit-PatchSet: 16 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ichspi: Introduce HSFC_FDBC_VAL(n) macro
by Subrata Banik (Code Review) 15 Apr '22

15 Apr '22

Attention is currently required from: Subrata Banik, Nico Huber. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62892 to look at the new patch set (#9). Change subject: ichspi: Introduce HSFC_FDBC_VAL(n) macro ...................................................................... ichspi: Introduce HSFC_FDBC_VAL(n) macro This patch introduces HSFC_FDBC_VAL(n) macro to use in SPI read and write operations. BUG=b:223630977 TEST=Able to perform read/write/erase operation on PCH 600 series chipset (board name: Brya). Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ie2512c85de9fc21286234b97f5842ecef1729787 --- M ichspi.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/62892/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/62892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie2512c85de9fc21286234b97f5842ecef1729787 Gerrit-Change-Number: 62892 Gerrit-PatchSet: 9 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022