March 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: ft2232_spi.c: Add FTDI FT4233H
by Charles Parent (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Nico Huber, Charles Parent. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62480 to look at the new patch set (#2). Change subject: ft2232_spi.c: Add FTDI FT4233H ...................................................................... ft2232_spi.c: Add FTDI FT4233H Change tested to probe, read, write and erase a MT25QU256 through a FT4233H FTDI Change-Id: I73cee8fd2a6613a8fbc26508d99bbe67da2b4f72 Signed-off-by: Charles Parent <charles.parent(a)orolia2s.com> --- M ft2232_spi.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/62480/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I73cee8fd2a6613a8fbc26508d99bbe67da2b4f72 Gerrit-Change-Number: 62480 Gerrit-PatchSet: 2 Gerrit-Owner: Charles Parent <cha.parent(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Charles Parent <cha.parent(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ichspi: Add Alder Lake support
by Angel Pons (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Nico Huber, Rizwan Qureshi, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62251 ) Change subject: ichspi: Add Alder Lake support ...................................................................... Patch Set 12: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62251/comment/2e13eff3_09e0111a PS12, Line 12: TEST=```localhost ~ # flashrom --flash-name Any other tests, e.g. reading? If the ME region is locked, you can still read the other regions. A good test would be: flashrom -p internal --ifd -i fd -i bios -r filename.rom This makes use of flashrom's IFD parsing code to decide which parts of the flash chip should be read. This tests the changes to `guess_ich_chipset_from_content()`, please check the flashrom log to verify the correct chipset is detected. -- To view, visit https://review.coreboot.org/c/flashrom/+/62251 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie66cf519df13f3391c41f5016b16a81ef3dfd4bf Gerrit-Change-Number: 62251 Gerrit-PatchSet: 12 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 01 Mar 2022 10:27:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add FTDI FT4233H
by Angel Pons (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Charles Parent. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62480 ) Change subject: Add FTDI FT4233H ...................................................................... Patch Set 1: Code-Review+1 (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62480/comment/ff803ef4_47b286f9 PS1, Line 7: Add FTDI FT4233H nit: add the file as prefix: ft2232_spi.c: Add FTDI FT4233H https://review.coreboot.org/c/flashrom/+/62480/comment/686f1853_47fd5023 PS1, Line 8: Has this change been tested? If so, how? I'd appreciate if you could add this information to the commit message. https://review.coreboot.org/c/flashrom/+/62480/comment/2431836c_f712f852 PS1, Line 9: Change-Id: I73cee8fd2a6613a8fbc26508d99bbe67da2b4f72 You'd need to sign-off the commit as per https://flashrom.org/Development_Guidelines#Sign-off_Procedure Patchset: PS1: Welcome! Looks good, just some comments regarding the commit message. You can update the commit message by amending the commit and repushing: as long as the Change-Id remains the same, Gerrit will treat the new commit as a new patchset (version) of this change. Or you can update the commit message directly using Gerrit's Web UI. -- To view, visit https://review.coreboot.org/c/flashrom/+/62480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I73cee8fd2a6613a8fbc26508d99bbe67da2b4f72 Gerrit-Change-Number: 62480 Gerrit-PatchSet: 1 Gerrit-Owner: Charles Parent <cha.parent(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Charles Parent <cha.parent(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Mar 2022 10:22:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add FTDI FT4233H
by Charles Parent (Code Review) 01 Mar '22

01 Mar '22

Charles Parent has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62480 ) Change subject: Add FTDI FT4233H ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hello, We develop a PCIe card used for timing applications. The card needs to be flashed using a FTDI FT4233H (is connected to a MT25QU256 EEPROM) It tested flashrom because FT4232H was supported and FT4233H chip is very similar to FT4232H one. This PR adds productId for FT4233H chip. Please let me know if you need more information. Also as MT25QU256 is specified as untested I will gladly send you logs showing that Probe, read, write and erase works like charm using flashrom. Best regards, Charles -- To view, visit https://review.coreboot.org/c/flashrom/+/62480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I73cee8fd2a6613a8fbc26508d99bbe67da2b4f72 Gerrit-Change-Number: 62480 Gerrit-PatchSet: 1 Gerrit-Owner: Charles Parent <cha.parent(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Mar 2022 09:37:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add FTDI FT4233H
by Charles Parent (Code Review) 01 Mar '22

01 Mar '22

Charles Parent has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62480 ) Change subject: Add FTDI FT4233H ...................................................................... Add FTDI FT4233H Change-Id: I73cee8fd2a6613a8fbc26508d99bbe67da2b4f72 --- M ft2232_spi.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/62480/1 diff --git a/ft2232_spi.c b/ft2232_spi.c index 65326f9..ccd5f4c 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -36,6 +36,7 @@ #define FTDI_FT2232H_PID 0x6010 #define FTDI_FT4232H_PID 0x6011 #define FTDI_FT232H_PID 0x6014 +#define FTDI_FT4233H_PID 0x6041 #define TIAO_TUMPA_PID 0x8a98 #define TIAO_TUMPA_LITE_PID 0x8a99 #define AMONTEC_JTAGKEY_PID 0xCFF8 @@ -61,6 +62,7 @@ {FTDI_VID, FTDI_FT2232H_PID, OK, "FTDI", "FT2232H"}, {FTDI_VID, FTDI_FT4232H_PID, OK, "FTDI", "FT4232H"}, {FTDI_VID, FTDI_FT232H_PID, OK, "FTDI", "FT232H"}, + {FTDI_VID, FTDI_FT4233H_PID, OK, "FTDI", "FT4233H"}, {FTDI_VID, TIAO_TUMPA_PID, OK, "TIAO", "USB Multi-Protocol Adapter"}, {FTDI_VID, TIAO_TUMPA_LITE_PID, OK, "TIAO", "USB Multi-Protocol Adapter Lite"}, {FTDI_VID, AMONTEC_JTAGKEY_PID, OK, "Amontec", "JTAGkey"}, @@ -344,6 +346,9 @@ } else if (!strcasecmp(arg, "232H")) { ft2232_type = FTDI_FT232H_PID; channel_count = 1; + } else if (!strcasecmp(arg, "4233H")) { + ft2232_type = FTDI_FT4233H_PID; + channel_count = 4; } else if (!strcasecmp(arg, "jtagkey")) { ft2232_type = AMONTEC_JTAGKEY_PID; channel_count = 2; -- To view, visit https://review.coreboot.org/c/flashrom/+/62480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I73cee8fd2a6613a8fbc26508d99bbe67da2b4f72 Gerrit-Change-Number: 62480 Gerrit-PatchSet: 1 Gerrit-Owner: Charles Parent <cha.parent(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: ichspi: Add Alder Lake support
by Sam McNally (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Nico Huber, Rizwan Qureshi, Edward O'Callaghan, Angel Pons. Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62251 ) Change subject: ichspi: Add Alder Lake support ...................................................................... Patch Set 12: Code-Review+2 (1 comment) Patchset: PS12: Tested on Nivviks with ADL-N. -- To view, visit https://review.coreboot.org/c/flashrom/+/62251 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie66cf519df13f3391c41f5016b16a81ef3dfd4bf Gerrit-Change-Number: 62251 Gerrit-PatchSet: 12 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Mar 2022 07:43:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: writeprotect: add {get,set}_wp_mode()
by Anastasia Klimchuk (Code Review) 01 Mar '22

01 Mar '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/58483 ) Change subject: writeprotect: add {get,set}_wp_mode() ...................................................................... writeprotect: add {get,set}_wp_mode() BUG=b:195381327,b:153800563 BRANCH=none TEST=flashrom --wp-{enable,disable,status} Change-Id: I7b68e940f0e1359281806c98e1da119b4caf8405 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/58483 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M libflashrom.h M writeprotect.c 2 files changed, 47 insertions(+), 7 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve Edward O'Callaghan: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/libflashrom.h b/libflashrom.h index 83a6250..936c9ae 100644 --- a/libflashrom.h +++ b/libflashrom.h @@ -128,7 +128,9 @@ FLASHROM_WP_ERR_READ_FAILED = 3, FLASHROM_WP_ERR_WRITE_FAILED = 4, FLASHROM_WP_ERR_VERIFY_FAILED = 5, - FLASHROM_WP_ERR_RANGE_UNSUPPORTED = 6 + FLASHROM_WP_ERR_RANGE_UNSUPPORTED = 6, + FLASHROM_WP_ERR_MODE_UNSUPPORTED = 7, + FLASHROM_WP_ERR_RANGE_LIST_UNAVAILABLE = 8 }; enum flashrom_wp_mode { diff --git a/writeprotect.c b/writeprotect.c index 82ecd8e..6b3bbcf 100644 --- a/writeprotect.c +++ b/writeprotect.c @@ -348,6 +348,50 @@ return ret; } +/** Get the mode selected by a WP configuration. */ +static int get_wp_mode(enum flashrom_wp_mode *mode, const struct wp_bits *bits) +{ + if (!bits->srp_bit_present) + return FLASHROM_WP_ERR_CHIP_UNSUPPORTED; + + if (bits->srl_bit_present && bits->srl == 1) { + *mode = bits->srp ? FLASHROM_WP_MODE_PERMANENT : + FLASHROM_WP_MODE_POWER_CYCLE; + } else { + *mode = bits->srp ? FLASHROM_WP_MODE_HARDWARE : + FLASHROM_WP_MODE_DISABLED; + } + + return FLASHROM_WP_OK; +} + +/** Modify a wp_bits structure such that it will select a specified protection mode. */ +static int set_wp_mode(struct wp_bits *bits, const enum flashrom_wp_mode mode) +{ + switch (mode) { + case FLASHROM_WP_MODE_DISABLED: + bits->srl = 0; + bits->srp = 0; + return FLASHROM_WP_OK; + + case FLASHROM_WP_MODE_HARDWARE: + bits->srl = 0; + bits->srp = 1; + return FLASHROM_WP_OK; + + case FLASHROM_WP_MODE_POWER_CYCLE: + case FLASHROM_WP_MODE_PERMANENT: + default: + /* + * Don't try to enable power cycle or permanent protection for + * now. Those modes may be possible to activate on some chips, + * but they are usually unavailable by default or require special + * commands to activate. + */ + return FLASHROM_WP_ERR_MODE_UNSUPPORTED; + } +} + static bool chip_supported(struct flashctx *flash) { return (flash->chip != NULL) && (flash->chip->decode_range != NULL); @@ -367,11 +411,8 @@ if (ret == FLASHROM_WP_OK) ret = get_wp_range(&cfg->range, flash, &bits); - /* TODO: implement and get_wp_mode() and call it */ - /* if (ret == FLASHROM_WP_OK) ret = get_wp_mode(&cfg->mode, &bits); - */ return ret; } @@ -394,11 +435,8 @@ ret = write_wp_bits(flash, bits); /* Set protection mode */ - /* TODO: implement set_wp_mode() and use it */ - /* if (ret == FLASHROM_WP_OK) ret = set_wp_mode(&bits, cfg->mode); - */ if (ret == FLASHROM_WP_OK) ret = write_wp_bits(flash, bits); -- To view, visit https://review.coreboot.org/c/flashrom/+/58483 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7b68e940f0e1359281806c98e1da119b4caf8405 Gerrit-Change-Number: 58483 Gerrit-PatchSet: 68 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: writeprotect: add {get,set}_wp_mode()
by Anastasia Klimchuk (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58483 ) Change subject: writeprotect: add {get,set}_wp_mode() ...................................................................... Patch Set 67: Code-Review+2 (1 comment) File writeprotect.c: https://review.coreboot.org/c/flashrom/+/58483/comment/b0c2c3b7_4a5e08fd PS58, Line 366: } > I agree, the reversed order isn't very readable. […] Ok, I can see a reason to submit this one together with the previous, because it completes WP implementation which can be used from libflashrom. To summarise, there are two follow-ups to do on this first batch of 11 patches: 1) update the wiki page (from CB:58477) 2) and this little refactoring from here. -- To view, visit https://review.coreboot.org/c/flashrom/+/58483 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7b68e940f0e1359281806c98e1da119b4caf8405 Gerrit-Change-Number: 58483 Gerrit-PatchSet: 67 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Tue, 01 Mar 2022 05:11:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: writeprotect: add {get,set}_wp_mode()
by Nikolai Artemiev (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Angel Pons, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58483 ) Change subject: writeprotect: add {get,set}_wp_mode() ...................................................................... Patch Set 67: (1 comment) File writeprotect.c: https://review.coreboot.org/c/flashrom/+/58483/comment/e04b3599_ab4f152f PS58, Line 366: } > s/int/enum flashrom_wp_mode I agree, the reversed order isn't very readable. I'll create another patch to change it but leave this patch as-is so it can land with the other patches and complete the core WP implementation. -- To view, visit https://review.coreboot.org/c/flashrom/+/58483 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7b68e940f0e1359281806c98e1da119b4caf8405 Gerrit-Change-Number: 58483 Gerrit-PatchSet: 67 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Tue, 01 Mar 2022 04:56:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Add Alder Lake support
by Subrata Banik (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Sam McNally, Nico Huber, Rizwan Qureshi, Edward O'Callaghan, Angel Pons. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62251 ) Change subject: ichspi: Add Alder Lake support ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62251 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie66cf519df13f3391c41f5016b16a81ef3dfd4bf Gerrit-Change-Number: 62251 Gerrit-PatchSet: 12 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Mar 2022 04:43:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2022