November 2022 - flashrom-gerrit

[M] Change in flashrom[master]: sb600spi.c: Drop "Promontory" support
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/69170 ) Change subject: sb600spi.c: Drop "Promontory" support ...................................................................... Abandoned Prefer CB:68823 for now -- To view, visit https://review.coreboot.org/c/flashrom/+/69170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1457946dce68321b496d9ffa40a0c5ab46455f72 Gerrit-Change-Number: 69170 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[1.3.x_infdev]: sb600spi.c: Drop "Promontory" support
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/68823 ) Change subject: sb600spi.c: Drop "Promontory" support ...................................................................... sb600spi.c: Drop "Promontory" support The "Promontory" code is riddled with issues, some of them can result in soft bricks. Moreover, Promontory doesn't have a SPI controller. Drop support for "Promontory" in flashrom for now: it's holding back the entire project and it's unlikely that it'll be fixed in a timely manner. Change-Id: I1457946dce68321b496d9ffa40a0c5ab46455f72 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M sb600spi.c 1 file changed, 16 insertions(+), 42 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/68823/1 diff --git a/sb600spi.c b/sb600spi.c index 6020145..2e7be81 100644 --- a/sb600spi.c +++ b/sb600spi.c @@ -48,7 +48,6 @@ CHIPSET_HUDSON234, CHIPSET_BOLTON, CHIPSET_YANGTZE, - CHIPSET_PROMONTORY, }; #define FIFO_SIZE_OLD 8 @@ -124,18 +123,6 @@ if (rev == 0x4a) { msg_pdbg("Yangtze detected.\n"); return CHIPSET_YANGTZE; - /** - * FCH chipsets called 'Promontory' are one's with the - * so-called SPI100 ip core that uses memory mapping and - * not a ring buffer for transactions. Typically this is - * found on both Stoney Ridge and Zen platforms. - * - * The revisions I have found by searching various lspci - * outputs are as follows: 0x4b, 0x59, 0x61 & 0x71. - */ - } else if (rev == 0x4b || rev == 0x51 || rev == 0x59 || rev == 0x61 || rev == 0x71) { - msg_pdbg("Promontory (rev 0x%02x) detected.\n", rev); - return CHIPSET_PROMONTORY; } else { msg_pwarn("FCH device found but SMBus revision 0x%02x does not match known values.\n" "Please report this to flashrom(a)flashrom.org and include this log and\n" @@ -572,18 +559,6 @@ return amd_imc_shutdown(dev); } -static int promontory_read_memmapped(struct flashctx *flash, uint8_t *buf, - unsigned int start, unsigned int len) -{ - struct sb600spi_data * data = (struct sb600spi_data *)flash->mst->spi.data; - if (!data->flash) { - map_flash(flash); - data->flash = flash; /* keep a copy of flashctx for unmap() on tear-down. */ - } - mmio_readn((void *)(flash->virtual_memory + start), buf, len); - return 0; -} - static int sb600spi_shutdown(void *data) { struct sb600spi_data *sb600_data = data; @@ -623,20 +598,6 @@ .probe_opcode = default_spi_probe_opcode, }; -static const struct spi_master spi_master_promontory = { - .max_data_read = MAX_DATA_READ_UNLIMITED, - .max_data_write = FIFO_SIZE_YANGTZE - 3, - .command = spi100_spi_send_command, - .multicommand = default_spi_send_multicommand, - .map_flash_region = physmap, - .unmap_flash_region = physunmap, - .read = promontory_read_memmapped, - .write_256 = default_spi_write_256, - .write_aai = default_spi_write_aai, - .shutdown = sb600spi_shutdown, - .probe_opcode = default_spi_probe_opcode, -}; - int sb600_probe_spi(const struct programmer_cfg *cfg, struct pci_dev *dev) { struct pci_dev *smbus_dev; @@ -740,7 +701,6 @@ case CHIPSET_SB89XX: case CHIPSET_HUDSON234: case CHIPSET_YANGTZE: - case CHIPSET_PROMONTORY: msg_pdbg(", SpiBusy=%i", (tmp >> 31) & 0x1); default: break; } @@ -817,8 +777,6 @@ register_spi_master(&spi_master_sb600, data); else if (amd_gen == CHIPSET_YANGTZE) register_spi_master(&spi_master_yangtze, data); - else - register_spi_master(&spi_master_promontory, data); return 0; } -- To view, visit https://review.coreboot.org/c/flashrom/+/68823 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.3.x_infdev Gerrit-Change-Id: I1457946dce68321b496d9ffa40a0c5ab46455f72 Gerrit-Change-Number: 68823 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[refs/meta/config]: Allow self (Angel) to create branches
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/68822 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Allow self (Angel) to create branches ...................................................................... Allow self (Angel) to create branches Change-Id: Iada3e3cc1c1c87e9e6b488f6bc1b43da6c1b3da9 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/68822 --- M project.config 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Angel Pons: Verified; Looks good to me, approved diff --git a/project.config b/project.config index 8b79b27..3971d25 100644 --- a/project.config +++ b/project.config @@ -51,9 +51,11 @@ owner = group user/build bot (Jenkins) (jenkins) [access "refs/heads/*"] exclusiveGroupPermissions = create delete submit + create = group user/Angel Pons (Th3Fanbus) create = group user/David Hendricks (dhendrix) create = group user/Nico Huber (Nico) create = group user/Stefan T (stefanct) + delete = group user/Angel Pons (Th3Fanbus) delete = group user/David Hendricks (dhendrix) delete = group user/Nico Huber (Nico) delete = group user/Stefan T (stefanct) -- To view, visit https://review.coreboot.org/c/flashrom/+/68822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: Iada3e3cc1c1c87e9e6b488f6bc1b43da6c1b3da9 Gerrit-Change-Number: 68822 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[refs/meta/config]: Allow self (Angel) to create branches
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68822 to look at the new patch set (#3). Change subject: Allow self (Angel) to create branches ...................................................................... Allow self (Angel) to create branches Change-Id: Iada3e3cc1c1c87e9e6b488f6bc1b43da6c1b3da9 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M project.config 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/68822/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/68822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: Iada3e3cc1c1c87e9e6b488f6bc1b43da6c1b3da9 Gerrit-Change-Number: 68822 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[refs/meta/config]: Allow self to create branches
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68822 ) Change subject: Allow self to create branches ...................................................................... Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: Iada3e3cc1c1c87e9e6b488f6bc1b43da6c1b3da9 Gerrit-Change-Number: 68822 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 Nov 2022 23:04:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[refs/meta/config]: Allow self to create branches
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Angel Pons. Angel Pons has removed a vote from this change. ( https://review.coreboot.org/c/flashrom/+/68822 ) Change subject: Allow self to create branches ...................................................................... Removed Verified-1 by build bot (Jenkins) <no-reply(a)coreboot.org> -- To view, visit https://review.coreboot.org/c/flashrom/+/68822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: Iada3e3cc1c1c87e9e6b488f6bc1b43da6c1b3da9 Gerrit-Change-Number: 68822 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: deleteVote

1 0

[S] Change in flashrom[refs/meta/config]: Allow self to create branches
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Angel Pons. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68822 to look at the new patch set (#2). Change subject: Allow self to create branches ...................................................................... Allow self to create branches Change-Id: Iada3e3cc1c1c87e9e6b488f6bc1b43da6c1b3da9 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M project.config 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/68822/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: Iada3e3cc1c1c87e9e6b488f6bc1b43da6c1b3da9 Gerrit-Change-Number: 68822 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[refs/meta/config]: Review access change
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/68822 ) Change subject: Review access change ...................................................................... Review access change Change-Id: Iada3e3cc1c1c87e9e6b488f6bc1b43da6c1b3da9 --- M project.config 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/68822/1 diff --git a/project.config b/project.config index 8b79b27..3971d25 100644 --- a/project.config +++ b/project.config @@ -51,9 +51,11 @@ owner = group user/build bot (Jenkins) (jenkins) [access "refs/heads/*"] exclusiveGroupPermissions = create delete submit + create = group user/Angel Pons (Th3Fanbus) create = group user/David Hendricks (dhendrix) create = group user/Nico Huber (Nico) create = group user/Stefan T (stefanct) + delete = group user/Angel Pons (Th3Fanbus) delete = group user/David Hendricks (dhendrix) delete = group user/Nico Huber (Nico) delete = group user/Stefan T (stefanct) -- To view, visit https://review.coreboot.org/c/flashrom/+/68822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: Iada3e3cc1c1c87e9e6b488f6bc1b43da6c1b3da9 Gerrit-Change-Number: 68822 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: sb600spi.c: Drop "Promontory" support
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/69170 ) Change subject: sb600spi.c: Drop "Promontory" support ...................................................................... sb600spi.c: Drop "Promontory" support The "Promontory" code is riddled with issues, some of them can result in soft bricks. Moreover, Promontory doesn't have a SPI controller. Drop support for "Promontory" in flashrom for now: it's holding back the entire project and it's unlikely that it'll be fixed in a timely manner. Change-Id: I1457946dce68321b496d9ffa40a0c5ab46455f72 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M sb600spi.c 1 file changed, 16 insertions(+), 42 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/69170/1 diff --git a/sb600spi.c b/sb600spi.c index 6020145..2e7be81 100644 --- a/sb600spi.c +++ b/sb600spi.c @@ -48,7 +48,6 @@ CHIPSET_HUDSON234, CHIPSET_BOLTON, CHIPSET_YANGTZE, - CHIPSET_PROMONTORY, }; #define FIFO_SIZE_OLD 8 @@ -124,18 +123,6 @@ if (rev == 0x4a) { msg_pdbg("Yangtze detected.\n"); return CHIPSET_YANGTZE; - /** - * FCH chipsets called 'Promontory' are one's with the - * so-called SPI100 ip core that uses memory mapping and - * not a ring buffer for transactions. Typically this is - * found on both Stoney Ridge and Zen platforms. - * - * The revisions I have found by searching various lspci - * outputs are as follows: 0x4b, 0x59, 0x61 & 0x71. - */ - } else if (rev == 0x4b || rev == 0x51 || rev == 0x59 || rev == 0x61 || rev == 0x71) { - msg_pdbg("Promontory (rev 0x%02x) detected.\n", rev); - return CHIPSET_PROMONTORY; } else { msg_pwarn("FCH device found but SMBus revision 0x%02x does not match known values.\n" "Please report this to flashrom(a)flashrom.org and include this log and\n" @@ -572,18 +559,6 @@ return amd_imc_shutdown(dev); } -static int promontory_read_memmapped(struct flashctx *flash, uint8_t *buf, - unsigned int start, unsigned int len) -{ - struct sb600spi_data * data = (struct sb600spi_data *)flash->mst->spi.data; - if (!data->flash) { - map_flash(flash); - data->flash = flash; /* keep a copy of flashctx for unmap() on tear-down. */ - } - mmio_readn((void *)(flash->virtual_memory + start), buf, len); - return 0; -} - static int sb600spi_shutdown(void *data) { struct sb600spi_data *sb600_data = data; @@ -623,20 +598,6 @@ .probe_opcode = default_spi_probe_opcode, }; -static const struct spi_master spi_master_promontory = { - .max_data_read = MAX_DATA_READ_UNLIMITED, - .max_data_write = FIFO_SIZE_YANGTZE - 3, - .command = spi100_spi_send_command, - .multicommand = default_spi_send_multicommand, - .map_flash_region = physmap, - .unmap_flash_region = physunmap, - .read = promontory_read_memmapped, - .write_256 = default_spi_write_256, - .write_aai = default_spi_write_aai, - .shutdown = sb600spi_shutdown, - .probe_opcode = default_spi_probe_opcode, -}; - int sb600_probe_spi(const struct programmer_cfg *cfg, struct pci_dev *dev) { struct pci_dev *smbus_dev; @@ -740,7 +701,6 @@ case CHIPSET_SB89XX: case CHIPSET_HUDSON234: case CHIPSET_YANGTZE: - case CHIPSET_PROMONTORY: msg_pdbg(", SpiBusy=%i", (tmp >> 31) & 0x1); default: break; } @@ -817,8 +777,6 @@ register_spi_master(&spi_master_sb600, data); else if (amd_gen == CHIPSET_YANGTZE) register_spi_master(&spi_master_yangtze, data); - else - register_spi_master(&spi_master_promontory, data); return 0; } -- To view, visit https://review.coreboot.org/c/flashrom/+/69170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1457946dce68321b496d9ffa40a0c5ab46455f72 Gerrit-Change-Number: 69170 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: meson: Move programmer test sources into programmer definition
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68162 ) Change subject: meson: Move programmer test sources into programmer definition ...................................................................... Patch Set 16: Code-Review+1 (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/68162/comment/d7af5115_e4e14524 PS16, Line 191: 'test_srcs' : > I also don't like it : / I'm not sure if I should fix the indentation in this patch or in a separate […] Let's do it in a follow-up -- To view, visit https://review.coreboot.org/c/flashrom/+/68162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I307faaf8a9f7ae3c54bd96e7d871a3abb8aadea3 Gerrit-Change-Number: 68162 Gerrit-PatchSet: 16 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 02 Nov 2022 19:20:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2022