November 2022 - flashrom-gerrit

[S] Change in flashrom[master]: ichspi: clear byte count in ich_start_hwseq_xfer()
by Edward O'Callaghan (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Subrata Banik, Angel Pons, Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69422 ) Change subject: ichspi: clear byte count in ich_start_hwseq_xfer() ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > > Did you test if `ich_hwseq_block_erase()` still works? Looking at CB:62869 it did not clear the by […] Also thank you Angel for pulling on this thread to get a deeper investigation going here so that we could get to the bottom of this. -- To view, visit https://review.coreboot.org/c/flashrom/+/69422 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2535bdfb77ff370bddcb507a229bbf4119681cdf Gerrit-Change-Number: 69422 Gerrit-PatchSet: 2 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 17 Nov 2022 23:58:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[master]: flashrom/gui: Add GUI to Flashrom
by Iman Bingi (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Thomas Heijligen. Iman Bingi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69714 ) Change subject: flashrom/gui: Add GUI to Flashrom ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Hi, I'm not able to run your patch on Linux. […] Hi Thomas, You are right, I just wanted to kick start the patch. I will get those errors fixed in upcoming patchsets. BTW i'm using mingw on windows. -- To view, visit https://review.coreboot.org/c/flashrom/+/69714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266 Gerrit-Change-Number: 69714 Gerrit-PatchSet: 2 Gerrit-Owner: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Thu, 17 Nov 2022 21:53:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[master]: flashrom/gui: Add GUI to Flashrom
by Thomas Heijligen (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Iman Bingi. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69714 ) Change subject: flashrom/gui: Add GUI to Flashrom ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Hi, I'm not able to run your patch on Linux. - The Makefile is missing the linking against the external libraries - data_buffer.c: Missing `#include <stdio.h>` for `FILE` - main.c: `LOCALDIR` is not defined When I patch those errors and get it to compile, I'm getting a `core dump` ``` (process:521838): GLib-GIO-CRITICAL **: 20:53:37.274: g_settings_get_enum() called on key 'font' which is not associated with an enumerated type (gflashrom:521838): GLib-GObject-CRITICAL **: 20:53:37.631: g_param_spec_object: assertion 'g_type_is_a (object_type, G_TYPE_OBJECT)' failed (gflashrom:521838): GLib-GObject-CRITICAL **: 20:53:37.631: validate_pspec_to_install: assertion 'G_IS_PARAM_SPEC (pspec)' failed (gflashrom:521838): GLib-GObject-CRITICAL **: 20:53:37.631: g_param_spec_ref_sink: assertion 'G_IS_PARAM_SPEC (pspec)' failed (gflashrom:521838): GLib-GObject-CRITICAL **: 20:53:37.631: g_param_spec_unref: assertion 'G_IS_PARAM_SPEC (pspec)' failed make: *** [Makefile:32: all] Segmentation fault (core dumped) ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/69714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266 Gerrit-Change-Number: 69714 Gerrit-PatchSet: 2 Gerrit-Owner: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Comment-Date: Thu, 17 Nov 2022 19:54:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashrom.c: Supplement `chip->unlock()` calls with wp unlocking
by Sergii Dmytruk (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69517 ) Change subject: flashrom.c: Supplement `chip->unlock()` calls with wp unlocking ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/69517 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I74b3f5d3a17749ea60485b916b2d87467a5d8b2f Gerrit-Change-Number: 69517 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 17 Nov 2022 16:39:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom.c: Use goto in err path of prepare_flash_access()
by Sergii Dmytruk (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69516 ) Change subject: flashrom.c: Use goto in err path of prepare_flash_access() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/69516 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie4f885d7f01fc78e6e431e96435757108bbf0005 Gerrit-Change-Number: 69516 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 17 Nov 2022 16:39:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: tests: add probe lifecycle test for ch341a_spi
by Alexander Goncharov (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Anastasia Klimchuk. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68755 ) Change subject: tests: add probe lifecycle test for ch341a_spi ...................................................................... Patch Set 3: (1 comment) File tests/ch341a_spi.c: https://review.coreboot.org/c/flashrom/+/68755/comment/f752ed84_34780577 PS2, Line 26: struct libusb_transfer *transfer_in; > I see the programmer has an array of these, but io_state has one. […] OK, I've done it. Does it seem clear to you? -- To view, visit https://review.coreboot.org/c/flashrom/+/68755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0a2d5591d097435fc69719e1d9bd153433425821 Gerrit-Change-Number: 68755 Gerrit-PatchSet: 3 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 17 Nov 2022 16:33:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: tests: add basic lifecycle test for ch341a_spi
by Alexander Goncharov (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67664 ) Change subject: tests: add basic lifecycle test for ch341a_spi ...................................................................... Patch Set 9: (2 comments) File tests/ch341a_spi.c: https://review.coreboot.org/c/flashrom/+/67664/comment/44ab14e7_ffde9cc7 PS5, Line 22: transfer->status = LIBUSB_TRANSFER_COMPLETED; : transfer->actual_length = transfer->length; : transfer->callback(transfer); > Thank you so much for the detailed explanation, I appreciate a lot! […] Finally, I've wrote :D File tests/ch341a_spi.c: https://review.coreboot.org/c/flashrom/+/67664/comment/e7eed9cf_630a9e26 PS8, Line 38: if (transfer->endpoint == WRITE_EP) > Just wanted to mention: the assertion on the previous line makes sure this condition is always true. […] I agree with your suggestion, let's add this piece of code in the next patch. -- To view, visit https://review.coreboot.org/c/flashrom/+/67664 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If28fbe09ad685082152aa3a7e8d5a150169aee9e Gerrit-Change-Number: 67664 Gerrit-PatchSet: 9 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 17 Nov 2022 16:30:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: tests: add probe lifecycle test for ch341a_spi
by Alexander Goncharov (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Alexander Goncharov. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68755 to look at the new patch set (#3). Change subject: tests: add probe lifecycle test for ch341a_spi ...................................................................... tests: add probe lifecycle test for ch341a_spi Change-Id: I0a2d5591d097435fc69719e1d9bd153433425821 Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> --- M tests/ch341a_spi.c M tests/tests.c M tests/tests.h 3 files changed, 55 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/68755/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/68755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0a2d5591d097435fc69719e1d9bd153433425821 Gerrit-Change-Number: 68755 Gerrit-PatchSet: 3 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: ichspi: clear byte count in ich_start_hwseq_xfer()
by Subrata Banik (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Angel Pons, Nikolai Artemiev. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69422 ) Change subject: ichspi: clear byte count in ich_start_hwseq_xfer() ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Did you test if `ich_hwseq_block_erase()` still works? Looking at CB:62869 it did not clear the byte count before. Seems like the original HW seq refactoring being done by me left few things open (based on the assumption of the EDS default value) and resulted in regression (as mentioned in the commit msg of the CLs https://review.coreboot.org/q/topic:fix_hw_seq_regression). Kindly help to review those https://review.coreboot.org/q/topic:fix_hw_seq_regression -- To view, visit https://review.coreboot.org/c/flashrom/+/69422 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2535bdfb77ff370bddcb507a229bbf4119681cdf Gerrit-Change-Number: 69422 Gerrit-PatchSet: 2 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 17 Nov 2022 15:54:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: tests: add basic lifecycle test for ch341a_spi
by Alexander Goncharov (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Alexander Goncharov. Hello build bot (Jenkins), Thomas Heijligen, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67664 to look at the new patch set (#9). Change subject: tests: add basic lifecycle test for ch341a_spi ...................................................................... tests: add basic lifecycle test for ch341a_spi Change-Id: If28fbe09ad685082152aa3a7e8d5a150169aee9e Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> --- A tests/ch341a_spi.c M tests/io_mock.h M tests/libusb_wraps.c M tests/libusb_wraps.h M tests/meson.build M tests/tests.c M tests/tests.h M tests/usb_unittests.h 8 files changed, 194 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/64/67664/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/67664 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If28fbe09ad685082152aa3a7e8d5a150169aee9e Gerrit-Change-Number: 67664 Gerrit-PatchSet: 9 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2022