September 2021 - flashrom-gerrit

Change in flashrom[master]: acpi_ec: Implement basic ACPI embedded controller API
by Michał Żygowski (Code Review) 08 Sep '21

08 Sep '21

Attention is currently required from: Nico Huber, Michał Żygowski, Michael Niewöhner. Hello build bot (Jenkins), Nico Huber, Sergii Dmytruk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55714 to look at the new patch set (#8). Change subject: acpi_ec: Implement basic ACPI embedded controller API ...................................................................... acpi_ec: Implement basic ACPI embedded controller API Implement basic functions to read/write EC registers and send standard ACPI EC commands. Those may prove useful in possible future implementations of embedded controllers in flashrom and are required to support EC firmware flashing on Tuxedo laptops. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Change-Id: Ie3bae8d81c80ae2f286b619e974869e3f2f4545d --- M Makefile A acpi_ec.c A acpi_ec.h 3 files changed, 154 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/14/55714/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/55714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie3bae8d81c80ae2f286b619e974869e3f2f4545d Gerrit-Change-Number: 55714 Gerrit-PatchSet: 8 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: board_enable.c: Add ME unlock function for TUXEDO laptops
by Michał Żygowski (Code Review) 08 Sep '21

08 Sep '21

Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56023 ) Change subject: board_enable.c: Add ME unlock function for TUXEDO laptops ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: Some feedback about the current state of the code vs open discussions would be appreciated. Thanks -- To view, visit https://review.coreboot.org/c/flashrom/+/56023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6bf1c40900aa674e3ea4f6add12dae8b73759fbb Gerrit-Change-Number: 56023 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 08 Sep 2021 17:17:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add Tiger Lake U Premium support
by Michał Żygowski (Code Review) 08 Sep '21

08 Sep '21

Attention is currently required from: Nico Huber, Paul Menzel. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55578 ) Change subject: Add Tiger Lake U Premium support ...................................................................... Patch Set 9: (3 comments) File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/55578/comment/1c8c912c_72c69259 PS3, Line 659: { "eSPI", BUS_LPC | BUS_FWH } }; > Added BUS_ESPI enum and removed LPC/FWH. […] Ping File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/55578/comment/c71db3e4_640360e5 PS5, Line 278: return "reserved"; > Added a separate function that will print either read frequency or EC/eSPI frequency for CNL/CML (ba […] Kindly asking to check if it does look good now https://review.coreboot.org/c/flashrom/+/55578/comment/1b6443bf_eec25fba PS5, Line 967: return CHIPSET_500_SERIES_TIGER_POINT; > Added a new enum for the new fields and used it in the condition Please check -- To view, visit https://review.coreboot.org/c/flashrom/+/55578 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I28f3b6fe9f8ce9e976a6808683f46b6f4ec72bdd Gerrit-Change-Number: 55578 Gerrit-PatchSet: 9 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 08 Sep 2021 17:15:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops
by Michał Żygowski (Code Review) 08 Sep '21

08 Sep '21

Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 ) Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ...................................................................... Patch Set 14: (12 comments) Patchset: PS4: > Yeah, I started some work on the Super I/O is preceding patch: 55849 […] Now I probe only for ITE Super I/Os. Just added more model IDs in the switch to catch the supported chips. Redesigning Super I/O code needs more thought and I won't pursue it right now. DMI checks have been replaced with PCI ID and SSID checks to not depend on any dmidecoder (which may fail depending on UEFI vs legacy). Patchset: PS11: > Ack Changed the name to ite_ecfw File Makefile: https://review.coreboot.org/c/flashrom/+/55715/comment/7a70ef3a_dff88d82 PS1, Line 409: ifeq ($(CONFIG_TUXEDO_EC), yes) : UNSUPPORTED_FEATURES += CONFIG_TUXEDO_EC=yes : else : override CONFIG_TUXEDO_EC = no : endif > Currently there is no coreboot (and libpayload) support for Tuxedo laptops, thus it is disabled here […] Ack https://review.coreboot.org/c/flashrom/+/55715/comment/2c1fdca4_c14131e7 PS1, Line 903: # Disable internal DMI decoder to be able to locate DMI tables on EFI systems and match TUXEDO laptops > The TUXEDO laptops currenlty come with an UEFI firmware from IBV, no CSM support, so the only way to […] DMI checks have been replaced with PCI ID and SSID checks File flashrom.8.tmpl: https://review.coreboot.org/c/flashrom/+/55715/comment/3d4487e2_3edacd54 PS1, Line 1399: autoloading > I can only guess. […] Elaborated a bit on this in the man entry https://review.coreboot.org/c/flashrom/+/55715/comment/4986721f_eb51bbdb PS1, Line 1411: ite5570 > The code automatically detects ITE5570, however it can be forcefully set as in the reference impleme […] Removed the option to force IT5570. It is automatically detected and selected right now and it should suffice. File flashrom.c: https://review.coreboot.org/c/flashrom/+/55715/comment/5a68766b_ace364a7 PS1, Line 2109: #if CONFIG_TUXEDO_EC == 1 > > The coreboot check above is a very bad rolemodel. It does things flashrom shouldn't […] For now I have left this function as global API. It works as expected and can be included in any future programmer API if needed. File ite_ec.c: https://review.coreboot.org/c/flashrom/+/55715/comment/beff25c1_18b648fd PS11, Line 735: if (!ec_write_reg(0xf9, 0x20, EC_MAX_STATUS_CHECKS) || : !ec_write_reg(0xfa, 0x02, EC_MAX_STATUS_CHECKS) || : !ec_write_reg(0xfb, 0x00, EC_MAX_STATUS_CHECKS) || : !ec_write_reg(0xf8, 0xb1, EC_MAX_STATUS_CHECKS)) { : msg_perr("Unable to initialize controller.\n"); : return 1; : } : > I found out what this does: […] Added a separate function for this purpose. Please check File ite_ec.c: https://review.coreboot.org/c/flashrom/+/55715/comment/957e0b40_5ea69886 PS13, Line 53: controlls the flash mirroring > nit: controls flash mirroring Done https://review.coreboot.org/c/flashrom/+/55715/comment/07781541_6b24dae3 PS13, Line 78: struct ite_string { > L140CU signatures: […] Added some structure defining those bits. Please check https://review.coreboot.org/c/flashrom/+/55715/comment/7dfcf0c4_34426878 PS13, Line 314: 0x06 > EC_CMD_WRITE_KBYTE Done https://review.coreboot.org/c/flashrom/+/55715/comment/e6f016b8_7307439a PS13, Line 554: p = extract_programmer_param("ite5570"); > I am already detecting it. You may be right that there is no use for it anymore. Removed the programmer option to set the it5570 by the user. -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 14 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Wed, 08 Sep 2021 16:59:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops
by Michał Żygowski (Code Review) 08 Sep '21

08 Sep '21

Attention is currently required from: Nico Huber, Michał Żygowski, Paul Menzel. Hello Felix Singer, build bot (Jenkins), Nico Huber, Sergii Dmytruk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55715 to look at the new patch set (#15). Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ...................................................................... ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops Add a new programmer supporting ITE Embedded Controllers found on TUXEDO laptops. Tested on TUXEDO InfinityBook S 14 Gen6 and 15 Gen6 with EC firmware updates from IBV, EC versions 1.07.02TR1 and 1.07.04TR4. Example standard command to update EC firmware on a TUXEDO laptop: "flashrom -p ite_ec:romsize=128K,autoload=disable -w eL14MU02.TR1" Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 --- M Makefile M flashrom.8.tmpl M it87spi.c A ite_ecfw.c A ite_ecfw.h M meson.build M meson_options.txt M programmer.h M programmer_table.c 9 files changed, 1,096 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/15/55715/15 -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 15 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops
by Michał Żygowski (Code Review) 08 Sep '21

08 Sep '21

Attention is currently required from: Nico Huber, Michał Żygowski, Paul Menzel, Sergii Dmytruk. Hello Felix Singer, build bot (Jenkins), Nico Huber, Sergii Dmytruk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55715 to look at the new patch set (#14). Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ...................................................................... ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops Add a new programmer supporting ITE Embedded Controllers found on TUXEDO laptops. Tested on TUXEDO InfinityBook S 14 Gen6 and 15 Gen6 with EC firmware updates from IBV, EC versions 1.07.02TR1 and 1.07.04TR4. Example standard command to update EC firmware on a TUXEDO laptop: "flashrom -p ite_ec:romsize=128K,autoload=disable -w eL14MU02.TR1" Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 --- M Makefile M flashrom.8.tmpl M it87spi.c A ite_ecfw.c A ite_ecfw.h M meson.build M meson_options.txt M programmer.h M programmer_table.c 9 files changed, 1,096 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/15/55715/14 -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 14 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests: Add NOT_ZERO and NOT_NULL macros to the header file
by Anastasia Klimchuk (Code Review) 08 Sep '21

08 Sep '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57269 ) Change subject: tests: Add NOT_ZERO and NOT_NULL macros to the header file ...................................................................... Patch Set 1: (2 comments) File tests/io_mock.h: https://review.coreboot.org/c/flashrom/+/57269/comment/3baf0341_0e165af4 PS1, Line 37: NOT > NONZERO ? Would you agree on NON_ZERO (with underscore)? I think it's a bit more readable. https://review.coreboot.org/c/flashrom/+/57269/comment/863054d9_246ca3d4 PS1, Line 38: NOT_NULL ((void *)NOT_ZERO) > I wonder if this should be a function ptr address so that you can set a break point on the address e […] Is it ok for this stub function to be in this header? And also, the same question as previous comment, is it ok to have not_null() and non_zero() with underscores? -- To view, visit https://review.coreboot.org/c/flashrom/+/57269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5ad6ee4aa9091447c6c9108c92bf7f6e755fca48 Gerrit-Change-Number: 57269 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 08 Sep 2021 06:58:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Extract setup and teardown for chip tests
by Edward O'Callaghan (Code Review) 07 Sep '21

07 Sep '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57436 ) Change subject: tests: Extract setup and teardown for chip tests ...................................................................... Patch Set 1: Code-Review+1 (3 comments) File tests/chip.c: https://review.coreboot.org/c/flashrom/+/57436/comment/4e305b53_15b3b205 PS1, Line 29: g_chip_state I wonder if it is time to embed this into `data` of the flashctx to avoid possible test coupling. Things like `reset_global_chip_state()` are signs that this could be a good idea to consider. https://review.coreboot.org/c/flashrom/+/57436/comment/55a52ebf_6b509d87 PS1, Line 89: static void reset_global_chip_state() : { : g_chip_state.unlock_calls = 0; : } Just inline this function to the one call site. OK more generally in OOP speak here; It is best to avoid having global state management functions which are akin to a singleton class and instead use generators for this kind of state. https://review.coreboot.org/c/flashrom/+/57436/comment/74a8e006_b2731b70 PS1, Line 94: setup_for_chip > Usually this would be a statement, e.g. just `set_up_chip`. +1 drop the _for_ just `setup_chip()` -- To view, visit https://review.coreboot.org/c/flashrom/+/57436 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If59315646f06344664df08b145866d9ce846d751 Gerrit-Change-Number: 57436 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 07 Sep 2021 12:56:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Make chip definitions static global
by Edward O'Callaghan (Code Review) 07 Sep '21

07 Sep '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57437 ) Change subject: tests: Make chip definitions static global ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/57437/comment/b4834199_d696fee6 PS2, Line 7: static it isn't static though unless you use the keyword 'static' ;) -- To view, visit https://review.coreboot.org/c/flashrom/+/57437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia9b5fc71e30610684e68e9aca9fb1970da8f840a Gerrit-Change-Number: 57437 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 07 Sep 2021 12:47:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Extract setup and teardown for chip tests
by Nico Huber (Code Review) 07 Sep '21

07 Sep '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57436 ) Change subject: tests: Extract setup and teardown for chip tests ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File tests/chip.c: https://review.coreboot.org/c/flashrom/+/57436/comment/1de248ca_0260a57f PS1, Line 94: setup_for_chip Usually this would be a statement, e.g. just `set_up_chip`. -- To view, visit https://review.coreboot.org/c/flashrom/+/57436 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If59315646f06344664df08b145866d9ce846d751 Gerrit-Change-Number: 57436 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 07 Sep 2021 11:48:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2021