Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57326 )
Change subject: tests: Add tests to read from chip
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS1:
> Can the refactor and the new tests be split into two patches to make it slightly easier to review?
Yes, I created a chain so that it's more readable. Previous one CB:57436 extracts setup and teardown, this one adds new tests.
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/57326/comment/de3f172d_d46ef6d0
PS1, Line 232: 16
> I was really wondering what this is about... I guess you mean the […]
There was something in my head when I was writing this comment, but I feel it's not that relevant anymore. I removed the comment (comes into effect in CB:57437). Also this size is really small, should be more realistic, which is also done in CB:57437.
I recall now, in the very first chip test there was a comment on why chip is so small.
In general, I was thinking, this can be expanded to test small or large chips, and various eraseblocks.
https://review.coreboot.org/c/flashrom/+/57326/comment/7e55bdec_da035d2e
PS1, Line 246: };
> Should these be static/global so they can be shared among test functions?
Yes right, they started to repeat once more tests have been added. I created CB:57437 for this.
--
To view, visit https://review.coreboot.org/c/flashrom/+/57326
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia57781ebc670c7bd6197e56fe8a20651a425c756
Gerrit-Change-Number: 57326
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Tue, 07 Sep 2021 05:58:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/57437
to look at the new patch set (#2).
Change subject: tests: Make chip definitions static global
......................................................................
tests: Make chip definitions static global
This way chip definitions can be reused between test functions.
Existing mock chip is promoted from 8KiB to 8MiB and eraseblocks
are expanded accordingly. Old value of 8KiB was very small and it
was confusing. Mock chip looks more realistic now.
BUG=b:181803212
TEST=builds and ninja test
Change-Id: Ia9b5fc71e30610684e68e9aca9fb1970da8f840a
Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org>
---
M tests/chip.c
1 file changed, 51 insertions(+), 112 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/57437/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/57437
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia9b5fc71e30610684e68e9aca9fb1970da8f840a
Gerrit-Change-Number: 57437
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Anastasia Klimchuk.
Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/57326
to look at the new patch set (#2).
Change subject: tests: Add tests to read from chip
......................................................................
tests: Add tests to read from chip
Two tests cover the code which performs do_read operation.
First one works with fake chip and dummy programmer. Fake chip has all
operations defined, and a buffer to emulate chip memory.
Second one uses the chip which is closer to the real one, because
read/write/unlock/erase operations are real. The tests takes the
advantage of dummyflasher's capability of emulating a W25Q128.V chip.
BUG=b:181803212
TEST=builds and ninja test
Change-Id: Ia57781ebc670c7bd6197e56fe8a20651a425c756
Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org>
---
M tests/chip.c
M tests/io_mock.h
M tests/meson.build
M tests/tests.c
M tests/tests.h
5 files changed, 146 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/26/57326/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/57326
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia57781ebc670c7bd6197e56fe8a20651a425c756
Gerrit-Change-Number: 57326
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sophie van Soest.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56060 )
Change subject: chipset_enable.c: Mark Z97 as DEP
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/56060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I73bdd9afefae8e7c013d400e17a15e56d84322f4
Gerrit-Change-Number: 56060
Gerrit-PatchSet: 5
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Comment-Date: Mon, 06 Sep 2021 21:55:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Sophie van Soest.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56060 )
Change subject: chipset_enable.c: Mark Z97 as DEP
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/56060/comment/d80ddd12_d14c928c
PS3, Line 1972: OK
> Done and rebased to latest origin/master.
Thanks!
--
To view, visit https://review.coreboot.org/c/flashrom/+/56060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I73bdd9afefae8e7c013d400e17a15e56d84322f4
Gerrit-Change-Number: 56060
Gerrit-PatchSet: 5
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Comment-Date: Mon, 06 Sep 2021 16:37:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sophie van Soest <sophie(a)entropie.rocks>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons.
Sophie van Soest has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56060 )
Change subject: chipset_enable.c: Mark Z97 as DEP
......................................................................
Patch Set 5:
(1 comment)
File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/56060/comment/1c1486f7_e2e04795
PS3, Line 1972: OK
> ME-enabled chipsets are marked as DEP (Depends) because the ME can interfere with internal flashing.
Done and rebased to latest origin/master.
--
To view, visit https://review.coreboot.org/c/flashrom/+/56060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I73bdd9afefae8e7c013d400e17a15e56d84322f4
Gerrit-Change-Number: 56060
Gerrit-PatchSet: 5
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 06 Sep 2021 09:48:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment